feat(ui): Jordan's redesign: Forest, Fire and Water themes, New Build, and every page in the new look #202
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!202
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:feat/redesign"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Jordan has finished his redesign of the launcher, with three colour themes, ahead of v3.0 stable, when many new players will arrive. This PR brings it to every page, built from his Paper artboards at their own sizes and in his words, so the first thing a new player sees is the launcher as he drew it.
What changed
The look
LauncherSettings.Theme,App/Themes.cs). Every page reads its colours from the theme.scripts/mukta_metrics.py) so text sits where the design puts it.OverlayPopups).Play (the home)
Build: the game file (found while the builder downloads; Browse, or right-click Browse for a romfs/exefs folder), Install to, Build version (another version of the channel; the picked game file carries over), the estimated time (and, for an update or a going back, which build it replaces in its folder), Build, Cancel. Switching Build version on the page of a new build never turns it into a replacement of another build. Steps 1 and 2 of the old wizard are now this one page.
Building: one bar with the percentage on its end, the current stage and count, the time remaining, and Cancel, which still asks first. A quiet Show details link under Cancel opens main's live log.
Settings, under Play, is one page with two tabs, and Save / Play (Play leaves without saving):
The page offers only what this PC can use (Jordan's call): an upscaler the GPU can't run is hidden, not greyed out. This changes #111 (DLSS and FSR 4 switchable on any GPU, for OptiScaler): on a PC whose card runs neither, they are no longer offered. Say if OptiScaler users need a way back to them. An upscaler that is switched on stays shown, whatever the card, so it can be turned off. A setting that depends on another is hidden while that one is off.
Saves: Jordan's page of the saves found on this PC (emulators, Hookshot, NX2navi, or a folder you browse to), opened to pick slots and import them one by one into the shared save. Each import backs up first (
Saves.Copy(only:), with its check). Manage saves opens main's Saves page, unchanged: export, .zip, backups, Progress.Escape, and a controller's B (main's #209), close the open dialog or New Build, or leave the page, as its Back or Cancel does. A running build asks first. Each page's way back carries
c:Pad.Back, and a controller's first press focuses the page's strip (Play, Build, Save, Import). The TV view and F11 keep main's full screen and corners; the pages scale with the artboard (SceneBox), not main's 1040×680 scaler.Where main's features are now
lowMemoryin settings.json is read and ignored, with a checkNot drawn yet (they keep their layout, recoloured to the theme): Ready, NFC, Backups, the save editor, and Build Failed's details. Try a completely cold build on a failed build still opens the old step 2 with it ticked.
Known limits: on Wayland, Avalonia has no option to draw popups inside the window, so a long list may still reach past its edge there. Picking a row in Your game builds also makes it the default, the one the shortcuts start.
Translations: every new text goes through
Tr/{c:T}, so it shows in English until the catalogs have it (python -I scripts/translations.py --missing <code>lists them). Texts the redesign no longer shows were removed from the catalogs.Not in this PR
Kept out so this one stays one topic. Each can be its own PR:
.gitattributesfor the fixtures, the 8.3 temp path)Tested
073e96e: #207, #208, #209, #211, #216),python -I tests/test_launcher_core.pyon Windows 11: the 743 checks this PR touches pass, run first (settings and the home's layout, PadChecks, BusyChecks, the chime, the slot import, instance folders, translations, version picks, pull requests, problems, icons, NFC's view model, perf and crash reports). The full run stops on Windows at checks that fail the same way on unchanged main (the atomic writer, shell links on a Unicode path, the portable home, unlisted builds, another launcher's data, a dump folder's game files, the NFC folder,LinkSavesCheckswithout Developer Mode); CI runs the whole suite on Linux.python -I tests/test_release.py: 42 tests, OK.dotnet build -c Release: 0 warnings. No package changes: the lock files are main's, byte for byte. On Windows, main's own lock files currently fail-p:RestoreLockedMode=true(since #158 they carrywin-x64andMicrosoft.NET.ILLink.Tasks), with or without this PR.HomeLayoutSourceChecks(main's #180 / #199 checks of the home's layout) were rewritten for the new Play page.BusyChecksnow looks for Check for updates' new binding.tools/screenshots(scenes added: play-forest/fire/water, play-new-build, -first, -checked, -pr, -pr-loading, build-page, build-page-go-back, build-settings, saves-page, and others). Scenes from main whose screens changed render the new pages.Screenshots
In the first comment: the three themes, New Build (and its Pull Request), the Build page (a new build and a going back), Building (and its log), Settings and Saves, from
tools/screenshotsat 1440×960.🤖 Generated with Claude Code
Screenshots, from
tools/screenshotsat 1440×960 (each scene's name in brackets).Play in the three themes (play-forest, play-fire, play-water)



New Build (play-new-build), its Pull Request (play-new-build-pr), nothing built yet (play-new-build-first)



The Build page: a new build (build-page), going back a version (build-page-go-back)


Building, and with Show details (build, build-log)


Settings (build-settings) and Saves (saves-page)


futondestroyer referenced this pull request2026-11-19 23:38:10 +00:00
Code review at
bae7e88(read only, nothing run). It's my own PR, so this can only be a comment, but it can't merge as it is: main has moved on by five commits and three of them change what this PR builds on.Blocking: rebase onto main (
073e96e)Git conflicts in 9 files:
MainWindow.axaml(.cs),HomeViewModel.cs,BuildStepView,HomeView,ProblemView,README.md,tools/screenshots/Program.cs, andChannelPickerView.axaml, which this PR deletes and main changed (keep it deleted). Some of these need decisions about the code, so it's more than a textual rebase. Beyond the conflicts, main's new code changes what this PR's code means:Versions.Candidateis gone, so the rebased branch won't compile. It's still used byChannelSuffix(HomeViewModel.cs:425), New Build's Pre-release (rc) row (:553),DefaultIsCandidate(:703, :1562) and the old Track list's names (:1755). New Build drops to Stable, Nightly and Pull Request. That changes the drawn New Build, so the artboard should lose its rc row as well. Remove the texts that go with them from the catalogs too.Shape()scales the pages from 1040×680 when the window is maximised or full screen (Scaler.LayoutTransform). This PR'sRescale()scales the 1440×960 artboard (SceneBox.Scale) on every resize. KeepRescaleand drop theScalertransform. Keep main's platform corners (WindowCorners), TV full screen, hidden Minimize and F11. F11'sif (!full && !tv) CanResize = falsehas to go, because this window is resizable. The title-bar handlers also need merging: main drags only while Normal, this PR adds double-click to maximise.PadCheckswill fail. Every view with a<Button>except HomeView needs ac:Pad.Back="True"button.BuildPageView,BuildSettingsPageViewandSavesPageViewhave none, and the restyledBuildStepViewandProblemViewmust keep theirs. New Build's ✗ is in HomeView, which the check skips, but it still needsc:Pad.Back. Without it, B does nothing while New Build is open.PadInput.Firstfocuses a button with classgo, thenprimary, then the page's first focusable control. The new strips (Play, Build, Save, Import) areClasses="strip", so the first press lands on the theme picker or the first control on the page. Addstripto that lookup, or give the stripsgo.MainViewModel.Back()(a switch over every page and dialog, run on Escape) and main'sc:Pad.Backmarkers (what B presses) now do the same job. Steam's desktop layout sends Escape, so both paths are live. Better to keep one source: Escape presses the visiblePad.Backbutton, as B does, and the switch goes. If both stay, check they always pick the same button.user/, one backups folder (#211). The Saves page goes throughSaves.ImportTarget,ImportExportandEnv.BackupRoot, so it follows main without changes. Check it once after the rebase.#207 and #216 merge cleanly. #207's follow-the-rename happens in
BuildStepViewModel.Run, which the Build page still goes through.After the rebase, update the description: controller support is on main now (it isn't "not in this PR"), and the rc channel is gone. Run
test_launcher_core.pyagain, since PadChecks and HomeLayoutSourceChecks are the ones at risk.Suggestions (not blocking)
Statusis cleared and the reason goes toCheckButtonTip, and Copy for a bug report goes with it. A tooltip can't be reached with a controller, a Steam Deck's touchscreen or a TV, which #209 now supports. Keep the line over Play (and its Copy) when the check fails.h:mm ttunder InvariantCulture. Everything else goes throughTr. Use the current culture's short date and time.SettingsViewModel, which saves the whole settings file on every change. That also writes any Build-tab switches flipped meanwhile.Discardwrites them back when the page is left or the window closes, so they only stick if the launcher dies in between. Either say so in the doc comment, or give GeneralSaveAsYouGotoo.Checked and fine
Saves.Copy(only:)replaces only the chosen slots, keeps the target's other slots and its account.sav and option.sav, backs up the whole save first, and still checks for a running game (the defaultrunning). Its checks cover a missing slot, an empty pick and a fresh target.WavLevel.Limitapplies one gain and leaves the header untouched. The chime runs on its own thread, one at a time, and every failure is swallowed.SettingsViewModelmoves no folders, so there's nothing on disk to undo.Tr/{c:T}in the new views.ci.yml). The test evidence is the local Windows run in the description.Nits are in the line comments; I'll fold them into the rebase.
@ -0,0 +112,4 @@new Command(() => Retarget(v.Tag)))).ToList();public bool HasVersionOptions => VersionOptions.Count > 1;/// Another version picked in Build version: built in the place of the build this one replaces (an update, or going back), or aTwo doc comments stacked on
InPlaceOf. The first describesRetarget(move it there); the second is the property's.@ -85,2 +76,2 @@public LauncherService Service { get; }/// The launcher's own version, small beside its name in the title bar// The links at the bottom right of Jordan's design (Website, Credits, the GitHub mark, Discord). For now: Longshot's site,// the launcher's README credits and Longshot's source on the forge; no Discord link is known yet, so that one is offStale:
DiscordUrlis set two lines down, and the Discord link is on.@ -96,2 +98,3 @@public Command DiscordCommand { get; }public IReadOnlyList<StepItem> Steps { get; } = new[] { new StepItem(1, Tr.N("Game files")), new StepItem(2, Tr.N("Settings")), new StepItem(3, Tr.N("Build")) };/// The window's links bottom right (Website, Credits, GitHub, Discord): not on Settings, whose sidebar has themTwo doc comments stacked here. This first one (links, "not on Settings") describes the old property;
ShowLinksis the window's launcher line now. Keep the second.bae7e88213ef23b09c90Rebased onto main (
073e96e), now mergeable. Headef23b09. The two commits are the same as before, with these fixes on top:67d08d6gives each new page a way back for B (c:Pad.Back), focuses the strip on a controller's first press, and makes B go back the way Escape does (MainViewModel.Back).docs/controller.mdnow says Settings is under Play.ef23b09): the Saves page's dates are in the player's language (English keeps "8th Nov"), Settings' summary says what is written when, and the stale comments are fixed.Still open from the review, and Jordan's call: when a check he asked for fails, the reason is only in Check for updates' tooltip, which a controller or touchscreen can't reach.
Screenshots after the rebase, from
tools/screenshotsatef23b09.New Build (play-new-build): Stable, Nightly and Pull Request, no rc row

Nothing built yet (play-new-build-first)

The TV view (tv-home, 1920×1080): main's full screen with only Close, and the artboard scaled to the screen. With nothing to build yet, Build is off, so the controller's first press lands on the theme picker.

ef23b09c90b066b09150b066b0915045e376978e@review
Recommendation: Request changes. Changing build versions can lose separately selected game folders, and the Linux chime can overwrite a file through a predictable temporary path. The redesigned settings also remove a supported OptiScaler workflow.
The PR redesigns the launcher around three themes and new build, settings and save pages. It preserves many existing workflows, but introduces file-handling and settings regressions that should be fixed before merge.
@fixwill do (6)App/ViewModels/BuildPageViewModel.cs:125: Retargeting carries only the file's Path. (more on the line)App/Sound.cs:51: The Linux chime writes to a predictable name in the shared temporary directory using WriteAllBytes, which follows an existing symlink. (more on the line)App/ViewModels/SettingsStepViewModel.cs:212: Keep both options available with an unsupported-GPU explanation, or provide an advanced override.App/ViewModels/BuildSettingsPageViewModel.cs:128: Save marks the page done before writing the settings and leaves even if the write fails. (more on the line)App/Views/HomeView.axaml:84: A manually requested update check puts its failure reason only in a tooltip. (more on the line)App/ViewModels/SavesPageViewModel.cs:215: The number of UI entries is derived without a bound from directory names. (more on the line)Before merging, for the author (1) (a run, a measurement or a decision; it doesn't hold the recommendation)
App/ViewModels/SettingsStepViewModel.cs:212: Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable them for OptiScaler. (more on the line)More: does it help, other systems, switches, what was read
Does it help: Not a perf change. The author reports a live Windows review and passing checks for the changed areas; those results do not establish the affected Linux and edge-case workflows.
Other systems: The folder-selection issue affects Windows and Linux. The temporary-file issue affects Linux. GPU-dependent visibility affects OptiScaler users. Controller and touch users cannot reach an update-check failure reason shown only in a tooltip.
Switches: SoundWhenDone is added and defaults to true. Theme defaults to Forest; window size, position and maximized state are remembered. DLSS and FSR 4 remain off by default but their controls are hidden on unsupported GPUs, removing the previous OptiScaler workflow.
Reviewed:
45e376978eagainste2220601db: Read AGENTS.md and CONTRIBUTING.md, the commit and change summary, BuildPageViewModel, BuildSettingsPageViewModel, SavesPageViewModel, SettingsViewModel, SettingsStepViewModel, Themes, Sound, WavLevel, the save-copy changes and relevant build, navigation and window code. Inspected portions of the UI, tests and remaining diffs. This is an incomplete review: the remaining changed files, translations, generated assets and screenshots were not all read or checked.; nothing run (a code review).Checked and fine:
Testing: Read-only review; no builds, tests or project scripts were run.
Overlaps and merge order: none found
Automated code review by BeanBot (gpt-6.1-terra), asked for by madebyjordan. Nothing was run; a maintainer decides.
@ -0,0 +48,4 @@static void PlayLinux(byte[] bytes){var file = Path.Combine(Path.GetTempPath(), $"longshot-launcher-chime-{Environment.ProcessId}.wav");L2: The Linux chime writes to a predictable name in the shared temporary directory using WriteAllBytes, which follows an existing symlink. Another local user can point that name at a file writable by the launcher user and have it overwritten when a build finishes. Create a private temporary file atomically, or pass the audio without a shared predictable file.
@ -0,0 +122,4 @@void Retarget(string tag){if (tag == Job.Version) return;var file = Files.Picked?.File.Path;L1: Retargeting carries only the file's Path. When romfs and exefs were selected separately, Path is the parent of romfs and may not contain exefs; Dropped cannot reconstruct the selection, so changing Build version loses the chosen game files. Carry the complete FoundGameFile, including both folder paths, into the new page and recheck it.
@ -0,0 +125,4 @@void Save(){done = true;L4 (minor): Save marks the page done before writing the settings and leaves even if the write fails. If settings.json is unwritable, the changes remain active in memory but will be lost on restart, and the player cannot retry from this page. Keep the page open and its edits pending when saving fails.
@ -0,0 +212,4 @@var picked = keepPicks ? Sources.Where(s => s.IsPicked).Select(s => s.Number).ToHashSet() : new HashSet<int>();openPath = place.Path;Sources.Clear();var count = Math.Max(SlotCount, place.Slots.Select(s => SaveText.Number(s.Name)).DefaultIfEmpty(0).Max());L6 (minor): The number of UI entries is derived without a bound from directory names. A browsed save containing a folder such as slot_100000000 causes the UI thread to allocate and populate 100 million entries. Validate slot names and bound the displayed range to the supported slots, or enumerate only the slots actually present.
@ -202,0 +209,4 @@/// DLSS: a GeForce RTX card here, or no card known (some Linux PCs: Upscalers.Unsupported offers both then); and while it is/// on, whatever the card (set on another PC or card), so it can be turned off: a hidden switch would still build it inpublic bool ShowDlss => !DlssUnsupported || s.Dlss;L3: Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable them for OptiScaler. For example, an AMD user who needs DLSS files cannot enable DLSS after turning it off. Preserve an accessible way to enable these build options, or have a maintainer explicitly decide to remove that supported workflow.
@ -437,0 +81,4 @@<!-- Check for updates, stateful: Checking for updates… while any check runs, then the answer to the one asked for, onitself (Jordan, 2026-11-18) --><Button Classes="biglink" Content="{Binding CheckButtonText}" Command="{Binding CheckForUpdatesCommand}" Margin="0,14,0,0"ToolTip.Tip="{Binding CheckButtonTip}"/>L5 (minor): A manually requested update check puts its failure reason only in a tooltip. A controller or touch user sees the failed check but cannot read why or use that information to recover. Show the reason in reachable page content or a dialog.
@review
Recommendation: Approve. The changes address all six ledger items, including preserving separately selected game folders and restoring access to upscaler options for OptiScaler users. The redesigned launcher has recorded Windows testing, though the fixes themselves have not been run in this review. Recommend approval; not approved on the forge.
The launcher gains the redesigned pages and themes while retaining its build, update and save workflows. The fixes add an opt-in for otherwise hidden upscalers, preserve game-file selections across version changes, and make failure handling safer.
Since the last review (on
45e376978e)Resolved: L1 (Retargeting carries only the file's Path. When romfs and exefs were selected separately, P…); L2 (The Linux chime writes to a predictable name in the shared temporary directory using Write…); L3 (Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable th…); L4 (Save marks the page done before writing the settings and leaves even if the write fails. I…); L5 (A manually requested update check puts its failure reason only in a tooltip. A controller…); L6 (The number of UI entries is derived without a bound from directory names. A browsed save c…)
Also noticed (2; not asked for, not blocking)
More: does it help, other systems, switches, what was read
Does it help: Yes for the requested fixes by code inspection; this is not a performance change. The author reports a live Windows review and passing checks for the redesign, but no run of the new fix commit is reported.
Other systems: The carried game-file object retains both folder paths and is checked with the new version's tools. Linux chime playback now uses a private temporary directory; Windows playback is unchanged. Save lists are bounded for both imported and shared saves.
Switches: Show upscalers for other GPUs is a page-local switch, off by default. It reveals unsupported DLSS and FSR 4 options for mod users while keeping the detected-GPU defaults; enabled options remain visible. README documents it.
Reviewed:
be18dd9eb7againste2220601db: Read AGENTS.md, CONTRIBUTING.md, the complete since-ledger diff, App/Sound.cs, App/ViewModels/BuildPageViewModel.cs and App/ViewModels/BuildSettingsPageViewModel.cs. Read the relevant sections of the other changed view models and views, their related callers, and the new screenshot checks. Skimmed the full change's file statistics and the supplied recorded runs; the remaining changed files and full base-to-HEAD diff were not read in full.; nothing run (a code review).Checked and fine:
Testing: No commands from the project or tests were run. The supplied CI lists no failing or running checks; the author reports Windows checks and a Release build before this fix commit.
Overlaps and merge order: none found
Automated code review by BeanBot (gpt-6.1-terra), asked for by madebyjordan. Nothing was run; a maintainer decides.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.