fix(build): Intel XeSS can be switched on again for nightly-611 and later #218
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!218
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:fix/xess-after-fetch-py"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Since nightly-611, the New Build step won't let you turn on Intel XeSS. The switch is greyed out with "This version can't fetch it yet.", even though the game still supports it.
Why: the launcher decides whether a version's tools can fetch Intel's
libxess.dllby looking forscripts/xess_sdk.pyin them. Longshot MagicBeanDev/Longshot#1802 (the dev revamp, first in nightly-611) mergedngx_sdk.py,ffx_sdk.pyandxess_sdk.pyinto onescripts/fetch.py.make_game.pystill takes--fetch-xess-runtimeand pins the same XeSS commit (de0fb9c1). The file the launcher looked for is gone, so every nightly since looks like tools from before XeSS. DLSS and FSR 4 aren't affected: their checks don't look for a script.Fix (
Core/MakeGameCommand.cs):XessBuildsaccepts eitherscripts/xess_sdk.pyorscripts/fetch.py.fetch.pywas born in #1802 with XeSS in it, so no version that has it lacks XeSS.The licence cross-check (
tests/test_launcher_core.py --longshot,check_licences) read the same three old scripts. It now readsfetch.py'sDLSS_COMMIT,FSR_COMMITandXESS_COMMITwhenfetch.pyis there, and the old scripts otherwise. That keeps it working once the Longshot pin moves past #1802. A comment inSettingsStepViewModel.csnames the new script. No text the player sees changes.How it was tested
Windows 11 Home 10.0.26200, .NET SDK 10.0.404, on main
985cc61.New check, its own commit (
b4ccb42,CommandChecks): tools that carryscripts/fetch.pyalone get--fetch-xess-runtime --accept-intel-licenseandLONGSHOT_XESS_SDK. It fails on main with "XeSS: tools that carry scripts/fetch.py (Longshot from #1802 on) fetch Intel's library too" and passes with the fix.The real tools on this PC, from a small program built against
Core:XessBuildsis true for nightly-612's and nightly-622's tools, which havefetch.pyand noxess_sdk.py. It's still true for v3.0.0's, which havexess_sdk.py. On main, the two nightlies give false.check_licencesagainst three Longshot layouts:514591a3(ngx_sdk.pyandffx_sdk.py, no XeSS yet);461da1bb(all three old scripts);fetch.py).All three pass, and a
fetch.pywith a changedXESS_COMMITis caught.The core suite, run with each check group continuing past a failure (a local wrapper, not committed): the same 8 Windows-only groups fail on this branch and on main, each with the same message.
CommandCheckspasses.dotnet build -warnaserroris clean.Not tested: a full build with XeSS ticked from a nightly.
Notes
--longshotcross-checks still read the old layout, both the same #1802 move. Neither runs in CI until the pin moves, and they're left for their own PR:check_shader_cachesreadsscripts/dev_packs.py, nowscripts/devtools/packs.py.CACHESgainedlongshot_textures_drawn.bin(#1122,RX_VK_TEX_AHEAD), whichShaderCaches.Namesdoesn't list yet.--fetch-xess-runtime. A game folder that didn't already havelibxess.dllfrom an earlier build has none. The next build or update after this lands fetches it.🤖 Generated with Claude Code
Possibly related, for context:
Recommendation: Wait. The capability check now recognizes the nightly tools and sends the existing licensed XeSS fetch arguments, but an actual nightly build with XeSS enabled has not yet been demonstrated.
This restores the XeSS choice for Windows builds using the consolidated fetch script without changing the Linux path or adding a player setting. The focused regression check and tests against real tool layouts support the fix; the remaining uncertainty is whether the complete launcher-to-builder path installs the DLL successfully.
Does it help: Unproven end to end. The author reports the new command check fails on main and passes with this change; nightly-612 and nightly-622 tools are recognized, while v3.0.0 remains recognized. No full nightly build with XeSS enabled was run.
Other systems: Windows builds and updates with XeSS and its licence enabled take the new path; Linux remains gated off. Old tools retain the original script check. DLSS and FSR command paths are unchanged. The separate shader-cache cross-check remains incompatible with newer Longshot layouts, as disclosed; it is not introduced here.
Switches: No new switches or defaults. The existing XeSS opt-in and licence gate now work with fetch.py; --fetch-xess-runtime, --accept-intel-license and LONGSHOT_XESS_SDK are passed only for opted-in Windows builds.
Reviewed:
efdb5ce67aagainst985cc61459: Read the repository rules, full diff, MakeGameCommand.cs, SettingsStepViewModel.cs and tests/test_launcher_core.py; Program.cs output was truncated, so its changed CommandChecks hunk was reviewed in the diff rather than the whole file. No review checklist or pull request template was present at the listed paths. Reviewed author-reported runs; no tests were run by this review.; nothing run (a code review).Checked and fine:
Testing: Wait for a Windows nightly build with XeSS ticked and its licence accepted, confirming libxess.dll is installed; ideally also check an update of an affected game folder. The reported Windows core-suite failures also occur on main; the release suite and a full nightly build were not reported.
Overlaps and merge order: #202 redesigns the build settings and XeSS UI; coordinate its rebase so this capability fix survives either merge order. #50 also changes build settings and command handling for ANR; rebase whichever lands second.
-# Automated code review by IssueBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.
Merged at
efdb5cebefore my self-review's follow-ups landed. They're in #219 (tests and README only): a check that the fix isn't too loose, and a --longshot check that would have caught Longshot #1802's move. One correction to this PR's notes: the stale shader-cache cross-check doesn't fail CI because the required CircleCI job uses the pinned Longshot; the job against Longshot's main is advisory.