feat(ui): Jordan's redesign: Forest, Fire and Water themes, New Build, and every page in the new look #202

Open
madebyjordan wants to merge 2 commits from madebyjordan/LongshotLauncher:feat/redesign into main
Member

Jordan has finished his redesign of the launcher, with three colour themes, ahead of v3.0 stable, when many new players will arrive. This PR brings it to every page, built from his Paper artboards at their own sizes and in his words, so the first thing a new player sees is the launcher as he drew it.

What changed

The look

  • Three themes, Forest, Fire and Water, picked at the top left of the home and remembered (LauncherSettings.Theme, App/Themes.cs). Every page reads its colours from the theme.
  • The window is 1440×960, the artboards' size. It can be resized and maximised, and the page scales to fit; on a smaller screen it opens smaller with the same shape. It remembers its size, position and maximised state.
  • Fonts: Faculty Glyphic for the title and headings, Mukta for text (both SIL OFL, bundled with their licences). Mukta's line metrics are set to a 1.2 em line (scripts/mukta_metrics.py) so text sits where the design puts it.
  • Lists, menus and tooltips draw inside the window and never past its edges (OverlayPopups).

Play (the home)

  • Bottom left: Play, Settings, Check for updates (its answer changes the button's own text), and the launcher's version, Website, Credits, the source and Discord.
  • Bottom right: Your game builds, numbered in the order they were built, newest first. The picked build is what Play starts. Its card shows its version as a list: the channel's other versions, picking one updates to it or goes back to it, built in its place (main's #119 / #180 go-back). The card also has Saves, Open Folder and Delete. Update available opens What's new from the build's version to the update, and its Update button builds it. A pull request's newer push goes straight to its warnings.
  • + opens New Build: Stable, Nightly and Pull Request (main's #199 track: its list shows each PR's title and author, a spinner while it loads, and Find a pull request… for any open one; the warnings are unchanged). Add a build folder… and NFC tags… are under the channels. It replaces the channel picker dialog.
  • Main's notices (the launcher's update, Hookshot or NX2navi saves found, old folders left, the old folder layout, an installed launcher's builds) are bars along the bottom, each keeping its actions.

Build: the game file (found while the builder downloads; Browse, or right-click Browse for a romfs/exefs folder), Install to, Build version (another version of the channel; the picked game file carries over), the estimated time (and, for an update or a going back, which build it replaces in its folder), Build, Cancel. Switching Build version on the page of a new build never turns it into a replacement of another build. Steps 1 and 2 of the old wizard are now this one page.

Building: one bar with the percentage on its end, the current stage and count, the time remaining, and Cancel, which still asks first. A quiet Show details link under Cancel opens main's live log.

Settings, under Play, is one page with two tabs, and Save / Play (Play leaves without saving):

  • General: main's launcher settings (language, channel for new builds, launcher updates, the update check, statistics, crash reports, the Linux menu entry).
  • Build: what used to be step 2, now set once for every build: game language, workers, memory, a chime when a build finishes (new, Jordan's sound, at most −10 dBFS), DLSS / FSR 4 / XeSS, Intel compiles and the shader time limit, the builds folder and the build files folder (Free up space).

The page offers only what this PC can use (Jordan's call): an upscaler the GPU can't run is hidden, not greyed out. This changes #111 (DLSS and FSR 4 switchable on any GPU, for OptiScaler): on a PC whose card runs neither, they are no longer offered. Say if OptiScaler users need a way back to them. An upscaler that is switched on stays shown, whatever the card, so it can be turned off. A setting that depends on another is hidden while that one is off.

Saves: Jordan's page of the saves found on this PC (emulators, Hookshot, NX2navi, or a folder you browse to), opened to pick slots and import them one by one into the shared save. Each import backs up first (Saves.Copy(only:), with its check). Manage saves opens main's Saves page, unchanged: export, .zip, backups, Progress.

Escape, and a controller's B (main's #209), close the open dialog or New Build, or leave the page, as its Back or Cancel does. A running build asks first. Each page's way back carries c:Pad.Back, and a controller's first press focuses the page's strip (Play, Build, Save, Import). The TV view and F11 keep main's full screen and corners; the pages scale with the artboard (SceneBox), not main's 1040×680 scaler.

Where main's features are now

Main This PR
Track / Version dropdowns, Play / Update to / Go back to the picked build's version list on its card; New Build for a new one
Channel picker dialog, Build another version + → New Build
Pull request track, Find a pull request…, warnings New Build → Pull Request, and a PR build's version list
Wizard steps 1 and 2 the Build page and Settings → Build
The cog / launcher Settings page Settings → General
Row actions (Saves, Open folder, Delete) the card's actions
Saves page (export, .zip, backups, Progress) Saves → Manage saves, unchanged
NFC card New Build → NFC tags…
Add a build folder… New Build → Add a build folder…
Notices and banners bars along the bottom
Low Memory, Prepare Shaders gone (Prepare Shaders was already removed on main, #79). An old lowMemory in settings.json is read and ignored, with a check

Not drawn yet (they keep their layout, recoloured to the theme): Ready, NFC, Backups, the save editor, and Build Failed's details. Try a completely cold build on a failed build still opens the old step 2 with it ticked.

Known limits: on Wayland, Avalonia has no option to draw popups inside the window, so a long list may still reach past its edge there. Picking a row in Your game builds also makes it the default, the one the shortcuts start.

Translations: every new text goes through Tr / {c:T}, so it shows in English until the catalogs have it (python -I scripts/translations.py --missing <code> lists them). Texts the redesign no longer shows were removed from the catalogs.

Not in this PR

Kept out so this one stays one topic. Each can be its own PR:

  • live reload for working on the screens (HotAvalonia)
  • two fixes so the core checks run on Windows (.gitattributes for the fixtures, the 8.3 temp path)

Tested

  • After the rebase onto main (073e96e: #207, #208, #209, #211, #216), python -I tests/test_launcher_core.py on Windows 11: the 743 checks this PR touches pass, run first (settings and the home's layout, PadChecks, BusyChecks, the chime, the slot import, instance folders, translations, version picks, pull requests, problems, icons, NFC's view model, perf and crash reports). The full run stops on Windows at checks that fail the same way on unchanged main (the atomic writer, shell links on a Unicode path, the portable home, unlisted builds, another launcher's data, a dump folder's game files, the NFC folder, LinkSavesChecks without Developer Mode); CI runs the whole suite on Linux.
  • python -I tests/test_release.py: 42 tests, OK.
  • dotnet build -c Release: 0 warnings. No package changes: the lock files are main's, byte for byte. On Windows, main's own lock files currently fail -p:RestoreLockedMode=true (since #158 they carry win-x64 and Microsoft.NET.ILLink.Tasks), with or without this PR.
  • Jordan reviewed each page in a live window running on his own launcher home (Windows, online, his real builds) while it was made.
  • HomeLayoutSourceChecks (main's #180 / #199 checks of the home's layout) were rewritten for the new Play page. BusyChecks now looks for Check for updates' new binding.
  • A cold review by a second agent before opening; its findings are fixed in the second commit (What's new before an update, the build's log, the replacement said, Find a pull request in New Build, a switched-on upscaler kept visible, Escape, the option.sav check, dead code).
  • Screenshots: tools/screenshots (scenes added: play-forest/fire/water, play-new-build, -first, -checked, -pr, -pr-loading, build-page, build-page-go-back, build-settings, saves-page, and others). Scenes from main whose screens changed render the new pages.

Screenshots

In the first comment: the three themes, New Build (and its Pull Request), the Build page (a new build and a going back), Building (and its log), Settings and Saves, from tools/screenshots at 1440×960.

🤖 Generated with Claude Code

Jordan has finished his redesign of the launcher, with three colour themes, ahead of v3.0 stable, when many new players will arrive. This PR brings it to every page, built from his Paper artboards at their own sizes and in his words, so the first thing a new player sees is the launcher as he drew it. ## What changed **The look** - Three themes, **Forest**, **Fire** and **Water**, picked at the top left of the home and remembered (`LauncherSettings.Theme`, `App/Themes.cs`). Every page reads its colours from the theme. - The window is 1440×960, the artboards' size. It can be resized and maximised, and the page scales to fit; on a smaller screen it opens smaller with the same shape. It remembers its size, position and maximised state. - Fonts: **Faculty Glyphic** for the title and headings, **Mukta** for text (both SIL OFL, bundled with their licences). Mukta's line metrics are set to a 1.2 em line (`scripts/mukta_metrics.py`) so text sits where the design puts it. - Lists, menus and tooltips draw inside the window and never past its edges (`OverlayPopups`). **Play (the home)** - Bottom left: Play, Settings, Check for updates (its answer changes the button's own text), and the launcher's version, Website, Credits, the source and Discord. - Bottom right: *Your game builds*, numbered in the order they were built, newest first. The picked build is what Play starts. Its card shows its **version as a list**: the channel's other versions, picking one updates to it or goes back to it, built in its place (main's #119 / #180 go-back). The card also has Saves, Open Folder and Delete. **Update available** opens What's new from the build's version to the update, and its Update button builds it. A pull request's newer push goes straight to its warnings. - **+** opens **New Build**: Stable, Nightly and **Pull Request** (main's #199 track: its list shows each PR's title and author, a spinner while it loads, and *Find a pull request…* for any open one; the warnings are unchanged). *Add a build folder…* and *NFC tags…* are under the channels. It replaces the channel picker dialog. - Main's notices (the launcher's update, Hookshot or NX2navi saves found, old folders left, the old folder layout, an installed launcher's builds) are bars along the bottom, each keeping its actions. **Build**: the game file (found while the builder downloads; *Browse*, or right-click Browse for a romfs/exefs folder), *Install to*, *Build version* (another version of the channel; the picked game file carries over), the estimated time (and, for an update or a going back, which build it replaces in its folder), Build, Cancel. Switching *Build version* on the page of a new build never turns it into a replacement of another build. Steps 1 and 2 of the old wizard are now this one page. **Building**: one bar with the percentage on its end, the current stage and count, the time remaining, and Cancel, which still asks first. A quiet *Show details* link under Cancel opens main's live log. **Settings**, under Play, is one page with two tabs, and *Save* / *Play* (Play leaves without saving): - **General**: main's launcher settings (language, channel for new builds, launcher updates, the update check, statistics, crash reports, the Linux menu entry). - **Build**: what used to be step 2, now set once for every build: game language, workers, memory, a chime when a build finishes (new, Jordan's sound, at most −10 dBFS), DLSS / FSR 4 / XeSS, Intel compiles and the shader time limit, the builds folder and the build files folder (*Free up space*). The page **offers only what this PC can use** (Jordan's call): an upscaler the GPU can't run is hidden, not greyed out. **This changes #111** (DLSS and FSR 4 switchable on any GPU, for OptiScaler): on a PC whose card runs neither, they are no longer offered. Say if OptiScaler users need a way back to them. An upscaler that is switched on stays shown, whatever the card, so it can be turned off. A setting that depends on another is hidden while that one is off. **Saves**: Jordan's page of the saves found on this PC (emulators, Hookshot, NX2navi, or a folder you browse to), opened to pick slots and import them one by one into the shared save. Each import backs up first (`Saves.Copy(only:)`, with its check). *Manage saves* opens main's Saves page, unchanged: export, .zip, backups, Progress. **Escape**, and a controller's **B** (main's #209), close the open dialog or New Build, or leave the page, as its Back or Cancel does. A running build asks first. Each page's way back carries `c:Pad.Back`, and a controller's first press focuses the page's strip (Play, Build, Save, Import). The TV view and F11 keep main's full screen and corners; the pages scale with the artboard (`SceneBox`), not main's 1040×680 scaler. ## Where main's features are now | Main | This PR | |---|---| | Track / Version dropdowns, Play / Update to / Go back to | the picked build's version list on its card; New Build for a new one | | Channel picker dialog, *Build another version* | **+** → New Build | | Pull request track, *Find a pull request…*, warnings | New Build → Pull Request, and a PR build's version list | | Wizard steps 1 and 2 | the Build page and Settings → Build | | The cog / launcher Settings page | Settings → General | | Row actions (Saves, Open folder, Delete) | the card's actions | | Saves page (export, .zip, backups, Progress) | Saves → *Manage saves*, unchanged | | NFC card | New Build → *NFC tags…* | | Add a build folder… | New Build → *Add a build folder…* | | Notices and banners | bars along the bottom | | Low Memory, Prepare Shaders | gone (Prepare Shaders was already removed on main, #79). An old `lowMemory` in settings.json is read and ignored, with a check | **Not drawn yet** (they keep their layout, recoloured to the theme): Ready, NFC, Backups, the save editor, and Build Failed's details. *Try a completely cold build* on a failed build still opens the old step 2 with it ticked. **Known limits**: on Wayland, Avalonia has no option to draw popups inside the window, so a long list may still reach past its edge there. Picking a row in *Your game builds* also makes it the default, the one the shortcuts start. **Translations**: every new text goes through `Tr` / `{c:T}`, so it shows in English until the catalogs have it (`python -I scripts/translations.py --missing <code>` lists them). Texts the redesign no longer shows were removed from the catalogs. ## Not in this PR Kept out so this one stays one topic. Each can be its own PR: - live reload for working on the screens (HotAvalonia) - two fixes so the core checks run on Windows (`.gitattributes` for the fixtures, the 8.3 temp path) ## Tested - After the rebase onto main (`073e96e`: #207, #208, #209, #211, #216), `python -I tests/test_launcher_core.py` on Windows 11: the 743 checks this PR touches pass, run first (settings and the home's layout, PadChecks, BusyChecks, the chime, the slot import, instance folders, translations, version picks, pull requests, problems, icons, NFC's view model, perf and crash reports). The full run stops on Windows at checks that fail the same way on unchanged main (the atomic writer, shell links on a Unicode path, the portable home, unlisted builds, another launcher's data, a dump folder's game files, the NFC folder, `LinkSavesChecks` without Developer Mode); CI runs the whole suite on Linux. - `python -I tests/test_release.py`: 42 tests, OK. - `dotnet build -c Release`: 0 warnings. No package changes: the lock files are main's, byte for byte. On Windows, main's own lock files currently fail `-p:RestoreLockedMode=true` (since #158 they carry `win-x64` and `Microsoft.NET.ILLink.Tasks`), with or without this PR. - Jordan reviewed each page in a live window running on his own launcher home (Windows, online, his real builds) while it was made. - `HomeLayoutSourceChecks` (main's #180 / #199 checks of the home's layout) were rewritten for the new Play page. `BusyChecks` now looks for Check for updates' new binding. - A cold review by a second agent before opening; its findings are fixed in the second commit (What's new before an update, the build's log, the replacement said, Find a pull request in New Build, a switched-on upscaler kept visible, Escape, the option.sav check, dead code). - Screenshots: `tools/screenshots` (scenes added: play-forest/fire/water, play-new-build, -first, -checked, -pr, -pr-loading, build-page, build-page-go-back, build-settings, saves-page, and others). Scenes from main whose screens changed render the new pages. ## Screenshots In the first comment: the three themes, New Build (and its Pull Request), the Build page (a new build and a going back), Building (and its log), Settings and Saves, from `tools/screenshots` at 1440×960. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The launcher's design by Jordan (madebyjordan), from his Paper artboards at their own sizes and words:

- three themes (Forest, Fire, Water), picked on the home and remembered; a 1440x960 window that resizes,
  maximises and remembers its size; Faculty Glyphic and Mukta (SIL OFL) bundled
- Play: Play, Settings and Check for updates bottom left; Your game builds bottom right, the picked build's
  card with its version as a list (go back or on, built in its place), Saves, Open Folder, Delete
- New Build (+): Stable, Pre-release, Nightly and Pull Request with their versions, Add a build folder…,
  NFC tags…; replaces the channel picker
- the Build page (game file, install to, build version), the Building page, Settings with General and
  Build tabs (how every build is made, set once; only what this PC's graphics run is offered), Jordan's
  Saves page with Manage saves for the rest; main's notices as bars along the bottom
- Escape closes a dialog or leaves the page; lists and menus stay inside the window
- the chime when a build is done (Jordan's sound, at most -10 dBFS)
- README and docs/pull-requests.md follow the new pages; their pictures are new

Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(ui): the redesign's review: What's new before an update, the build's log, a replacement said
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
bae7e88213
- Update available opens What's new from the build's version to the update; its Update builds it
  (a pull request's newer push goes to its warnings, as before)
- the Building page: a quiet Show details link under Cancel opens the live log, between the title and the bar
- the Build page says "Replaces X in its folder." for an update or a going back; Build version on a new
  build's page never turns it into a replacement of another build
- New Build's Pull Request list has Find a pull request… (a build of its own), so any open pull request
  can be built with none installed; opening New Build is never held by a running check
- an upscaler that is switched on stays shown, whatever the card, so it can be turned off
- Escape closes New Build and the pull request dialogs
- the slot copy's check has a source option.sav, which the target's must outlive
- dead code of the earlier layouts removed (the channel picker, the overlays, the hero's commands), with
  the 7 catalog texts only they used; the chime's player gets the file as one argument
- "by Team MagicBean" translatable; a screenshot scene of the Build page going back

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Screenshots, from tools/screenshots at 1440×960 (each scene's name in brackets).

Play in the three themes (play-forest, play-fire, play-water)
Forest
Fire
Water

New Build (play-new-build), its Pull Request (play-new-build-pr), nothing built yet (play-new-build-first)
New Build
Pull Request
First start

The Build page: a new build (build-page), going back a version (build-page-go-back)
Build page
Going back

Building, and with Show details (build, build-log)
Building
Building, the log

Settings (build-settings) and Saves (saves-page)
Settings
Saves

Screenshots, from `tools/screenshots` at 1440×960 (each scene's name in brackets). **Play in the three themes** (play-forest, play-fire, play-water) ![Forest](https://git.magicbean.dev/attachments/f587cea6-ff83-4a24-bdf0-9b5a6e0a3f19) ![Fire](https://git.magicbean.dev/attachments/8b9539a6-6bcd-497d-9f58-6f8e5dd963cd) ![Water](https://git.magicbean.dev/attachments/09b3ab17-9bfa-492d-953a-fdbb9a778de2) **New Build** (play-new-build), **its Pull Request** (play-new-build-pr), **nothing built yet** (play-new-build-first) ![New Build](https://git.magicbean.dev/attachments/18e018cc-6950-4c0b-8776-d8c3f7b5b44f) ![Pull Request](https://git.magicbean.dev/attachments/d7d3c5aa-20d9-4116-a833-30ca553d29f8) ![First start](https://git.magicbean.dev/attachments/b9746c06-582f-48a6-af0b-6664e3b279c2) **The Build page**: a new build (build-page), going back a version (build-page-go-back) ![Build page](https://git.magicbean.dev/attachments/aad8e53d-7cb0-4d99-b504-8ff200eb7f21) ![Going back](https://git.magicbean.dev/attachments/b29f981c-0ad4-43f7-98de-4d85d75d914b) **Building**, and with Show details (build, build-log) ![Building](https://git.magicbean.dev/attachments/0fe1c3e9-fd2e-4865-87f4-62b507a9cff4) ![Building, the log](https://git.magicbean.dev/attachments/e21cd126-5bc6-4b81-8b9c-503c7dd2cbd0) **Settings** (build-settings) and **Saves** (saves-page) ![Settings](https://git.magicbean.dev/attachments/372da312-8bf0-4966-8678-689c4dad7663) ![Saves](https://git.magicbean.dev/attachments/0aca6634-b8d4-4aad-84d0-aaa9f3908c32)
madebyjordan left a comment

Code review at bae7e88 (read only, nothing run). It's my own PR, so this can only be a comment, but it can't merge as it is: main has moved on by five commits and three of them change what this PR builds on.

Blocking: rebase onto main (073e96e)

Git conflicts in 9 files: MainWindow.axaml(.cs), HomeViewModel.cs, BuildStepView, HomeView, ProblemView, README.md, tools/screenshots/Program.cs, and ChannelPickerView.axaml, which this PR deletes and main changed (keep it deleted). Some of these need decisions about the code, so it's more than a textual rebase. Beyond the conflicts, main's new code changes what this PR's code means:

  1. No more release candidates (#208). Versions.Candidate is gone, so the rebased branch won't compile. It's still used by ChannelSuffix (HomeViewModel.cs:425), New Build's Pre-release (rc) row (:553), DefaultIsCandidate (:703, :1562) and the old Track list's names (:1755). New Build drops to Stable, Nightly and Pull Request. That changes the drawn New Build, so the artboard should lose its rc row as well. Remove the texts that go with them from the catalogs too.
  2. Controller and TV view (#209).
    • Scaling twice. Main's Shape() scales the pages from 1040×680 when the window is maximised or full screen (Scaler.LayoutTransform). This PR's Rescale() scales the 1440×960 artboard (SceneBox.Scale) on every resize. Keep Rescale and drop the Scaler transform. Keep main's platform corners (WindowCorners), TV full screen, hidden Minimize and F11. F11's if (!full && !tv) CanResize = false has to go, because this window is resizable. The title-bar handlers also need merging: main drags only while Normal, this PR adds double-click to maximise.
    • PadChecks will fail. Every view with a <Button> except HomeView needs a c:Pad.Back="True" button. BuildPageView, BuildSettingsPageView and SavesPageView have none, and the restyled BuildStepView and ProblemView must keep theirs. New Build's ✗ is in HomeView, which the check skips, but it still needs c:Pad.Back. Without it, B does nothing while New Build is open.
    • A controller's first press misses Play. PadInput.First focuses a button with class go, then primary, then the page's first focusable control. The new strips (Play, Build, Save, Import) are Classes="strip", so the first press lands on the theme picker or the first control on the page. Add strip to that lookup, or give the strips go.
    • Two ways back. This PR's MainViewModel.Back() (a switch over every page and dialog, run on Escape) and main's c:Pad.Back markers (what B presses) now do the same job. Steam's desktop layout sends Escape, so both paths are live. Better to keep one source: Escape presses the visible Pad.Back button, as B does, and the switch goes. If both stay, check they always pick the same button.
  3. Saves in user/, one backups folder (#211). The Saves page goes through Saves.ImportTarget, ImportExport and Env.BackupRoot, so it follows main without changes. Check it once after the rebase.

#207 and #216 merge cleanly. #207's follow-the-rename happens in BuildStepViewModel.Run, which the Build page still goes through.

After the rebase, update the description: controller support is on main now (it isn't "not in this PR"), and the rc channel is gone. Run test_launcher_core.py again, since PadChecks and HomeLayoutSourceChecks are the ones at risk.

Suggestions (not blocking)

  • A failed check's reason is only in a tooltip (HomeViewModel.cs:1628). When the player asked for the check, Status is cleared and the reason goes to CheckButtonTip, and Copy for a bug report goes with it. A tooltip can't be reached with a controller, a Steam Deck's touchscreen or a TV, which #209 now supports. Keep the line over Play (and its Copy) when the check fails.
  • Saves page dates are English in every language (SavesPageViewModel.cs:51 and :124): "8th Nov" ordinals and h:mm tt under InvariantCulture. Everything else goes through Tr. Use the current culture's short date and time.
  • Settings: "nothing is written until Save" isn't quite true. The General tab is main's SettingsViewModel, which saves the whole settings file on every change. That also writes any Build-tab switches flipped meanwhile. Discard writes them back when the page is left or the window closes, so they only stick if the launcher dies in between. Either say so in the doc comment, or give General SaveAsYouGo too.

Checked and fine

  • Saves.Copy(only:) replaces only the chosen slots, keeps the target's other slots and its account.sav and option.sav, backs up the whole save first, and still checks for a running game (the default running). Its checks cover a missing slot, an empty pick and a fresh target.
  • WavLevel.Limit applies one gain and leaves the header untouched. The chime runs on its own thread, one at a time, and every failure is swallowed.
  • Mukta's metric patch is allowed: its OFL names no Reserved Font Name, and the licence ships with it.
  • Settings' Back puts back only setting values. Main's SettingsViewModel moves no folders, so there's nothing on disk to undo.
  • No literal UI text outside Tr / {c:T} in the new views.
  • CI's Compile and test is skipped on pull requests by design (ci.yml). The test evidence is the local Windows run in the description.

Nits are in the line comments; I'll fold them into the rebase.

Code review at `bae7e88` (read only, nothing run). It's my own PR, so this can only be a comment, but it **can't merge as it is**: main has moved on by five commits and three of them change what this PR builds on. ## Blocking: rebase onto main (`073e96e`) Git conflicts in 9 files: `MainWindow.axaml(.cs)`, `HomeViewModel.cs`, `BuildStepView`, `HomeView`, `ProblemView`, `README.md`, `tools/screenshots/Program.cs`, and `ChannelPickerView.axaml`, which this PR deletes and main changed (keep it deleted). Some of these need decisions about the code, so it's more than a textual rebase. Beyond the conflicts, main's new code changes what this PR's code means: 1. **No more release candidates ([#208](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/208)).** `Versions.Candidate` is gone, so the rebased branch won't compile. It's still used by `ChannelSuffix` (HomeViewModel.cs:425), New Build's **Pre-release (rc)** row (:553), `DefaultIsCandidate` (:703, :1562) and the old Track list's names (:1755). New Build drops to Stable, Nightly and Pull Request. That changes the drawn New Build, so the artboard should lose its rc row as well. Remove the texts that go with them from the catalogs too. 2. **Controller and TV view ([#209](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/209)).** - **Scaling twice.** Main's `Shape()` scales the pages from 1040×680 when the window is maximised or full screen (`Scaler.LayoutTransform`). This PR's `Rescale()` scales the 1440×960 artboard (`SceneBox.Scale`) on every resize. Keep `Rescale` and drop the `Scaler` transform. Keep main's platform corners (`WindowCorners`), TV full screen, hidden Minimize and F11. F11's `if (!full && !tv) CanResize = false` has to go, because this window is resizable. The title-bar handlers also need merging: main drags only while Normal, this PR adds double-click to maximise. - **`PadChecks` will fail.** Every view with a `<Button>` except HomeView needs a `c:Pad.Back="True"` button. `BuildPageView`, `BuildSettingsPageView` and `SavesPageView` have none, and the restyled `BuildStepView` and `ProblemView` must keep theirs. New Build's ✗ is in HomeView, which the check skips, but it still needs `c:Pad.Back`. Without it, B does nothing while New Build is open. - **A controller's first press misses Play.** `PadInput.First` focuses a button with class `go`, then `primary`, then the page's first focusable control. The new strips (Play, Build, Save, Import) are `Classes="strip"`, so the first press lands on the theme picker or the first control on the page. Add `strip` to that lookup, or give the strips `go`. - **Two ways back.** This PR's `MainViewModel.Back()` (a switch over every page and dialog, run on Escape) and main's `c:Pad.Back` markers (what B presses) now do the same job. Steam's desktop layout sends Escape, so both paths are live. Better to keep one source: Escape presses the visible `Pad.Back` button, as B does, and the switch goes. If both stay, check they always pick the same button. 3. **Saves in `user/`, one backups folder ([#211](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/211)).** The Saves page goes through `Saves.ImportTarget`, `ImportExport` and `Env.BackupRoot`, so it follows main without changes. Check it once after the rebase. [#207](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/207) and [#216](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/216) merge cleanly. #207's follow-the-rename happens in `BuildStepViewModel.Run`, which the Build page still goes through. After the rebase, update the description: controller support is on main now (it isn't "not in this PR"), and the rc channel is gone. Run `test_launcher_core.py` again, since PadChecks and HomeLayoutSourceChecks are the ones at risk. ## Suggestions (not blocking) - **A failed check's reason is only in a tooltip** (HomeViewModel.cs:1628). When the player asked for the check, `Status` is cleared and the reason goes to `CheckButtonTip`, and *Copy for a bug report* goes with it. A tooltip can't be reached with a controller, a Steam Deck's touchscreen or a TV, which #209 now supports. Keep the line over Play (and its Copy) when the check fails. - **Saves page dates are English in every language** (SavesPageViewModel.cs:51 and :124): "8th Nov" ordinals and `h:mm tt` under InvariantCulture. Everything else goes through `Tr`. Use the current culture's short date and time. - **Settings: "nothing is written until Save" isn't quite true.** The General tab is main's `SettingsViewModel`, which saves the whole settings file on every change. That also writes any Build-tab switches flipped meanwhile. `Discard` writes them back when the page is left or the window closes, so they only stick if the launcher dies in between. Either say so in the doc comment, or give General `SaveAsYouGo` too. ## Checked and fine - `Saves.Copy(only:)` replaces only the chosen slots, keeps the target's other slots and its account.sav and option.sav, backs up the whole save first, and still checks for a running game (the default `running`). Its checks cover a missing slot, an empty pick and a fresh target. - `WavLevel.Limit` applies one gain and leaves the header untouched. The chime runs on its own thread, one at a time, and every failure is swallowed. - Mukta's metric patch is allowed: its OFL names no Reserved Font Name, and the licence ships with it. - Settings' Back puts back only setting values. Main's `SettingsViewModel` moves no folders, so there's nothing on disk to undo. - No literal UI text outside `Tr` / `{c:T}` in the new views. - CI's *Compile and test* is skipped on pull requests by design (`ci.yml`). The test evidence is the local Windows run in the description. Nits are in the line comments; I'll fold them into the rebase.
@ -0,0 +112,4 @@
new Command(() => Retarget(v.Tag)))).ToList();
public bool HasVersionOptions => VersionOptions.Count > 1;
/// Another version picked in Build version: built in the place of the build this one replaces (an update, or going back), or a
Author
Member

Two doc comments stacked on InPlaceOf. The first describes Retarget (move it there); the second is the property's.

Two doc comments stacked on `InPlaceOf`. The first describes `Retarget` (move it there); the second is the property's.
@ -85,2 +76,2 @@
public LauncherService Service { get; }
/// The launcher's own version, small beside its name in the title bar
// The links at the bottom right of Jordan's design (Website, Credits, the GitHub mark, Discord). For now: Longshot's site,
// the launcher's README credits and Longshot's source on the forge; no Discord link is known yet, so that one is off
Author
Member

Stale: DiscordUrl is set two lines down, and the Discord link is on.

Stale: `DiscordUrl` is set two lines down, and the Discord link is on.
@ -96,2 +98,3 @@
public Command DiscordCommand { get; }
public IReadOnlyList<StepItem> Steps { get; } = new[] { new StepItem(1, Tr.N("Game files")), new StepItem(2, Tr.N("Settings")), new StepItem(3, Tr.N("Build")) };
/// The window's links bottom right (Website, Credits, GitHub, Discord): not on Settings, whose sidebar has them
Author
Member

Two doc comments stacked here. This first one (links, "not on Settings") describes the old property; ShowLinks is the window's launcher line now. Keep the second.

Two doc comments stacked here. This first one (links, "not on Settings") describes the old property; `ShowLinks` is the window's launcher line now. Keep the second.
madebyjordan force-pushed feat/redesign from bae7e88213
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
to ef23b09c90
Some checks failed
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Failing after 4s
2026-11-20 13:34:40 +00:00
Compare
Author
Member

Rebased onto main (073e96e), now mergeable. Head ef23b09. The two commits are the same as before, with these fixes on top:

  • No more release candidates (#208): New Build lists Stable, Nightly and Pull Request. The (Pre-release) label and the rc screenshot scenes are gone.
  • Controller and TV view (#209): the window keeps main's TV full screen, F11 and the platform's corners. The pages scale with the artboard only, so main's 1040×680 scaler is gone. 67d08d6 gives each new page a way back for B (c:Pad.Back), focuses the strip on a controller's first press, and makes B go back the way Escape does (MainViewModel.Back). docs/controller.md now says Settings is under Play.
  • From the review (ef23b09): the Saves page's dates are in the player's language (English keeps "8th Nov"), Settings' summary says what is written when, and the stale comments are fixed.
  • Tests: 743 checks on Windows, everything this PR touches, pass. What's left of the run fails on Windows on unchanged main too (details in the description).

Still open from the review, and Jordan's call: when a check he asked for fails, the reason is only in Check for updates' tooltip, which a controller or touchscreen can't reach.

Rebased onto main (`073e96e`), now mergeable. Head `ef23b09`. The two commits are the same as before, with these fixes on top: - **No more release candidates (#208):** New Build lists Stable, Nightly and Pull Request. The *(Pre-release)* label and the rc screenshot scenes are gone. - **Controller and TV view (#209):** the window keeps main's TV full screen, F11 and the platform's corners. The pages scale with the artboard only, so main's 1040×680 scaler is gone. `67d08d6` gives each new page a way back for B (`c:Pad.Back`), focuses the strip on a controller's first press, and makes B go back the way Escape does (`MainViewModel.Back`). `docs/controller.md` now says Settings is under Play. - **From the review (`ef23b09`):** the Saves page's dates are in the player's language (English keeps "8th Nov"), Settings' summary says what is written when, and the stale comments are fixed. - **Tests:** 743 checks on Windows, everything this PR touches, pass. What's left of the run fails on Windows on unchanged main too (details in the description). Still open from the review, and Jordan's call: when a check he asked for fails, the reason is only in Check for updates' tooltip, which a controller or touchscreen can't reach.
Author
Member

Screenshots after the rebase, from tools/screenshots at ef23b09.

New Build (play-new-build): Stable, Nightly and Pull Request, no rc row
New Build

Nothing built yet (play-new-build-first)
First start

The TV view (tv-home, 1920×1080): main's full screen with only Close, and the artboard scaled to the screen. With nothing to build yet, Build is off, so the controller's first press lands on the theme picker.
TV home

Screenshots after the rebase, from `tools/screenshots` at `ef23b09`. **New Build** (play-new-build): Stable, Nightly and Pull Request, no rc row ![New Build](https://git.magicbean.dev/attachments/da5e26c8-4131-436c-9181-03c52e301f1b) **Nothing built yet** (play-new-build-first) ![First start](https://git.magicbean.dev/attachments/724ba22e-371f-49da-a998-cc1e4b380ff2) **The TV view** (tv-home, 1920×1080): main's full screen with only Close, and the artboard scaled to the screen. With nothing to build yet, Build is off, so the controller's first press lands on the theme picker. ![TV home](https://git.magicbean.dev/attachments/733ab702-d6f5-498b-9e02-b2cd93802378)
madebyjordan force-pushed feat/redesign from ef23b09c90
Some checks failed
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Failing after 4s
to b066b09150
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 16s
2026-11-20 20:01:08 +00:00
Compare
madebyjordan force-pushed feat/redesign from b066b09150
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 16s
to 45e376978e
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 23s
2026-11-21 08:02:25 +00:00
Compare
Author
Member
@review
BeanBot left a comment

Recommendation: Request changes. Changing build versions can lose separately selected game folders, and the Linux chime can overwrite a file through a predictable temporary path. The redesigned settings also remove a supported OptiScaler workflow.

The PR redesigns the launcher around three themes and new build, settings and save pages. It preserves many existing workflows, but introduces file-handling and settings regressions that should be fixed before merge.

@fix will do (6)

  1. L1 App/ViewModels/BuildPageViewModel.cs:125: Retargeting carries only the file's Path. (more on the line)
  2. L2 App/Sound.cs:51: The Linux chime writes to a predictable name in the shared temporary directory using WriteAllBytes, which follows an existing symlink. (more on the line)
  3. L3 (its part an edit can do) App/ViewModels/SettingsStepViewModel.cs:212: Keep both options available with an unsupported-GPU explanation, or provide an advanced override.
  4. L4 (minor) App/ViewModels/BuildSettingsPageViewModel.cs:128: Save marks the page done before writing the settings and leaves even if the write fails. (more on the line)
  5. L5 (minor) App/Views/HomeView.axaml:84: A manually requested update check puts its failure reason only in a tooltip. (more on the line)
  6. L6 (minor) App/ViewModels/SavesPageViewModel.cs:215: The number of UI entries is derived without a bound from directory names. (more on the line)

Before merging, for the author (1) (a run, a measurement or a decision; it doesn't hold the recommendation)

  • L3 App/ViewModels/SettingsStepViewModel.cs:212: Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable them for OptiScaler. (more on the line)
More: does it help, other systems, switches, what was read

Does it help: Not a perf change. The author reports a live Windows review and passing checks for the changed areas; those results do not establish the affected Linux and edge-case workflows.

Other systems: The folder-selection issue affects Windows and Linux. The temporary-file issue affects Linux. GPU-dependent visibility affects OptiScaler users. Controller and touch users cannot reach an update-check failure reason shown only in a tooltip.

Switches: SoundWhenDone is added and defaults to true. Theme defaults to Forest; window size, position and maximized state are remembered. DLSS and FSR 4 remain off by default but their controls are hidden on unsupported GPUs, removing the previous OptiScaler workflow.

Reviewed: 45e376978e against e2220601db: Read AGENTS.md and CONTRIBUTING.md, the commit and change summary, BuildPageViewModel, BuildSettingsPageViewModel, SavesPageViewModel, SettingsViewModel, SettingsStepViewModel, Themes, Sound, WavLevel, the save-copy changes and relevant build, navigation and window code. Inspected portions of the UI, tests and remaining diffs. This is an incomplete review: the remaining changed files, translations, generated assets and screenshots were not all read or checked.; nothing run (a code review).

Checked and fine:

  • The partial-save copy stages the result and backs up an existing save before replacing it; the added core checks cover retaining unselected slots and settings.
  • The author reports that the rebased Windows checks for the changed areas passed, and the supplied CI report has no head-only failures.

Testing: Read-only review; no builds, tests or project scripts were run.

Overlaps and merge order: none found


Automated code review by BeanBot (gpt-6.1-terra), asked for by madebyjordan. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Changing build versions can lose separately selected game folders, and the Linux chime can overwrite a file through a predictable temporary path. The redesigned settings also remove a supported OptiScaler workflow. The PR redesigns the launcher around three themes and new build, settings and save pages. It preserves many existing workflows, but introduces file-handling and settings regressions that should be fixed before merge. **`@fix` will do (6)** 1. **L1** `App/ViewModels/BuildPageViewModel.cs:125`: Retargeting carries only the file's Path. (more on the line) 2. **L2** `App/Sound.cs:51`: The Linux chime writes to a predictable name in the shared temporary directory using WriteAllBytes, which follows an existing symlink. (more on the line) 3. **L3** (its part an edit can do) `App/ViewModels/SettingsStepViewModel.cs:212`: Keep both options available with an unsupported-GPU explanation, or provide an advanced override. 4. **L4** (minor) `App/ViewModels/BuildSettingsPageViewModel.cs:128`: Save marks the page done before writing the settings and leaves even if the write fails. (more on the line) 5. **L5** (minor) `App/Views/HomeView.axaml:84`: A manually requested update check puts its failure reason only in a tooltip. (more on the line) 6. **L6** (minor) `App/ViewModels/SavesPageViewModel.cs:215`: The number of UI entries is derived without a bound from directory names. (more on the line) **Before merging, for the author (1)** (a run, a measurement or a decision; it doesn't hold the recommendation) - **L3** `App/ViewModels/SettingsStepViewModel.cs:212`: Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable them for OptiScaler. (more on the line) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Not a perf change. The author reports a live Windows review and passing checks for the changed areas; those results do not establish the affected Linux and edge-case workflows. **Other systems:** The folder-selection issue affects Windows and Linux. The temporary-file issue affects Linux. GPU-dependent visibility affects OptiScaler users. Controller and touch users cannot reach an update-check failure reason shown only in a tooltip. **Switches:** SoundWhenDone is added and defaults to true. Theme defaults to Forest; window size, position and maximized state are remembered. DLSS and FSR 4 remain off by default but their controls are hidden on unsupported GPUs, removing the previous OptiScaler workflow. **Reviewed:** 45e376978e7c against e2220601db28: Read AGENTS.md and CONTRIBUTING.md, the commit and change summary, BuildPageViewModel, BuildSettingsPageViewModel, SavesPageViewModel, SettingsViewModel, SettingsStepViewModel, Themes, Sound, WavLevel, the save-copy changes and relevant build, navigation and window code. Inspected portions of the UI, tests and remaining diffs. This is an incomplete review: the remaining changed files, translations, generated assets and screenshots were not all read or checked.; nothing run (a code review). **Checked and fine:** - The partial-save copy stages the result and backs up an existing save before replacing it; the added core checks cover retaining unselected slots and settings. - The author reports that the rebased Windows checks for the changed areas passed, and the supplied CI report has no head-only failures. **Testing:** Read-only review; no builds, tests or project scripts were run. **Overlaps and merge order:** none found </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by madebyjordan. Nothing was run; a maintainer decides.</sub>
App/Sound.cs Outdated
@ -0,0 +48,4 @@
static void PlayLinux(byte[] bytes)
{
var file = Path.Combine(Path.GetTempPath(), $"longshot-launcher-chime-{Environment.ProcessId}.wav");
Member

L2: The Linux chime writes to a predictable name in the shared temporary directory using WriteAllBytes, which follows an existing symlink. Another local user can point that name at a file writable by the launcher user and have it overwritten when a build finishes. Create a private temporary file atomically, or pass the audio without a shared predictable file.

**L2**: The Linux chime writes to a predictable name in the shared temporary directory using WriteAllBytes, which follows an existing symlink. Another local user can point that name at a file writable by the launcher user and have it overwritten when a build finishes. Create a private temporary file atomically, or pass the audio without a shared predictable file.
@ -0,0 +122,4 @@
void Retarget(string tag)
{
if (tag == Job.Version) return;
var file = Files.Picked?.File.Path;
Member

L1: Retargeting carries only the file's Path. When romfs and exefs were selected separately, Path is the parent of romfs and may not contain exefs; Dropped cannot reconstruct the selection, so changing Build version loses the chosen game files. Carry the complete FoundGameFile, including both folder paths, into the new page and recheck it.

**L1**: Retargeting carries only the file's Path. When romfs and exefs were selected separately, Path is the parent of romfs and may not contain exefs; Dropped cannot reconstruct the selection, so changing Build version loses the chosen game files. Carry the complete FoundGameFile, including both folder paths, into the new page and recheck it.
@ -0,0 +125,4 @@
void Save()
{
done = true;
Member

L4 (minor): Save marks the page done before writing the settings and leaves even if the write fails. If settings.json is unwritable, the changes remain active in memory but will be lost on restart, and the player cannot retry from this page. Keep the page open and its edits pending when saving fails.

**L4** (minor): Save marks the page done before writing the settings and leaves even if the write fails. If settings.json is unwritable, the changes remain active in memory but will be lost on restart, and the player cannot retry from this page. Keep the page open and its edits pending when saving fails.
@ -0,0 +212,4 @@
var picked = keepPicks ? Sources.Where(s => s.IsPicked).Select(s => s.Number).ToHashSet() : new HashSet<int>();
openPath = place.Path;
Sources.Clear();
var count = Math.Max(SlotCount, place.Slots.Select(s => SaveText.Number(s.Name)).DefaultIfEmpty(0).Max());
Member

L6 (minor): The number of UI entries is derived without a bound from directory names. A browsed save containing a folder such as slot_100000000 causes the UI thread to allocate and populate 100 million entries. Validate slot names and bound the displayed range to the supported slots, or enumerate only the slots actually present.

**L6** (minor): The number of UI entries is derived without a bound from directory names. A browsed save containing a folder such as slot_100000000 causes the UI thread to allocate and populate 100 million entries. Validate slot names and bound the displayed range to the supported slots, or enumerate only the slots actually present.
@ -202,0 +209,4 @@
/// DLSS: a GeForce RTX card here, or no card known (some Linux PCs: Upscalers.Unsupported offers both then); and while it is
/// on, whatever the card (set on another PC or card), so it can be turned off: a hidden switch would still build it in
public bool ShowDlss => !DlssUnsupported || s.Dlss;
Member

L3: Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable them for OptiScaler. For example, an AMD user who needs DLSS files cannot enable DLSS after turning it off. Preserve an accessible way to enable these build options, or have a maintainer explicitly decide to remove that supported workflow.

**L3**: Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable them for OptiScaler. For example, an AMD user who needs DLSS files cannot enable DLSS after turning it off. Preserve an accessible way to enable these build options, or have a maintainer explicitly decide to remove that supported workflow.
@ -437,0 +81,4 @@
<!-- Check for updates, stateful: Checking for updates… while any check runs, then the answer to the one asked for, on
itself (Jordan, 2026-11-18) -->
<Button Classes="biglink" Content="{Binding CheckButtonText}" Command="{Binding CheckForUpdatesCommand}" Margin="0,14,0,0"
ToolTip.Tip="{Binding CheckButtonTip}"/>
Member

L5 (minor): A manually requested update check puts its failure reason only in a tooltip. A controller or touch user sees the failed check but cannot read why or use that information to recover. Show the reason in reachable page content or a dialog.

**L5** (minor): A manually requested update check puts its failure reason only in a tooltip. A controller or touch user sees the failed check but cannot read why or use that information to recover. Show the reason in reachable page content or a dialog.
fix(ui): address PR #202 review findings and add OptiScaler opt-in switch
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
be18dd9eb7
- L1: preserve separate romfs/exefs picks when retargeting Build version (FilesStepViewModel.Carry) and avoid StartSearch overwriting a carried/dropped pick
- L2: create a private temp directory with FileMode.CreateNew in Sound.PlayLinux instead of a predictable /tmp filename
- L3: add 'Show upscalers for other GPUs' opt-in switch on Settings -> Build for OptiScaler and other upscaler mods, keeping unsupported warnings visible
- L4: keep Settings open (and Discard armed) when SaveSettings() fails
- L5: avoid duplicating update-check failure status/Copy button when EmptyCheckFailed is already shown on an empty Home, and update comment
- L6: bound SavesPageViewModel Targets/Sources loops to SlotCount (6) so crafted slot_* folders cannot allocate huge lists
- Add regression checks in VulkanChecks and build-settings-optiscaler screenshot scene
Author
Member
@review
BeanBot left a comment

Recommendation: Approve. The changes address all six ledger items, including preserving separately selected game folders and restoring access to upscaler options for OptiScaler users. The redesigned launcher has recorded Windows testing, though the fixes themselves have not been run in this review. Recommend approval; not approved on the forge.

The launcher gains the redesigned pages and themes while retaining its build, update and save workflows. The fixes add an opt-in for otherwise hidden upscalers, preserve game-file selections across version changes, and make failure handling safer.

Since the last review (on 45e376978e)
Resolved: L1 (Retargeting carries only the file's Path. When romfs and exefs were selected separately, P…); L2 (The Linux chime writes to a predictable name in the shared temporary directory using Write…); L3 (Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable th…); L4 (Save marks the page done before writing the settings and leaves even if the write fails. I…); L5 (A manually requested update check puts its failure reason only in a tooltip. A controller…); L6 (The number of UI entries is derived without a bound from directory names. A browsed save c…)

Also noticed (2; not asked for, not blocking)
  • The new Carry check verifies preservation of both paths directly, but does not exercise selecting another version and completing its file check.
  • The pull request description still says unsupported upscalers are hidden without mentioning the new opt-in.
More: does it help, other systems, switches, what was read

Does it help: Yes for the requested fixes by code inspection; this is not a performance change. The author reports a live Windows review and passing checks for the redesign, but no run of the new fix commit is reported.

Other systems: The carried game-file object retains both folder paths and is checked with the new version's tools. Linux chime playback now uses a private temporary directory; Windows playback is unchanged. Save lists are bounded for both imported and shared saves.

Switches: Show upscalers for other GPUs is a page-local switch, off by default. It reveals unsupported DLSS and FSR 4 options for mod users while keeping the detected-GPU defaults; enabled options remain visible. README documents it.

Reviewed: be18dd9eb7 against e2220601db: Read AGENTS.md, CONTRIBUTING.md, the complete since-ledger diff, App/Sound.cs, App/ViewModels/BuildPageViewModel.cs and App/ViewModels/BuildSettingsPageViewModel.cs. Read the relevant sections of the other changed view models and views, their related callers, and the new screenshot checks. Skimmed the full change's file statistics and the supplied recorded runs; the remaining changed files and full base-to-HEAD diff were not read in full.; nothing run (a code review).

Checked and fine:

  • The settings page retains pending edits after a failed save and can still discard them.
  • The empty home and a home with builds both have visible update-check failure content.
  • The upscaler opt-in remains visible while enabled and refreshes the affected visibility bindings.

Testing: No commands from the project or tests were run. The supplied CI lists no failing or running checks; the author reports Windows checks and a Release build before this fix commit.

Overlaps and merge order: none found


Automated code review by BeanBot (gpt-6.1-terra), asked for by madebyjordan. Nothing was run; a maintainer decides.

**Recommendation: Approve.** The changes address all six ledger items, including preserving separately selected game folders and restoring access to upscaler options for OptiScaler users. The redesigned launcher has recorded Windows testing, though the fixes themselves have not been run in this review. Recommend approval; not approved on the forge. The launcher gains the redesigned pages and themes while retaining its build, update and save workflows. The fixes add an opt-in for otherwise hidden upscalers, preserve game-file selections across version changes, and make failure handling safer. **Since the last review** (on 45e376978e7c) Resolved: L1 (Retargeting carries only the file's Path. When romfs and exefs were selected separately, P…); L2 (The Linux chime writes to a predictable name in the shared temporary directory using Write…); L3 (Hiding DLSS and FSR 4 on an unsupported detected GPU removes the existing way to enable th…); L4 (Save marks the page done before writing the settings and leaves even if the write fails. I…); L5 (A manually requested update check puts its failure reason only in a tooltip. A controller…); L6 (The number of UI entries is derived without a bound from directory names. A browsed save c…) <details> <summary>Also noticed (2; not asked for, not blocking)</summary> - The new Carry check verifies preservation of both paths directly, but does not exercise selecting another version and completing its file check. - The pull request description still says unsupported upscalers are hidden without mentioning the new opt-in. </details> <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes for the requested fixes by code inspection; this is not a performance change. The author reports a live Windows review and passing checks for the redesign, but no run of the new fix commit is reported. **Other systems:** The carried game-file object retains both folder paths and is checked with the new version's tools. Linux chime playback now uses a private temporary directory; Windows playback is unchanged. Save lists are bounded for both imported and shared saves. **Switches:** Show upscalers for other GPUs is a page-local switch, off by default. It reveals unsupported DLSS and FSR 4 options for mod users while keeping the detected-GPU defaults; enabled options remain visible. README documents it. **Reviewed:** be18dd9eb70b against e2220601db28: Read AGENTS.md, CONTRIBUTING.md, the complete since-ledger diff, App/Sound.cs, App/ViewModels/BuildPageViewModel.cs and App/ViewModels/BuildSettingsPageViewModel.cs. Read the relevant sections of the other changed view models and views, their related callers, and the new screenshot checks. Skimmed the full change's file statistics and the supplied recorded runs; the remaining changed files and full base-to-HEAD diff were not read in full.; nothing run (a code review). **Checked and fine:** - The settings page retains pending edits after a failed save and can still discard them. - The empty home and a home with builds both have visible update-check failure content. - The upscaler opt-in remains visible while enabled and refreshes the affected visibility bindings. **Testing:** No commands from the project or tests were run. The supplied CI lists no failing or running checks; the author reports Windows checks and a Release build before this fix commit. **Overlaps and merge order:** none found </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by madebyjordan. Nothing was run; a maintainer decides.</sub>
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/redesign:madebyjordan-feat/redesign'
git switch 'madebyjordan-feat/redesign'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!202
No description provided.