fix(home): each build's size is what it holds of its own, and the footer says what builds share #210

Merged
HumanBean merged 3 commits from madebyjordan/LongshotLauncher:fix/honest-build-sizes into main 2026-11-20 18:03:14 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11 Home (26200), .NET SDK 10.0.404: the core checks (on base 4e85759: the same Windows-only failures as main, below), dotnet build of the solution with warnings as errors, the screenshots tool; no launcher run against real builds · Needs: a look from someone with two builds that share their game files; the shader store side waits for the game's store PR

TL;DR

The home made two builds look like two full copies of the game. With Nightly 486 and v3.0.0 installed, the rows said 36.6 GB and 36.0 GB (72 GB together). But the two share their 24.4 GB of game files by hard links (Longshot MagicBeanDev/Longshot#360, launcher #58), so they really take 48.2 GB. Now each row shows what the build holds of its own (12.2 GB, 11.6 GB), and the footer keeps the real total and says what the builds share:

2 instances use 48.2 GB in C:\Users\Player\Games\Longshot: 24.4 GB of it is the game's files, which they share.

The launcher also learns about the shared SPIR-V shader store the game is getting: the footer counts it once, and Free up space clears it along with every version's shader caches. And a build whose .nup was moved to another folder now still shares its game files. Related to Longshot MagicBeanDev/Longshot#1759 (cache reuse across instances).

Screenshots

Same two builds, measured as on a real PC (tools/screenshots, scenes home-shared-sizes and home-shared-store; the "before" is the same scene on main):

Before (main) After
home before home after

With the shader store (3.5 GB), and Free up space with it (scene free-space-store):

Home, with the store Free up space, with the store
home with the store free up space with the store

What changed

Sizes on the home (Core/Disk.cs, App/ViewModels/HomeViewModel.cs)

  • Disk.Own(entry): what a build holds of its own. That's BuildEntry.Frees (its files with no hard link outside its folder), or its folder's bytes when Frees isn't known. The row shows it. The Delete dialog already used the same number (Freed), so the row and Delete frees … now agree.
  • Disk.InstancesUse(...): the footer. The total is unchanged (Counted, each file once), plus the shader store. What they share is the total minus the sum of the rows' own sizes. It's only said when it's more than 0:
    • game files only: …: 24.4 GB of it is the game's files, which they share.
    • with the store: …: 24.4 GB of it is the game's files and 3.5 GB the shader store, which they share.
    • store only: …: 3.5 GB of it is the shader store, which they share.
    • one build linked to a folder with no row (an update's old folder): …, which it shares with a folder not listed here.
    • An older builds.json with Bytes but no Counted/Frees says nothing about sharing, as before.
  • App/Views/HomeView.axaml: the footer's TextBlock wraps instead of being cut with an ellipsis (TextWrapping="Wrap" in place of TextTrimming). The longer line was cut at "24.4 GB …" at the window's normal size. This is the one layout change: no new element, button or row. It still takes one line when the text fits. Jordan: say if you'd rather keep it to one line; the alternatives are a shorter sentence or the share in a tooltip.

The shader store (Core/Saves.cs, Core/ShaderCaches.cs, App/LauncherService.cs, App/ViewModels/SettingsViewModel.cs)

  • SaveEnvironment.ShaderStore is where the game keeps it. That's LONGSHOT_SHADER_STORE when set, else %LOCALAPPDATA%\Longshot\shaders on Windows and ${XDG_CACHE_HOME:-~/.cache}/longshot/shaders on Linux. It's the PC's store even for a portable launcher, since the game doesn't take it from --user. It reads the switch exactly as the game does (gpu/vk/spirv_pack.h's default_dir): LONGSHOT_SHADER_STORE=0 (and, on Windows, no LOCALAPPDATA) means no store, so nothing is counted or cleared, and an XDG_CACHE_HOME that isn't a full path is ignored.
  • ShaderCaches.StoreFiles/StoreBytes/ClearStore cover spirv.pack, spirv.idx, spirv.lock and what a write leaves beside them (spirv.pack.<anything>). They never touch anything else in the folder, because LONGSHOT_SHADER_STORE may name one that holds other things. The folder itself goes only once it is empty. Nothing is cleared while Longshot runs (the same check as ShaderCaches.Clear).
  • The home measures the store in the background each time it's shown: a few files, no walk (LauncherService.MeasureShaderStore).
  • Free up space: when Also clear the shader caches is ticked, the store goes too, after every version's caches. That's safe because each build's cache sees the store changed and starts over. The option's size includes the store, and its hint names it: 3.5 GB of that is the shader store your versions share, which goes with their caches. The option's label stays one line because the checkbox doesn't wrap (a longer label was clipped). With no version caches, the option names the store alone. Settings' build-files hint counts the store with the caches.
  • A build's own delete and a cold build never touch the store. ColdBuild and DeleteGame are unchanged, and the store's names aren't ShaderCaches.IsCache names (checked).

Game files shared from a moved .nup (Core/BuildRegistry.cs, its own commit)

  • SameGameFiles used to offer a donor build only when its recorded .nup path was the new build's. Why the path was required: I found no reason in #58 or its history. make_game's romfs_from_build compares the donor's .longshot_romfs stamp alone (the .nup's file name and size), and the launcher already checks that stamp (Unpacked). So the path check only missed shares: a .nup moved or copied to another folder, or a build listed again without its Nup record, made the next build unpack about 25 GB again. The check is now the stamp, as the builder's is. The order is unchanged: same drive first, then the newest. The safety is the same as before, since the builder's check is the gate either way.

Translations: the three footer sentences are in all 12 catalogs, placed after "{0} instances use {1} in {2}.". These are my translations and want a native speaker's look. The three Free up space texts are left out, like the texts beside them, which no catalog has yet. scripts/translations.py: no broken placeholders or plural forms.

How it was tested

Run by an AI agent (Claude Opus 5.5) working for me. Windows 11 Home 10.0.26200, .NET SDK 10.0.404, base 4e85759 (rebased 2026-11-20 after #211, #213, #215 and #216).

  • New checks (tests/launcher_core):
    • ScreenChecks.InstancesUseChecks: the row size and every footer sentence, with the real PC's numbers (36.6/12.2 and 36.0/11.6 GB give 48.2 GB and 24.4 GB shared), the store, one build, an unmeasured build, and an old builds.json.
    • ShaderCacheChecks.ShaderStoreChecks: the store's path on both systems and with LONGSHOT_SHADER_STORE; no store with LONGSHOT_SHADER_STORE=0 or no LOCALAPPDATA on Windows (never a folder named 0); a relative XDG_CACHE_HOME ignored; its size; clearing it (refused while Longshot runs; only its files, the player's files in the folder stay; the folder goes when that empties it); the store's names are no build cache's; Free up space's option and hint.
    • RegistryChecks: a moved .nup still shares, so does a build with no Nup record, and a .nup of the same name and another size shares nothing.
    • InstanceFolderChecks' footer source check now reads Core/Disk.cs.
  • The whole core suite, python -I tests/test_launcher_core.py, on this branch and on main 4e85759 side by side, each check group run on past a failure (a local wrapper, not committed): the same 8 groups fail on both, each with the same message, all Windows-only (InstallChecks' shortcut on the Unicode scratch path, UnlistedChecks, OtherLauncherChecks, SavesChecks, SaveBackupsChecks, HookshotChecks' Linux paths, NfcChecks, ScreenChecks' dump folder). Every group this PR adds to passes: RegistryChecks, InstanceFolderChecks, ShaderCacheChecks and DiskChecks (InstancesUseChecks). CI on Linux runs them all.
  • dotnet build LongshotLauncher.slnx -warnaserror: no warnings.
  • The screenshots above, from tools/screenshots.

Measurements: the home measures the store each time it's shown: one listing of one folder, off the window's thread. The build folders' measuring (Disk.Measure) is unchanged. Nothing in the build or the game changes.

Not tested:

  • The launcher against real builds on this PC. The numbers come from a measurement of real folders (nightly-486 holds 12.2 GB of its own, v3.0.0 10.1 GB), and the screenshots use the same shape.
  • The store against a real game. The game's store (Longshot MagicBeanDev/Longshot#1809) isn't merged yet, so the folder doesn't exist on players' PCs: until it does, the footer and Free up space look exactly as on main. Checked against #1809's head 720c6988: its store is spirv.pack/spirv.idx/spirv.lock, a store made again is written as <name>.new and renamed into place (covered by <name>.<anything>), 0 means none, and its delete contract (the three files together, never while a game has them open) is what ClearStore does.
  • Linux.

Needs: a launcher run with two builds of one .nup (the footer's text), and, once the game's store lands, Free up space with the store ticked.

Notes

  • The store's layout is the game PR's. This follows the store the game is getting in a separate Longshot PR: spirv.pack/.idx/.lock in that folder, with LONGSHOT_SHADER_STORE to move it. If that layout changes before it merges, ShaderCaches.StoreNames and SaveEnvironment.ShaderStore change with it. Longshot MagicBeanDev/Longshot#737 is a different shared-store design and doesn't use these paths.
  • #202 (the redesign): this PR adds two small conflicts to it, the footer's TextWrapping in App/Views/HomeView.axaml and the footer source check in tests/launcher_core/InstanceFolderChecks.cs. #202 keeps Meta and Footer as they are, so they carry over.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11 Home (26200), .NET SDK 10.0.404: the core checks (on base `4e85759`: the same Windows-only failures as main, below), `dotnet build` of the solution with warnings as errors, the screenshots tool; no launcher run against real builds · **Needs:** a look from someone with two builds that share their game files; the shader store side waits for the game's store PR ## TL;DR The home made two builds look like two full copies of the game. With Nightly 486 and v3.0.0 installed, the rows said **36.6 GB** and **36.0 GB** (72 GB together). But the two share their 24.4 GB of game files by hard links (Longshot https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/360, launcher #58), so they really take 48.2 GB. Now each row shows what the build holds of its own (12.2 GB, 11.6 GB), and the footer keeps the real total and says what the builds share: > 2 instances use 48.2 GB in C:\Users\Player\Games\Longshot: 24.4 GB of it is the game's files, which they share. The launcher also learns about the shared SPIR-V shader store the game is getting: the footer counts it once, and *Free up space* clears it along with every version's shader caches. And a build whose .nup was moved to another folder now still shares its game files. Related to Longshot https://git.magicbean.dev/MagicBeanDev/Longshot/issues/1759 (cache reuse across instances). ## Screenshots Same two builds, measured as on a real PC (`tools/screenshots`, scenes `home-shared-sizes` and `home-shared-store`; the "before" is the same scene on main): | Before (main) | After | |---|---| | ![home before](https://git.magicbean.dev/attachments/ee89c7dd-6a89-4e80-90b4-7741db942d33) | ![home after](https://git.magicbean.dev/attachments/452fa9bf-d3d7-4835-b505-7ee1b62978b8) | With the shader store (3.5 GB), and *Free up space* with it (scene `free-space-store`): | Home, with the store | Free up space, with the store | |---|---| | ![home with the store](https://git.magicbean.dev/attachments/a1f38817-9655-433b-827e-e82c0cf8d2dd) | ![free up space with the store](https://git.magicbean.dev/attachments/1fb8101e-454f-468f-b5cb-6b596c64ad8b) | ## What changed **Sizes on the home** (`Core/Disk.cs`, `App/ViewModels/HomeViewModel.cs`) - `Disk.Own(entry)`: what a build holds of its own. That's `BuildEntry.Frees` (its files with no hard link outside its folder), or its folder's bytes when Frees isn't known. The row shows it. The Delete dialog already used the same number (`Freed`), so the row and *Delete frees …* now agree. - `Disk.InstancesUse(...)`: the footer. The total is unchanged (`Counted`, each file once), plus the shader store. What they share is the total minus the sum of the rows' own sizes. It's only said when it's more than 0: - game files only: *…: 24.4 GB of it is the game's files, which they share.* - with the store: *…: 24.4 GB of it is the game's files and 3.5 GB the shader store, which they share.* - store only: *…: 3.5 GB of it is the shader store, which they share.* - one build linked to a folder with no row (an update's old folder): *…, which it shares with a folder not listed here.* - An older `builds.json` with Bytes but no Counted/Frees says nothing about sharing, as before. - `App/Views/HomeView.axaml`: the footer's TextBlock wraps instead of being cut with an ellipsis (`TextWrapping="Wrap"` in place of `TextTrimming`). The longer line was cut at *"24.4 GB …"* at the window's normal size. **This is the one layout change: no new element, button or row.** It still takes one line when the text fits. Jordan: say if you'd rather keep it to one line; the alternatives are a shorter sentence or the share in a tooltip. **The shader store** (`Core/Saves.cs`, `Core/ShaderCaches.cs`, `App/LauncherService.cs`, `App/ViewModels/SettingsViewModel.cs`) - `SaveEnvironment.ShaderStore` is where the game keeps it. That's `LONGSHOT_SHADER_STORE` when set, else `%LOCALAPPDATA%\Longshot\shaders` on Windows and `${XDG_CACHE_HOME:-~/.cache}/longshot/shaders` on Linux. It's the PC's store even for a portable launcher, since the game doesn't take it from `--user`. It reads the switch exactly as the game does (`gpu/vk/spirv_pack.h`'s `default_dir`): `LONGSHOT_SHADER_STORE=0` (and, on Windows, no `LOCALAPPDATA`) means no store, so nothing is counted or cleared, and an `XDG_CACHE_HOME` that isn't a full path is ignored. - `ShaderCaches.StoreFiles`/`StoreBytes`/`ClearStore` cover `spirv.pack`, `spirv.idx`, `spirv.lock` and what a write leaves beside them (`spirv.pack.<anything>`). They never touch anything else in the folder, because `LONGSHOT_SHADER_STORE` may name one that holds other things. The folder itself goes only once it is empty. Nothing is cleared while Longshot runs (the same check as `ShaderCaches.Clear`). - The home measures the store in the background each time it's shown: a few files, no walk (`LauncherService.MeasureShaderStore`). - *Free up space*: when **Also clear the shader caches** is ticked, the store goes too, after every version's caches. That's safe because each build's cache sees the store changed and starts over. The option's size includes the store, and its hint names it: *3.5 GB of that is the shader store your versions share, which goes with their caches.* The option's label stays one line because the checkbox doesn't wrap (a longer label was clipped). With no version caches, the option names the store alone. Settings' build-files hint counts the store with the caches. - **A build's own delete and a cold build never touch the store.** `ColdBuild` and `DeleteGame` are unchanged, and the store's names aren't `ShaderCaches.IsCache` names (checked). **Game files shared from a moved .nup** (`Core/BuildRegistry.cs`, its own commit) - `SameGameFiles` used to offer a donor build only when its recorded .nup path was the new build's. Why the path was required: I found no reason in #58 or its history. make_game's `romfs_from_build` compares the donor's `.longshot_romfs` stamp alone (the .nup's file name and size), and the launcher already checks that stamp (`Unpacked`). So the path check only missed shares: a .nup moved or copied to another folder, or a build listed again without its `Nup` record, made the next build unpack about 25 GB again. The check is now the stamp, as the builder's is. The order is unchanged: same drive first, then the newest. The safety is the same as before, since the builder's check is the gate either way. **Translations:** the three footer sentences are in all 12 catalogs, placed after `"{0} instances use {1} in {2}."`. These are my translations and want a native speaker's look. The three *Free up space* texts are left out, like the texts beside them, which no catalog has yet. `scripts/translations.py`: no broken placeholders or plural forms. ## How it was tested Run by an AI agent (Claude Opus 5.5) working for me. Windows 11 Home 10.0.26200, .NET SDK 10.0.404, base `4e85759` (rebased 2026-11-20 after #211, #213, #215 and #216). - **New checks** (`tests/launcher_core`): - `ScreenChecks.InstancesUseChecks`: the row size and every footer sentence, with the real PC's numbers (36.6/12.2 and 36.0/11.6 GB give 48.2 GB and 24.4 GB shared), the store, one build, an unmeasured build, and an old `builds.json`. - `ShaderCacheChecks.ShaderStoreChecks`: the store's path on both systems and with `LONGSHOT_SHADER_STORE`; no store with `LONGSHOT_SHADER_STORE=0` or no `LOCALAPPDATA` on Windows (never a folder named `0`); a relative `XDG_CACHE_HOME` ignored; its size; clearing it (refused while Longshot runs; only its files, the player's files in the folder stay; the folder goes when that empties it); the store's names are no build cache's; *Free up space*'s option and hint. - `RegistryChecks`: a moved .nup still shares, so does a build with no `Nup` record, and a .nup of the same name and another size shares nothing. - `InstanceFolderChecks`' footer source check now reads `Core/Disk.cs`. - **The whole core suite**, `python -I tests/test_launcher_core.py`, on this branch and on main `4e85759` side by side, each check group run on past a failure (a local wrapper, not committed): the same 8 groups fail on both, each with the same message, all Windows-only (`InstallChecks`' shortcut on the Unicode scratch path, `UnlistedChecks`, `OtherLauncherChecks`, `SavesChecks`, `SaveBackupsChecks`, `HookshotChecks`' Linux paths, `NfcChecks`, `ScreenChecks`' dump folder). Every group this PR adds to passes: `RegistryChecks`, `InstanceFolderChecks`, `ShaderCacheChecks` and `DiskChecks` (`InstancesUseChecks`). CI on Linux runs them all. - `dotnet build LongshotLauncher.slnx -warnaserror`: no warnings. - The screenshots above, from `tools/screenshots`. **Measurements:** the home measures the store each time it's shown: one listing of one folder, off the window's thread. The build folders' measuring (`Disk.Measure`) is unchanged. Nothing in the build or the game changes. **Not tested:** - The launcher against real builds on this PC. The numbers come from a measurement of real folders (nightly-486 holds 12.2 GB of its own, v3.0.0 10.1 GB), and the screenshots use the same shape. - The store against a real game. The game's store (Longshot https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1809) isn't merged yet, so the folder doesn't exist on players' PCs: until it does, the footer and *Free up space* look exactly as on main. Checked against #1809's head `720c6988`: its store is `spirv.pack`/`spirv.idx`/`spirv.lock`, a store made again is written as `<name>.new` and renamed into place (covered by `<name>.<anything>`), `0` means none, and its delete contract (the three files together, never while a game has them open) is what `ClearStore` does. - Linux. **Needs:** a launcher run with two builds of one .nup (the footer's text), and, once the game's store lands, *Free up space* with the store ticked. ## Notes - **The store's layout is the game PR's.** This follows the store the game is getting in a separate Longshot PR: `spirv.pack`/`.idx`/`.lock` in that folder, with `LONGSHOT_SHADER_STORE` to move it. If that layout changes before it merges, `ShaderCaches.StoreNames` and `SaveEnvironment.ShaderStore` change with it. Longshot https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/737 is a different shared-store design and doesn't use these paths. - **#202 (the redesign)**: this PR adds two small conflicts to it, the footer's `TextWrapping` in `App/Views/HomeView.axaml` and the footer source check in `tests/launcher_core/InstanceFolderChecks.cs`. #202 keeps `Meta` and `Footer` as they are, so they carry over. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
BuildRegistry.SameGameFiles offered a donor build only when its recorded
.nup path was the new build's. make_game's romfs_from_build compares the
donor's .longshot_romfs stamp alone (the .nup's name and size), which the
launcher already checks, so the path added nothing but missed shares: a
.nup moved or copied elsewhere, or a build listed again without its
record, made the next build unpack ~25 GB again. Same drive first, then
the newest, as before.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(home): each build's size is what it holds of its own, and the footer says what builds share
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
b315ef27c8
A build's row showed its folder's bytes, so two builds sharing 24.4 GB of
game files by hard links (Longshot #360, launcher #58) read as two full
copies. The row now shows what deleting it frees (BuildEntry.Frees, as
the Delete dialog already did), and the footer keeps its real total and
says how much of it the builds share (Disk.InstancesUse).

The shared SPIR-V shader store the game is getting (%LOCALAPPDATA%\Longshot\shaders,
${XDG_CACHE_HOME:-~/.cache}/longshot/shaders, LONGSHOT_SHADER_STORE) is
counted once in the footer's total and named as shared. Free up space,
when it clears every version's shader caches, clears the store's files
too (never anything else in its folder, never while Longshot runs) and
says so under its option; a build's own delete or cold build leaves it.

The footer wraps instead of being cut with an ellipsis, so the longer
line stays readable; no new element.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Screenshots from tools/screenshots (Windows, 960x600): the home before (main) and after with two builds sharing their game files, the home with the shader store, and Free up space with and without the store.

home-before.png

home-after.png

home-after-store.png

free-space-store.png

free-space-no-store.png

Screenshots from `tools/screenshots` (Windows, 960x600): the home before (main) and after with two builds sharing their game files, the home with the shader store, and Free up space with and without the store. ![home-before.png](https://git.magicbean.dev/attachments/ee89c7dd-6a89-4e80-90b4-7741db942d33) ![home-after.png](https://git.magicbean.dev/attachments/452fa9bf-d3d7-4835-b505-7ee1b62978b8) ![home-after-store.png](https://git.magicbean.dev/attachments/a1f38817-9655-433b-827e-e82c0cf8d2dd) ![free-space-store.png](https://git.magicbean.dev/attachments/1fb8101e-454f-468f-b5cb-6b596c64ad8b) ![free-space-no-store.png](https://git.magicbean.dev/attachments/af3b65dd-9016-472b-8c25-64607fdb4535)
Owner

Looks great! Let's get this rebased and merged

Looks great! Let's get this rebased and merged
HumanBean approved these changes 2026-11-20 15:41:49 +00:00
Dismissed
madebyjordan force-pushed fix/honest-build-sizes from b315ef27c8
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
to ccf7067c9e
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 18s
2026-11-20 17:49:02 +00:00
Compare
madebyjordan dismissed HumanBean's review 2026-11-20 17:49:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fix(settings): no shader store when the game has none
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
408c11f37c
LONGSHOT_SHADER_STORE=0 turns the game's store off, but the launcher took
it for a folder named 0 in its own working folder. ShaderStore now reads
the switch as the game does (gpu/vk/spirv_pack.h's default_dir): null for
0 or, on Windows, no LOCALAPPDATA, and an XDG_CACHE_HOME that is not a
full path is not used. No store: nothing counted, nothing cleared.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

@HumanBean thanks. Rebased onto main 4e85759 (after #211, #213, #215 and #216). Head is now 408c11f.

  • Rebase: one conflict, in Core/Saves.cs. #211's LinuxUserFiles/LongshotUser and this PR's ShaderStore were added at the same spot, so I kept both. Nothing else needed changing.
  • One new commit, 408c11f: I checked the launcher's store path against the game's store PR (Longshot #1809, head 720c6988). The game takes LONGSHOT_SHADER_STORE=0 to mean no store, but the launcher read it as a folder named 0 in its own working folder. ShaderStore now reads the switch exactly as the game does: 0 (or, on Windows, no LOCALAPPDATA) means no store, so nothing is counted or cleared, and an XDG_CACHE_HOME that isn't a full path is ignored. Checks added in ShaderStoreChecks.
  • Delete contract: #1809's store remakes write <name>.new and rename it into place, and StoreFiles already covers those. Its cleanup contract (the three files deleted together, never while a game has them open) is what ClearStore does.
  • Tested on Windows: dotnet build -warnaserror is clean. In the core suite, with each check group run on past a failure, this branch and main fail the same 8 Windows-only groups with the same messages. Every group this PR touches passes.

Taking it out of WIP, as you asked to merge it. The footer wrapping is still Jordan's call (in the description).

@HumanBean thanks. Rebased onto main `4e85759` (after #211, #213, #215 and #216). Head is now **408c11f**. - **Rebase:** one conflict, in `Core/Saves.cs`. #211's `LinuxUserFiles`/`LongshotUser` and this PR's `ShaderStore` were added at the same spot, so I kept both. Nothing else needed changing. - **One new commit, `408c11f`:** I checked the launcher's store path against the game's store PR (Longshot #1809, head `720c6988`). The game takes `LONGSHOT_SHADER_STORE=0` to mean no store, but the launcher read it as a folder named `0` in its own working folder. `ShaderStore` now reads the switch exactly as the game does: `0` (or, on Windows, no `LOCALAPPDATA`) means no store, so nothing is counted or cleared, and an `XDG_CACHE_HOME` that isn't a full path is ignored. Checks added in `ShaderStoreChecks`. - **Delete contract:** #1809's store remakes write `<name>.new` and rename it into place, and `StoreFiles` already covers those. Its cleanup contract (the three files deleted together, never while a game has them open) is what `ClearStore` does. - **Tested** on Windows: `dotnet build -warnaserror` is clean. In the core suite, with each check group run on past a failure, this branch and main fail the same 8 Windows-only groups with the same messages. Every group this PR touches passes. Taking it out of WIP, as you asked to merge it. The footer wrapping is still Jordan's call (in the description).
madebyjordan changed title from WIP: fix(home): each build's size is what it holds of its own, and the footer says what builds share to fix(home): each build's size is what it holds of its own, and the footer says what builds share 2026-11-20 17:52:10 +00:00
HumanBean deleted branch fix/honest-build-sizes 2026-11-20 18:03:15 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!210
No description provided.