fix(pr): a pull request is compared with the Windows builder's tools.lock, which is at the top of its folder #216
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!216
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix-pr-windows-tools-lock"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Building a Pull request track on Windows fails with "nightly-…'s tools have no tools.lock to compare the pull request's with", because the Windows builder's zip keeps
tools.lockat the top of its folder and the launcher only looked inLongshotBuilder/tools/andLongshotBuilder/.InstallPullRequestnow also looks at<install folder>/tools.lock. A check inPullRequestChecks.csbuilds a pull request from a Windows-layout nightly (itstools.lockonly at the top); it fails without the fix.Tests: the new check passes.
BuildReportChecks("home folder taken out before a line is cut") fails on my PC with or without this change, so the fulltest_launcher_core.pyrun doesn't finish here. I did not runtest_release.py.🤖 Generated with Claude Code