fix(pr): a pull request is compared with the Windows builder's tools.lock, which is at the top of its folder #216

Merged
HumanBean merged 2 commits from HumanBean/LongshotLauncher:fix-pr-windows-tools-lock into main 2026-11-20 06:16:04 +00:00
Owner

Building a Pull request track on Windows fails with "nightly-…'s tools have no tools.lock to compare the pull request's with", because the Windows builder's zip keeps tools.lock at the top of its folder and the launcher only looked in LongshotBuilder/tools/ and LongshotBuilder/.

InstallPullRequest now also looks at <install folder>/tools.lock. A check in PullRequestChecks.cs builds a pull request from a Windows-layout nightly (its tools.lock only at the top); it fails without the fix.

Tests: the new check passes. BuildReportChecks ("home folder taken out before a line is cut") fails on my PC with or without this change, so the full test_launcher_core.py run doesn't finish here. I did not run test_release.py.

🤖 Generated with Claude Code

Building a Pull request track on Windows fails with "nightly-…'s tools have no tools.lock to compare the pull request's with", because the Windows builder's zip keeps `tools.lock` at the top of its folder and the launcher only looked in `LongshotBuilder/tools/` and `LongshotBuilder/`. `InstallPullRequest` now also looks at `<install folder>/tools.lock`. A check in `PullRequestChecks.cs` builds a pull request from a Windows-layout nightly (its `tools.lock` only at the top); it fails without the fix. Tests: the new check passes. `BuildReportChecks` ("home folder taken out before a line is cut") fails on my PC with or without this change, so the full `test_launcher_core.py` run doesn't finish here. I did not run `test_release.py`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(controller): a controller moves through the launcher, and Steam's Gaming Mode and Big Picture get a full-screen TV view; the window's corners are the platform's
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
f1dd6beccd
Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(pr): a pull request is compared with the Windows builder's tools.lock, which is at the top of its folder
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
c06191dd95
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
HumanBean deleted branch fix-pr-windows-tools-lock 2026-11-20 06:16:05 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!216
No description provided.