feat(storage): a Storage page, and tabs in the title bar #221

Merged
HumanBean merged 7 commits from dyst/LongshotLauncher:feat/storage-page into main 2026-11-21 07:07:18 +00:00
Member

Players can't see what Longshot keeps on their disk, or let any of it go one part at a time: the only tool was Settings' Free up space, all or nothing, and the launcher quietly kept up to ~8.5 GB of older builds' work (the object and lift stores). Old versions an update left in the builds folder took ~25-40 GB each and showed nowhere but a notice on Home.

Type: feat · Risk: medium (it deletes folders; every delete goes through the launcher's existing guarded deletes) · Tested on: Windows 11 Pro (22631), .NET SDK 10.0.404, the launcher run against a real launcher home with a nightly, PR runtimes and an old version's folder · Not tested: Linux

What changed

A Storage page (the title bar's Storage tab, and Manage storage in Settings), Core/Storage.cs, App/ViewModels/StorageViewModel.cs:

  • What Longshot keeps by what it is for, never by build: Game files, Installed games, Shader caches, Faster updates, Build tools, Your data. One bar shows the split, the groups' tabs sit above it, and the group shown lists its items, each with its size, what removing it costs (asked first), and Remove.
  • A Remove that can't be pressed now is disabled with a tooltip saying why (Longshot is running, a download is running, the folder holds your mods). Remove all per group; in Installed games it reads Remove those not in your versions and never touches a listed version.
  • Measured off the window's thread with a pinned progress bar and spinner; a removal shows how much is freed so far. The measure is kept while the launcher is open, with a refresh button beside the drive (its tooltip says when it was measured).
  • More than one drive: a dropdown for all drives or one; Remove then lets go only that drive's files.
  • Sizes under 1 MB show in KB, so a nearly empty drive doesn't read as "0 MB".

Game files, one row per copy on the disk (Disk.MeasureCopies): romfs folders that share hard links are one copy, named by the versions using it, with what removing them frees. A copy that folders outside the launcher's also link to (a developer's base, an old builds folder) says so and how little removing its versions frees. On Windows it names those folders (FileLinks.Names, FindFirstFileNameW); Linux has no call to list a file's names, so there it only says "other folders".

Installed games lists each version (removed through Home's own delete, saves brought out first) and every game folder in the builds folder that no row lists (Leftovers.All): old versions an update left, folders the player chose to keep, a version taken off the list with its files kept. Each is measured whole, its game files counted with the copies, and deleted through LauncherService.DeleteLeftover (a save still in it is backed up first). A folder holding the player's mods is never deleted from here.

Shader caches: one row per version, plus the shared shader store from #210 as its own row, cleared on its own (ShaderCaches.ClearStore; each version's caches see the store changed and start over).

Build work is kept by default. The object and lift stores are passed to make_game, capped at 4 GB of objects and two translations. Turning off Keep the most recent build's files cleans the build work and stores after a successful build (Storage.AfterBuild); a failed or stopped build can leave them behind. Settings' Free up space dialog is replaced by Manage storage.

Navigation: the title bar has tabs, each icon with a small label: Home, Saves, NFC, Storage, Settings. The page shown is lit, and the tabs are on those pages only (a build or a transfer keeps its own way back). The pages' Back/Done buttons and Home's Manage saves and NFC cards are gone. Leaving Settings saves it and leaving NFC stops a scan (ILeavingPage). A controller's B goes Home where a page has no back of its own.

Rebased on #210 and #220

#210's Free up space store option and its texts (ShaderCaches.ClearText, StoreHint) went with the dialog. The store is the Storage page's row instead, so nothing #210 could clear is lost.

Testing

  • Core checks: python -I tests/test_launcher_core.py, 2163 passed. The new checks are in StorageChecks.cs, with additions to LeftoverChecks, PadChecks, ScreenChecks and ShaderCacheChecks. They cover:

    • every byte counted once across hard links, and copies told apart;
    • files linked from outside the measured folders not counted as freed;
    • unlisted folders, and the refusals (running, mods, another drive);
    • the store's own files only;
    • Remove taking only what an item is.

    Run locally with UnlistedChecks and SavesChecks.Run skipped: both fail on main on this Windows PC too. The skip is not in the commit.

  • Build: dotnet build LongshotLauncher.slnx -warnaserror, Debug and Release, 0 warnings.

  • Tooling's test_release.py: 3 failures (test_the_bump, test_the_next_stable, test_check_tag_against_the_published_releases). main at dad2200 fails the same three on this PC.

  • mise run lint not run: gitleaks and shellcheck aren't installed here. No shell script changed.

  • The real launcher, on a home with a nightly, two PR runtimes in the builds folder and their dev bases:

    • the measure, the copies, the outside folders named;
    • deleting a PR runtime's folder from Installed games;
    • the drives dropdown;
    • the tabs.
  • Screenshots: the tools/screenshots scenes storage, storage-games, storage-copies, storage-shaders, storage-drives, storage-running, storage-deleting, storage-measuring, storage-drive-c and home. Pictures are in the first comment.

🤖 Generated with Claude Code

Players can't see what Longshot keeps on their disk, or let any of it go one part at a time: the only tool was Settings' *Free up space*, all or nothing, and the launcher quietly kept up to ~8.5 GB of older builds' work (the object and lift stores). Old versions an update left in the builds folder took ~25-40 GB each and showed nowhere but a notice on Home. **Type:** feat · **Risk:** medium (it deletes folders; every delete goes through the launcher's existing guarded deletes) · **Tested on:** Windows 11 Pro (22631), .NET SDK 10.0.404, the launcher run against a real launcher home with a nightly, PR runtimes and an old version's folder · **Not tested:** Linux ## What changed **A Storage page** (the title bar's *Storage* tab, and *Manage storage* in Settings), `Core/Storage.cs`, `App/ViewModels/StorageViewModel.cs`: - What Longshot keeps **by what it is for**, never by build: Game files, Installed games, Shader caches, Faster updates, Build tools, Your data. One bar shows the split, the groups' tabs sit above it, and the group shown lists its items, each with its size, what removing it costs (asked first), and *Remove*. - A *Remove* that can't be pressed now is disabled with a tooltip saying why (Longshot is running, a download is running, the folder holds your mods). *Remove all* per group; in Installed games it reads *Remove those not in your versions* and never touches a listed version. - Measured off the window's thread with a pinned progress bar and spinner; a removal shows how much is freed so far. The measure is kept while the launcher is open, with a refresh button beside the drive (its tooltip says when it was measured). - **More than one drive:** a dropdown for all drives or one; Remove then lets go only that drive's files. - Sizes under 1 MB show in KB, so a nearly empty drive doesn't read as "0 MB". **Game files, one row per copy on the disk** (`Disk.MeasureCopies`): `romfs` folders that share hard links are one copy, named by the versions using it, with what removing them frees. A copy that folders outside the launcher's also link to (a developer's base, an old builds folder) says so and how little removing its versions frees. On Windows it names those folders (`FileLinks.Names`, `FindFirstFileNameW`); Linux has no call to list a file's names, so there it only says "other folders". **Installed games** lists each version (removed through Home's own delete, saves brought out first) and **every game folder in the builds folder that no row lists** (`Leftovers.All`): old versions an update left, folders the player chose to keep, a version taken off the list with its files kept. Each is measured whole, its game files counted with the copies, and deleted through `LauncherService.DeleteLeftover` (a save still in it is backed up first). A folder holding the player's mods is never deleted from here. **Shader caches:** one row per version, plus the **shared shader store** from #210 as its own row, cleared on its own (`ShaderCaches.ClearStore`; each version's caches see the store changed and start over). **Build work is kept by default.** The object and lift stores are passed to make_game, capped at 4 GB of objects and two translations. Turning off *Keep the most recent build's files* cleans the build work and stores after a successful build (`Storage.AfterBuild`); a failed or stopped build can leave them behind. Settings' *Free up space* dialog is replaced by *Manage storage*. **Navigation:** the title bar has tabs, each icon with a small label: Home, Saves, NFC, Storage, Settings. The page shown is lit, and the tabs are on those pages only (a build or a transfer keeps its own way back). The pages' Back/Done buttons and Home's *Manage saves* and *NFC* cards are gone. Leaving Settings saves it and leaving NFC stops a scan (`ILeavingPage`). A controller's **B** goes Home where a page has no back of its own. ## Rebased on #210 and #220 #210's *Free up space* store option and its texts (`ShaderCaches.ClearText`, `StoreHint`) went with the dialog. The store is the Storage page's row instead, so nothing #210 could clear is lost. ## Testing - **Core checks:** `python -I tests/test_launcher_core.py`, 2163 passed. The new checks are in `StorageChecks.cs`, with additions to `LeftoverChecks`, `PadChecks`, `ScreenChecks` and `ShaderCacheChecks`. They cover: - every byte counted once across hard links, and copies told apart; - files linked from outside the measured folders not counted as freed; - unlisted folders, and the refusals (running, mods, another drive); - the store's own files only; - Remove taking only what an item is. Run locally with `UnlistedChecks` and `SavesChecks.Run` skipped: both fail on main on this Windows PC too. The skip is not in the commit. - **Build:** `dotnet build LongshotLauncher.slnx -warnaserror`, Debug and Release, 0 warnings. - **Tooling's `test_release.py`:** 3 failures (`test_the_bump`, `test_the_next_stable`, `test_check_tag_against_the_published_releases`). main at dad2200 fails the same three on this PC. - **`mise run lint` not run:** gitleaks and shellcheck aren't installed here. No shell script changed. - **The real launcher**, on a home with a nightly, two PR runtimes in the builds folder and their dev bases: - the measure, the copies, the outside folders named; - deleting a PR runtime's folder from Installed games; - the drives dropdown; - the tabs. - **Screenshots:** the `tools/screenshots` scenes `storage`, `storage-games`, `storage-copies`, `storage-shaders`, `storage-drives`, `storage-running`, `storage-deleting`, `storage-measuring`, `storage-drive-c` and `home`. Pictures are in the first comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(storage): a Storage page, and tabs in the title bar
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 15s
0b1c6f990a
Players can't see what Longshot keeps on their disk or let it go, and the
launcher kept up to ~8.5 GB of older builds' work nobody asked for.

- Storage: what Longshot keeps by what it is for (game files, installed
  games, shader caches, faster updates, build tools, your data), one bar of
  the groups, each item with its size, what removing it costs, and Remove
  (disabled with why while Longshot or a download holds it). Measured off
  the window's thread with a pinned progress bar, kept until refreshed;
  sizes below 1 MB in KB.
- Game files one row a copy: romfs folders that share hard links are one
  copy (Disk.MeasureCopies), named by the versions using it; a copy other
  folders link to says so, and names them on Windows (FileLinks.Names).
- Installed games: each version, removed through Home's delete; and every
  game folder in the builds folder no row lists (Leftovers.All), deleted
  through the launcher's delete, never one with the player's mods.
- Shader caches: one row a version, and the shader store every version
  shares (main's, #210) as its own row, cleared on its own.
- Several drives: a dropdown for all of them or one; Remove lets go only
  that drive's.
- Only the most recent build's work is kept: the object and lift stores are
  no longer passed to make_game (their variables cleared), what they left
  goes after the next build; Keep the most recent build's files is a
  setting. Settings' Free up space dialog is replaced by Manage storage.
- Title bar tabs (Home, Saves, NFC, Storage, Settings) with small labels,
  the page shown lit; the pages' Back/Done buttons and Home's saves and NFC
  cards go. A controller's B goes Home where a page has no back of its own.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Screenshots, from tools/screenshots (made-up builds and paths, nothing of the game):

The Storage tab: Faster updates, the bar and the groups' tabs, the labelled title-bar tabs
storage

Installed games: the listed versions, and an old version's folder no row lists
installed games

Game files, one row per copy: a copy shared by two versions, an old version's own, and one linked from folders outside the launcher's, named
game files by copy

Shader caches: one row per version, and the shared shader store
shader caches

Two drives: the dropdown in place of the free space
two drives

Home: no saves or NFC cards; the tabs reach them
home

Screenshots, from `tools/screenshots` (made-up builds and paths, nothing of the game): **The Storage tab:** Faster updates, the bar and the groups' tabs, the labelled title-bar tabs ![storage](https://git.magicbean.dev/attachments/e9f9af5c-c3b1-4855-86ba-ea0f446b0489) **Installed games:** the listed versions, and an old version's folder no row lists ![installed games](https://git.magicbean.dev/attachments/fc6c8bcb-6d83-4a04-90b0-0e516d9d5e3a) **Game files, one row per copy:** a copy shared by two versions, an old version's own, and one linked from folders outside the launcher's, named ![game files by copy](https://git.magicbean.dev/attachments/fc83e4ef-f55c-4489-ab34-94bf2be689c5) **Shader caches:** one row per version, and the shared shader store ![shader caches](https://git.magicbean.dev/attachments/f4484f67-f38b-40f7-a14a-000088fd0115) **Two drives:** the dropdown in place of the free space ![two drives](https://git.magicbean.dev/attachments/6999227d-96c1-45c7-bbdf-143423e9f805) **Home:** no saves or NFC cards; the tabs reach them ![home](https://git.magicbean.dev/attachments/eb529407-c795-4618-965e-277244aca9ae)
BeanBot requested changes 2026-11-21 00:36:02 +00:00
Dismissed
BeanBot left a comment

Recommendation: Request changes. The Storage page gives players useful control over disk space, but its deletion paths can overlap a build, remove mods added after measurement, and cross a selected drive boundary. Disabling the build stores also removes reuse for returning to an older build without measuring the added build time.

Adds a Storage page with per-item cleanup, moves navigation into title-bar tabs, and replaces the build-store policy with retention of the most recent build. The Windows walkthrough shows parts of the UI working. Deletion needs launcher-wide coordination, and the size estimates and deletion targets need to come from the same set of files.

Does it help: Unproven for the build-cache tradeoff. The description cites up to about 8.5 GB retained under the old policy and about 1.6 GB of translation data per store write. It provides no repeated base-versus-HEAD runs on matching hardware, builds and settings. Measure stable-to-nightly-to-stable, a return to an already-built PR, and a routine forward update, recording elapsed time, peak disk use and retained bytes.
Other systems: The cleanup paths share files with builds, prefetch, Home's deletion actions, save backups and the shared shader store. Home also uses Disk.Measure, so its measurements take the modified path. Linux and Steam Deck drive filtering and deletion were untested. Clearing shader caches or the shared store can delay the next launch across GPU vendors. The PR supplies no cross-vendor shader rebuild timings. No direct change to gameplay rendering, audio or input was found. Controller navigation changes in the launcher.
Switches: KeepBuildFiles defaults to true and retains the latest build's work. With it off, cleanup must finish before another operation can use that work directory. LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE change from launcher-selected paths to unset in make_game. LONGSHOT_OBJ_STORE_GB changes from 4 to unset, and LONGSHOT_LIFT_STORE_KEEP from 2 to unset. This also strips user-supplied values. The README describes the policy, but the universal default lacks build-time evidence.

Reviewed: 0b1c6f990a against dad2200360: Read base AGENTS.md, CONTRIBUTING.md and docs/pull-requests.md. No review checklist or Forgejo PR template was present. Read the application and core diff, the new Storage code and view, and relevant callers for build completion, navigation, prefetch, shader caches, deletion and saves. Reviewed changed portions of the larger existing files. Skimmed the translation removals, screenshot scenes and author-reported runs. The committed screenshot was not visually inspected, and the supplied comments contained no screenshots or tester runs.; nothing run (a code review).
Checked and fine:

  • The commit uses Conventional Commit form and the description opens with the player problem. Package pins, signing keys, release tooling and CI are untouched.
  • The new filesystem fixtures use synthetic files. The diff adds no upload path for game files, saves or NFC dumps and introduces no Hookshot compatibility.
  • The per-version shader-cache removal still uses the existing guarded clear with pipeline notes excluded. The shared store clear still uses its existing file allowlist.
  • The core tests exercise basic hard-link accounting, work-part selection and small-size formatting. They leave gaps in deletion coordination, live mod protection and mounted-drive behavior.

Blocking (to change before merge)

  1. App/ViewModels/BuildStepViewModel.cs:618: Post-build cleanup races the next build. With KeepBuildFiles off, Ready appears while a worker can still recursively delete objcache and sa. A player can return Home and start another build using that work folder while deletion continues. Await cleanup before Ready or hold the same exclusive work-directory guard through cleanup and the next build's startup.
  2. App/ViewModels/StorageViewModel.cs:550: Deletion is guarded only by this Storage page instance. Start removing build files, switch to Home and start a build, or re-enter Storage and start another removal. The worker keeps deleting in the background. The once-sampled download flag also allows a prefetch that starts before a later batch item to lose its staging files. Serialize conflicting operations through the service and acquire the staging guard that prefetch uses before deleting staging.
  3. App/ViewModels/StorageViewModel.cs:542: Unlisted-folder deletion trusts the measured HoldsYours flag. Measure an unmodded folder, add a mod in the file manager, and remove it from the cached row. DeleteLeftover checks the folder and backs up saves but does not recheck mods. Revalidate mod and custom-link protection immediately before deletion, and add a test that changes the contents after measurement.
  4. App/ViewModels/StorageViewModel.cs:409: A listed version with mods can be removed from Storage. Listed items never receive HoldsYours and the row invokes Home's whole-folder delete. A player can lose their installed mods despite the PR's protection promise. Apply the mod guard to listed versions reached from Storage and recheck it at execution.
  5. Core/Storage.cs:302: The drive filter checks p.Work rather than the paths it deletes. On Linux, a separately mounted objcache under work is measured on its own drive, but removing compiled code on the parent drive can walk into that mount and delete its files. Selecting the objcache drive can instead report success without deleting it. Use the drive of each actual target and prevent recursive deletes from crossing mount boundaries.
  6. App/ViewModels/StorageViewModel.cs:59: Bulk confirmation recalculates the deletion list when Remove is pressed. For example, if a download finishes while the Build Tools confirmation is open, the next watcher tick can add Unfinished downloads to an already-open confirmation. Capture the confirmed targets and revalidate eligibility at execution. Require fresh confirmation before adding targets.
  7. App/ViewModels/StorageViewModel.cs:407: Refresh leaves removal enabled against the old rows because Measure sets IsBusy while the commands check only removing. A player can refresh, start a deletion during the scan, and have the scan callback clear removing while deletion is still in flight. Gate both confirmation and execution on the same operation state, and publish results only from the active operation.
  8. Core/Storage.cs:164: Storage measures a different set of paths from the one it clears. A directory called spirv.pack.backup is walked and counted as shader-store data, but ClearStore only deletes direct files. A linked measurement root can also be walked because Disk.Walk only checks descendants. Use the same enumeration for measurement and deletion, and skip linked roots so linked saves and caches do not inflate totals.
  9. Core/Storage.cs:193: Per-version shader caches bypass hard-link accounting. Two listed folders with a hard-linked cache file each show the full size and claim their own removal frees it. Run cache files and pipeline notes through the same identity accounting as other files, and calculate bulk frees across the confirmed targets so the last link is counted once.
  10. App/ViewModels/StorageViewModel.cs:551: The success toast reports measured bytes as freed even when no files went. For example, deleting older logs skips the current launcher log and can skip open files, yet the measurement includes them and the worker credits the full estimate. Exclude files that are kept, report measured estimates as estimates, and distinguish no-op or partial deletion from success.
  11. The repository requires one topic per PR. Global navigation and removal of Home's Saves and NFC entry cards change unrelated workflows and can ship independently of Storage. Split the global navigation change and the build-store retention policy from the Storage page, which can be reached from Settings.

Waiting on the author (a run, a measurement or a decision; no edit does it)

  • Core/MakeGameCommand.cs:94: Returning to a previously built stable or PR after an intervening build can now recompile or retranslate work the base could reuse. Measure that workflow and forward updates against the base before removing the stores by default, including the cost on slower hardware and the disk space saved.

Suggestions (the author may take or leave)

  • Reuse the Settings save-on-leave hook for Manage storage. That button currently saves immediately before the same navigation saves again.

Testing: Static review only. The author reports 2,163 core checks with UnlistedChecks and SavesChecks skipped locally, clean Windows Debug and Release builds, and a Windows walkthrough. Three Tooling release checks reportedly fail on both base and HEAD on that PC. No lint result or Linux run was supplied. The local author report does not establish a full-suite or ci:smoke pass. Add regression coverage for re-entering Storage mid-delete, a refresh racing deletion, mods added after measurement, and nested mount boundaries.
Overlaps and merge order: #210's shared shader store and #220's shader-cache transfer behavior are part of the base this change builds on. No separate merge prerequisite was identified in the supplied checkout.


Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The Storage page gives players useful control over disk space, but its deletion paths can overlap a build, remove mods added after measurement, and cross a selected drive boundary. Disabling the build stores also removes reuse for returning to an older build without measuring the added build time. Adds a Storage page with per-item cleanup, moves navigation into title-bar tabs, and replaces the build-store policy with retention of the most recent build. The Windows walkthrough shows parts of the UI working. Deletion needs launcher-wide coordination, and the size estimates and deletion targets need to come from the same set of files. **Does it help:** Unproven for the build-cache tradeoff. The description cites up to about 8.5 GB retained under the old policy and about 1.6 GB of translation data per store write. It provides no repeated base-versus-HEAD runs on matching hardware, builds and settings. Measure stable-to-nightly-to-stable, a return to an already-built PR, and a routine forward update, recording elapsed time, peak disk use and retained bytes. **Other systems:** The cleanup paths share files with builds, prefetch, Home's deletion actions, save backups and the shared shader store. Home also uses Disk.Measure, so its measurements take the modified path. Linux and Steam Deck drive filtering and deletion were untested. Clearing shader caches or the shared store can delay the next launch across GPU vendors. The PR supplies no cross-vendor shader rebuild timings. No direct change to gameplay rendering, audio or input was found. Controller navigation changes in the launcher. **Switches:** KeepBuildFiles defaults to true and retains the latest build's work. With it off, cleanup must finish before another operation can use that work directory. LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE change from launcher-selected paths to unset in make_game. LONGSHOT_OBJ_STORE_GB changes from 4 to unset, and LONGSHOT_LIFT_STORE_KEEP from 2 to unset. This also strips user-supplied values. The README describes the policy, but the universal default lacks build-time evidence. **Reviewed:** 0b1c6f990a59 against dad220036044: Read base AGENTS.md, CONTRIBUTING.md and docs/pull-requests.md. No review checklist or Forgejo PR template was present. Read the application and core diff, the new Storage code and view, and relevant callers for build completion, navigation, prefetch, shader caches, deletion and saves. Reviewed changed portions of the larger existing files. Skimmed the translation removals, screenshot scenes and author-reported runs. The committed screenshot was not visually inspected, and the supplied comments contained no screenshots or tester runs.; nothing run (a code review). **Checked and fine:** - The commit uses Conventional Commit form and the description opens with the player problem. Package pins, signing keys, release tooling and CI are untouched. - The new filesystem fixtures use synthetic files. The diff adds no upload path for game files, saves or NFC dumps and introduces no Hookshot compatibility. - The per-version shader-cache removal still uses the existing guarded clear with pipeline notes excluded. The shared store clear still uses its existing file allowlist. - The core tests exercise basic hard-link accounting, work-part selection and small-size formatting. They leave gaps in deletion coordination, live mod protection and mounted-drive behavior. **Blocking** (to change before merge) 1. App/ViewModels/BuildStepViewModel.cs:618: Post-build cleanup races the next build. With KeepBuildFiles off, Ready appears while a worker can still recursively delete objcache and sa. A player can return Home and start another build using that work folder while deletion continues. Await cleanup before Ready or hold the same exclusive work-directory guard through cleanup and the next build's startup. 2. App/ViewModels/StorageViewModel.cs:550: Deletion is guarded only by this Storage page instance. Start removing build files, switch to Home and start a build, or re-enter Storage and start another removal. The worker keeps deleting in the background. The once-sampled download flag also allows a prefetch that starts before a later batch item to lose its staging files. Serialize conflicting operations through the service and acquire the staging guard that prefetch uses before deleting staging. 3. App/ViewModels/StorageViewModel.cs:542: Unlisted-folder deletion trusts the measured HoldsYours flag. Measure an unmodded folder, add a mod in the file manager, and remove it from the cached row. DeleteLeftover checks the folder and backs up saves but does not recheck mods. Revalidate mod and custom-link protection immediately before deletion, and add a test that changes the contents after measurement. 4. App/ViewModels/StorageViewModel.cs:409: A listed version with mods can be removed from Storage. Listed items never receive HoldsYours and the row invokes Home's whole-folder delete. A player can lose their installed mods despite the PR's protection promise. Apply the mod guard to listed versions reached from Storage and recheck it at execution. 5. Core/Storage.cs:302: The drive filter checks p.Work rather than the paths it deletes. On Linux, a separately mounted objcache under work is measured on its own drive, but removing compiled code on the parent drive can walk into that mount and delete its files. Selecting the objcache drive can instead report success without deleting it. Use the drive of each actual target and prevent recursive deletes from crossing mount boundaries. 6. App/ViewModels/StorageViewModel.cs:59: Bulk confirmation recalculates the deletion list when Remove is pressed. For example, if a download finishes while the Build Tools confirmation is open, the next watcher tick can add Unfinished downloads to an already-open confirmation. Capture the confirmed targets and revalidate eligibility at execution. Require fresh confirmation before adding targets. 7. App/ViewModels/StorageViewModel.cs:407: Refresh leaves removal enabled against the old rows because Measure sets IsBusy while the commands check only removing. A player can refresh, start a deletion during the scan, and have the scan callback clear removing while deletion is still in flight. Gate both confirmation and execution on the same operation state, and publish results only from the active operation. 8. Core/Storage.cs:164: Storage measures a different set of paths from the one it clears. A directory called spirv.pack.backup is walked and counted as shader-store data, but ClearStore only deletes direct files. A linked measurement root can also be walked because Disk.Walk only checks descendants. Use the same enumeration for measurement and deletion, and skip linked roots so linked saves and caches do not inflate totals. 9. Core/Storage.cs:193: Per-version shader caches bypass hard-link accounting. Two listed folders with a hard-linked cache file each show the full size and claim their own removal frees it. Run cache files and pipeline notes through the same identity accounting as other files, and calculate bulk frees across the confirmed targets so the last link is counted once. 10. App/ViewModels/StorageViewModel.cs:551: The success toast reports measured bytes as freed even when no files went. For example, deleting older logs skips the current launcher log and can skip open files, yet the measurement includes them and the worker credits the full estimate. Exclude files that are kept, report measured estimates as estimates, and distinguish no-op or partial deletion from success. 11. The repository requires one topic per PR. Global navigation and removal of Home's Saves and NFC entry cards change unrelated workflows and can ship independently of Storage. Split the global navigation change and the build-store retention policy from the Storage page, which can be reached from Settings. **Waiting on the author** (a run, a measurement or a decision; no edit does it) - Core/MakeGameCommand.cs:94: Returning to a previously built stable or PR after an intervening build can now recompile or retranslate work the base could reuse. Measure that workflow and forward updates against the base before removing the stores by default, including the cost on slower hardware and the disk space saved. **Suggestions** (the author may take or leave) - Reuse the Settings save-on-leave hook for Manage storage. That button currently saves immediately before the same navigation saves again. **Testing:** Static review only. The author reports 2,163 core checks with UnlistedChecks and SavesChecks skipped locally, clean Windows Debug and Release builds, and a Windows walkthrough. Three Tooling release checks reportedly fail on both base and HEAD on that PC. No lint result or Linux run was supplied. The local author report does not establish a full-suite or ci:smoke pass. Add regression coverage for re-entering Storage mid-delete, a refresh racing deletion, mods added after measurement, and nested mount boundaries. **Overlaps and merge order:** #210's shared shader store and #220's shader-cache transfer behavior are part of the base this change builds on. No separate merge prerequisite was identified in the supplied checkout. --- <sub>Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
@ -614,0 +615,4 @@
// keeping off; an earlier launcher's object and lift stores go. Off the window's thread: thousands of files)
var work = service.Work;
var keep = s.KeepBuildFiles;
_ = Task.Run(() => Storage.AfterBuild(work, keep));
Member

With retention off, this can still delete objcache or sa when the next build starts. Await it before Ready or keep the build's exclusive work guard until it finishes.

With retention off, this can still delete objcache or sa when the next build starts. Await it before Ready or keep the build's exclusive work guard until it finishes.
@ -0,0 +56,4 @@
places = PlacesOf(main);
CancelCommand = new Command(() => { confirming = null; confirmingAll = false; RaiseItems(); });
AskAllCommand = new Command(() => { confirmingAll = true; confirming = null; RaiseItems(); }, () => CanClearAll);
RemoveAllCommand = new Command(() => _ = RemoveAsync(Clearable().ToList()), () => !removing);
Member

Freeze the confirmed target list. A download finishing during confirmation can otherwise add staging files to the operation.

Freeze the confirmed target list. A download finishing during confirmation can otherwise add staging files to the operation.
@ -0,0 +404,4 @@
var show = refusal != Storage.Refusal.NotRemovable && i.Bytes > 0 && confirming != i
&& (i.Kind != Storage.Kind.Programs || version != null);
return new Row(name, about, Durations.Size(i.Bytes), tag, tagInk, tagFill,
show, show && refusal == Storage.Refusal.None && !removing,
Member

Refresh sets IsBusy, so checking only removing leaves old rows actionable during a scan. Use one busy guard for measurement and deletion.

Refresh sets IsBusy, so checking only removing leaves old rows actionable during a scan. Use one busy guard for measurement and deletion.
@ -0,0 +406,4 @@
return new Row(name, about, Durations.Size(i.Bytes), tag, tagInk, tagFill,
show, show && refusal == Storage.Refusal.None && !removing,
removing ? Tr.T("Wait until what is being removed is gone.") : WhyNot(i.Kind, refusal), confirming == i, confirm,
version != null ? new Command(() => Main.Home.AskDelete(version, d => Deleted(d, version.Entry.Id), () => Deleting(version)))
Member

This allows Storage to delete a listed version with mods. Apply the promised mod guard here and recheck it before the folder goes.

This allows Storage to delete a listed version with mods. Apply the promised mod guard here and recheck it before the folder goes.
@ -0,0 +539,4 @@
// (a game folder no row lists: the launcher's delete, as Home's offer does it, its save backed up first)
void DeleteFolder(Storage.Game g)
{
if (service.DeleteLeftover(new Leftover(g.Folder, null)) is { } backup) backups.Add(backup);
Member

A mod added after measurement can be deleted here. Recheck mods and custom links at the point of deletion.

A mod added after measurement can be deleted here. Recheck mods and custom links at the point of deletion.
@ -0,0 +547,4 @@
{
foreach (var i in parts)
{
var r = Storage.Remove(i, places, running, downloading, own, deleteFolder: DeleteFolder);
Member

Tabs let this worker outlive the page while Home starts a build. The prefetch check can also go stale before staging deletion. Coordinate removal with the launcher operations that use these files.

Tabs let this worker outlive the page while Home starts a build. The prefetch check can also go stale before staging deletion. Coordinate removal with the launcher operations that use these files.
@ -0,0 +548,4 @@
foreach (var i in parts)
{
var r = Storage.Remove(i, places, running, downloading, own, deleteFolder: DeleteFolder);
if (r == Storage.Refusal.None) freed += i.Frees;
Member

This credits estimated bytes even for skipped files, including the active launcher log. Report completed removal separately from the estimate.

This credits estimated bytes even for skipped files, including the active launcher log. Report completed removal separately from the estimate.
@ -101,0 +91,4 @@
// translation ~1.6 GB a version), which only going back to one of them used, and saved each new translation's
// lifted C whole during the build. Null: one set on the PC is not passed on either. What an earlier launcher's stores
// left goes after the next build (Storage.AfterBuild), or from the Storage page)
["LONGSHOT_OBJ_STORE"] = null,
Member

Measure the time lost when revisiting a previously built stable or PR, as well as forward-update time and disk savings, before disabling both stores by default.

Measure the time lost when revisiting a previously built stable or PR, as well as forward-update time and disk savings, before disabling both stores by default.
Core/Storage.cs Outdated
@ -0,0 +161,4 @@
var measured = Disk.MeasureCopies(parts.Select(x => x.Path).ToList(), (i, name) =>
parts[i].Program ? NotProgram.Contains(name)
: parts[i].Kind == Kind.Unlisted ? name is Romfs or Exefs
: parts[i].Kind == Kind.ShaderStore ? !ShaderCaches.StoreNames.Any(n => name == n || name.StartsWith(n + ".", StringComparison.Ordinal))
Member

The walker includes matching directories and can walk a linked root. Use the same direct-file allowlist as ClearStore and reject linked roots.

The walker includes matching directories and can walk a linked root. Use the same direct-file allowlist as ClearStore and reject linked roots.
Core/Storage.cs Outdated
@ -0,0 +190,4 @@
var caches = ShaderCaches.ClearableBytes(path);
var notes = Math.Max(0, Disk.FolderBytes(cache) - caches);
Add(Kind.Programs, game, drive, s.Counted + notes, s.Frees + notes);
Add(Kind.ShaderCache, game, drive, caches, caches);
Member

Hard-linked caches are counted in full for each game and each removal claims the full bytes. Include them in identity-based accounting.

Hard-linked caches are counted in full for each game and each removal claims the full bytes. Include them in identity-based accounting.
Core/Storage.cs Outdated
@ -0,0 +299,4 @@
foreach (var g in p.Games.Where(g => !g.Unlisted && On(g.Folder))) DeleteFiles(Path.Combine(g.Folder, GameLogs), null);
break;
default:
if (On(p.Work)) Disk.FreeWork(p.Work, WorkPartsOf(item.Kind));
Member

A mount under work can be on another drive. Check the actual work parts and keep recursive removal inside the selected mount.

A mount under work can be on another drive. Check the actual work parts and keep recursive removal inside the selected mount.
fix(storage): the first measure's progress takes the bar's place
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 22s
c105e1ea7d
While nothing is measured yet the bar is hidden, so the progress notice sits
where it goes instead of below an empty space. Measuring again keeps the bar
(it has the last sizes) with the notice below it, as before.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Pushed c105e1e: during the first measure the bar is hidden, so the progress notice sits where the bar goes instead of below an empty space. Measuring again keeps the bar (it has the last sizes) with the notice below it, as before. Core checks: 2163 passed. Scene: storage-first-measure. first measure

Pushed c105e1e: during the first measure the bar is hidden, so the progress notice sits where the bar goes instead of below an empty space. Measuring again keeps the bar (it has the last sizes) with the notice below it, as before. Core checks: 2163 passed. Scene: storage-first-measure. ![first measure](https://git.magicbean.dev/attachments/e4dd0842-c59a-4f4e-8b46-51f1b00e8f9a)
HumanBean changed title from WIP: feat(storage): a Storage page, and tabs in the title bar to feat(storage): a Storage page, and tabs in the title bar 2026-11-21 02:11:12 +00:00
Owner
@fix
Member

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is 1c8f7ca003.

Changed

  • Live deletion guard: Core/Leftovers.cs:63 rechecks player data before deletion; tests/launcher_core/LeftoverChecks.cs:71 adds a mod after measurement.
  • Unreadable registry: App/LauncherService.cs:490 marks unlisted rows read-only and refuses deletion when the registry is unreadable.
  • Refresh and removal overlap: App/ViewModels/StorageViewModel.cs:413 guards removal while busy and captures places before deletion.
  • Log file selection: Core/Storage.cs:123 uses explicit log names and rotations for measurement and deletion, including loose game logs; tests/launcher_core/StorageChecks.cs:141 covers unrelated files.
  • Rooted holder fixture: tests/launcher_core/StorageChecks.cs:220 passes the rooted sampled file. Tests were not run, as requested.
  • Mod links: Core/Leftovers.cs:198 detects nested and dangling links without following them; tests/launcher_core/LeftoverChecks.cs:128 exercises the delete guard.
  • Linked partition roots: Core/Disk.cs:91 and Core/Disk.cs:259 skip linked roots; tests/launcher_core/StorageChecks.cs:24 covers a symlink or junction.
  • Backup recovery notice: App/ViewModels/StorageViewModel.cs:571 preserves FolderNotDeleted.Backup in the persistent Home notice.
  • External holders: Core/Storage.cs:225 derives the ROMFS-relative suffix, excludes known roots by containment and falls back to the containing directory.
  • Windows volume paths: Core/FileLinks.cs:237 uses an extended-path-sized volume buffer and preserves UNC roots.
  • Removal progress drive: App/ViewModels/StorageViewModel.cs:541 uses the measured target drive for single-drive work and indeterminate progress for multiple drives.
  • Progress animation: App/Views/StorageView.axaml:143 binds the sweep to busy state; App/Controls/Controls.cs:145 checks effective visibility and reduced motion.
  • Navigation guides: docs/nfc.md:4 and docs/controller.md:14 describe the title-bar navigation and B behavior.
  • Recheck unlisted folders before deletion: Core/BuildRegistry.cs:454 checks the guard after save backup and preserves the backup path on refusal; Core/Leftovers.cs:66 supplies the guard.
  • Exclude staging cleanup from installation: Core/ToolsPrefetch.cs:139 shares the install semaphore with staging cleanup, called from App/ViewModels/StorageViewModel.cs:562.
  • Retain build ownership during finalization: App/ViewModels/BuildStepViewModel.cs:576 prevents Stop during cleanup; App/MainWindow.axaml.cs:96 defers closing until it finishes.
  • Preserve drive-root holders: Core/Storage.cs:236 preserves the root separator; tests/launcher_core/StorageChecks.cs:230 adds a root fixture.
  • Fix Linux store assertion: tests/launcher_core/Program.cs:1128 checks the work-folder paths and both caps. Tests were not run.
  • Show retained stores: App/ViewModels/StorageViewModel.cs:368 includes both stores in the retained size and marks them kept.

Changed in part (the rest is for the author)

  • Launcher-wide cleanup lifetime: App/ViewModels/StorageViewModel.cs:539 captures places for the worker. Launcher-wide exclusion, immutable registry inputs, shutdown coordination and the navigation/re-entry test remain.
  • Post-build cleanup: App/ViewModels/BuildStepViewModel.cs:617 awaits cleanup of the captured work path and invalidates the snapshot afterward. Launcher-wide ownership across navigation and shutdown remains.
  • Stale measurements: App/ViewModels/MainViewModel.cs:265 and App/ViewModels/StorageViewModel.cs:144 add a launcher-owned scan generation. Other storage mutations still need to invalidate it consistently.
  • Observed removal results: App/ViewModels/StorageViewModel.cs:578 labels the old figure as an estimate. Per-file removed, skipped and failed results remain.
  • Measurement failures: App/ViewModels/StorageViewModel.cs:150 catches measurement exceptions and retains successful sizes. Explicit incomplete-scan reporting and a guaranteed finally restoration remain.
  • Cache policy measurement: Core/MakeGameCommand.cs:89 restores capped stores and Core/Storage.cs:320 retains them when keeping build files. The author must compare repeated base and head builds with identical inputs, versions, hardware and settings, reporting elapsed time and peak and retained disk use.
  • Document restored stores: README.md:475 and docs/pull-requests.md:57 describe the caps and opt-out. The author must update the PR description; the network is closed.

Left for the author

  • Prefetch exclusion: Implement shared exclusion between ToolsPrefetch installation and staging cleanup; the busy check still has a race.
  • Filesystem boundaries: Implement filesystem-identity inventory and deletion, including refusal of whole-folder removals that cross a filesystem.
  • Cache identity census: Feed exact shader-cache and store file sets into the identity-aware census, excluding store directories that cleanup leaves.
  • Bulk confirmation estimate: Freeze the confirmed target set and calculate its union’s reclaimable bytes, including shared files.
  • Settings inventory: Add shared and legacy per-game settings locations to Your Data and keep them disjoint from other categories.
  • Background discovery: Snapshot registry entries on the UI thread, then move game discovery and measurement to the worker.
  • Controller dispatch tests: Add B-button dispatch tests for a tab without Back, a modal and a wizard, including priority.
  • Launcher-wide deletion lifetime: The launcher-wide operation guard, registry snapshot, shutdown handling, and navigation test remain to be implemented.
  • Filesystem-scoped inventory and deletion: Filesystem identity checks and refusal of removals crossing a mounted filesystem remain to be implemented.
  • Invalidate scans around mutations: Mutation-wide scan invalidation and suppression of publication during mutations remain to be implemented.
  • Report removal outcomes: Removed, skipped, and failed outcomes still need to be returned and reflected in the completion notice.
  • Identity-aware cache and store census: The exact cache and store file sets still need to enter the shared identity census.
  • Freeze bulk targets and estimate their union: The confirmation still needs a frozen target set and a union-based estimate.
  • Inventory shared and legacy settings: Shared user settings and legacy game-root settings still need disjoint inventory categories.
  • Distinguish failed and partial scans: Partial-scan reporting, timestamp retention, and finally-based busy-state cleanup remain to be implemented.
  • Move discovery off the UI thread: Registry entries still need to be snapshotted on the UI thread and folder discovery moved to the worker.
  • Exercise controller Back dispatch: The tab, modal, and wizard dispatch and priority tests remain to be written.

Nothing was built or run: check the change. Its review follows.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is 1c8f7ca0030f. **Changed** - **Live deletion guard**: Core/Leftovers.cs:63 rechecks player data before deletion; tests/launcher_core/LeftoverChecks.cs:71 adds a mod after measurement. - **Unreadable registry**: App/LauncherService.cs:490 marks unlisted rows read-only and refuses deletion when the registry is unreadable. - **Refresh and removal overlap**: App/ViewModels/StorageViewModel.cs:413 guards removal while busy and captures places before deletion. - **Log file selection**: Core/Storage.cs:123 uses explicit log names and rotations for measurement and deletion, including loose game logs; tests/launcher_core/StorageChecks.cs:141 covers unrelated files. - **Rooted holder fixture**: tests/launcher_core/StorageChecks.cs:220 passes the rooted sampled file. Tests were not run, as requested. - **Mod links**: Core/Leftovers.cs:198 detects nested and dangling links without following them; tests/launcher_core/LeftoverChecks.cs:128 exercises the delete guard. - **Linked partition roots**: Core/Disk.cs:91 and Core/Disk.cs:259 skip linked roots; tests/launcher_core/StorageChecks.cs:24 covers a symlink or junction. - **Backup recovery notice**: App/ViewModels/StorageViewModel.cs:571 preserves FolderNotDeleted.Backup in the persistent Home notice. - **External holders**: Core/Storage.cs:225 derives the ROMFS-relative suffix, excludes known roots by containment and falls back to the containing directory. - **Windows volume paths**: Core/FileLinks.cs:237 uses an extended-path-sized volume buffer and preserves UNC roots. - **Removal progress drive**: App/ViewModels/StorageViewModel.cs:541 uses the measured target drive for single-drive work and indeterminate progress for multiple drives. - **Progress animation**: App/Views/StorageView.axaml:143 binds the sweep to busy state; App/Controls/Controls.cs:145 checks effective visibility and reduced motion. - **Navigation guides**: docs/nfc.md:4 and docs/controller.md:14 describe the title-bar navigation and B behavior. - **Recheck unlisted folders before deletion**: Core/BuildRegistry.cs:454 checks the guard after save backup and preserves the backup path on refusal; Core/Leftovers.cs:66 supplies the guard. - **Exclude staging cleanup from installation**: Core/ToolsPrefetch.cs:139 shares the install semaphore with staging cleanup, called from App/ViewModels/StorageViewModel.cs:562. - **Retain build ownership during finalization**: App/ViewModels/BuildStepViewModel.cs:576 prevents Stop during cleanup; App/MainWindow.axaml.cs:96 defers closing until it finishes. - **Preserve drive-root holders**: Core/Storage.cs:236 preserves the root separator; tests/launcher_core/StorageChecks.cs:230 adds a root fixture. - **Fix Linux store assertion**: tests/launcher_core/Program.cs:1128 checks the work-folder paths and both caps. Tests were not run. - **Show retained stores**: App/ViewModels/StorageViewModel.cs:368 includes both stores in the retained size and marks them kept. **Changed in part (the rest is for the author)** - **Launcher-wide cleanup lifetime**: App/ViewModels/StorageViewModel.cs:539 captures places for the worker. Launcher-wide exclusion, immutable registry inputs, shutdown coordination and the navigation/re-entry test remain. - **Post-build cleanup**: App/ViewModels/BuildStepViewModel.cs:617 awaits cleanup of the captured work path and invalidates the snapshot afterward. Launcher-wide ownership across navigation and shutdown remains. - **Stale measurements**: App/ViewModels/MainViewModel.cs:265 and App/ViewModels/StorageViewModel.cs:144 add a launcher-owned scan generation. Other storage mutations still need to invalidate it consistently. - **Observed removal results**: App/ViewModels/StorageViewModel.cs:578 labels the old figure as an estimate. Per-file removed, skipped and failed results remain. - **Measurement failures**: App/ViewModels/StorageViewModel.cs:150 catches measurement exceptions and retains successful sizes. Explicit incomplete-scan reporting and a guaranteed finally restoration remain. - **Cache policy measurement**: Core/MakeGameCommand.cs:89 restores capped stores and Core/Storage.cs:320 retains them when keeping build files. The author must compare repeated base and head builds with identical inputs, versions, hardware and settings, reporting elapsed time and peak and retained disk use. - **Document restored stores**: README.md:475 and docs/pull-requests.md:57 describe the caps and opt-out. The author must update the PR description; the network is closed. **Left for the author** - **Prefetch exclusion**: Implement shared exclusion between ToolsPrefetch installation and staging cleanup; the busy check still has a race. - **Filesystem boundaries**: Implement filesystem-identity inventory and deletion, including refusal of whole-folder removals that cross a filesystem. - **Cache identity census**: Feed exact shader-cache and store file sets into the identity-aware census, excluding store directories that cleanup leaves. - **Bulk confirmation estimate**: Freeze the confirmed target set and calculate its union’s reclaimable bytes, including shared files. - **Settings inventory**: Add shared and legacy per-game settings locations to Your Data and keep them disjoint from other categories. - **Background discovery**: Snapshot registry entries on the UI thread, then move game discovery and measurement to the worker. - **Controller dispatch tests**: Add B-button dispatch tests for a tab without Back, a modal and a wizard, including priority. - **Launcher-wide deletion lifetime**: The launcher-wide operation guard, registry snapshot, shutdown handling, and navigation test remain to be implemented. - **Filesystem-scoped inventory and deletion**: Filesystem identity checks and refusal of removals crossing a mounted filesystem remain to be implemented. - **Invalidate scans around mutations**: Mutation-wide scan invalidation and suppression of publication during mutations remain to be implemented. - **Report removal outcomes**: Removed, skipped, and failed outcomes still need to be returned and reflected in the completion notice. - **Identity-aware cache and store census**: The exact cache and store file sets still need to enter the shared identity census. - **Freeze bulk targets and estimate their union**: The confirmation still needs a frozen target set and a union-based estimate. - **Inventory shared and legacy settings**: Shared user settings and legacy game-root settings still need disjoint inventory categories. - **Distinguish failed and partial scans**: Partial-scan reporting, timestamp retention, and finally-based busy-state cleanup remain to be implemented. - **Move discovery off the UI thread**: Registry entries still need to be snapshotted on the UI thread and folder discovery moved to the worker. - **Exercise controller Back dispatch**: The tab, modal, and wizard dispatch and priority tests remain to be written. Nothing was built or run: check the change. Its review follows. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
fix(storage): protect player data and retain build caches
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
1c8f7ca003
As the review on #221 asked.
BeanBot requested changes 2026-11-21 02:28:41 +00:00
Dismissed
BeanBot left a comment

Recommendation: Request changes. Storage gives players useful control over disk use, but removal can still overlap Play or a build and can delete files on an unselected filesystem. A Stop accepted just before the build’s success callback can also leave cleanup running after Home has reopened.

Adds title-bar tabs and a Storage page that shows where disk space went and lets players remove individual categories. The latest fixes preserve the capped build stores by default, recheck for mods after save backup, and serialize staging cleanup with installs. The remaining cost is coordination across navigation, deletion, builds, and inventory refresh.

@fix will do (14)

  1. L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation.
  2. L5 App/ViewModels/BuildStepViewModel.cs:579: Finalizing starts in Complete, after the worker posts Exited. If the player confirms Stop after make_game has returned successfully but before the dispatcher handles Exited, Stop opens Home and the queued callback still registers the build, deletes its work with retention off, and can replace a newer page with Ready. Keep ownership through the exit handoff and settle Stop versus success once before either path navigates or deletes. Test with the success callback held in the queue.
  3. L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem.
  4. L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation.
  5. L13 App/ViewModels/StorageViewModel.cs:580: The new wording qualifies the bytes but still reports completion when files were skipped. If Windows holds a previous log open, DeleteFiles swallows the IOException and the toast gives no indication that the log stayed. Return removed, skipped and failed outcomes and use them in the completion notice.
  6. L15 (minor) Core/Storage.cs:189: Per-version caches bypass the identity census. If two versions hard-link a shader cache, each row counts the full file and says it frees the full size. Store measurement also walks matching directories such as spirv.pack.backup/, which ClearStore deliberately leaves alone. Feed the exact cache and store file sets into the same identity-aware census used for other categories.
  7. L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it.
  8. L19 (minor) Core/Storage.cs:135: The Your Data inventory misses the shared user settings and classifies older per-game settings at the game root as program files. For example, SaveEnvironment.LongshotUser can hold mods.json and longshot_options.ini beside save, but Storage only supplies the shared save subtree. Inventory the known settings locations and keep the categories disjoint.
  9. L20 (minor) App/ViewModels/StorageViewModel.cs:159: A first-scan exception says the last successful sizes are shown even when none exist. A permission error swallowed by Disk.Walk can instead publish a partial scan with a fresh timestamp. Distinguish failed and partial scans, keep the prior successful timestamp, and clear busy state in a finally path.
  10. L22 (minor) App/ViewModels/StorageViewModel.cs:108: Opening Storage synchronously discovers games and checks unlisted mod trees on the UI thread, then repeats discovery for the initial measurement. A sleeping build drive or a large mod tree can stall navigation before the spinner appears. Snapshot registry entries on the UI thread, then discover folders and measure them on the worker.
  11. L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority.
  12. L29 (minor) README.md: The PR still promises default removal of both stores, but default builds use and retain them. (more on the line)
  13. L30 (minor) Core/ToolsPrefetch.cs:141: Staging cleanup now waits for a fetch that starts after the button’s last busy refresh. (more on the line)
  14. L31 (minor) Core/BuildRegistry.cs:456: The tests do not exercise the new post-backup guard. (more on the line)
More: does it help, other systems, switches, what was read

Does it help: Unproven on 7ba82b1. The earlier Windows run showed the inventory, drive picker, and unlisted-folder removal working. The PR estimates 25–40 GB per old game folder, but gives no before-and-after disk measurement for the latest head. Default cache retention matches the base, and the claimed default disk saving no longer applies.

Other systems: Windows names external hard-link holders. Linux and Steam Deck use the same inventory and deletion paths, with mount scoping still open. Clearing the shared shader store makes versions prepare shaders again across GPU vendors. Build cleanup shares work paths with later builds, and staging cleanup shares the prefetch installer’s semaphore. Home and Storage share the unlisted-folder delete and surface its backup path.

Switches: KeepBuildFiles is new and defaults to on, preserving base behavior after successful builds. Turning it off requests removal of the work files and both stores after a successful build. LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE still point inside the work folder, with LONGSHOT_OBJ_STORE_GB=4 and LONGSHOT_LIFT_STORE_KEEP=2, as on the base. The on default preserves existing build reuse. The PR description still describes the superseded defaults.

Reviewed: 1c8f7ca003 against dad2200360: The checkout was at 7ba82b1eef38, despite the PR header naming c105e1e. Read AGENTS.md, CONTRIBUTING.md, the commits, and the full d53d7c4-to-HEAD diff. Read the Storage view model, Storage core, Leftovers, ToolsPrefetch, and the window close handler in context. Read the relevant sections of BuildStepViewModel, BuildRegistry, Disk, FileLinks, the save backup code, launcher services, navigation, and core tests. Earlier UI and documentation changes, translations, and screenshot fixtures were skimmed within the re-check scope. Remote images were unavailable.; nothing run (a code review).

Checked and fine:

  • Both unlisted-folder callers preserve and report a verified save backup when the final mod guard refuses deletion.
  • The Windows and Linux command assertions match the work-folder paths and store caps, and the root fixture exercises the path normalization.
  • The latest fix adds no package, signing, release-format, CI, or script changes. The description opens with the player problem and the comments provide screenshot references.

Testing: Read-only review. The author reported 2,163 core checks and a Windows launcher run on earlier revisions, with two checks skipped locally that also fail on the base. Three Tooling failures were reported on both branches. The latest fix report records no test run, supplied CI lists no failures or pending checks, and Linux and Steam Deck behavior remains unverified.

Overlaps and merge order: #210 and #220 are already incorporated in the review base. No other overlap was identified from the checkout and supplied discussion.


Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Storage gives players useful control over disk use, but removal can still overlap Play or a build and can delete files on an unselected filesystem. A Stop accepted just before the build’s success callback can also leave cleanup running after Home has reopened. Adds title-bar tabs and a Storage page that shows where disk space went and lets players remove individual categories. The latest fixes preserve the capped build stores by default, recheck for mods after save backup, and serialize staging cleanup with installs. The remaining cost is coordination across navigation, deletion, builds, and inventory refresh. **`@fix` will do (14)** 1. **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. 2. **L5** `App/ViewModels/BuildStepViewModel.cs:579`: Finalizing starts in Complete, after the worker posts Exited. If the player confirms Stop after make_game has returned successfully but before the dispatcher handles Exited, Stop opens Home and the queued callback still registers the build, deletes its work with retention off, and can replace a newer page with Ready. Keep ownership through the exit handoff and settle Stop versus success once before either path navigates or deletes. Test with the success callback held in the queue. 3. **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. 4. **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. 5. **L13** `App/ViewModels/StorageViewModel.cs:580`: The new wording qualifies the bytes but still reports completion when files were skipped. If Windows holds a previous log open, DeleteFiles swallows the IOException and the toast gives no indication that the log stayed. Return removed, skipped and failed outcomes and use them in the completion notice. 6. **L15** (minor) `Core/Storage.cs:189`: Per-version caches bypass the identity census. If two versions hard-link a shader cache, each row counts the full file and says it frees the full size. Store measurement also walks matching directories such as `spirv.pack.backup/`, which `ClearStore` deliberately leaves alone. Feed the exact cache and store file sets into the same identity-aware census used for other categories. 7. **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. 8. **L19** (minor) `Core/Storage.cs:135`: The Your Data inventory misses the shared user settings and classifies older per-game settings at the game root as program files. For example, `SaveEnvironment.LongshotUser` can hold `mods.json` and `longshot_options.ini` beside `save`, but Storage only supplies the shared save subtree. Inventory the known settings locations and keep the categories disjoint. 9. **L20** (minor) `App/ViewModels/StorageViewModel.cs:159`: A first-scan exception says the last successful sizes are shown even when none exist. A permission error swallowed by Disk.Walk can instead publish a partial scan with a fresh timestamp. Distinguish failed and partial scans, keep the prior successful timestamp, and clear busy state in a finally path. 10. **L22** (minor) `App/ViewModels/StorageViewModel.cs:108`: Opening Storage synchronously discovers games and checks unlisted mod trees on the UI thread, then repeats discovery for the initial measurement. A sleeping build drive or a large mod tree can stall navigation before the spinner appears. Snapshot registry entries on the UI thread, then discover folders and measure them on the worker. 11. **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. 12. **L29** (minor) `README.md`: The PR still promises default removal of both stores, but default builds use and retain them. (more on the line) 13. **L30** (minor) `Core/ToolsPrefetch.cs:141`: Staging cleanup now waits for a fetch that starts after the button’s last busy refresh. (more on the line) 14. **L31** (minor) `Core/BuildRegistry.cs:456`: The tests do not exercise the new post-backup guard. (more on the line) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven on 7ba82b1. The earlier Windows run showed the inventory, drive picker, and unlisted-folder removal working. The PR estimates 25–40 GB per old game folder, but gives no before-and-after disk measurement for the latest head. Default cache retention matches the base, and the claimed default disk saving no longer applies. **Other systems:** Windows names external hard-link holders. Linux and Steam Deck use the same inventory and deletion paths, with mount scoping still open. Clearing the shared shader store makes versions prepare shaders again across GPU vendors. Build cleanup shares work paths with later builds, and staging cleanup shares the prefetch installer’s semaphore. Home and Storage share the unlisted-folder delete and surface its backup path. **Switches:** `KeepBuildFiles` is new and defaults to on, preserving base behavior after successful builds. Turning it off requests removal of the work files and both stores after a successful build. `LONGSHOT_OBJ_STORE` and `LONGSHOT_LIFT_STORE` still point inside the work folder, with `LONGSHOT_OBJ_STORE_GB=4` and `LONGSHOT_LIFT_STORE_KEEP=2`, as on the base. The on default preserves existing build reuse. The PR description still describes the superseded defaults. **Reviewed:** 1c8f7ca0030f against dad220036044: The checkout was at 7ba82b1eef38, despite the PR header naming c105e1e. Read AGENTS.md, CONTRIBUTING.md, the commits, and the full d53d7c4-to-HEAD diff. Read the Storage view model, Storage core, Leftovers, ToolsPrefetch, and the window close handler in context. Read the relevant sections of BuildStepViewModel, BuildRegistry, Disk, FileLinks, the save backup code, launcher services, navigation, and core tests. Earlier UI and documentation changes, translations, and screenshot fixtures were skimmed within the re-check scope. Remote images were unavailable.; nothing run (a code review). **Checked and fine:** - Both unlisted-folder callers preserve and report a verified save backup when the final mod guard refuses deletion. - The Windows and Linux command assertions match the work-folder paths and store caps, and the root fixture exercises the path normalization. - The latest fix adds no package, signing, release-format, CI, or script changes. The description opens with the player problem and the comments provide screenshot references. **Testing:** Read-only review. The author reported 2,163 core checks and a Windows launcher run on earlier revisions, with two checks skipped locally that also fail on the base. Three Tooling failures were reported on both branches. The latest fix report records no test run, supplied CI lists no failures or pending checks, and Linux and Steam Deck behavior remains unverified. **Overlaps and merge order:** #210 and #220 are already incorporated in the review base. No other overlap was identified from the checkout and supplied discussion. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
@ -0,0 +394,4 @@
}
if (selected == Storage.Group.FasterUpdates)
{
var kept = KeepBuildFiles && i.Kind is Storage.Kind.RecentCode or Storage.Kind.RecentTranslation or Storage.Kind.OlderCode or Storage.Kind.OlderTranslations;
Member

L28 (minor): With KeepBuildFiles on, the restored object and lift stores still get a Goes after the next build badge. They survive that build, and the checkbox's size omits them. Show both stores as kept while the setting is on and make the label and size cover the full retained set.

**L28** (minor): With KeepBuildFiles on, the restored object and lift stores still get a Goes after the next build badge. They survive that build, and the checkbox's size omits them. Show both stores as kept while the setting is on and make the label and size cover the full retained set.
@ -454,1 +454,3 @@
try { Toolchains.DeleteTree(full); }
try
{
if (guard != null && !guard()) throw new IOException("The folder holds mods or links; move them out before removing it.");
Member

L31 (minor): The tests do not exercise the new post-backup guard. Use the existing save backup test hook to add a mod after the initial check, then assert that the game folder and mod survive and FolderNotDeleted carries the verified backup path. The check should fail if the guard moves above the backup.

**L31** (minor): The tests do not exercise the new post-backup guard. Use the existing save backup test hook to add a mod after the initial check, then assert that the game folder and mod survive and FolderNotDeleted carries the verified backup path. The check should fail if the guard moves above the backup.
@ -138,0 +138,4 @@
/// Run staging cleanup under the same exclusion as an install.
public void CleanStaging(Action cleanup)
{
one.Wait();
Member

L30 (minor): Staging cleanup now waits for a fetch that starts after the button’s last busy refresh. If the update check starts a download while the confirmation is open, clicking Remove can leave Storage showing removal progress for the duration of the fetch. Try to acquire the same semaphore immediately and return Downloading if it is held. Cover the case with a paused fetch.

**L30** (minor): Staging cleanup now waits for a fetch that starts after the button’s last busy refresh. If the update check starts a download while the confirmation is open, clicking Remove can leave Storage showing removal progress for the duration of the fetch. Try to acquire the same semaphore immediately and return Downloading if it is held. Cover the case with a paused fetch.
@ -484,3 +475,1 @@
pipeline notes (`longshot_pipelines.bin`), which hold the list the build shipped and only a build writes again. Each
version then prepares its shaders again at its next start. The settings say what is kept and why, with the shader
caches' size beside the build files'.
- **Build work is kept.** The build files folder keeps the last build's compiled objects
Member

L29 (minor): The README and PR description still say the stores are disabled and old data goes after the next build. With the default on, players can still have both stores afterward. Update the README, the PR-build guide and the description to explain the restored caps and what opting out removes.

**L29** (minor): The README and PR description still say the stores are disabled and old data goes after the next build. With the default on, players can still have both stores afterward. Update the README, the PR-build guide and the description to explain the restored caps and what opting out removes.
@ -1125,3 +1126,3 @@
&& l.Environment["LONGSHOT_SYSROOT"] == Path.Combine(lin.LibRoot, "sysroot") && l.Environment["EMSDK"] == Path.Combine(lin.LibRoot, "emsdk")
&& l.Environment["LONGSHOT_FFX_SDK"] == null, "Linux environment (DLSS builds its own Vulkan back end).");
Require(l.Environment["LONGSHOT_OBJ_STORE"] == Path.Combine("/w", "obj-store") && l.Environment["LONGSHOT_LIFT_STORE"] == Path.Combine("/w", "lift-store")
Require(l.Environment["LONGSHOT_OBJ_STORE"] == Path.Combine("/w", Disk.ObjectStore)
Member

L27: The Linux assertion references stores after the same commit removed its declaration. The core test project fails to compile on either host OS. Assert the restored store paths under /w and the 4 GB and two-translation caps, as the Windows check does for its work folder.

**L27**: The Linux assertion references stores after the same commit removed its declaration. The core test project fails to compile on either host OS. Assert the restored store paths under /w and the 4 GB and two-translation caps, as the Windows check does for its work folder.
Owner
@fix
Member

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is e92dd57d3f.

Changed

  • Settings inventory: Core/Storage.cs:90 and App/ViewModels/StorageViewModel.cs:116 inventory shared and per-game settings separately from programs and saves; added coverage in tests/launcher_core/StorageChecks.cs:95.
  • Nonblocking staging cleanup: Core/ToolsPrefetch.cs:139 tries the semaphore immediately; App/ViewModels/StorageViewModel.cs:564 reports a running download. Added a paused-fetch check in tests/launcher_core/PrefetchChecks.cs:41.
  • Post-backup mod guard test: tests/launcher_core/DeleteSaveChecks.cs:64 adds a mod during backup and checks that the folder survives and FolderNotDeleted reports the verified backup. Tests were not run, as requested.
  • Removal outcomes: Core/Storage.cs:287 reports removed, kept and failed log counts; App/ViewModels/StorageViewModel.cs:597 includes them in the notice.
  • Cache and store census: Core/Storage.cs:142 includes cache files in the identity census and excludes store-named directories; StorageChecks covers both cases.
  • Player settings classification: Core/Storage.cs:122 uses Saves.PlayerFiles; StorageChecks covers shared and per-game settings.
  • Worker-side folder discovery: App/ViewModels/StorageViewModel.cs:106 snapshots registry entries and discovers folders on the measurement worker; cached snapshots retain their discovered places.
  • Isolate late-mod backup: tests/launcher_core/DeleteSaveChecks.cs:71 gives the late-mod case its own backup folder.
  • Linked user directory: Core/Storage.cs:142 avoids scanning mods through a linked user directory; StorageChecks covers a linked parent.
  • Protect user mods: Core/Leftovers.cs:198 checks both mod locations in discovery and deletion guards; LeftoverChecks covers user/mods. Tests were not run.

Changed in part (the rest is for the author)

  • Build-store documentation: README.md:480 and docs/pull-requests.md:58 now say cleanup follows a successful build and failed or stopped builds can leave files. The author must update the pull request description with the default retention, 4 GB object cap, two-translation cap, opt-out, and successful-build condition.

Left for the author

  • Launcher-wide deletion guard: Still needs a launcher-wide operation guard, guarded registry snapshot, shutdown handling, and a paused-deletion navigation test.
  • Build exit handoff: Still needs Stop and success to settle ownership before navigation or cleanup, plus a queued-success test.
  • Filesystem-scoped removal: Still needs filesystem identities for inventory and deletion on Linux and Windows, including refusal of cross-filesystem folder removal.
  • Scan invalidation during mutations: Still needs mutation-wide scan invalidation and publication guards across Home and Storage.
  • Removal outcomes: Still needs removed, skipped, and failed outcomes propagated to the completion notice.
  • Cache and store census: Still needs exact cache and store file sets measured through the identity-aware census.
  • Bulk removal estimate: Still needs a frozen confirmation target set and a union-based free-space estimate.
  • Scan failure reporting: Still needs partial-scan detection, accurate first-scan messaging, preserved timestamps, and finally-based busy-state cleanup.
  • Background discovery: Still needs registry entries captured on the UI thread and folder discovery and measurement moved to the worker.
  • Controller Back dispatch: Still needs behavioral tests for tab fallback, modal priority, and wizard Back dispatch.
  • Deletion lifetime and registry snapshot: Still needs a launcher-wide operation guard, a registry snapshot under that guard, and a paused-deletion navigation test.
  • Build exit handoff: Still needs Stop and success to settle ownership before navigation or cleanup, with a queued-success regression test.
  • Filesystem-scoped removal: Still needs filesystem identities for inventory and deletion and a guard against crossing mounted filesystems.
  • Storage scan invalidation: Still needs mutation-wide invalidation and prevention of scan publication during mutations.
  • Bulk removal estimate: Still needs a frozen confirmation target set and a union-based estimate.
  • Failed and partial scans: Still needs partial-scan detection, accurate failure messaging, timestamp preservation and finally-based busy cleanup.
  • Controller Back dispatch tests: Still needs dispatch tests for a tab page, modal and wizard, including priority.
  • PR description: Update the PR description to say both stores are kept by default, capped at 4 GB of objects and two translations; opting out cleans them after success, while failed or stopped builds can leave them behind.

Nothing was built or run: check the change. Its review follows.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is e92dd57d3fd1. **Changed** - **Settings inventory**: Core/Storage.cs:90 and App/ViewModels/StorageViewModel.cs:116 inventory shared and per-game settings separately from programs and saves; added coverage in tests/launcher_core/StorageChecks.cs:95. - **Nonblocking staging cleanup**: Core/ToolsPrefetch.cs:139 tries the semaphore immediately; App/ViewModels/StorageViewModel.cs:564 reports a running download. Added a paused-fetch check in tests/launcher_core/PrefetchChecks.cs:41. - **Post-backup mod guard test**: tests/launcher_core/DeleteSaveChecks.cs:64 adds a mod during backup and checks that the folder survives and FolderNotDeleted reports the verified backup. Tests were not run, as requested. - **Removal outcomes**: Core/Storage.cs:287 reports removed, kept and failed log counts; App/ViewModels/StorageViewModel.cs:597 includes them in the notice. - **Cache and store census**: Core/Storage.cs:142 includes cache files in the identity census and excludes store-named directories; StorageChecks covers both cases. - **Player settings classification**: Core/Storage.cs:122 uses Saves.PlayerFiles; StorageChecks covers shared and per-game settings. - **Worker-side folder discovery**: App/ViewModels/StorageViewModel.cs:106 snapshots registry entries and discovers folders on the measurement worker; cached snapshots retain their discovered places. - **Isolate late-mod backup**: tests/launcher_core/DeleteSaveChecks.cs:71 gives the late-mod case its own backup folder. - **Linked user directory**: Core/Storage.cs:142 avoids scanning mods through a linked user directory; StorageChecks covers a linked parent. - **Protect user mods**: Core/Leftovers.cs:198 checks both mod locations in discovery and deletion guards; LeftoverChecks covers user/mods. Tests were not run. **Changed in part (the rest is for the author)** - **Build-store documentation**: README.md:480 and docs/pull-requests.md:58 now say cleanup follows a successful build and failed or stopped builds can leave files. The author must update the pull request description with the default retention, 4 GB object cap, two-translation cap, opt-out, and successful-build condition. **Left for the author** - **Launcher-wide deletion guard**: Still needs a launcher-wide operation guard, guarded registry snapshot, shutdown handling, and a paused-deletion navigation test. - **Build exit handoff**: Still needs Stop and success to settle ownership before navigation or cleanup, plus a queued-success test. - **Filesystem-scoped removal**: Still needs filesystem identities for inventory and deletion on Linux and Windows, including refusal of cross-filesystem folder removal. - **Scan invalidation during mutations**: Still needs mutation-wide scan invalidation and publication guards across Home and Storage. - **Removal outcomes**: Still needs removed, skipped, and failed outcomes propagated to the completion notice. - **Cache and store census**: Still needs exact cache and store file sets measured through the identity-aware census. - **Bulk removal estimate**: Still needs a frozen confirmation target set and a union-based free-space estimate. - **Scan failure reporting**: Still needs partial-scan detection, accurate first-scan messaging, preserved timestamps, and finally-based busy-state cleanup. - **Background discovery**: Still needs registry entries captured on the UI thread and folder discovery and measurement moved to the worker. - **Controller Back dispatch**: Still needs behavioral tests for tab fallback, modal priority, and wizard Back dispatch. - **Deletion lifetime and registry snapshot**: Still needs a launcher-wide operation guard, a registry snapshot under that guard, and a paused-deletion navigation test. - **Build exit handoff**: Still needs Stop and success to settle ownership before navigation or cleanup, with a queued-success regression test. - **Filesystem-scoped removal**: Still needs filesystem identities for inventory and deletion and a guard against crossing mounted filesystems. - **Storage scan invalidation**: Still needs mutation-wide invalidation and prevention of scan publication during mutations. - **Bulk removal estimate**: Still needs a frozen confirmation target set and a union-based estimate. - **Failed and partial scans**: Still needs partial-scan detection, accurate failure messaging, timestamp preservation and finally-based busy cleanup. - **Controller Back dispatch tests**: Still needs dispatch tests for a tab page, modal and wizard, including priority. - **PR description**: Update the PR description to say both stores are kept by default, capped at 4 GB of objects and two translations; opting out cleans them after success, while failed or stopped builds can leave them behind. Nothing was built or run: check the change. Its review follows. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
fix(storage): count settings and avoid waiting for downloads
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
e92dd57d3f
As the review on #221 asked.
BeanBot requested changes 2026-11-21 05:42:15 +00:00
Dismissed
BeanBot left a comment

Recommendation: Request changes. The new storage test declares the same local twice and prevents the core suite from compiling. Removal can still race a build or cross into an unselected filesystem, and changing the builds folder can leave Storage offering to delete folders from the previous location.

Storage gives players a breakdown of disk use, lets them remove individual categories, and replaces the all-or-nothing cleanup dialog. Title-bar tabs make Storage, Saves, NFC and Settings easier to reach. The latest fix improves hard-link accounting, protects unlisted games with mods under user/mods, and moves game discovery to the worker. The remaining cost is coordinating deletion, measurement and build completion across pages.

@fix will do (13)

  1. L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation.
  2. L5 App/ViewModels/BuildStepViewModel.cs:579: Finalizing starts in Complete, after the worker posts Exited. If the player confirms Stop after make_game has returned successfully but before the dispatcher handles Exited, Stop opens Home and the queued callback still registers the build, deletes its work with retention off, and can replace a newer page with Ready. Keep ownership through the exit handoff and settle Stop versus success once before either path navigates or deletes. Test with the success callback held in the queue.
  3. L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem.
  4. L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation.
  5. L13 App/ViewModels/StorageViewModel.cs:597: The notice now reports skipped and failed logs, but other removals can still report success after skipping files. If the shader-store directory becomes unreadable after measurement, StoreFiles returns an empty list, ClearStore returns zero, and Storage reports completion using the old estimate. Carry deletion outcomes through the shader and other removal paths and cover both a locked log and an unreadable store.
  6. L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it.
  7. L20 (minor) App/ViewModels/StorageViewModel.cs:137: A failed refresh now leaves the last sizes and timestamp on screen but replaces their discovered paths with an unfiltered registry snapshot. A later log removal can therefore act on a different set of games than the displayed total. Publish paths, sizes and timestamp together on success, distinguish first-scan failure and partial scans, and clear busy state in finally.
  8. L22 (minor) App/ViewModels/StorageViewModel.cs:60: Game and mod discovery now run on the worker, but opening Storage still calls RunningNow synchronously. On Linux that reads cmdline and comm under /proc before the spinner can paint. PlacesOf also probes for the shared user directory. Move these probes to the initial worker pass and keep affected actions disabled until it finishes.
  9. L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority.
  10. L29 (minor) README.md: The PR description still promises that make_game no longer receives the object and lift stores. Update it to say both are kept by default, capped at 4 GB of objects and two translations, and that opting out cleans them after a successful build. A failed or stopped build can leave them behind.
  11. L34 tests/launcher_core/StorageChecks.cs:95: The new store fixture declares shaderStore in the same method scope as the existing declaration at line 277. (more on the line)
  12. L35 App/ViewModels/StorageViewModel.cs:124: The snapshot key now uses listed rows and omits the builds folder used for unlisted discovery. (more on the line)
  13. L36 (minor) App/ViewModels/StorageViewModel.cs:423: The new census can assign zero counted bytes to a version that still has a removable cache. (more on the line)

Since the last review (on 1c8f7ca003)
Resolved: L15 (Per-version caches bypass the identity census. If two versions hard-link a shader cache, e…); L19 (The settings list omits mouse_sens.txt and present.txt, which Saves.PlayerFiles already id…); L30 (Staging cleanup now waits for a fetch that starts after the button’s last busy refresh. If…); L31 (The late-mod case creates a verified delete backup in windows.BackupRoot. The subsequent d…)
Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (Finalizing starts in Complete, after the worker posts Exited. If the player confirms Stop…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L13 (The notice now reports skipped and failed logs, but other removals can still report succes…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L20 (A failed refresh now leaves the last sizes and timestamp on screen but replaces their disc…); L22 (Game and mod discovery now run on the worker, but opening Storage still calls RunningNow s…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…); L29 (The PR description still promises that make_game no longer receives the object and lift st…)
New: L32 (Scanning user/mods directly bypasses Disk.Walk's link check on user. If a version's user d…); L33 (The unlisted-game guard checks only the root mods directory. An unlisted folder with a reg…); L34 (The new store fixture declares shaderStore in the same method scope as the existing declar…); L35 (The snapshot key now uses listed rows and omits the builds folder used for unlisted discov…); L36 (The new census can assign zero counted bytes to a version that still has a removable cache…)

More: does it help, other systems, switches, what was read

Does it help: Unproven at b73bfc2. Earlier Windows testing reports 2,163 core checks with two suites skipped, clean Debug and Release builds, and a manual Storage walkthrough. There is no Linux run or matched before-and-after timing for opening Storage or rebuilding with retention off. The latest core fixture has a compile error.

Other systems: Windows and Linux share the Storage and build paths but differ in process discovery, hard-link enumeration and mount handling. Home, Play, build completion and download staging can touch paths Storage displays or removes. Unlisted deletion backs up saves and checks both mod locations. Shared shader-store removal affects shader preparation across versions. Linux and Steam Deck behavior remain unverified.

Switches: KeepBuildFiles is new and defaults to on, preserving the recent build's work and the capped stores. Off clears them after a successful build. The existing LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE paths and their limits of 4 GB and two translations remain in effect during the build. README and the PR-build guide describe the current default and cleanup timing.

Reviewed: e92dd57d3f against dad2200360: Read AGENTS.md, CONTRIBUTING.md, the commit log and the six files changed since 63faa36 in full. Read the ledger-related sections of build, navigation, Home deletion, filesystem, shader, save and download code. Skimmed the remaining base diff, translations, screenshot fixtures and reported runs. No review checklist or PR template was present. The checkout is b73bfc2, matching the supplied range-diff.; nothing run (a code review).

Checked and fine:

  • The prefetch semaphore excludes staging cleanup while an install owns it. The source checks exercise refusal during the fetch and cleanup after it ends.
  • The late-mod test keeps the post-backup guard assertion and isolates its backup root.
  • The description opens with the player problem and includes screenshot evidence. The diff leaves package pins, release tooling, signing trust and CI definitions untouched.

Testing: Read-only review. No builds or tests executed. The supplied CI record lists no failing or running checks. The reported Windows results predate b73bfc2, and the fix report records no test run for the latest changes.

Overlaps and merge order: #210 and #220 are already in the base. No pending merge-order dependency is shown.


Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The new storage test declares the same local twice and prevents the core suite from compiling. Removal can still race a build or cross into an unselected filesystem, and changing the builds folder can leave Storage offering to delete folders from the previous location. Storage gives players a breakdown of disk use, lets them remove individual categories, and replaces the all-or-nothing cleanup dialog. Title-bar tabs make Storage, Saves, NFC and Settings easier to reach. The latest fix improves hard-link accounting, protects unlisted games with mods under user/mods, and moves game discovery to the worker. The remaining cost is coordinating deletion, measurement and build completion across pages. **`@fix` will do (13)** 1. **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. 2. **L5** `App/ViewModels/BuildStepViewModel.cs:579`: Finalizing starts in Complete, after the worker posts Exited. If the player confirms Stop after make_game has returned successfully but before the dispatcher handles Exited, Stop opens Home and the queued callback still registers the build, deletes its work with retention off, and can replace a newer page with Ready. Keep ownership through the exit handoff and settle Stop versus success once before either path navigates or deletes. Test with the success callback held in the queue. 3. **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. 4. **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. 5. **L13** `App/ViewModels/StorageViewModel.cs:597`: The notice now reports skipped and failed logs, but other removals can still report success after skipping files. If the shader-store directory becomes unreadable after measurement, StoreFiles returns an empty list, ClearStore returns zero, and Storage reports completion using the old estimate. Carry deletion outcomes through the shader and other removal paths and cover both a locked log and an unreadable store. 6. **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. 7. **L20** (minor) `App/ViewModels/StorageViewModel.cs:137`: A failed refresh now leaves the last sizes and timestamp on screen but replaces their discovered paths with an unfiltered registry snapshot. A later log removal can therefore act on a different set of games than the displayed total. Publish paths, sizes and timestamp together on success, distinguish first-scan failure and partial scans, and clear busy state in finally. 8. **L22** (minor) `App/ViewModels/StorageViewModel.cs:60`: Game and mod discovery now run on the worker, but opening Storage still calls RunningNow synchronously. On Linux that reads cmdline and comm under /proc before the spinner can paint. PlacesOf also probes for the shared user directory. Move these probes to the initial worker pass and keep affected actions disabled until it finishes. 9. **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. 10. **L29** (minor) `README.md`: The PR description still promises that make_game no longer receives the object and lift stores. Update it to say both are kept by default, capped at 4 GB of objects and two translations, and that opting out cleans them after a successful build. A failed or stopped build can leave them behind. 11. **L34** `tests/launcher_core/StorageChecks.cs:95`: The new store fixture declares shaderStore in the same method scope as the existing declaration at line 277. (more on the line) 12. **L35** `App/ViewModels/StorageViewModel.cs:124`: The snapshot key now uses listed rows and omits the builds folder used for unlisted discovery. (more on the line) 13. **L36** (minor) `App/ViewModels/StorageViewModel.cs:423`: The new census can assign zero counted bytes to a version that still has a removable cache. (more on the line) **Since the last review** (on 1c8f7ca0030f) Resolved: L15 (Per-version caches bypass the identity census. If two versions hard-link a shader cache, e…); L19 (The settings list omits mouse_sens.txt and present.txt, which Saves.PlayerFiles already id…); L30 (Staging cleanup now waits for a fetch that starts after the button’s last busy refresh. If…); L31 (The late-mod case creates a verified delete backup in windows.BackupRoot. The subsequent d…) Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (Finalizing starts in Complete, after the worker posts Exited. If the player confirms Stop…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L13 (The notice now reports skipped and failed logs, but other removals can still report succes…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L20 (A failed refresh now leaves the last sizes and timestamp on screen but replaces their disc…); L22 (Game and mod discovery now run on the worker, but opening Storage still calls RunningNow s…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…); L29 (The PR description still promises that make_game no longer receives the object and lift st…) New: L32 (Scanning user/mods directly bypasses Disk.Walk's link check on user. If a version's user d…); L33 (The unlisted-game guard checks only the root mods directory. An unlisted folder with a reg…); L34 (The new store fixture declares shaderStore in the same method scope as the existing declar…); L35 (The snapshot key now uses listed rows and omits the builds folder used for unlisted discov…); L36 (The new census can assign zero counted bytes to a version that still has a removable cache…) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven at b73bfc2. Earlier Windows testing reports 2,163 core checks with two suites skipped, clean Debug and Release builds, and a manual Storage walkthrough. There is no Linux run or matched before-and-after timing for opening Storage or rebuilding with retention off. The latest core fixture has a compile error. **Other systems:** Windows and Linux share the Storage and build paths but differ in process discovery, hard-link enumeration and mount handling. Home, Play, build completion and download staging can touch paths Storage displays or removes. Unlisted deletion backs up saves and checks both mod locations. Shared shader-store removal affects shader preparation across versions. Linux and Steam Deck behavior remain unverified. **Switches:** KeepBuildFiles is new and defaults to on, preserving the recent build's work and the capped stores. Off clears them after a successful build. The existing LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE paths and their limits of 4 GB and two translations remain in effect during the build. README and the PR-build guide describe the current default and cleanup timing. **Reviewed:** e92dd57d3fd1 against dad220036044: Read AGENTS.md, CONTRIBUTING.md, the commit log and the six files changed since 63faa36 in full. Read the ledger-related sections of build, navigation, Home deletion, filesystem, shader, save and download code. Skimmed the remaining base diff, translations, screenshot fixtures and reported runs. No review checklist or PR template was present. The checkout is b73bfc2, matching the supplied range-diff.; nothing run (a code review). **Checked and fine:** - The prefetch semaphore excludes staging cleanup while an install owns it. The source checks exercise refusal during the fetch and cleanup after it ends. - The late-mod test keeps the post-backup guard assertion and isolates its backup root. - The description opens with the player problem and includes screenshot evidence. The diff leaves package pins, release tooling, signing trust and CI definitions untouched. **Testing:** Read-only review. No builds or tests executed. The supplied CI record lists no failing or running checks. The reported Windows results predate b73bfc2, and the fix report records no test run for the latest changes. **Overlaps and merge order:** #210 and #220 are already in the base. No pending merge-order dependency is shown. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
@ -0,0 +121,4 @@
public sealed record Snapshot(string Key, IReadOnlyList<Storage.Item> Items, DateTimeOffset At, Storage.Places Places);
/// The places as one text: another version, a folder moved, and a kept measure is not theirs
static string KeyOf(Storage.Places p) => string.Join("\n",
Member

L35: The snapshot key now uses listed rows and omits the builds folder used for unlisted discovery. Measure Storage, change only the builds folder in Settings, then reopen Storage. It restores the old unlisted rows and their Remove actions, and DeleteLeftover can still delete a folder under the old root. Include the discovery root in the key and revalidate unlisted targets against the current root before deletion.

**L35**: The snapshot key now uses listed rows and omits the builds folder used for unlisted discovery. Measure Storage, change only the builds folder in Settings, then reopen Storage. It restores the old unlisted rows and their Remove actions, and DeleteLeftover can still delete a folder under the old root. Include the discovery root in the key and revalidate unlisted targets against the current root before deletion.
@ -0,0 +420,4 @@
: Tr.T(info.About);
if (version != null && View.FirstOrDefault(c => c.Kind == Storage.Kind.ShaderCache && c.Game?.Id == i.Game!.Id) is { Bytes: > 0 } cache)
about = Tr.F("Its program and shader list. Removing it also deletes its {0} of shader caches", Durations.Size(cache.Bytes));
var show = refusal != Storage.Refusal.NotRemovable && i.Bytes > 0 && confirming != i
Member

L36 (minor): The new census can assign zero counted bytes to a version that still has a removable cache. With the two hard-linked caches in StorageChecks, the second version loses its Remove button and is excluded from Remove all at line 486. Use the presence of clearable files for eligibility and keep counted bytes for the usage total.

**L36** (minor): The new census can assign zero counted bytes to a version that still has a removable cache. With the two hard-linked caches in StorageChecks, the second version loses its Remove button and is excluded from Remove all at line 486. Use the presence of clearable files for eligibility and keep counted bytes for the usage total.
@ -167,3 +200,1 @@
var mods = Path.Combine(dir, "mods");
if (IsLink(mods) || Directory.Exists(mods) && Directory.EnumerateFileSystemEntries(mods, "*", SearchOption.AllDirectories)
.Any(e => File.Exists(e))) return false;
return EmptyMods(Path.Combine(dir, "mods")) && EmptyMods(Path.Combine(dir, "user", "mods"));
Member

L33: The unlisted-game guard checks only the root mods directory. An unlisted folder with a regular user/mods/pack file and no root mods passes the guard and Remove deletes the pack. Storage now inventories user/mods for listed games. Use the same mod locations in discovery and the final deletion guard, and cover an unlisted folder with mods under user.

**L33**: The unlisted-game guard checks only the root mods directory. An unlisted folder with a regular user/mods/pack file and no root mods passes the guard and Remove deletes the pack. Storage now inventories user/mods for listed games. Use the same mod locations in discovery and the final deletion guard, and cover an unlisted folder with mods under user.
@ -0,0 +139,4 @@
parts.Add((g.Folder, Kind.ModsAndSettings, g, false));
parts.Add((Path.Combine(g.Folder, User), Kind.Saves, g, false));
parts.Add((Path.Combine(g.Folder, User), Kind.ModsAndSettings, g, false));
var user = new DirectoryInfo(Path.Combine(g.Folder, User));
Member

L32 (minor): Scanning user/mods directly bypasses Disk.Walk's link check on user. If a version's user directory links to the shared user directory, a regular file in shared user/mods can be counted through both paths on Linux. Check the user directory for a link before scanning its children and cover a linked parent in StorageChecks.

**L32** (minor): Scanning user/mods directly bypasses Disk.Walk's link check on user. If a version's user directory links to the shared user directory, a regular file in shared user/mods can be counted through both paths on Linux. Check the user directory for a link before scanning its children and cover a linked parent in StorageChecks.
@ -0,0 +92,4 @@
"Hard-linked caches count once and neither version frees the shared file alone.");
File.Delete(linkedCache);
Touch(linkedCache, new string('s', 1000));
var shaderStore = Path.Combine(root, "shader-store");
Member

L34: The new store fixture declares shaderStore in the same method scope as the existing declaration at line 277. C# rejects the duplicate local. Give the new fixture its own variable and directory.

**L34**: The new store fixture declares shaderStore in the same method scope as the existing declaration at line 277. C# rejects the duplicate local. Give the new fixture its own variable and directory.
Owner
@fix
Member

I didn't fix this pull request: it failed (the Codex runner answered 409: busy). Nothing was pushed.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I didn't fix this pull request: it failed (the Codex runner answered 409: busy). Nothing was pushed. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
Owner
@fix
Owner
@fix
Owner
@fix
Member

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is c9eb512415.

Changed

  • Duplicate shader-store fixture, tests/launcher_core/StorageChecks.cs:95: Gave the new fixture a distinct variable and directory.
  • Hard-linked cache eligibility, Core/Storage.cs:100: Tracked clearable cache-file presence separately from counted bytes and used it for individual and bulk removal eligibility; extended the hard-link fixture.
  • Initial Storage probes: App/ViewModels/StorageViewModel.cs:127 moves shared-user and running-process probes to the worker and keeps removal disabled during the initial measurement.

Changed in part (the rest is for the author)

  • Builds-root snapshot key, App/ViewModels/StorageViewModel.cs:124: Included the builds root in the snapshot key and added a containment check before unlisted deletion. A launcher-wide guard is still needed to keep the current root stable through deletion.
  • Build exit handoff: App/ViewModels/BuildStepViewModel.cs:399 ignores a queued exit after Stop and restores seeded files. Ownership through shutdown and the held-callback test remain to be implemented.
  • Removal failures and checks: Core/Storage.cs:261 propagates staging discovery failures and checks log directory access; tests/launcher_core/StorageChecks.cs:193 adds locked-log and unreadable-store checks. Other removal paths still need skipped and failed outcomes carried through.
  • Scan failure reporting: App/ViewModels/StorageViewModel.cs:174 distinguishes first-scan failure and clears busy state in finally. Partial discovery results still need to be detected and reported.

Left for the author

  • Launcher-wide removal lifetime: Still requires a launcher-wide guard through deletion and shutdown, a guarded registry snapshot, and a paused-deletion navigation test.
  • Filesystem-scoped removal: Still requires filesystem identities for inventory and deletion, including Windows mounted volumes, and refusal of removals crossing a nested filesystem.
  • Storage mutation invalidation: Still requires invalidation around every storage mutation and preventing scan publication during an active mutation.
  • Bulk removal estimate: Still requires estimating the union of confirmed targets and freezing the target set when confirmation opens.
  • Controller Back dispatch tests: Still requires tests that exercise B dispatch and priority on a tab page, in a modal, and in a wizard.

Still for the author (no edit does these)

  • L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation.
  • L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem.
  • L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation.
  • L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it.
  • L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority.

Nothing was built or run: check the change. Its review follows.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is c9eb51241582. **Changed** - **Duplicate shader-store fixture, tests/launcher_core/StorageChecks.cs:95**: Gave the new fixture a distinct variable and directory. - **Hard-linked cache eligibility, Core/Storage.cs:100**: Tracked clearable cache-file presence separately from counted bytes and used it for individual and bulk removal eligibility; extended the hard-link fixture. - **Initial Storage probes**: App/ViewModels/StorageViewModel.cs:127 moves shared-user and running-process probes to the worker and keeps removal disabled during the initial measurement. **Changed in part (the rest is for the author)** - **Builds-root snapshot key, App/ViewModels/StorageViewModel.cs:124**: Included the builds root in the snapshot key and added a containment check before unlisted deletion. A launcher-wide guard is still needed to keep the current root stable through deletion. - **Build exit handoff**: App/ViewModels/BuildStepViewModel.cs:399 ignores a queued exit after Stop and restores seeded files. Ownership through shutdown and the held-callback test remain to be implemented. - **Removal failures and checks**: Core/Storage.cs:261 propagates staging discovery failures and checks log directory access; tests/launcher_core/StorageChecks.cs:193 adds locked-log and unreadable-store checks. Other removal paths still need skipped and failed outcomes carried through. - **Scan failure reporting**: App/ViewModels/StorageViewModel.cs:174 distinguishes first-scan failure and clears busy state in finally. Partial discovery results still need to be detected and reported. **Left for the author** - **Launcher-wide removal lifetime**: Still requires a launcher-wide guard through deletion and shutdown, a guarded registry snapshot, and a paused-deletion navigation test. - **Filesystem-scoped removal**: Still requires filesystem identities for inventory and deletion, including Windows mounted volumes, and refusal of removals crossing a nested filesystem. - **Storage mutation invalidation**: Still requires invalidation around every storage mutation and preventing scan publication during an active mutation. - **Bulk removal estimate**: Still requires estimating the union of confirmed targets and freezing the target set when confirmation opens. - **Controller Back dispatch tests**: Still requires tests that exercise B dispatch and priority on a tab page, in a modal, and in a wizard. **Still for the author** (no edit does these) - **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. - **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. - **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. - **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. - **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. Nothing was built or run: check the change. Its review follows. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
fix(storage): preserve snapshot paths and cache removal eligibility
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
c9eb512415
As the review on #221 asked.
BeanBot requested changes 2026-11-21 06:03:09 +00:00
Dismissed
BeanBot left a comment

Recommendation: Request changes. Storage removal can outlive its page and race a build or Play. Drive-scoped removal can also delete files on an unselected filesystem, and stopping a build can release Home before rollback finishes.

Storage gives players a per-category view of disk use and lets them remove individual items. Title-bar tabs make those tools easier to reach. The latest fix moves the initial user-folder and process probes off the UI thread and improves error reporting, but the deletion and build handoffs still need shared ownership.

@fix will do (5)

  1. L5 App/ViewModels/BuildStepViewModel.cs:404: After Stop wins against a queued successful exit, the callback now avoids registering the build but starts rollback after Home has opened. A retry of the same update can race the old rollback moving the folder back, and closing can interrupt rollback. Keep build ownership until rollback finishes before opening Home or allowing shutdown. Add the held-callback test.
  2. L13 App/ViewModels/StorageViewModel.cs:600: Staging access errors now surface and the two requested checks exist. Work and SDK removal can still skip an inaccessible or vanished target and return success. Carry skipped and failed outcomes through those paths and use them in the completion notice.
  3. L20 (minor) Core/Disk.cs:294: An unreadable subtree can still be omitted from a scan that publishes a new total and measurement time. Carry partial-discovery status through the walker and inventory, then label partial results separately from a complete refresh.
  4. L29 (minor) README.md: The PR description still promises that make_game no longer receives the object and lift stores. Update it to say both are kept by default, capped at 4 GB of objects and two translations, and that opting out cleans them after a successful build. A failed or stopped build can leave them behind.
  5. L37 (minor) Core/Storage.cs:358: The new attribute probe accepts a regular file where a log directory is expected. (more on the line)

For the author (5) (a run, a measurement or a decision)

  • L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. (@fix couldn't: Still requires a launcher-wide guard through deletion and shutdown, a guarded registry snapshot, and a paused-deletion navigation test.)
  • L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. (@fix couldn't: Still requires filesystem identities for inventory and deletion, including Windows mounted volumes, and refusal of removals crossing a nested filesystem.)
  • L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. (@fix couldn't: Still requires invalidation around every storage mutation and preventing scan publication during an active mutation.)
  • L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. (@fix couldn't: Still requires estimating the union of confirmed targets and freezing the target set when confirmation opens.)
  • L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. (@fix couldn't: Still requires tests that exercise B dispatch and priority on a tab page, in a modal, and in a wizard.)

Since the last review (on e92dd57d3f)
Resolved: L22 (Game and mod discovery now run on the worker, but opening Storage still calls RunningNow s…); L34 (The new store fixture declares shaderStore in the same method scope as the existing declar…); L35 (The snapshot key now uses listed rows and omits the builds folder used for unlisted discov…); L36 (The new census can assign zero counted bytes to a version that still has a removable cache…)
Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (After Stop wins against a queued successful exit, the callback now avoids registering the…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L13 (Staging access errors now surface and the two requested checks exist. Work and SDK removal…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L20 (An unreadable subtree can still be omitted from a scan that publishes a new total and meas…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…); L29 (The PR description still promises that make_game no longer receives the object and lift st…)
New: L37 (The new attribute probe accepts a regular file where a log directory is expected. If an im…)

More: does it help, other systems, switches, what was read

Does it help: Yes for the feature. The author reports using storage measurement, unlisted-game removal, the drive picker and tabs on Windows 11. Build-time and disk-use tradeoffs are unproven. The PR gives size estimates but no matched base-versus-head runs.

Other systems: Storage shares paths and registry state with Home, Play, builds, tool downloads and save backups. Staging cleanup shares the install semaphore. Windows has an earlier manual run. Linux and Steam Deck behavior, including mounted filesystems and process discovery, have no reported runs.

Switches: KeepBuildFiles is new and defaults to on. That preserves warm builds and their disk use. Turning it off cleans up work and both stores after a successful build. The builder still receives LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE under the work folder, with LONGSHOT_OBJ_STORE_GB=4 and LONGSHOT_LIFT_STORE_KEEP=2. Those defaults match the base.

Reviewed: c9eb512415 against dad2200360: The checkout is 75ff09e, the head listed in the range-diff. Read AGENTS.md, CONTRIBUTING.md, the commit list and the full diff since 324d77f. Read BuildStepViewModel.cs, StorageViewModel.cs, Storage.cs and StorageChecks.cs in full, plus the relevant navigation, shutdown, registry, deletion, disk, cache and controller callers. Skimmed the broader PR file list, description, test reports and screenshot captions. The rest of the unchanged PR code and the screenshot images were outside this re-check.; nothing run (a code review).

Checked and fine:

  • The previous snapshot keeps its paths, sizes and timestamp together on cache reuse.
  • The locked-log check asserts that the current log stays and the held previous log counts as failed. The unreadable-store check exercises removal directly and restores permissions in finally.
  • The latest diff has no whitespace errors and uses synthetic fixtures for the new checks. The title and commit subjects follow Conventional Commits, and the description opens with the player problem and includes screenshot references.

Testing: Read-only review. The author reports 2,163 core checks with two suites skipped because they also fail on base, clean Debug and Release builds, and three Tooling release-test failures shared with base. Lint was skipped. Those runs predate the latest fix. The supplied CI summary lists no head-only failures or pending checks.

Overlaps and merge order: #210 and #220 are in the supplied base. Local main also contains merged #222, which overlaps the BuildStepViewModel constructor and changes screen tests and translations. Integrate current main before merging #221 and preserve #222’s GPU diagnostics alongside the build cancellation guard.


Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Storage removal can outlive its page and race a build or Play. Drive-scoped removal can also delete files on an unselected filesystem, and stopping a build can release Home before rollback finishes. Storage gives players a per-category view of disk use and lets them remove individual items. Title-bar tabs make those tools easier to reach. The latest fix moves the initial user-folder and process probes off the UI thread and improves error reporting, but the deletion and build handoffs still need shared ownership. **`@fix` will do (5)** 1. **L5** `App/ViewModels/BuildStepViewModel.cs:404`: After Stop wins against a queued successful exit, the callback now avoids registering the build but starts rollback after Home has opened. A retry of the same update can race the old rollback moving the folder back, and closing can interrupt rollback. Keep build ownership until rollback finishes before opening Home or allowing shutdown. Add the held-callback test. 2. **L13** `App/ViewModels/StorageViewModel.cs:600`: Staging access errors now surface and the two requested checks exist. Work and SDK removal can still skip an inaccessible or vanished target and return success. Carry skipped and failed outcomes through those paths and use them in the completion notice. 3. **L20** (minor) `Core/Disk.cs:294`: An unreadable subtree can still be omitted from a scan that publishes a new total and measurement time. Carry partial-discovery status through the walker and inventory, then label partial results separately from a complete refresh. 4. **L29** (minor) `README.md`: The PR description still promises that make_game no longer receives the object and lift stores. Update it to say both are kept by default, capped at 4 GB of objects and two translations, and that opting out cleans them after a successful build. A failed or stopped build can leave them behind. 5. **L37** (minor) `Core/Storage.cs:358`: The new attribute probe accepts a regular file where a log directory is expected. (more on the line) **For the author (5)** (a run, a measurement or a decision) - **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. (`@fix` couldn't: Still requires a launcher-wide guard through deletion and shutdown, a guarded registry snapshot, and a paused-deletion navigation test.) - **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. (`@fix` couldn't: Still requires filesystem identities for inventory and deletion, including Windows mounted volumes, and refusal of removals crossing a nested filesystem.) - **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. (`@fix` couldn't: Still requires invalidation around every storage mutation and preventing scan publication during an active mutation.) - **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. (`@fix` couldn't: Still requires estimating the union of confirmed targets and freezing the target set when confirmation opens.) - **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. (`@fix` couldn't: Still requires tests that exercise B dispatch and priority on a tab page, in a modal, and in a wizard.) **Since the last review** (on e92dd57d3fd1) Resolved: L22 (Game and mod discovery now run on the worker, but opening Storage still calls RunningNow s…); L34 (The new store fixture declares shaderStore in the same method scope as the existing declar…); L35 (The snapshot key now uses listed rows and omits the builds folder used for unlisted discov…); L36 (The new census can assign zero counted bytes to a version that still has a removable cache…) Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (After Stop wins against a queued successful exit, the callback now avoids registering the…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L13 (Staging access errors now surface and the two requested checks exist. Work and SDK removal…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L20 (An unreadable subtree can still be omitted from a scan that publishes a new total and meas…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…); L29 (The PR description still promises that make_game no longer receives the object and lift st…) New: L37 (The new attribute probe accepts a regular file where a log directory is expected. If an im…) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes for the feature. The author reports using storage measurement, unlisted-game removal, the drive picker and tabs on Windows 11. Build-time and disk-use tradeoffs are unproven. The PR gives size estimates but no matched base-versus-head runs. **Other systems:** Storage shares paths and registry state with Home, Play, builds, tool downloads and save backups. Staging cleanup shares the install semaphore. Windows has an earlier manual run. Linux and Steam Deck behavior, including mounted filesystems and process discovery, have no reported runs. **Switches:** KeepBuildFiles is new and defaults to on. That preserves warm builds and their disk use. Turning it off cleans up work and both stores after a successful build. The builder still receives LONGSHOT_OBJ_STORE and LONGSHOT_LIFT_STORE under the work folder, with LONGSHOT_OBJ_STORE_GB=4 and LONGSHOT_LIFT_STORE_KEEP=2. Those defaults match the base. **Reviewed:** c9eb51241582 against dad220036044: The checkout is 75ff09e, the head listed in the range-diff. Read AGENTS.md, CONTRIBUTING.md, the commit list and the full diff since 324d77f. Read BuildStepViewModel.cs, StorageViewModel.cs, Storage.cs and StorageChecks.cs in full, plus the relevant navigation, shutdown, registry, deletion, disk, cache and controller callers. Skimmed the broader PR file list, description, test reports and screenshot captions. The rest of the unchanged PR code and the screenshot images were outside this re-check.; nothing run (a code review). **Checked and fine:** - The previous snapshot keeps its paths, sizes and timestamp together on cache reuse. - The locked-log check asserts that the current log stays and the held previous log counts as failed. The unreadable-store check exercises removal directly and restores permissions in finally. - The latest diff has no whitespace errors and uses synthetic fixtures for the new checks. The title and commit subjects follow Conventional Commits, and the description opens with the player problem and includes screenshot references. **Testing:** Read-only review. The author reports 2,163 core checks with two suites skipped because they also fail on base, clean Debug and Release builds, and three Tooling release-test failures shared with base. Lint was skipped. Those runs predate the latest fix. The supplied CI summary lists no head-only failures or pending checks. **Overlaps and merge order:** #210 and #220 are in the supplied base. Local main also contains merged #222, which overlaps the BuildStepViewModel constructor and changes screen tests and translations. Integrate current main before merging #221 and preserve #222’s GPU diagnostics alongside the build cancellation guard. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
Core/Storage.cs Outdated
@ -0,0 +355,4 @@
/// The files right in folder, never a link's target nor a folder inside; keep: one not to delete (the log this run writes)
static (int Removed, int Skipped, int Failed) DeleteFiles(string folder, string? keep, Func<string, bool> matches)
{
try { File.GetAttributes(folder); }
Member

L37 (minor): The new attribute probe accepts a regular file where a log directory is expected. If an imported game's folder contains a file named logs, EnumerateFiles throws and cleanup stops before reaching the game's loose logs or later versions. Check the Directory attribute before enumerating and preserve access-error reporting for actual directories.

**L37** (minor): The new attribute probe accepts a regular file where a log directory is expected. If an imported game's folder contains a file named logs, EnumerateFiles throws and cleanup stops before reaching the game's loose logs or later versions. Check the Directory attribute before enumerating and preserve access-error reporting for actual directories.
Owner
@fix
Member

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is c2589f041c. I edited the pull request's description too (1 edit).

Changed

  • Regular file named logs: Core/Storage.cs:373 checks the directory attribute before enumerating; tests/launcher_core/StorageChecks.cs:219 covers loose-log cleanup. Tests were not run.
  • Strict folder deletion outcomes: Core/Toolchains.cs:689 reports whether the target existed at deletion, and Core/Disk.cs:78 and Core/Storage.cs:371 propagate that result.
  • Error-aware game discovery: Core/GameFolder.cs:75 reports probe failures; listed and unlisted storage discovery use it and mark the measurement partial.
  • Measured SDK removal targets: Core/Storage.cs:156 retains measured SDK targets for removal. tests/launcher_core/StorageChecks.cs:211 distinguishes a vanished SDK from one absent throughout. Tests were not run.
  • Build-store retention description: Updated the proposed description to state the default retention, caps, and successful-build cleanup behavior.

Changed in part (the rest is for the author)

  • SIGTERM and rollback completion: App/Program.cs:109 routes SIGTERM through the build completion guard, and App/ViewModels/BuildStepViewModel.cs:434 guards failed-build rollback. The held-callback regression test for retry and shutdown remains to be written.

Still for the author (no edit does these)

  • L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation.
  • L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem.
  • L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation.
  • L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it.
  • L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority.

Nothing was built or run: check the change. Its review follows.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is c2589f041cb0. I edited the pull request's description too (1 edit). **Changed** - **Regular file named logs**: Core/Storage.cs:373 checks the directory attribute before enumerating; tests/launcher_core/StorageChecks.cs:219 covers loose-log cleanup. Tests were not run. - **Strict folder deletion outcomes**: Core/Toolchains.cs:689 reports whether the target existed at deletion, and Core/Disk.cs:78 and Core/Storage.cs:371 propagate that result. - **Error-aware game discovery**: Core/GameFolder.cs:75 reports probe failures; listed and unlisted storage discovery use it and mark the measurement partial. - **Measured SDK removal targets**: Core/Storage.cs:156 retains measured SDK targets for removal. tests/launcher_core/StorageChecks.cs:211 distinguishes a vanished SDK from one absent throughout. Tests were not run. - **Build-store retention description**: Updated the proposed description to state the default retention, caps, and successful-build cleanup behavior. **Changed in part (the rest is for the author)** - **SIGTERM and rollback completion**: App/Program.cs:109 routes SIGTERM through the build completion guard, and App/ViewModels/BuildStepViewModel.cs:434 guards failed-build rollback. The held-callback regression test for retry and shutdown remains to be written. **Still for the author** (no edit does these) - **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. - **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. - **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. - **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. - **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. Nothing was built or run: check the change. Its review follows. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
fix(storage): report incomplete cleanup and measurements
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 28s
c2589f041c
As the review on #221 asked.
BeanBot requested changes 2026-11-21 06:39:31 +00:00
Dismissed
BeanBot left a comment

Recommendation: Request changes. Storage removal can still race a build or launcher shutdown, and removal scoped to one drive can delete files on an unselected filesystem. Storage can also publish a snapshot while files are being removed.

Players can see and selectively remove what Longshot keeps, and reach the main pages from the title bar. This revision improves SDK cleanup reporting and flags inaccessible game folders as a partial measurement. Recursive deletion still needs launcher-wide coordination and filesystem boundary checks.

@fix will do (1)

  1. L5 App/ViewModels/BuildStepViewModel.cs:750: SIGTERM starts sending the opted-in build summary and discards the task. When cancellation and rollback finish before an HTTP connection is ready, shutdown can end the process before the summary reaches the server. Preserve the previous bounded send window without blocking the UI, alongside the rollback wait.

For the author (5) (a run, a measurement or a decision)

  • L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. (@fix couldn't: StorageViewModel.cs:563–591 still uses page-local removal state. LauncherService.cs:541 enumerates the live registry on the worker. The launcher-wide guard through shutdown, protected registry snapsho)
  • L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. (@fix couldn't: Storage.cs:223 and 306 still attribute and filter by the root path's drive label. Disk.cs:406 still uses the Windows drive letter. Filesystem identities and refusal to delete across nested filesystem )
  • L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. (@fix couldn't: StorageViewModel.cs:176 still checks only the scan generation before publishing. Home's deletion flow can change the disk without bumping that generation, and a new Storage page can scan and publish d)
  • L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. (@fix couldn't: StorageViewModel.cs:523–528 still sums individual estimates, and line 60 recomputes eligibility when Remove is pressed. The confirmation still needs a frozen set and the estimate for removing that set)
  • L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. (@fix couldn't: PadChecks.cs:105–107 still checks the Home button's XAML marker. It would pass with the fallback removed from PadInput.Back and still does not exercise dispatch on a tab, in a modal, or in a wizard.)

Since the last review (on c9eb512415)
Resolved: L13 (The attribute probe can succeed and the deletion helper can still return without deleting.…); L20 (If the scan can list a game's parent but lacks access to probe the game's stamp and execut…); L29 (The PR description still promises that make_game no longer receives the object and lift st…); L37 (The new attribute probe accepts a regular file where a log directory is expected. If an im…)
Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (SIGTERM starts sending the opted-in build summary and discards the task. When cancellation…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…)
New: L38 (Removing graphics libraries reports a skipped target even on a successful cleanup when opt…)

More: does it help, other systems, switches, what was read

Does it help: Unproven at HEAD. Earlier Windows testing reported 2,163 core checks passing with two groups skipped, clean Debug and Release builds, and manual Storage coverage. Those reports predate 39fd7ea. No Linux run or matched before-and-after performance measurements were supplied.

Other systems: The rollback guard affects Linux SIGTERM and window close. Filesystem scoping affects Linux nested mounts and Windows directory-mounted volumes. Storage removal shares paths and registry state with Home, Play, the build wizard, and tool downloads. SDK cleanup affects the next build that needs DLSS, FSR or XeSS. The Windows report covers basic Storage use. Linux, Steam Deck, and mounted-volume behavior remain unverified.

Switches: KeepBuildFiles is new and defaults to on. It preserves existing build reuse, including the existing 4 GB object cap and two-translation lift cap. Turning it off cleans the work and stores after a successful build. No environment switch changed in this revision.

Reviewed: c2589f041c against dad2200360: Reviewed actual HEAD 39fd7ea. Read AGENTS.md and CONTRIBUTING.md in full. No review checklist or PR template was present. Read the complete delta since c22af0a, the affected methods at HEAD, and the callers and tests needed for the ledger. Read the supplied PR description, comments, CI state, and fix report. Reviewed selected base-to-HEAD hunks. Skimmed translation removals and screenshot descriptions. Other unchanged portions of the PR and the screenshot attachments were outside this re-check.; nothing run (a code review).

Checked and fine:

  • The normal SIGTERM path keeps the current build through stopped-build rollback and runs its completion callback on the UI thread.
  • A vanished work or SDK directory is reported as skipped, while a measured SDK can be removed without counting peers that were absent throughout.
  • Listed and unlisted discovery use the partial-measurement callback on access failures.
  • The default still passes both capped build stores to make_game. Opt-out cleanup is tied to successful build completion.

Testing: Read-only review. The author reported 2,163 passing core checks on Windows with two groups skipped, zero build warnings in Debug and Release, and three release-tool failures reproduced on the base. The final fix report says its tests were not run. The supplied CI record lists no failures or pending checks.

Overlaps and merge order: LongshotLauncher #222 is already on local main at 8a75fe1 and overlaps the build-step settings and cancellation code. Reconcile #221 with that commit before merging and preserve both the GPU-selection reporting and the rollback guard.


Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Storage removal can still race a build or launcher shutdown, and removal scoped to one drive can delete files on an unselected filesystem. Storage can also publish a snapshot while files are being removed. Players can see and selectively remove what Longshot keeps, and reach the main pages from the title bar. This revision improves SDK cleanup reporting and flags inaccessible game folders as a partial measurement. Recursive deletion still needs launcher-wide coordination and filesystem boundary checks. **`@fix` will do (1)** 1. **L5** `App/ViewModels/BuildStepViewModel.cs:750`: SIGTERM starts sending the opted-in build summary and discards the task. When cancellation and rollback finish before an HTTP connection is ready, shutdown can end the process before the summary reaches the server. Preserve the previous bounded send window without blocking the UI, alongside the rollback wait. **For the author (5)** (a run, a measurement or a decision) - **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. (`@fix` couldn't: StorageViewModel.cs:563–591 still uses page-local removal state. LauncherService.cs:541 enumerates the live registry on the worker. The launcher-wide guard through shutdown, protected registry snapsho) - **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. (`@fix` couldn't: Storage.cs:223 and 306 still attribute and filter by the root path's drive label. Disk.cs:406 still uses the Windows drive letter. Filesystem identities and refusal to delete across nested filesystem ) - **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. (`@fix` couldn't: StorageViewModel.cs:176 still checks only the scan generation before publishing. Home's deletion flow can change the disk without bumping that generation, and a new Storage page can scan and publish d) - **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. (`@fix` couldn't: StorageViewModel.cs:523–528 still sums individual estimates, and line 60 recomputes eligibility when Remove is pressed. The confirmation still needs a frozen set and the estimate for removing that set) - **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. (`@fix` couldn't: PadChecks.cs:105–107 still checks the Home button's XAML marker. It would pass with the fallback removed from PadInput.Back and still does not exercise dispatch on a tab, in a modal, or in a wizard.) **Since the last review** (on c9eb51241582) Resolved: L13 (The attribute probe can succeed and the deletion helper can still return without deleting.…); L20 (If the scan can list a game's parent but lacks access to probe the game's stamp and execut…); L29 (The PR description still promises that make_game no longer receives the object and lift st…); L37 (The new attribute probe accepts a regular file where a log directory is expected. If an im…) Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (SIGTERM starts sending the opted-in build summary and discards the task. When cancellation…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…) New: L38 (Removing graphics libraries reports a skipped target even on a successful cleanup when opt…) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven at HEAD. Earlier Windows testing reported 2,163 core checks passing with two groups skipped, clean Debug and Release builds, and manual Storage coverage. Those reports predate 39fd7ea. No Linux run or matched before-and-after performance measurements were supplied. **Other systems:** The rollback guard affects Linux SIGTERM and window close. Filesystem scoping affects Linux nested mounts and Windows directory-mounted volumes. Storage removal shares paths and registry state with Home, Play, the build wizard, and tool downloads. SDK cleanup affects the next build that needs DLSS, FSR or XeSS. The Windows report covers basic Storage use. Linux, Steam Deck, and mounted-volume behavior remain unverified. **Switches:** KeepBuildFiles is new and defaults to on. It preserves existing build reuse, including the existing 4 GB object cap and two-translation lift cap. Turning it off cleans the work and stores after a successful build. No environment switch changed in this revision. **Reviewed:** c2589f041cb0 against dad220036044: Reviewed actual HEAD 39fd7ea. Read AGENTS.md and CONTRIBUTING.md in full. No review checklist or PR template was present. Read the complete delta since c22af0a, the affected methods at HEAD, and the callers and tests needed for the ledger. Read the supplied PR description, comments, CI state, and fix report. Reviewed selected base-to-HEAD hunks. Skimmed translation removals and screenshot descriptions. Other unchanged portions of the PR and the screenshot attachments were outside this re-check.; nothing run (a code review). **Checked and fine:** - The normal SIGTERM path keeps the current build through stopped-build rollback and runs its completion callback on the UI thread. - A vanished work or SDK directory is reported as skipped, while a measured SDK can be removed without counting peers that were absent throughout. - Listed and unlisted discovery use the partial-measurement callback on access failures. - The default still passes both capped build stores to make_game. Opt-out cleanup is tied to successful build completion. **Testing:** Read-only review. The author reported 2,163 passing core checks on Windows with two groups skipped, zero build warnings in Debug and Release, and three release-tool failures reproduced on the base. The final fix report says its tests were not run. The supplied CI record lists no failures or pending checks. **Overlaps and merge order:** LongshotLauncher #222 is already on local main at 8a75fe1 and overlaps the build-step settings and cancellation code. Reconcile #221 with that commit before merging and preserve both the GPU-selection reporting and the rollback guard. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
@ -0,0 +315,4 @@
break;
case Kind.ShaderCache when item.Game is { } g:
// (its own look at whether Longshot runs as well: running only ever refuses, never lets a clear past that)
return ShaderCaches.Clear(g.Folder, notes: false, running: running ? () => true : cachesHeld) == null ? Refusal.Running : Refusal.None;
Member

L38 (minor): Removing graphics libraries reports a skipped target even on a successful cleanup when optional SDKs were never installed. With only DLSS installed, deleting its SDK counts the absent FSR and XeSS folders as skips, and the toast excludes the DLSS estimate. Carry the measured SDK targets into removal. Update the test at StorageChecks.cs:211 to distinguish an SDK that vanished after measurement from one that was absent throughout.

**L38** (minor): Removing graphics libraries reports a skipped target even on a successful cleanup when optional SDKs were never installed. With only DLSS installed, deleting its SDK counts the absent FSR and XeSS folders as skips, and the toast excludes the DLSS estimate. Carry the measured SDK targets into removal. Update the test at StorageChecks.cs:211 to distinguish an SDK that vanished after measurement from one that was absent throughout.
Owner
@fix
Member

I didn't fix this pull request: it failed (Codex didn't finish with an answer (exit 1)). Nothing was pushed.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I didn't fix this pull request: it failed (Codex didn't finish with an answer (exit 1)). Nothing was pushed. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
Owner
@fix
Member

The ChatGPT usage limit is reached (it resets Nov 25th, 2026 1:04 AM), so this fix is paused. It runs by itself once the limit lifts (tried again every 30 minutes); nothing needs asking again.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

The ChatGPT usage limit is reached (it resets Nov 25th, 2026 1:04 AM), so this fix is paused. It runs by itself once the limit lifts (tried again every 30 minutes); nothing needs asking again. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
Owner
@fix
Member

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is 8650304818.

Changed in part (the rest is for the author)

  • Build finalization and shutdown regression: Tracked pending summaries across retries, guarded repeated SIGTERM, and added held-callback and deadline checks in Core/BuildReports.cs:200 and tests/launcher_core/BuildReportChecks.cs:105. The checks exercise the shared shutdown coordinator and inspect its wiring; a regression that drives BuildStepViewModel’s actual rollback and retry path is still needed. No tests were run.

Still for the author (no edit does these)

  • L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation.
  • L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem.
  • L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation.
  • L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it.
  • L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority.

Nothing was built or run: check the change. Its review follows.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is 865030481847. **Changed in part (the rest is for the author)** - **Build finalization and shutdown regression**: Tracked pending summaries across retries, guarded repeated SIGTERM, and added held-callback and deadline checks in Core/BuildReports.cs:200 and tests/launcher_core/BuildReportChecks.cs:105. The checks exercise the shared shutdown coordinator and inspect its wiring; a regression that drives BuildStepViewModel’s actual rollback and retry path is still needed. No tests were run. **Still for the author** (no edit does these) - **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. - **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. - **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. - **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. - **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. Nothing was built or run: check the change. Its review follows. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
fix(build): wait briefly for summaries on shutdown
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 14s
8650304818
As the review on #221 asked.
BeanBot left a comment

Recommendation: Request changes. Storage removal can overlap builds or other disk operations, and drive-scoped deletion can cross into an unselected filesystem. The shutdown regression test still does not exercise the build’s actual rollback and retry path.

The launcher gains a Storage page for inspecting and removing retained files, plus title-bar navigation. It makes disk use more visible, but deletion coordination and filesystem boundaries need correction before merge.

@fix will do (1)

  1. L5 tests/launcher_core/BuildReportChecks.cs:105: The new coordinator test holds a simulated callback and checks source wiring, but does not exercise the actual build rollback and retry path. Add a regression test that drives that path and verifies shutdown waits for rollback and the bounded sends across retry.

For the author (5) (a run, a measurement or a decision)

  • L3 App/ViewModels/StorageViewModel.cs:554: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. (@fix couldn't: Removal remains page-local in StorageViewModel.RemoveAsync, and DeleteLeftover still enumerates Registry.Builds on the worker. The launcher-wide guard through completion and shutdown, protected snapsh)
  • L7 Core/Storage.cs:273: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, Disk.DriveName also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. (@fix couldn't: Storage.Remove still filters top-level paths using Disk.DriveName, which uses the drive letter on Windows. Filesystem identity accounting and refusal of whole-folder deletion across nested filesystems)
  • L11 App/ViewModels/StorageViewModel.cs:153: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. (@fix couldn't: Scan publication still checks StorageGeneration alone; Home deletion does not invalidate it around mutation, and a new Storage page can scan during removal.)
  • L16 (minor) App/ViewModels/StorageViewModel.cs:500: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. (@fix couldn't: The confirmation still sums individual Frees estimates and the command recomputes Clearable. The union estimate and frozen confirmed target set are missing.)
  • L24 (minor) tests/launcher_core/PadChecks.cs:106: The new assertion checks the Home tab's XAML marker and passes if the fallback in PadInput.Back is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. (@fix couldn't: PadChecks still checks the Home tab’s XAML marker rather than exercising B dispatch and priority on a tab page, in a modal and in a wizard.)

Since the last review (on c2589f041c)
Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (The new coordinator test holds a simulated callback and checks source wiring, but does not…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…)

More: does it help, other systems, switches, what was read

Does it help: Unproven as a complete feature: the author reports a real Windows launcher run and 2,163 core checks, but Linux was not tested and the deletion defects remain. No build-speed measurements are supplied for retaining build work.

Other systems: The deletion and scan races affect launcher navigation, builds and game files on both Windows and Linux. Nested mounts affect Linux and Windows mounted volumes. Build-summary shutdown also depends on rollback, retries and the telemetry service; the new coordinator has isolated checks but its actual build path lacks the requested regression test.

Switches: KeepBuildFiles is added, defaults to true, and retains build work for faster updates. Its disk cost is described, but the speed benefit and suitability of the default are not measured. No switch changed in the latest fix.

Reviewed: 8650304818 against dad2200360: Read the repository rules, the diff since the ledger head, and relevant portions of storage removal, measurement, drive identification, build finalization and controller checks. The large combined file output was truncated; the full pull request and all changed files were not read in full. Translations, screenshots and generated assets were not independently inspected.; nothing run (a code review).

Checked and fine:

  • The new shutdown coordinator tracks pending sends across attempts and ignores repeated termination requests.
  • The pull request description states the need, testing limitations and screenshots.

Testing: No commands that run project code or tests were executed. The author reports Windows core checks and Debug and Release builds; Linux was not tested. CI reports no failing or running checks.

Overlaps and merge order: #210 and #220 are described as already incorporated by the rebase; no independent overlap search was possible with the network closed.


Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Storage removal can overlap builds or other disk operations, and drive-scoped deletion can cross into an unselected filesystem. The shutdown regression test still does not exercise the build’s actual rollback and retry path. The launcher gains a Storage page for inspecting and removing retained files, plus title-bar navigation. It makes disk use more visible, but deletion coordination and filesystem boundaries need correction before merge. **`@fix` will do (1)** 1. **L5** `tests/launcher_core/BuildReportChecks.cs:105`: The new coordinator test holds a simulated callback and checks source wiring, but does not exercise the actual build rollback and retry path. Add a regression test that drives that path and verifies shutdown waits for rollback and the bounded sends across retry. **For the author (5)** (a run, a measurement or a decision) - **L3** `App/ViewModels/StorageViewModel.cs:554`: Capturing Places leaves the deletion lifetime page-local and the callback still reads Registry.Builds on the worker. Start a large removal, switch to Home, then start a build or return to a new Storage page. Hold a launcher-wide operation guard through completion and shutdown, snapshot registry inputs under that guard, and test paused deletion across navigation. (`@fix` couldn't: Removal remains page-local in StorageViewModel.RemoveAsync, and DeleteLeftover still enumerates Registry.Builds on the worker. The launcher-wide guard through completion and shutdown, protected snapsh) - **L7** `Core/Storage.cs:273`: Drive scoping checks only the selected tree's top-level path. On Linux, mount another filesystem inside a game's folder and Remove from the parent drive will recurse into it. On Windows, `Disk.DriveName` also treats a volume mounted in a directory as the path's drive letter. Use filesystem identities for inventory and deletion, and refuse whole-folder removals that would cross the selected filesystem. (`@fix` couldn't: Storage.Remove still filters top-level paths using Disk.DriveName, which uses the drive letter on Windows. Filesystem identity accounting and refusal of whole-folder deletion across nested filesystems) - **L11** `App/ViewModels/StorageViewModel.cs:153`: The generation only tracks scan starts and explicit snapshot clears. A scan of listed files can publish after Home deletes them from disk and keeps the same row, and a new Storage page can scan while cleanup is active. Invalidate around every storage mutation and publish scans only outside an active mutation. (`@fix` couldn't: Scan publication still checks StorageGeneration alone; Home deletion does not invalidate it around mutation, and a new Storage page can scan during removal.) - **L16** (minor) `App/ViewModels/StorageViewModel.cs:500`: Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are the only holders of a shared 25 GB romfs can free it together, but the confirmation excludes it. Use the union of the confirmed targets for the estimate and freeze that set when opening the confirmation so a newly eligible item cannot join it. (`@fix` couldn't: The confirmation still sums individual Frees estimates and the command recomputes Clearable. The union estimate and frozen confirmed target set are missing.) - **L24** (minor) `tests/launcher_core/PadChecks.cs:106`: The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInput.Back` is deleted. Exercise B on a tab page with no local Back, in a modal, and in a wizard so the check covers dispatch and priority. (`@fix` couldn't: PadChecks still checks the Home tab’s XAML marker rather than exercising B dispatch and priority on a tab page, in a modal and in a wizard.) **Since the last review** (on c2589f041cb0) Still open: L3 (Capturing Places leaves the deletion lifetime page-local and the callback still reads Regi…); L5 (The new coordinator test holds a simulated callback and checks source wiring, but does not…); L7 (Drive scoping checks only the selected tree's top-level path. On Linux, mount another file…); L11 (The generation only tracks scan starts and explicit snapshot clears. A scan of listed file…); L16 (Bulk removal adds estimates for deleting each folder alone. Two unlisted versions that are…); L24 (The new assertion checks the Home tab's XAML marker and passes if the fallback in `PadInpu…) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven as a complete feature: the author reports a real Windows launcher run and 2,163 core checks, but Linux was not tested and the deletion defects remain. No build-speed measurements are supplied for retaining build work. **Other systems:** The deletion and scan races affect launcher navigation, builds and game files on both Windows and Linux. Nested mounts affect Linux and Windows mounted volumes. Build-summary shutdown also depends on rollback, retries and the telemetry service; the new coordinator has isolated checks but its actual build path lacks the requested regression test. **Switches:** KeepBuildFiles is added, defaults to true, and retains build work for faster updates. Its disk cost is described, but the speed benefit and suitability of the default are not measured. No switch changed in the latest fix. **Reviewed:** 865030481847 against dad220036044: Read the repository rules, the diff since the ledger head, and relevant portions of storage removal, measurement, drive identification, build finalization and controller checks. The large combined file output was truncated; the full pull request and all changed files were not read in full. Translations, screenshots and generated assets were not independently inspected.; nothing run (a code review). **Checked and fine:** - The new shutdown coordinator tracks pending sends across attempts and ignores repeated termination requests. - The pull request description states the need, testing limitations and screenshots. **Testing:** No commands that run project code or tests were executed. The author reports Windows core checks and Debug and Release builds; Linux was not tested. CI reports no failing or running checks. **Overlaps and merge order:** #210 and #220 are described as already incorporated by the rebase; no independent overlap search was possible with the network closed. </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
HumanBean deleted branch feat/storage-page 2026-11-21 07:07:19 +00:00
Owner

Recommendation: Request changes, now as follow-ups (this merged as e2220601 while the review ran). The Storage page is a real gain and its deletes are guarded well. But the merged head was never built or tested: the author's runs cover c105e1e, and five later automated commits (about 700 changed lines) changed how a build stops, closes and handles SIGTERM. The description doesn't mention that change.

Players can now see what Longshot keeps on their disk, grouped by what it is for. They can let go of one part at a time, including old versions' folders an update left behind (25-40 GB each), which only a notice on Home showed before. The title-bar tabs replace Home's Saves and NFC cards and the pages' Done buttons. On net it makes the launcher better. The open question is whether the head behaves the way the tested commit did.

Does it help: not a perf change. The feature is shown working on Windows 11 at c105e1e: the author ran the launcher against a real home, ran 2163 core checks and built Debug and Release with no warnings, and posted screenshots in the comments. Nothing has been run at 8650304, and twice in this PR an untested fixer commit broke the core tests' compile (L27, L34).
Other systems: Linux and the Steam Deck take the same measure and delete paths, and nothing was run there. Linux has no FileLinks.Names, so it says "other folders" by design. The build page's Stop now stays on the page until make_game is killed and the caches and folder are put back, where before it went Home at once. Closing during that wait waits too. SIGTERM now goes through the window thread on every Linux run, with or without a build, and waits up to 2 s for summaries before desktop.Shutdown(). Before, with no build, the launcher ended the default way. Clearing the shared shader store makes every version prepare shaders again on any GPU, and the page says so before it goes. The build's environment is the same as on main: both stores are passed, with the 4 GB and two-translation caps.
Switches: KeepBuildFiles (a Storage page checkbox, on by default). On is main's behaviour, so the default is right, and the opt-out serves players short of disk space (a Deck). With it off, the work parts and both stores go after each successful build only (Storage.AfterBuild).

Reviewed: 8650304818 against dad2200360 (the PR's base; main has since gained #222, and the squash e2220601 is this head plus #222, no other change). I read in full: Core/Storage.cs, StorageViewModel.cs, StorageView.axaml, ShareRow.cs, and the changed parts of Disk.cs, Leftovers.cs, BuildRegistry.cs, ShaderCaches.cs, Toolchains.cs, ToolsPrefetch.cs, FileLinks.cs, GameFolder.cs, InstanceFolders.cs, MakeGameCommand.cs, LauncherService.cs, BuildReports.cs, BuildStepViewModel.cs (with Run, Exited, Stop, Fail, Complete and PutBack in full), Program.cs, MainWindow.axaml(.cs), PadInput.cs, MainViewModel.cs, HomeViewModel.cs, SettingsViewModel.cs, NfcViewModel.cs, SavesViewModel.cs and App.axaml. I skimmed the tests (StorageChecks, LeftoverChecks, BuildReportChecks, PadChecks), the docs, the screenshot scenes and the catalog removals. Nothing was run (a code review).
Fixed in this review: nothing pushed (it merged first). The two comment nits below are a 14-line follow-up patch, ready if wanted.
Checked and fine:

  • Every delete is by name and never follows a link. Disk.FreeWork takes only WorkParts. Shader caches and the store keep their allowlists (Clearable, StoreFiles), and pipeline notes stay. Logs skip the one this run writes.
  • An unlisted folder is rechecked for mods and links (both mods/ and user/mods/) right before the delete, and again after its save backup (Leftovers.Delete, the guard in DeleteGameFolder). FolderNotDeleted.Backup reaches Home's notice. With builds.json unreadable, every unlisted row is read-only and the delete throws.
  • An unlisted delete checks that the folder is still inside the current builds folder. The snapshot key includes the builds folder, so changing it in Settings drops the old rows.
  • A version's row goes through Home's own delete (saves first, the default moved), so Storage can't remove a version in a way Home wouldn't.
  • Staging cleanup takes the prefetch semaphore without waiting (CleanStaging) and reports a running download.
  • Stop and exit: every worker return after a cancel posts StoppedIfRequested, including the cold-clear, seed, cancelled-run, start-failure and queued-exit paths. A Stop that wins against a queued successful exit rolls back instead of registering the build and opening Ready over Home, which was a real bug on main's shape. SetRunning(false) comes before every CloseAfterFinalizing, so OnClosing lets the window go.
  • The sizes count each hard-linked file once, and copies are told apart by union-find over shared file ids.

Blocking (now follow-ups)

  1. The head is untested. Build 8650304 (now main) with -warnaserror and run the core checks. Then run the launcher on Windows, and on Linux if you can: Stop during a build (on an update, so caches are put back), close the window during a build and during Removing…, a Storage removal from each group, and the Settings → Manage storage path. Post the results here. CI doesn't run tests on pull requests, so the PR's own results are the only ones.
  2. Describe the build stop and shutdown change: Stop waits on the build page now, a close during finalisation waits, and SIGTERM goes through the window thread with or without a build (App/ViewModels/BuildStepViewModel.cs:565, App/Program.cs:121). It is beyond what the PR says it does. It belongs in the release notes, or in a PR of its own if it needs changing.

Suggestions

  • Core/Storage.cs:356: the work kinds check the drive of p.Work, not of the part they delete. If objcache or a store is a mount on another drive (Linux), removing on one drive can delete the other's, or report a removal that deleted nothing. Check On(Path.Combine(p.Work, part)) per part. These files can be rebuilt, so this is low.
  • App/ViewModels/StorageViewModel.cs:563: a removal outlives its page. Start one, go Home and start an update, and make_game runs while objcache is still being deleted. Settings' old Free up space had the same race, so it isn't a regression. A launcher-wide "storage removing" flag that CanStartBuild and Play read would close it.
  • App/ViewModels/StorageViewModel.cs:614: only IO errors are caught. Anything else leaves removing and the pinned progress on until the page is opened again. A finally that calls Measure() would avoid that.
  • The new texts (about 60) are in no catalog, so the Storage page and the tabs show in English in the 12 translated languages (translations.py --missing <code>).
  • The Settings work hint now says only the most recent build's work is kept, and the stores are kept too.
  • Still open from BeanBot, none blocking in my reading: a bulk estimate that sums items rather than their union (L16), a scan that can publish during a Home delete (L11), the B-button check that reads XAML rather than dispatching (L24), and a test of the real rollback path (L5).

Nits (inline): the MakeGameCommand stores comment lost its reasons (the 14 days, 4 GB vs Longshot's 8, two translations), and the KeepBuildFiles comment says ~1.1 GB and leaves out the stores.

Testing: the author ran the launcher on Windows 11 at c105e1e, with 2163 core checks, Debug and Release builds, and screenshots. Two suites were skipped, both of which also fail on main on that PC. Nothing has been run since: BeanBot's five commits say so themselves. Linux and the Deck were never run. CI ran only the title check (Compile and test was skipped).
Overlaps and merge order: #202 (Jordan's redesign, already not mergeable) keeps Free up space, the pages' DoneCommands, the cog and Home's Saves and NFC entry points, all of which this PR removed. It has to be reworked onto the tabs and the Storage page, or the maintainers have to choose one navigation. #183 (Saves: SavesViewModel and SavesView, the Done button), #55 (MainWindow, Program.cs, BuildStepViewModel, HomeView/HomeViewModel, Saves), #151 (Program.cs, BuildStepViewModel), #130 (BuildStepViewModel), #50 (BuildStepViewModel, LauncherSettings, MakeGameCommand) and #59 (HomeView/HomeViewModel, Toolchains) now need rebasing onto it.

**Recommendation: Request changes, now as follow-ups (this merged as e2220601 while the review ran).** The Storage page is a real gain and its deletes are guarded well. But the merged head was never built or tested: the author's runs cover c105e1e, and five later automated commits (about 700 changed lines) changed how a build stops, closes and handles SIGTERM. The description doesn't mention that change. Players can now see what Longshot keeps on their disk, grouped by what it is for. They can let go of one part at a time, including old versions' folders an update left behind (25-40 GB each), which only a notice on Home showed before. The title-bar tabs replace Home's Saves and NFC cards and the pages' Done buttons. On net it makes the launcher better. The open question is whether the head behaves the way the tested commit did. **Does it help:** not a perf change. The feature is shown working on Windows 11 at c105e1e: the author ran the launcher against a real home, ran 2163 core checks and built Debug and Release with no warnings, and posted screenshots in the comments. Nothing has been run at 8650304, and twice in this PR an untested fixer commit broke the core tests' compile (L27, L34). **Other systems:** Linux and the Steam Deck take the same measure and delete paths, and nothing was run there. Linux has no `FileLinks.Names`, so it says "other folders" by design. The build page's Stop now stays on the page until make_game is killed and the caches and folder are put back, where before it went Home at once. Closing during that wait waits too. SIGTERM now goes through the window thread on every Linux run, with or without a build, and waits up to 2 s for summaries before `desktop.Shutdown()`. Before, with no build, the launcher ended the default way. Clearing the shared shader store makes every version prepare shaders again on any GPU, and the page says so before it goes. The build's environment is the same as on main: both stores are passed, with the 4 GB and two-translation caps. **Switches:** `KeepBuildFiles` (a Storage page checkbox, on by default). On is main's behaviour, so the default is right, and the opt-out serves players short of disk space (a Deck). With it off, the work parts and both stores go after each successful build only (`Storage.AfterBuild`). **Reviewed:** 865030481847 against dad220036044 (the PR's base; main has since gained #222, and the squash e2220601 is this head plus #222, no other change). I read in full: Core/Storage.cs, StorageViewModel.cs, StorageView.axaml, ShareRow.cs, and the changed parts of Disk.cs, Leftovers.cs, BuildRegistry.cs, ShaderCaches.cs, Toolchains.cs, ToolsPrefetch.cs, FileLinks.cs, GameFolder.cs, InstanceFolders.cs, MakeGameCommand.cs, LauncherService.cs, BuildReports.cs, BuildStepViewModel.cs (with Run, Exited, Stop, Fail, Complete and PutBack in full), Program.cs, MainWindow.axaml(.cs), PadInput.cs, MainViewModel.cs, HomeViewModel.cs, SettingsViewModel.cs, NfcViewModel.cs, SavesViewModel.cs and App.axaml. I skimmed the tests (StorageChecks, LeftoverChecks, BuildReportChecks, PadChecks), the docs, the screenshot scenes and the catalog removals. Nothing was run (a code review). **Fixed in this review:** nothing pushed (it merged first). The two comment nits below are a 14-line follow-up patch, ready if wanted. **Checked and fine:** - Every delete is by name and never follows a link. `Disk.FreeWork` takes only `WorkParts`. Shader caches and the store keep their allowlists (`Clearable`, `StoreFiles`), and pipeline notes stay. Logs skip the one this run writes. - An unlisted folder is rechecked for mods and links (both `mods/` and `user/mods/`) right before the delete, and again after its save backup (`Leftovers.Delete`, the `guard` in `DeleteGameFolder`). `FolderNotDeleted.Backup` reaches Home's notice. With builds.json unreadable, every unlisted row is read-only and the delete throws. - An unlisted delete checks that the folder is still inside the current builds folder. The snapshot key includes the builds folder, so changing it in Settings drops the old rows. - A version's row goes through Home's own delete (saves first, the default moved), so Storage can't remove a version in a way Home wouldn't. - Staging cleanup takes the prefetch semaphore without waiting (`CleanStaging`) and reports a running download. - Stop and exit: every worker return after a cancel posts `StoppedIfRequested`, including the cold-clear, seed, cancelled-run, start-failure and queued-exit paths. A `Stop` that wins against a queued successful exit rolls back instead of registering the build and opening Ready over Home, which was a real bug on main's shape. `SetRunning(false)` comes before every `CloseAfterFinalizing`, so `OnClosing` lets the window go. - The sizes count each hard-linked file once, and copies are told apart by union-find over shared file ids. **Blocking** (now follow-ups) 1. The head is untested. Build 8650304 (now main) with `-warnaserror` and run the core checks. Then run the launcher on Windows, and on Linux if you can: Stop during a build (on an update, so caches are put back), close the window during a build and during *Removing…*, a Storage removal from each group, and the Settings → Manage storage path. Post the results here. CI doesn't run tests on pull requests, so the PR's own results are the only ones. 2. Describe the build stop and shutdown change: Stop waits on the build page now, a close during finalisation waits, and SIGTERM goes through the window thread with or without a build (`App/ViewModels/BuildStepViewModel.cs:565`, `App/Program.cs:121`). It is beyond what the PR says it does. It belongs in the release notes, or in a PR of its own if it needs changing. **Suggestions** - `Core/Storage.cs:356`: the work kinds check the drive of `p.Work`, not of the part they delete. If `objcache` or a store is a mount on another drive (Linux), removing on one drive can delete the other's, or report a removal that deleted nothing. Check `On(Path.Combine(p.Work, part))` per part. These files can be rebuilt, so this is low. - `App/ViewModels/StorageViewModel.cs:563`: a removal outlives its page. Start one, go Home and start an update, and make_game runs while `objcache` is still being deleted. Settings' old *Free up space* had the same race, so it isn't a regression. A launcher-wide "storage removing" flag that `CanStartBuild` and Play read would close it. - `App/ViewModels/StorageViewModel.cs:614`: only IO errors are caught. Anything else leaves `removing` and the pinned progress on until the page is opened again. A `finally` that calls `Measure()` would avoid that. - The new texts (about 60) are in no catalog, so the Storage page and the tabs show in English in the 12 translated languages (`translations.py --missing <code>`). - The Settings work hint now says only the most recent build's work is kept, and the stores are kept too. - Still open from BeanBot, none blocking in my reading: a bulk estimate that sums items rather than their union (L16), a scan that can publish during a Home delete (L11), the B-button check that reads XAML rather than dispatching (L24), and a test of the real rollback path (L5). **Nits** (inline): the MakeGameCommand stores comment lost its reasons (the 14 days, 4 GB vs Longshot's 8, two translations), and the `KeepBuildFiles` comment says ~1.1 GB and leaves out the stores. **Testing:** the author ran the launcher on Windows 11 at c105e1e, with 2163 core checks, Debug and Release builds, and screenshots. Two suites were skipped, both of which also fail on main on that PC. Nothing has been run since: BeanBot's five commits say so themselves. Linux and the Deck were never run. CI ran only the title check (Compile and test was skipped). **Overlaps and merge order:** https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/202 (Jordan's redesign, already not mergeable) keeps *Free up space*, the pages' `DoneCommand`s, the cog and Home's Saves and NFC entry points, all of which this PR removed. It has to be reworked onto the tabs and the Storage page, or the maintainers have to choose one navigation. https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/183 (Saves: `SavesViewModel` and `SavesView`, the Done button), https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/55 (MainWindow, Program.cs, BuildStepViewModel, HomeView/HomeViewModel, Saves), https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/151 (Program.cs, BuildStepViewModel), https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/130 (BuildStepViewModel), https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/50 (BuildStepViewModel, LauncherSettings, MakeGameCommand) and https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/59 (HomeView/HomeViewModel, Toolchains) now need rebasing onto it.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!221
No description provided.