feat(saves): add player profiles and progress previews #55

Open

Anarkkie wants to merge 19 commits from Anarkkie/LongshotLauncher:feat/player-save-previews into main

pull from: Anarkkie/LongshotLauncher:feat/player-save-previews

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 3 Commits 19 Files changed 63 +3770 -363

Anarkkie commented 2026-11-14 00:36:54 +00:00

First-time contributor

• Copy link
• Copy Markdown

Players sharing a PC need separate named playthroughs and a way to recognize their progress before starting a version. This adds remembered player selection and read-only save previews to Home and Saves, following the launcher's existing theme and save-transfer flow.

What changed

• Named players use stable folders independent of display names and game versions. Default keeps the existing save environment. Selection and rename persist; running games, corrupt metadata, ambiguous accounts and stale confirmations cannot silently select another player's saves. Uninstall preserves profile folders even when their index is unavailable.
• Home shows the selected player's latest save; Saves lets the player select a slot and inspect its screenshot, location, vitals and supported inventory. Empty players and unavailable data clear the previous preview.
• Usable items, equipment and trading items are separate from upgrades and collectibles. Swords, shields, tunics, arrows and bottles stay with their families. Spiritual stones and medallions have separate rows; six normal songs sit above six warp songs, with Scarecrow separate.
• Rupees are right-aligned below the screenshot, above ten-heart rows. Unlocked magic has its own row below, with optional native segments at the same scale for normal and double capacity. Locked magic has no row.
• Current stock determines replaceable tools, gear and trading items; permanent rewards and depleted consumables retain supported unlock state. Replacement tiers collapse to the appropriate highest tier. The preview does not claim equipped state, age eligibility, quest completion or playable Scarecrow notes.
• Optional artwork and song metadata are prepared locally with scripts/extract_save_icons.py. The branch ships no game artwork or metadata. Missing, corrupt, linked or unsupported assets fall back without losing the rest of the preview. The authored item catalog retains its MIT notice.

Alignment with accepted upstream

Includes accepted main 9b3d202, including the translation system, first-import destination work, NX2navi import, Hookshot settings import and current crash-log discovery. This replaces the earlier proposal's temporary first-save prerequisite and outstanding integration notes for #47 and #52, which have now merged.

• Empty named players import through upstream Saves.ImportTarget; previews use the same game account and ignore stray account folders. Import/export confirmations revalidate the selected player and destination.
• New UI labels use Tr and refresh when the language changes without losing player/slot selection. 59 new strings use the accepted English fallback pending translation.
• Hookshot game settings remain scoped to an explicitly selected build, independent of the player-save directory. Startup crash-page diversion releases its unused Home preview.
• Upstream's ambiguous-account export guard remains intact. A real account plus a stray account may still block export.

This remains a framework contribution for maintainers to adapt as the launcher grows. Automatic icon extraction during installation and the long-term profile-storage policy remain maintainer decisions. Open #54, #57, #58 and #61 were inspected but are not included; some touch shared launcher/build files and may need merge-order coordination.

Validation

Feature code: 5bca18c; latest accepted main: 9b3d202. The accompanying documentation records source revisions and measured configurations in docs/tested-configurations.md.

Scope	Result
Standalone profile integration e4893d5, Linux / .NET 10.0.404	Strict core 1,089, release 28, icon exporter 4, metadata 6; all pass.
Standalone profile integration, Windows headless UI	290 checks pass.
Final private integration ae3c27e, after accepted #60	Windows/Linux strict core 1,120 / 1,145; headless UI 290 / 289; Linux release 28, exporter 4, metadata 6; all pass.
Locked Release builds, Windows and Linux	0 warnings, 0 errors.
Actual Avalonia Home/Saves at 960 x 600	Early/advanced/empty saves; art fallback; 3/10/11/20 hearts; both magic capacities; grouped progress; first imports; stale confirmations; language switching; settings/build separation and preview lifetime covered.

The final private integration also includes the Windows filesystem fixes in #64 and source-built game-layout fix in #63. Its full Windows-suite result is not a standalone pass for this profile branch. The standalone branch retains the upstream Windows core-runner failures addressed by those fixes. Windows successful-symlink fixtures explicitly report unavailable privilege; their complete Linux coverage passes. Linux release tests emit existing Python socket ResourceWarnings.

Native acceptance used nightly-80-7315957c (source cdf3d9d8), Kokiri Forest, Windows 11 Pro 10.0.26300, RTX 3080 Ti / NVIDIA 610.88, Ryzen 7 5800X3D and 32 GB RAM. Early QA -> Upgraded QA -> Early QA, reopening the launcher service for each run, loaded the correct selected save every time: three hearts -> twenty hearts with magic/upgraded ammunition -> three hearts. All three runs rendered the settled scene, accepted movement and exited 0. All 70 pre-existing and 28 copied test-save files retained their hashes. These runs used combined e262bd6; launch/routing/preview source is unchanged by the final crash-log-only merge to ae3c27e.

Native checks were offscreen through the game's control bridge with HOS_HEADLESS=1, HOS_AUDIO=0, RX_VK_LOAD=create and RX_VK_PRECOMPILE unset. The advanced fixture was edited in an isolated copy, not obtained through a completed playthrough. Earlier game-write/readback checks retained all 85 supported displayed records. Not every natural unlock event, native Linux/Steam Deck window, physical controller, stable game build or newly packaged single-file release has been exercised. No performance improvement is claimed.

Screenshots

Current Home and Saves at 960 x 600, showing the upgraded test copy. Update and both screenshots.

The earlier early-progress and fallback screenshots remain available.

Risk and rollback

The main risks are player-directory routing, import destinations and future save-schema changes. Routing fails closed for missing/corrupt profiles; parsing is bounded and read-only. Unknown fields remain unavailable. Selecting Default restores the original save environment. Reverting the feature leaves named-player folders intact; preserve/export them rather than deleting them.

Only source, authored fixtures, documentation and permitted launcher screenshots are shared. Game files, saves, extracted textures and generated game metadata remain local.

AI-assisted implementation and independent source review with OpenAI Codex; all validation above ran locally.

Players sharing a PC need separate named playthroughs and a way to recognize their progress before starting a version. This adds remembered player selection and read-only save previews to Home and Saves, following the launcher's existing theme and save-transfer flow. ## What changed - Named players use stable folders independent of display names and game versions. Default keeps the existing save environment. Selection and rename persist; running games, corrupt metadata, ambiguous accounts and stale confirmations cannot silently select another player's saves. Uninstall preserves profile folders even when their index is unavailable. - Home shows the selected player's latest save; Saves lets the player select a slot and inspect its screenshot, location, vitals and supported inventory. Empty players and unavailable data clear the previous preview. - Usable items, equipment and trading items are separate from upgrades and collectibles. Swords, shields, tunics, arrows and bottles stay with their families. Spiritual stones and medallions have separate rows; six normal songs sit above six warp songs, with Scarecrow separate. - Rupees are right-aligned below the screenshot, above ten-heart rows. Unlocked magic has its own row below, with optional native segments at the same scale for normal and double capacity. Locked magic has no row. - Current stock determines replaceable tools, gear and trading items; permanent rewards and depleted consumables retain supported unlock state. Replacement tiers collapse to the appropriate highest tier. The preview does not claim equipped state, age eligibility, quest completion or playable Scarecrow notes. - Optional artwork and song metadata are prepared locally with `scripts/extract_save_icons.py`. The branch ships no game artwork or metadata. Missing, corrupt, linked or unsupported assets fall back without losing the rest of the preview. The authored item catalog retains its MIT notice. ## Alignment with accepted upstream Includes accepted main `9b3d202`, including the translation system, first-import destination work, NX2navi import, Hookshot settings import and current crash-log discovery. This replaces the earlier proposal's temporary first-save prerequisite and outstanding integration notes for #47 and #52, which have now merged. - Empty named players import through upstream `Saves.ImportTarget`; previews use the same game account and ignore stray account folders. Import/export confirmations revalidate the selected player and destination. - New UI labels use `Tr` and refresh when the language changes without losing player/slot selection. **59 new strings use the accepted English fallback** pending translation. - Hookshot game settings remain scoped to an explicitly selected build, independent of the player-save directory. Startup crash-page diversion releases its unused Home preview. - Upstream's ambiguous-account export guard remains intact. A real account plus a stray account may still block export. This remains a framework contribution for maintainers to adapt as the launcher grows. Automatic icon extraction during installation and the long-term profile-storage policy remain maintainer decisions. Open #54, #57, #58 and #61 were inspected but are not included; some touch shared launcher/build files and may need merge-order coordination. ## Validation Feature code: `5bca18c`; latest accepted main: `9b3d202`. The accompanying documentation records source revisions and measured configurations in `docs/tested-configurations.md`. | Scope | Result | |---|---| | Standalone profile integration `e4893d5`, Linux / .NET 10.0.404 | Strict core **1,089**, release **28**, icon exporter **4**, metadata **6**; all pass. | | Standalone profile integration, Windows headless UI | **290** checks pass. | | Final private integration `ae3c27e`, after accepted #60 | Windows/Linux strict core **1,120 / 1,145**; headless UI **290 / 289**; Linux release **28**, exporter **4**, metadata **6**; all pass. | | Locked Release builds, Windows and Linux | **0 warnings, 0 errors**. | | Actual Avalonia Home/Saves at 960 x 600 | Early/advanced/empty saves; art fallback; 3/10/11/20 hearts; both magic capacities; grouped progress; first imports; stale confirmations; language switching; settings/build separation and preview lifetime covered. | The final private integration also includes the Windows filesystem fixes in #64 and source-built game-layout fix in #63. Its full Windows-suite result is **not** a standalone pass for this profile branch. The standalone branch retains the upstream Windows core-runner failures addressed by those fixes. Windows successful-symlink fixtures explicitly report unavailable privilege; their complete Linux coverage passes. Linux release tests emit existing Python socket ResourceWarnings. Native acceptance used nightly-80-7315957c (source `cdf3d9d8`), Kokiri Forest, Windows 11 Pro 10.0.26300, RTX 3080 Ti / NVIDIA 610.88, Ryzen 7 5800X3D and 32 GB RAM. Early QA -> Upgraded QA -> Early QA, reopening the launcher service for each run, loaded the correct selected save every time: three hearts -> twenty hearts with magic/upgraded ammunition -> three hearts. All three runs rendered the settled scene, accepted movement and exited 0. **All 70 pre-existing and 28 copied test-save files retained their hashes.** These runs used combined `e262bd6`; launch/routing/preview source is unchanged by the final crash-log-only merge to `ae3c27e`. Native checks were offscreen through the game's control bridge with `HOS_HEADLESS=1`, `HOS_AUDIO=0`, `RX_VK_LOAD=create` and `RX_VK_PRECOMPILE` unset. The advanced fixture was edited in an isolated copy, not obtained through a completed playthrough. Earlier game-write/readback checks retained all **85** supported displayed records. Not every natural unlock event, native Linux/Steam Deck window, physical controller, stable game build or newly packaged single-file release has been exercised. No performance improvement is claimed. ## Screenshots Current Home and Saves at 960 x 600, showing the upgraded test copy. [Update and both screenshots](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/55#issuecomment-17832).   The earlier [early-progress and fallback screenshots](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/55#issuecomment-15496) remain available. ## Risk and rollback The main risks are player-directory routing, import destinations and future save-schema changes. Routing fails closed for missing/corrupt profiles; parsing is bounded and read-only. Unknown fields remain unavailable. Selecting Default restores the original save environment. Reverting the feature leaves named-player folders intact; preserve/export them rather than deleting them. Only source, authored fixtures, documentation and permitted launcher screenshots are shared. Game files, saves, extracted textures and generated game metadata remain local. AI-assisted implementation and independent source review with OpenAI Codex; all validation above ran locally.

❤️ 1

Anarkkie added 16 commits 2026-11-14 00:36:54 +00:00

feat(saves): add named players and caption previews ... de6a3805cf

Keep Default on its existing save root while optional named players have
separate persisted roots shared across game versions. Show bounded read-only
caption previews in the existing launcher and handle unavailable profile data.

Add authored core checks and headless Avalonia interaction coverage. Local
validation: 65 profile checks and 68 headless checks passed; locked Release
build passed. Full Windows suites retain documented upstream/environment
failures. Real-game and native Linux acceptance remain pending.

Assisted-by: OpenAI Codex

fix(saves): preserve players and polish profile recovery 3d887878c2

feat(saves): show selected save progress beside players 0d8d0a44cc

feat(saves): refine previews with local game icons 1a82959fc3

style(saves): let heart graphics show health 5286c42718

style(saves): show magic only when unlocked 876bbe290a

style(saves): align save panels with launcher theme d222785031

feat(saves): fit complete inventory beside save previews c79f2a019c

fix(saves): fill heart rows to ten before wrapping 47e612fe48

fix(saves): group related inventory and equipment f25555e671

feat(saves): organize quest progress and local song icons 1281d8578c

fix(saves): avoid a rounding scrollbar in quest overview 5bcab8f1a9

fix(saves): show current tools and trading items faithfully 07dbde60d4

fix(saves): use native magic gauge below hearts ... 28f93ba395

Place rupees above health at the screenshot's right edge. Preserve native gauge segments across normal and double capacity, with an honest fallback when local art is unavailable.

docs(saves): record game acceptance and tested configurations ... b2302692e4

Assisted-by: OpenAI Codex

docs(saves): record final upstream comparison de5eb1c9dd

Anarkkie commented 2026-11-14 00:37:20 +00:00

Author

First-time contributor

• Copy link
• Copy Markdown

Compiled launcher views for this PR at 960 x 600. Local artwork is optional; these are permitted launcher screenshots, not extracted asset attachments.

Early progress after the game writes its save. Magic is hidden until unlocked; rupees sit above the heart row.

Advanced test copy after a game save: 85 displayed progress records, grouped inventory, two rows of ten hearts and the native magic gauge below them. This is an isolated unlock/transition fixture, not a completed playthrough.

The same shared detail card on Saves, with its selected slot.

Optional-art fallback, using authored data only. Values and accessible item names remain available when local textures are absent.

Compiled launcher views for this PR at 960 x 600. Local artwork is optional; these are permitted launcher screenshots, not extracted asset attachments. Early progress after the game writes its save. Magic is hidden until unlocked; rupees sit above the heart row.  Advanced test copy after a game save: 85 displayed progress records, grouped inventory, two rows of ten hearts and the native magic gauge below them. This is an isolated unlock/transition fixture, not a completed playthrough.  The same shared detail card on Saves, with its selected slot.  Optional-art fallback, using authored data only. Values and accessible item names remain available when local textures are absent. 

early-home.png

83 KiB

upgraded-home.png

132 KiB

upgraded-saves.png

168 KiB

optional-art-fallback.png

59 KiB

Anarkkie added 3 commits 2026-11-14 11:06:44 +00:00

merge: align player save framework with accepted launcher updates e4893d5cf8

Merge remote-tracking branch 'forge/main' into codex/save-framework-integration 5bca18ce96

docs(saves): record upstream integration validation 8934451faf

Anarkkie referenced this pull request 2026-11-14 11:06:50 +00:00

fix(launcher): recognize source-built game folders #63

Anarkkie referenced this pull request 2026-11-14 11:06:52 +00:00

fix(windows): correct file operations and core checks #64

Anarkkie commented 2026-11-14 11:06:59 +00:00

Author

First-time contributor

• Copy link
• Copy Markdown

Updated to the accepted launcher main at 9b3d202. Empty-player imports now use the accepted account destination; translation switching, NX2navi imports and build-scoped Hookshot settings are integrated. The refreshed description records standalone and combined validation separately. The independent layout and Windows corrections are #63 and #64.

Current Home and Saves at 960 x 600 use an isolated upgraded test copy with 85 supported displayed records. These are launcher screenshots; saves, extracted art and generated metadata remain local.

Updated to the accepted launcher main at 9b3d202. Empty-player imports now use the accepted account destination; translation switching, NX2navi imports and build-scoped Hookshot settings are integrated. The refreshed description records standalone and combined validation separately. The independent layout and Windows corrections are #63 and #64. Current Home and Saves at 960 x 600 use an isolated upgraded test copy with 85 supported displayed records. These are launcher screenshots; saves, extracted art and generated metadata remain local.  

profile-home-upgraded.png

132 KiB

profile-saves-upgraded.png

168 KiB

Victor commented 2026-11-14 16:57:53 +00:00

First-time contributor

• Copy link
• Copy Markdown

Hey! Thanks for the heads-up about !57. I checked the overlap between our PRs: the only files we both touch are the 12 Core/Lang catalogs and README.md. None of the code overlap, mine just touch the build folder logic in BuildRegistry / LauncherSettings and the wizard. So whichever lands second, just needs a small rebase on the catalogs. Happy to rebase mine if yours goes first!

Hey! Thanks for the heads-up about !57. I checked the overlap between our PRs: the only files we both touch are the 12 Core/Lang catalogs and README.md. None of the code overlap, mine just touch the build folder logic in BuildRegistry / LauncherSettings and the wizard. So whichever lands second, just needs a small rebase on the catalogs. Happy to rebase mine if yours goes first!

Some checks are pending

Hide checks

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Compile and test (pull_request) Blocked by required conditions

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

Some workflows are waiting to be reviewed.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'feat/player-save-previews:Anarkkie-feat/player-save-previews'

git switch 'Anarkkie-feat/player-save-previews'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/build

Building Longshot from your game

  

area/install

Installing Longshot

  

area/saves

Moving and backing up saves

  

area/ui

The launcher's windows and screens

  

area/updates

Finding and applying updates

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

platform/linux

Linux only

  

platform/steam-deck

Steam Deck

  

platform/windows

Windows only

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

No labels

area/build

area/install

area/saves

area/ui

area/updates

good first issue

gpu/amd

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

platform/linux

platform/steam-deck

platform/windows

priority

critical

priority

high

priority

low

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/LongshotLauncher!55

No description provided.