fix(windows): correct file operations and core checks

Anarkkie commented

2026-11-14 11:06:52 +00:00

First-time contributor

The Windows core runner exposes real filesystem failures: concurrent atomic replacements can fail with access denied, and adding a separator to an existing drive root makes free-space detection fall back. This fixes those Windows paths and writes, and makes the cross-platform test fixtures state their platform requirements accurately.

Changes

Serialize only the final Windows AtomicFile rename with a named mutex derived from the normalized, case-folded destination. Temporary writes and flushes remain independent. Abandoned ownership recovers; genuine locked-file errors still propagate with the old bytes intact and temporary files removed.
Preserve a Windows drive root's existing separator in Disk.Within, so free-space lookup uses C:\ rather than a doubled separator.
Validate a Linux AppImage path with Linux absolute-path semantics even when the caller runs on Windows.
Report successful symlink fixtures as unavailable when Windows lacks the privilege; run them fully on Linux. Ordinary extraction, traversal rejection and prohibited-link rejection remain covered on Windows. No machine privilege setting changes.
Use the existing quoting contract for native Windows paths in the authored Linux shortcut fixture, retaining its independent escaping vectors.

These are separate commits within the Windows correctness topic, so the runtime fixes and fixture changes can be reviewed independently. No retry loop hides permission errors.

Reproduction and validation

Code a8f320e, based on main 01f2797; it applies cleanly to current main 9b3d202. The accompanying documentation commit adds the measured configurations without changing code.

Check	Result
Windows four-process reproduction, 100 writes each	Existing final replacement: 26 access-denied failures; evaluated `File.Replace` alternative: 71; named-mutex final rename: 0. Correctness comparison, not a performance benchmark.
Production atomic-write regression checks	Four synchronized child processes, 64 writes each, absent and existing destinations: 512 writes. Case aliases, abandoned owner with a surviving handle, release checked from a different process, and a genuine locked destination all pass.
Windows 11 Pro 10.0.26300 / .NET 10.0.404	Strict full core 960 checks pass; independently repeated successfully.
Local Linux container / .NET 10.0.404	Strict core 985 checks and release tooling 28 tests pass, including successful links.
Locked Release builds, both platforms	0 warnings, 0 errors.

The Windows successful-link capability skip is explicit in output. Linux release tests emit existing Python socket ResourceWarnings but pass. docs/tested-configurations.md records the runs and their limits.

The private integration of these fixes with #55 and the root-layout fix in #63, on main 9b3d202, also passes Windows/Linux core 1,120 / 1,145, headless UI 290 / 289 and Linux release 28. These larger totals are combined validation, not this branch's standalone counts. Native Early -> Upgraded -> Early player routing passed in that integration; this PR itself changes no renderer or gameplay behavior.

Boundaries

The mutex coordinates ordinary normalized paths within one Windows session, following the existing InstanceLock convention. It does not promise coordination through arbitrary aliases, across sessions or across machines. Linux retains its existing atomic-replacement behavior. No UI layout or new default is introduced.

Open #54 also touches SelfUpdate.CurrentFile for package start paths. This change preserves its existing contract and should be kept when resolving merge order with that proposal.

AI-assisted implementation and independent source review with OpenAI Codex. Tests use authored files and processes; no game data is included.

The Windows core runner exposes real filesystem failures: concurrent atomic replacements can fail with access denied, and adding a separator to an existing drive root makes free-space detection fall back. This fixes those Windows paths and writes, and makes the cross-platform test fixtures state their platform requirements accurately. ## Changes - Serialize only the final Windows `AtomicFile` rename with a named mutex derived from the normalized, case-folded destination. Temporary writes and flushes remain independent. Abandoned ownership recovers; genuine locked-file errors still propagate with the old bytes intact and temporary files removed. - Preserve a Windows drive root's existing separator in `Disk.Within`, so free-space lookup uses `C:\` rather than a doubled separator. - Validate a Linux AppImage path with Linux absolute-path semantics even when the caller runs on Windows. - Report successful symlink fixtures as unavailable when Windows lacks the privilege; run them fully on Linux. Ordinary extraction, traversal rejection and prohibited-link rejection remain covered on Windows. No machine privilege setting changes. - Use the existing quoting contract for native Windows paths in the authored Linux shortcut fixture, retaining its independent escaping vectors. These are separate commits within the Windows correctness topic, so the runtime fixes and fixture changes can be reviewed independently. No retry loop hides permission errors. ## Reproduction and validation Code `a8f320e`, based on main `01f2797`; it applies cleanly to current main `9b3d202`. The accompanying documentation commit adds the measured configurations without changing code. | Check | Result | |---|---| | Windows four-process reproduction, 100 writes each | Existing final replacement: **26 access-denied failures**; evaluated `File.Replace` alternative: **71**; named-mutex final rename: **0**. Correctness comparison, not a performance benchmark. | | Production atomic-write regression checks | Four synchronized child processes, 64 writes each, absent and existing destinations: **512 writes**. Case aliases, abandoned owner with a surviving handle, release checked from a different process, and a genuine locked destination all pass. | | Windows 11 Pro 10.0.26300 / .NET 10.0.404 | Strict full core **960 checks** pass; independently repeated successfully. | | Local Linux container / .NET 10.0.404 | Strict core **985 checks** and release tooling **28 tests** pass, including successful links. | | Locked Release builds, both platforms | **0 warnings, 0 errors**. | The Windows successful-link capability skip is explicit in output. Linux release tests emit existing Python socket ResourceWarnings but pass. `docs/tested-configurations.md` records the runs and their limits. The private integration of these fixes with #55 and the root-layout fix in #63, on main `9b3d202`, also passes Windows/Linux core **1,120 / 1,145**, headless UI **290 / 289** and Linux release **28**. These larger totals are combined validation, not this branch's standalone counts. Native Early -> Upgraded -> Early player routing passed in that integration; this PR itself changes no renderer or gameplay behavior. ## Boundaries The mutex coordinates ordinary normalized paths within one Windows session, following the existing `InstanceLock` convention. It does not promise coordination through arbitrary aliases, across sessions or across machines. Linux retains its existing atomic-replacement behavior. No UI layout or new default is introduced. Open #54 also touches `SelfUpdate.CurrentFile` for package start paths. This change preserves its existing contract and should be kept when resolving merge order with that proposal. AI-assisted implementation and independent source review with OpenAI Codex. Tests use authored files and processes; no game data is included.

Anarkkie added 6 commits

2026-11-14 11:06:52 +00:00

fix(update): validate AppImage paths by target platform b1a27251af

fix(storage): serialize concurrent Windows file replacements 7ca3a2efe7

test: report unavailable Windows symlink fixtures 8afdc2dfea

fix(storage): recognize Windows drive roots for free space be81277464

test: quote native paths in Linux shortcut fixture a8f320e341

docs(windows): record filesystem validation

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Compile and test (pull_request) Blocked by required conditions

Details