fix(build): estimate progress from the work left #213
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!213
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/LongshotLauncher:fix/build-progress-eta"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Launcher could only infer shader preparation time from one percentage, and that percentage can jump when the renderer finds reusable work or changes phases. This PR keeps the earlier stage-aware progress fixes and combines the renderer's recent rate with the Launcher's cumulative rate when both are fresh.
What changed
Measurements
Windows 11 build 26300, i7-13700F, RTX 4070 driver 32.0.16.2101. The isolated runtimes use the same shared Longshot base. The separate producer PR adds the event in newer builders. Measurements used Launcher
af8aa5f8. Rebased headd2f22c35has identical progress, ETA and Build view source.The comparison replays identical live events twice at one-second checkpoints, with and without the new shader signal. Mean absolute error is computed only where both estimators showed a number.
Using the raw renderer rate alone gave 88.23 s mean error on the cold trace. The final estimator also withheld a numeric estimate longer than the old one: it showed 446 versus 615 samples on that trace. At an early cold checkpoint with 530.1 s actual remaining, the estimate moved from 698.8 s to 524.1 s. At a late checkpoint with 10.1 s remaining, it still estimated 47.9 s. Both warm patched runs emitted separate cache-saving signals and reached successful completion. These are ETA results on one PC and shader setting, with no speedup claim.
Late shader countdown experiment
I tested a local variant that could shorten a fresh estimate by up to half after 90% based on roughly 30 seconds of progress. The table compares it with this PR's estimator on identical events at one-second intervals.
The independent run reused the assembled development runtime, including its application cache, and completed shader preparation in 636.25 s. The last 5% took 130.60 s, compared with 3.85 s on the original patched run. Both short warm replays were unchanged. The experiment stays out of this PR. The next measurement needs to distinguish elapsed time spent preparing programs, compiling pipelines, waiting for the remaining workers and saving caches.
Testing
UnlistedCheckson current main and this patch. The strict Longshot pin check also encounters an existing pipeline-cache filename mismatch. The Tooling release suite reports the same three tag failures on both revisions.UnlistedChecksassertion. Both reached the same nextSavesChecksfailure while importing the fixture that simulates a legacy Linux save moved intouser/. The diagnostic changed one assertion in each temporary copy and gives baseline parity evidence.Rebase validation
073e96e0. Git's independent merge calculation produced the same tree. The upstream tools.lock path fix and the ETA patch apply together cleanly.d2f22c35passed all 140 focused progress and clock assertions. They cover older-builder fallback, active renderer estimates, expiry, cache saving and completion. The base passed its 67 focused assertions. Lint and the locked Release build passed on both revisions.UnlistedChecksassertion on both revisions. The pinned producer contract reported the same pipeline-cache filename mismatch.mise run ci:smokereproduced the same three Tooling release-test failures on both revisions, with 39 release tests passing on each. The failed cases areBump.test_the_bump,Bump.test_the_next_stableandPublish.test_check_tag_against_the_published_releases.89c3d21estopped because the licence reader still expectsscripts/ngx_sdk.py. The contract needs a coordinated reader update to move to that base.Still to verify
CI / Conventional Commit titlefails ond2f22c35. It reads main's all-zero.tooling-revbefore it checks the title. Launcher PR #215 changes just that file to Tooling main0b0059ac, which containsscripts/release.py. #215 remains WIP and its own title job reads the same base pin. ForgejoCI / Compile and testis intentionally skipped on PR events.ci: approvedlabel starts the CircleCI fork workflow. Itsci/circleci: gatecombinesfork-lint,fork-build-test,fork-release-scriptsandfork-packageas applicable. The description check passes. The local core, release and producer-contract checks still reproduce baseline failures, so the repository's check requirement for leaving WIP remains open.89c3d21e. Its Windows Builder appears in a checksum manifest whose signature verified against this Launcher's trust keys. The tagged builder and renderer sources lack@@shader_eta, and there is no PR-specific release tag for #1830. The portable end-to-end check still needs a published, signed builder that contains the producer signal. Shader error on additional drivers is still unmeasured.Possibly related, for context:
Same synthetic cold-read transcript on main and the patch. Main shows fixed stage markers. The patch shows elapsed time against estimated work left and keeps the measured read percentage in its row.
Separated shader timing from translation, compile, disk pace and build worker count. Replayed four saved cold-build checkpoints: at shader start the estimate is 5m11s instead of 14m05s, with 1m18s actually remaining. 119 focused assertions passed. Warm rebuild is queued.
Warm v3.0.0 rebuild on
82b60eacreached Ready in 26.2s with zero changed compile files. Shader preparation took 11.6s. At the final pre-completion sample the fallback ETA showed 301s with 1.5s left. This exposes a remaining warm shader forecast gap; PR stays WIP.The estimate now names the work before shaders and waits for shader progress before giving a total. A real 27.0s warm rebuild ended with 78% in the shader row and no false five-minute countdown. The cold Finish checkpoints and 128 focused assertions are recorded.
Synthetic build scene showing the estimate before shaders and the stage duration rows.
Rebased on current Launcher main and added the renderer shader ETA consumer. The exact-SDK locked build and 137 focused assertions passed. The paired renderer measurements are running; the existing Windows-suite failures are documented.
f010114d6e436194f7e6Synthetic scenes from the updated Build screen. The renderer countdown and the cache-write status are distinct, and build completion remains a separate event.
Final synthetic build scenes from the bounded estimator. The renderer countdown and cache saving still have distinct states.
Final guarded shader ETA: cold replay mean absolute error fell from 49.68s to 35.17s on 446 common samples. Both warm pairs completed. 140 focused checks passed. The paired Longshot producer is #1830 in its own repository. Full local checks and fork CI still have the documented baseline and maintainer gates.
A fresh isolated shader run finished in 636.25 s and took 130.60 s after reporting 95%. On identical holdout events the local tail adjustment left final-minute mean absolute error at 28.58 s and slightly worsened overall error, so the published estimator stays at
af8aa5f8. The PR records the test limits and the separate CI prerequisites.The exact main and PR snapshots reached the same second Launcher core assertion when the local diagnostic continued past the known UnlistedChecks failure. The description records that comparison and distinguishes the intentionally skipped Forgejo compile job, the failed Forgejo title check, and the maintainer-approved CircleCI fork gate.
af8aa5f8a9d2f22c353bRebased on
073e96e0. The progress, ETA and Build view source is byte-identical to the previous published head. All 140 focused checks passed, and both exact revisions reproduced the same core, contract and Tooling smoke failures. The PR records the pin fix in #215 and the separate fork CI approval.Verified both external blockers on
d2f22c35. #215 is still WIP and points to the correct Tooling commit; the title job currently reads main's zero pin, and fork CI awaits ci: approved. The newest nightly's checksum manifest verified against the Launcher trust keys, but its tagged source lacks the shader ETA event. No portable installation or CI dispatch was used.WIP: fix(build): estimate progress from the work leftto fix(build): estimate progress from the work left