feat(home): a track and a version to pick on the home, and one button that plays, updates, goes back to or builds it #180

Merged
HumanBean merged 2 commits from dyst/LongshotLauncher:feat/home-version-picker into main 2026-11-17 21:12:13 +00:00
Member

Picking a version to play, build or go back to was split across three places: Play only ever started the default, a new track went through the Build another version dialog, and going back sat behind the clock icon on a row. This puts it all on the home: pick a track and a version, and one button does the right thing for it.

What it looks like

On the left of the home (where the default version's name, Play and Update were):

  • Track dropdown: Stable, Release candidate, Nightly. Each row says what is installed on it ("v3.0.0 installed", "none installed").
  • Version dropdown: that track's versions from the update check (every release and release candidate the server keeps, its newest 5 nightlies) plus any installed version the server no longer lists. A check beside the installed one; "default" and "newest" beside those.
  • One button under them, following the pick (Core/VersionPick.cs):
    • Play when the picked version is installed, with Update beside it when its track has a newer one (as before), and Remove, which opens the row's existing Delete dialog.
    • Update to vX / Go back to vX when the track has a build of another version: built in its place, in its folder, exactly as Update and Other versions did (JobKind.Update; one build per track).
    • Build vX when the track has nothing yet, into a folder of its own.
    • A line under it says which: the installed version's line, "vX is built in place of vY, in its folder", or that a new folder is made.
  • Your versions on the right stays as it is, with each row's Saves, Open folder, Set as default and Delete. Selecting a row puts the dropdowns on it; Set as default does too. The home opens on the default build.

Choices made

  • The clock button (Other versions) and its dialog are gone: the Version dropdown does what it did, for any track. Core/OtherVersions.cs is replaced by Core/VersionPick.cs, its checks moved and extended (tests/launcher_core/VersionPickChecks.cs).
  • Build another version stays: it is still the way to a second build of a track ("nightly (2)") or to build a version again.
  • Several builds on one track: each installed version gets its check and Play starts that build; a pick to replace replaces the row selected, else the track's default, else its last built.
  • Before the update check answers (or when it fails): the Version dropdown lists the installed versions only; a track with none says "Its versions show once git.magicbean.dev answers." and the button is off. The existing check and failure lines are unchanged.
  • While a check, the launcher's update or a leftovers delete runs, Update to / Go back to / Build are off, as the other build buttons are (CanStartBuild).
  • The empty home (no build yet) is unchanged: Build plus Change channel already does the job there.
  • Remove reuses DeleteViewModel unchanged, so it follows #176's Delete (taking a version's own save in, or backing it up, first). Related: #176.

Translations

The new texts (TRACK, VERSION, Installed, default, newest, none installed, {0} installed, Installed. {0}., and the two hints) are in every full catalog, written by an AI assistant: a native speaker should check them, especially the word chosen for "track" (I used each catalog's existing word for channel). The texts of the removed dialog are dropped from the catalogs.

Testing

  • python -I tests/test_launcher_core.py: 1547 checks passed (the new VersionPick checks: a track's versions and their marks, no answer yet, installed nightlies the server dropped, unordered versions, several builds on a track; Play / Update / Go back / Build for each case).
  • python -I tests/test_release.py: 37 tests OK.
  • dotnet build App -c Release: 0 warnings, 0 errors.
  • Screenshot scenes added in tools/screenshots (home-versions, home-tracks, home-go-back, home-build-track, and the row scenes renamed home-row-opened*); the PNGs are in the comment below. Before and after, against main: #180 (comment)
  • Not tried in the real window, only in the headless screenshots, and no build was started from the new button.
Picking a version to play, build or go back to was split across three places: Play only ever started the default, a new track went through the Build another version dialog, and going back sat behind the clock icon on a row. This puts it all on the home: pick a track and a version, and one button does the right thing for it. ## What it looks like On the left of the home (where the default version's name, Play and Update were): - **Track** dropdown: Stable, Release candidate, Nightly. Each row says what is installed on it ("v3.0.0 installed", "none installed"). - **Version** dropdown: that track's versions from the update check (every release and release candidate the server keeps, its newest 5 nightlies) plus any installed version the server no longer lists. A check beside the installed one; "default" and "newest" beside those. - **One button** under them, following the pick (`Core/VersionPick.cs`): - **Play** when the picked version is installed, with **Update** beside it when its track has a newer one (as before), and **Remove**, which opens the row's existing Delete dialog. - **Update to vX** / **Go back to vX** when the track has a build of another version: built in its place, in its folder, exactly as Update and Other versions did (`JobKind.Update`; one build per track). - **Build vX** when the track has nothing yet, into a folder of its own. - A line under it says which: the installed version's line, "vX is built in place of vY, in its folder", or that a new folder is made. - Your versions on the right stays as it is, with each row's Saves, Open folder, Set as default and Delete. Selecting a row puts the dropdowns on it; Set as default does too. The home opens on the default build. ## Choices made - **The clock button (Other versions) and its dialog are gone**: the Version dropdown does what it did, for any track. `Core/OtherVersions.cs` is replaced by `Core/VersionPick.cs`, its checks moved and extended (`tests/launcher_core/VersionPickChecks.cs`). - **Build another version stays**: it is still the way to a second build of a track ("nightly (2)") or to build a version again. - **Several builds on one track**: each installed version gets its check and Play starts that build; a pick to replace replaces the row selected, else the track's default, else its last built. - **Before the update check answers** (or when it fails): the Version dropdown lists the installed versions only; a track with none says "Its versions show once git.magicbean.dev answers." and the button is off. The existing check and failure lines are unchanged. - **While a check, the launcher's update or a leftovers delete runs**, Update to / Go back to / Build are off, as the other build buttons are (`CanStartBuild`). - **The empty home (no build yet) is unchanged**: Build plus Change channel already does the job there. - **Remove reuses `DeleteViewModel` unchanged**, so it follows #176's Delete (taking a version's own save in, or backing it up, first). Related: #176. ## Translations The new texts (TRACK, VERSION, Installed, default, newest, none installed, {0} installed, Installed. {0}., and the two hints) are in every full catalog, written by an AI assistant: **a native speaker should check them**, especially the word chosen for "track" (I used each catalog's existing word for channel). The texts of the removed dialog are dropped from the catalogs. ## Testing - `python -I tests/test_launcher_core.py`: 1547 checks passed (the new VersionPick checks: a track's versions and their marks, no answer yet, installed nightlies the server dropped, unordered versions, several builds on a track; Play / Update / Go back / Build for each case). - `python -I tests/test_release.py`: 37 tests OK. - `dotnet build App -c Release`: 0 warnings, 0 errors. - Screenshot scenes added in `tools/screenshots` (`home-versions`, `home-tracks`, `home-go-back`, `home-build-track`, and the row scenes renamed `home-row-opened*`); the PNGs are in the comment below. Before and after, against `main`: https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/180#issuecomment-43540 - **Not tried in the real window**, only in the headless screenshots, and no build was started from the new button.
feat(home): a track and a version to pick on the home, and one button that plays, updates, goes back to or builds it
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
b3cd5aab4d
The home's left side gets a Track dropdown (stable, rc, nightly, each saying what
is installed on it) and a Version dropdown (that track's versions from the update
check, a check beside the installed one, the default and the newest marked). The
button below follows the pick (Core/VersionPick.cs): Play when it is installed,
Update to or Go back to when the track has a build of another version (built in
its place, in its folder: one build per track), Build when the track has none.
Remove sits beside Play and opens the row's Delete as it is.

The rows' Other versions (the clock) and its dialog go: the Version dropdown does
what it did, for any track. Build another version stays, for a second build of a
track or building one again.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Screenshots from tools/screenshots (headless): the Version dropdown open, the Track dropdown open, an older nightly picked (Go back to), a track with no build picked (Build), a second row selected (the dropdowns follow it), and an installed version with an update (Play, Update, Remove).

home-versions.png

home-tracks.png

home-go-back.png

home-build-track.png

home-row-opened-second.png

home-update.png

Screenshots from tools/screenshots (headless): the Version dropdown open, the Track dropdown open, an older nightly picked (Go back to), a track with no build picked (Build), a second row selected (the dropdowns follow it), and an installed version with an update (Play, Update, Remove). ![home-versions.png](https://git.magicbean.dev/attachments/fb9599c1-22ce-44d1-9b0c-48b2e034c551) ![home-tracks.png](https://git.magicbean.dev/attachments/3ffba5ac-9443-4ee3-8934-fc00e3bef17e) ![home-go-back.png](https://git.magicbean.dev/attachments/7176b810-d57d-44c7-b03a-48ab00582efc) ![home-build-track.png](https://git.magicbean.dev/attachments/7ad172a0-b9a0-4bc7-b2b0-8b833f3e2e1d) ![home-row-opened-second.png](https://git.magicbean.dev/attachments/c7dd1860-dd55-4a5f-8339-0c91e4a1a4cf) ![home-update.png](https://git.magicbean.dev/attachments/10505f90-7cb6-4e8b-aef2-f38b38e29bd7)
Author
Member

Screenshots: before and after

Drawn with tools/screenshots (headless, the same scenes and window on both sides): before from main @ 321a9e1, after from this branch.

The home with an update

Before

before: home-update, main

After: the Track and Version dropdowns in the hero, Play / Update / Remove under them.

after: home-update, this PR

A version's row opened

Before: Other versions (the clock) beside Saves.

before: home-other-versions, main

After: Saves, Open folder, Delete; no clock.

after: home-row-opened, this PR

A second version's row opened

Before

before: home-other-versions-second, main

After: the dropdowns follow the row.

after: home-row-opened-second, this PR

Going back to an older version

Before: the Other versions dialog.

before: other-versions, main

After: the Version dropdown, then Go back to.

after: home-versions, this PR

after: home-go-back, this PR

New screens: no before

The Track dropdown open, and a track with no build picked (Build).

after: home-tracks, this PR

after: home-build-track, this PR

The channel picker (Build another version) is unchanged by this PR and has no scene, so it isn't shown.

## Screenshots: before and after Drawn with `tools/screenshots` (headless, the same scenes and window on both sides): before from `main` @ 321a9e1, after from this branch. ### The home with an update **Before** ![before: home-update, main](https://git.magicbean.dev/attachments/b6f45d04-fabe-4b60-a328-e3998fa05bde) **After**: the Track and Version dropdowns in the hero, Play / Update / Remove under them. ![after: home-update, this PR](https://git.magicbean.dev/attachments/10505f90-7cb6-4e8b-aef2-f38b38e29bd7) ### A version's row opened **Before**: Other versions (the clock) beside Saves. ![before: home-other-versions, main](https://git.magicbean.dev/attachments/ed6b7caf-12f9-4fd2-a6aa-bae83202583b) **After**: Saves, Open folder, Delete; no clock. ![after: home-row-opened, this PR](https://git.magicbean.dev/attachments/11ea5c5c-f3f6-4051-ae9c-c3d5f32889e5) ### A second version's row opened **Before** ![before: home-other-versions-second, main](https://git.magicbean.dev/attachments/ba4e110c-5803-4ac9-8bc4-908cfd6ea64b) **After**: the dropdowns follow the row. ![after: home-row-opened-second, this PR](https://git.magicbean.dev/attachments/c7dd1860-dd55-4a5f-8339-0c91e4a1a4cf) ### Going back to an older version **Before**: the Other versions dialog. ![before: other-versions, main](https://git.magicbean.dev/attachments/a95c3cd6-320f-4b7b-912b-2f30a68cc23b) **After**: the Version dropdown, then Go back to. ![after: home-versions, this PR](https://git.magicbean.dev/attachments/fb9599c1-22ce-44d1-9b0c-48b2e034c551) ![after: home-go-back, this PR](https://git.magicbean.dev/attachments/7176b810-d57d-44c7-b03a-48ab00582efc) ### New screens: no before The Track dropdown open, and a track with no build picked (Build). ![after: home-tracks, this PR](https://git.magicbean.dev/attachments/3ffba5ac-9443-4ee3-8934-fc00e3bef17e) ![after: home-build-track, this PR](https://git.magicbean.dev/attachments/7ad172a0-b9a0-4bc7-b2b0-8b833f3e2e1d) The channel picker (Build another version) is unchanged by this PR and has no scene, so it isn't shown.
Author
Member

Before and after screenshots added.

Before and after screenshots added.
dyst changed title from WIP: feat(home): a track and a version to pick on the home, and one button that plays, updates, goes back to or builds it to feat(home): a track and a version to pick on the home, and one button that plays, updates, goes back to or builds it 2026-11-17 19:08:15 +00:00
feat(home): the list of builds is "Your instances"
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
6ed6a3ef09
Each row is a build in a folder of its own, which can change version
(update, go back), so "Your versions" read as a list of releases.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

After the rename: Your instances

The list's heading is now Your instances (6ed6a3e), in all 12 languages. Drawn with tools/screenshots (headless), the same scenes as the earlier after shots; nothing else on these screens changed.

home-row-opened.png

home-row-opened-second.png

home-update.png

home-versions.png

home-go-back.png

home-build-track.png

## After the rename: Your instances The list's heading is now **Your instances** (6ed6a3e), in all 12 languages. Drawn with `tools/screenshots` (headless), the same scenes as the earlier after shots; nothing else on these screens changed. ![home-row-opened.png](https://git.magicbean.dev/attachments/05637e9c-0743-4023-bbbc-665fe2081eda) ![home-row-opened-second.png](https://git.magicbean.dev/attachments/5b6abd3a-271e-4078-bedc-26af61430550) ![home-update.png](https://git.magicbean.dev/attachments/32205311-7525-4d52-9edf-b241aed1ef0b) ![home-versions.png](https://git.magicbean.dev/attachments/bd3e35c0-4dbf-48fe-be22-1030e458504c) ![home-go-back.png](https://git.magicbean.dev/attachments/dfff7e61-6301-45a7-ad3d-a29d8c16679a) ![home-build-track.png](https://git.magicbean.dev/attachments/47fd161c-0606-4a73-a52c-4e0be5ef5377)
dyst force-pushed feat/home-version-picker from 6ed6a3ef09
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
to eca781b139
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
2026-11-17 20:52:59 +00:00
Compare
HumanBean deleted branch feat/home-version-picker 2026-11-17 21:12:13 +00:00
Owner

Review after the merge, posted as a comment: the forge takes no review on a merged pull request.

Verdict: Request changes. On the Release candidate track the button says "Build vX … into a folder of its own" for a stable version the player already has, but it rebuilds their stable build in its own folder and moves it onto the rc track, so a stable player starts getting release candidates as updates. The rework of the first screen every player sees has also not been run in the real window: no Play, Go back or Build from the new button, and no keyboard or controller pass. This PR was merged (1289a75) before this review, so both points need a follow-up before the next stable.

For a player, the home now puts choosing a version, going back and building another track in one place: a Track and a Version dropdown, and one button that plays, updates to, goes back to or builds the version picked. It replaces the clock dialog on each row. On net it is a better home and simpler code (VersionPick replaces OtherVersions and the dialog's view model, with core checks). It costs one case that main's channel picker labelled honestly ("Rebuild vX") and the home now mislabels, below.

Reviewed: eca781b1 against 7a4a61e7 (its fork point on main, after #170): Core/VersionPick.cs, App/ViewModels/HomeViewModel.cs (the diff, plus Go, ShowPick, Select, SetDefault, Deleting and CanStartBuild around it), App/Views/HomeView.axaml, App/LauncherService.cs, tests/launcher_core/VersionPickChecks.cs, tools/screenshots/Program.cs, README.md, the removed VersionPickerViewModel/OtherVersions, plus BuildJob, MainViewModel.StartWizard, BuildStepViewModel.Complete, BuildRegistry.Add and ReleaseManifest.OnChannel, which the new button relies on. I checked the 15 catalogs for every new and removed key and only skimmed their wording. Nothing was run (a code review). I also read main after the merge, where #179 landed on top.
Fixed in this review: nothing (already merged).
Checked and fine:

  • A misclick never starts a build by itself. Update to, Go back to and Build all open the wizard (StartWizard → files step), whose start button says what it will do. The old dialog did the same.
  • Play stays Play. The home opens on the default build's track and version, so the first button is Play with Update beside it, as before. A Refresh (the check answering, the window coming back) keeps the pick while its version is still listed, and installed versions are always listed.
  • The default is kept. A Replace keeps its row through BuildRegistry.Replace, so the default flag stays on that row. Set as default moves the dropdowns to that build, and Remove reuses DeleteViewModel with its confirmation and #176's save handling.
  • No versions or offline: only the installed versions are listed. A track with none shows the "Its versions show once git.magicbean.dev answers." line and no button.
  • While a check, the launcher's update or a leftovers delete runs: Update to, Go back to and Build are off (CanStartBuild, raised in BusyChanged). A build being deleted can't be played or replaced.
  • Several builds on a track: a pick replaces the selected row if it is on that track, else the track's default, else the last built. There are checks for each case and for a selection on another track.
  • Portable launcher (#173): the shortcuts are decided in the Ready step (Shortcuts.MadeAtReady), which this PR doesn't touch, so a portable launcher still makes none unless ticked. New folders still come from BuildsFolder, the portable builds folder.
  • Translations: every new key is in all 12 full catalogs. en-GB, es-419 and fr-CA are overlays and fall back. The removed dialog's keys are gone and nothing still uses them.
  • Nothing left behind: main has no remaining reference to OtherVersions, VersionPickerViewModel, HeroVersion or HeroChannel.
  • The VersionPick checks test behaviour: rc lists the stables but doesn't mark a stable-channel build as installed, dev versions sort last, and a nightly the server dropped is still listed.

Blocking (for the follow-up)

  1. App/ViewModels/HomeViewModel.cs:320 and :381, with Core/VersionPick.cs:63: a version installed on another track is planned as a new build and described as one, but it is started as a Rebuild of that other track's build.

    • The case: a stable player with v3.1.0 (their default) picks Track = Release candidate. OnChannel(rc) lists every release, so its newest is v3.1.0, and ShowPick picks it. Plan only looks at rc builds and finds none, so it returns Build. The button reads "Build v3.1.0" and the line under it says "Nothing on this track yet: it is built into a folder of its own".
    • What happens: Go() finds the stable build by version and starts JobKind.Rebuild with channel rc in the stable folder. When the build completes, BuildRegistry.Add (FindByFolder) sets entry.Channel = "rc". Their default now sits on the rc track, the stable track says "none installed", and Update offers release candidates.
    • Where it shows: any older stable picked on the rc track hits the same path.
    • How main handles it: the channel picker names this "Rebuild vX".
    • A fix: make Plan see a version installed on any track. Either play that build, as it is the same version, or give the case its own action with an honest label. Don't leave it as a Build the App layer quietly turns into a Rebuild. Add a check in VersionPickChecks for it.
  2. Run it in the real window before the stable. risk/high, and the description says only headless screenshots ran and no build was started from the new button. Wanted:

    • one Play;
    • one Go back that completes (the row keeps its id, the default and its folder);
    • one Build on an empty track;
    • Remove;
    • the dropdowns with keyboard only, and on a Steam Deck with a controller.

    Avalonia's ComboBox changes its selection on Up/Down (and, I believe, the mouse wheel) while closed and focused. On the home that turns Play into "Go back to vX" or "Build vX" under the player's thumb. It only opens the wizard, but it needs checking on the Deck. If it happens, consider opening the list on Enter/A only.

Suggestions (the author may take or leave)

  • After Remove (HomeViewModel.cs:857 → Refresh → ShowPick), the pick stays on the removed version. The same button then reads "Go back to vX" (another build on the track) or "Build vX". Putting the pick back on the default after a delete would avoid a second press landing in a wizard for the default.
  • Untested App logic: Go(), ShowPick() and the Build→Rebuild branch live in the App layer, which no check reaches. Moving "which version to pick when the track changes" and "what Go starts" into VersionPick would put them under the core checks.
  • Terminology: the English UI now says "Track" in the hero but "channel" in "{0} is out on the {1} channel." and Change channel. One word for both would read better. The catalogs already use their channel word for TRACK.
  • Dead code: PlayDefaultCommand (HomeViewModel.cs:459) is no longer bound by any view.
  • Unknown track: a default build on no channel (a test build's "dev" with no channel) gives a pickTrack that matches no TrackChoice, so the Track box shows empty. That is probably fine for test builds only.

Testing: the author reports 1547 core checks, 37 release tests and a clean dotnet build, and posted headless screenshots before and after for each scene in the comments. CI's compile-and-test was skipped (manual dispatch). Nothing was run in a real window, no build was started from the new button, and there is no keyboard or controller pass. That is blocking point 2.
Overlaps and merge order: #179 (cold build) merged right after this one, on top of it (8594b47). It touches the wizard, the build step and the problem view, not the home. Its README and tools/screenshots additions merged cleanly beside this PR's, and main has no stale reference, so there is no conflict.

_Review after the merge, posted as a comment: the forge takes no review on a merged pull request._ **Verdict: Request changes.** On the Release candidate track the button says "Build vX … into a folder of its own" for a stable version the player already has, but it rebuilds their stable build in its own folder and moves it onto the rc track, so a stable player starts getting release candidates as updates. The rework of the first screen every player sees has also not been run in the real window: no Play, Go back or Build from the new button, and no keyboard or controller pass. This PR was merged (1289a75) before this review, so both points need a follow-up before the next stable. For a player, the home now puts choosing a version, going back and building another track in one place: a Track and a Version dropdown, and one button that plays, updates to, goes back to or builds the version picked. It replaces the clock dialog on each row. On net it is a better home and simpler code (`VersionPick` replaces `OtherVersions` and the dialog's view model, with core checks). It costs one case that main's channel picker labelled honestly ("Rebuild vX") and the home now mislabels, below. **Reviewed:** eca781b1 against 7a4a61e7 (its fork point on main, after https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/170): `Core/VersionPick.cs`, `App/ViewModels/HomeViewModel.cs` (the diff, plus `Go`, `ShowPick`, `Select`, `SetDefault`, `Deleting` and `CanStartBuild` around it), `App/Views/HomeView.axaml`, `App/LauncherService.cs`, `tests/launcher_core/VersionPickChecks.cs`, `tools/screenshots/Program.cs`, `README.md`, the removed `VersionPickerViewModel`/`OtherVersions`, plus `BuildJob`, `MainViewModel.StartWizard`, `BuildStepViewModel.Complete`, `BuildRegistry.Add` and `ReleaseManifest.OnChannel`, which the new button relies on. I checked the 15 catalogs for every new and removed key and only skimmed their wording. Nothing was run (a code review). I also read main after the merge, where https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/179 landed on top. **Fixed in this review:** nothing (already merged). **Checked and fine:** - **A misclick never starts a build by itself.** Update to, Go back to and Build all open the wizard (`StartWizard` → files step), whose start button says what it will do. The old dialog did the same. - **Play stays Play.** The home opens on the default build's track and version, so the first button is Play with Update beside it, as before. A Refresh (the check answering, the window coming back) keeps the pick while its version is still listed, and installed versions are always listed. - **The default is kept.** A Replace keeps its row through `BuildRegistry.Replace`, so the default flag stays on that row. Set as default moves the dropdowns to that build, and Remove reuses `DeleteViewModel` with its confirmation and https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/176's save handling. - **No versions or offline:** only the installed versions are listed. A track with none shows the "Its versions show once git.magicbean.dev answers." line and no button. - **While a check, the launcher's update or a leftovers delete runs:** Update to, Go back to and Build are off (`CanStartBuild`, raised in `BusyChanged`). A build being deleted can't be played or replaced. - **Several builds on a track:** a pick replaces the selected row if it is on that track, else the track's default, else the last built. There are checks for each case and for a selection on another track. - **Portable launcher (https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/173):** the shortcuts are decided in the Ready step (`Shortcuts.MadeAtReady`), which this PR doesn't touch, so a portable launcher still makes none unless ticked. New folders still come from `BuildsFolder`, the portable builds folder. - **Translations:** every new key is in all 12 full catalogs. en-GB, es-419 and fr-CA are overlays and fall back. The removed dialog's keys are gone and nothing still uses them. - **Nothing left behind:** main has no remaining reference to `OtherVersions`, `VersionPickerViewModel`, `HeroVersion` or `HeroChannel`. - **The `VersionPick` checks test behaviour:** rc lists the stables but doesn't mark a stable-channel build as installed, dev versions sort last, and a nightly the server dropped is still listed. **Blocking** (for the follow-up) 1. `App/ViewModels/HomeViewModel.cs:320` and `:381`, with `Core/VersionPick.cs:63`: a version installed on another track is planned as a new build and described as one, but it is started as a Rebuild of that other track's build. - **The case:** a stable player with v3.1.0 (their default) picks Track = Release candidate. `OnChannel(rc)` lists every release, so its newest is v3.1.0, and `ShowPick` picks it. `Plan` only looks at rc builds and finds none, so it returns `Build`. The button reads "Build v3.1.0" and the line under it says "Nothing on this track yet: it is built into a folder of its own". - **What happens:** `Go()` finds the stable build by version and starts `JobKind.Rebuild` with channel `rc` in the stable folder. When the build completes, `BuildRegistry.Add` (`FindByFolder`) sets `entry.Channel = "rc"`. Their default now sits on the rc track, the stable track says "none installed", and Update offers release candidates. - **Where it shows:** any older stable picked on the rc track hits the same path. - **How main handles it:** the channel picker names this "Rebuild vX". - **A fix:** make `Plan` see a version installed on any track. Either play that build, as it is the same version, or give the case its own action with an honest label. Don't leave it as a Build the App layer quietly turns into a Rebuild. Add a check in `VersionPickChecks` for it. 2. **Run it in the real window before the stable.** risk/high, and the description says only headless screenshots ran and no build was started from the new button. Wanted: - one Play; - one Go back that completes (the row keeps its id, the default and its folder); - one Build on an empty track; - Remove; - the dropdowns with keyboard only, and on a Steam Deck with a controller. Avalonia's ComboBox changes its selection on Up/Down (and, I believe, the mouse wheel) while closed and focused. On the home that turns Play into "Go back to vX" or "Build vX" under the player's thumb. It only opens the wizard, but it needs checking on the Deck. If it happens, consider opening the list on Enter/A only. **Suggestions** (the author may take or leave) - **After Remove** (`HomeViewModel.cs:857` → `Refresh` → `ShowPick`), the pick stays on the removed version. The same button then reads "Go back to vX" (another build on the track) or "Build vX". Putting the pick back on the default after a delete would avoid a second press landing in a wizard for the default. - **Untested App logic:** `Go()`, `ShowPick()` and the Build→Rebuild branch live in the App layer, which no check reaches. Moving "which version to pick when the track changes" and "what Go starts" into `VersionPick` would put them under the core checks. - **Terminology:** the English UI now says "Track" in the hero but "channel" in "{0} is out on the {1} channel." and Change channel. One word for both would read better. The catalogs already use their channel word for TRACK. - **Dead code:** `PlayDefaultCommand` (`HomeViewModel.cs:459`) is no longer bound by any view. - **Unknown track:** a default build on no channel (a test build's "dev" with no channel) gives a `pickTrack` that matches no `TrackChoice`, so the Track box shows empty. That is probably fine for test builds only. **Testing:** the author reports 1547 core checks, 37 release tests and a clean `dotnet build`, and posted headless screenshots before and after for each scene in the comments. CI's compile-and-test was skipped (manual dispatch). Nothing was run in a real window, no build was started from the new button, and there is no keyboard or controller pass. That is blocking point 2. **Overlaps and merge order:** https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/179 (cold build) merged right after this one, on top of it (8594b47). It touches the wizard, the build step and the problem view, not the home. Its README and `tools/screenshots` additions merged cleanly beside this PR's, and main has no stale reference, so there is no conflict.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!180
No description provided.