fix(shortcuts): a portable launcher makes no shortcuts unless ticked, and none takes over another launcher's (#161) #173
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!173
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:fix/portable-no-shortcuts"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #161. A portable launcher made Desktop and Start-menu shortcuts after every build, aimed at whatever its file was called (for the reporter, the setup-named exe on a removable drive), though "Run portable" promises none, and it remade any the player deleted. It could also take over the installed launcher's "Longshot" shortcuts.
What changes
.lnktarget on Windows and the.desktopExec line on Linux to tell.WriteLinuxandWindowsShortcuts.Writenow return the shortcuts they left alone.Testing
Windows 11, .NET SDK 10.0.404.
python -I tests/test_launcher_core.pywith TEMP on its long path: main 1439 checks, this branch 1454. The check commit fails on main withA portable launcher took over the shortcuts another launcher made (#161).; breaking the default ticks failsReady makes the shortcuts as it opens, both ticked, for every launcher but a portable one….dotnet build: 0 warnings.Not tested: a real portable launcher on a removable drive. Not changed: on uninstall,
WindowsShortcuts.RemoveGamestill deletes every "Longshot" shortcut, a portable copy's too.🤖 Generated with Claude Code