feat(saves): a Progress view per slot shows what a save has and is missing, and edits it with a backup first #186

Open
mooki wants to merge 3 commits from mooki/LongshotLauncher:saves-editor into main
Member

Type: feat · Risk: medium · Tested on: Linux (Arch, kernel 7.2.15), .NET SDK 10.0.113, Python 3.14.8: the launcher's core and release tests, a build of the whole solution, and the launcher's code and view models against the real save editor on made-up saves; no Windows PC, no real game or save · Needs: Windows (a real save), and a Longshot release whose tools carry the save editor (MagicBeanDev/Longshot#1401 merged)

TL;DR

Finishing a save, setting one up for a test or fixing a mistake means leaving the launcher for the command line, and the launcher cannot say what a save is missing, because it reads nothing inside one. I added a Progress button to each slot of the Saves page: it shows what the slot has and is missing, by name and area, and makes the usual edits with a backup first, refused while a game runs. It runs Longshot's own save editor from the build's tools (MagicBeanDev/Longshot#1401), so the launcher carries no second copy of its rules. I checked it with the real editor on made-up saves and the launcher's tests; nothing ran on Windows.

Breakdown

  • Who it helps: players who want to finish a save, set one up for a test or repair one, and testers. Today they use Longshot's command line or the game's Debug tools.
  • What was wrong: the launcher reads nothing inside a save. It cannot say what a save has or is missing, and it cannot change anything in one.
  • What changes: each slot of the Saves page gets a Progress button. Its page lists every category with how many the slot has of how many and, for the one picked, its areas and every missing entry by name. Set, Take away, Give, Start place and Copy slot each ask first (what the editor says it would change, where the backup goes), back the whole save folder up, and are refused while a game or an emulator runs. All of it is Longshot's save editor, run with --json from the build's own tools (Core/SaveEditor.cs, SaveEditorAnswer.cs, SaveEditorReport.cs).
  • What does not change: the save files and their format, builds.json, settings, releases, the build; no package; copying, importing and exporting saves still need no Python; nothing runs until a player presses Progress. #55's preview code (SavePreview, SaveProgress, the Home card) is not touched.
  • How it was checked: on the head, three commits on launcher main @ 0e96947: the core tests 1,890 checks passed (main: 1,752; one check that fails on Linux on main itself is skipped in both runs, see How it was tested), the release tests 37 OK, the whole solution builds with 0 warnings and 0 errors, and the editor's real answers equal the fixtures the launcher is tested on. The launcher's code and its Progress view models were driven against the real editor on a made-up game and made-up saves (36 checks), and the nine screenshots below were drawn headless and looked at.
  • What is still open: MagicBeanDev/Longshot#1401 must merge and a release must carry the editor; a run on Windows; a real game and save; the AppImage's own Python (3.12); translations (120 new texts, English only); where Progress sits once #55 and #183 change the slot row (Overlaps, Questions).
  • Risk: medium. An edit writes a player's save, but only through the editor, after a confirmation, with the whole save folder backed up first, refused while a game runs, and put back if the write or its read-back fails. The editor's rules (what a "set" writes and what it leaves) are the main risk, and they are the editor's, in its guide.

Why

Players who finish a save, set one up for a test or put right something that went wrong can only do it from Longshot's command line or the game's Debug tools, and the launcher cannot even say what a save is missing because it reads nothing inside one. I added a Progress button to each slot of the Saves page that shows what the slot has and is missing, by name and area, and makes the usual edits, with a backup first and refused while a game runs. It does that by running Longshot's own offline save editor from the build's tools, not by carrying a second copy of the editor's rules: what a save can hold, and where, needs the game's own lists (names, chests, Gold Skulltulas, dungeons, quests), which only the editor reads.

Depends on MagicBeanDev/Longshot#1401, builds on #55

Depends on MagicBeanDev/Longshot#1401, the pull request that adds scripts/longshot_save_editor.py, its guide and its tests. It was open and mergeable on 17 Nov 2026 with head 6c45402bf, which is the editor I tested against. I need it with --json on every command, schema 1, and its reason codes, as that head has them. Merge it first. This change only works for a build made from a Longshot release that carries the script in its tools (the builders copy scripts/, so a release after the merge has it). Until then every version shows Progress switched off with the reason "This version has no save editor yet", and nothing else changes.

Builds on #55 (Anarkkie, player profiles and progress previews, open, head 5d9e9d1). #55 gives each player a save of their own and a read-only picture of what it holds: slot pictures, a save card on Home, a grouped list of the items. As I read its code it cannot say what is missing (SaveProgress reads the table of values and not the key table at the end of progress.sav, where chests, Gold Skulltulas, heart pieces and bosses are), and it never edits ("Previews are read-only"). This is the other half: what is missing, by name and area, and the edits. I opened it on main, not on #55's branch (the forge opens a pull request onto main only, and #55 is large and still under review), so it works alone. After #55 the editor follows the selected player with one line, and its button sits in #55's slot detail; both are in Overlaps below. This pull request does not touch #55's preview code.

What changed

  • Core/SaveEditor.cs, Core/SaveEditorReport.cs, Core/SaveEditorAnswer.cs (new, 556 lines): run the editor the way PerfReports runs perf_report.py: the default build's own version's pinned Python, isolated (-I -B), in the game's environment, with the build's game folder (romfs holds the lists the editor reads), the save folder the Saves page lists, and the launcher's own backup folder. Every command is run with --json and its answer read (the editor's guide, "For programs": schema, command, ok): the report into records, the item and place lists, and each edit's lines, files, backup and read-back. A refusal is ok: false with a reason code (SaveFailure.Code). For a game running, NX2navi waiting, a link, a backup folder inside the save, a failed write, a file that could not be read or written, game files or zstd the editor cannot use, another game version, a damaged file, a slot that is gone, a copy over a slot, the same slot and an area that needs Link's age, the launcher says it in its own words. For the rest (a count the game does not allow, the bag to give first, a name that fits two items, an unknown target or place) and for any code a newer editor adds, the editor's own words stay, because they hold what only it knows. An answer with a newer schema than 1 says the launcher is older. A build with no save, no build, no game files, no tools, or tools from before the editor gets a reason instead. A slot is always passed as slot_NN: the Saves page counts from 1 (slot_00 is Slot 1), and the editor's 3 would mean slot_03.
  • Every edit is refused before the editor is started while a game or an emulator runs (Saves.Running, which leaves the launcher itself out). The editor checks again, backs the whole save folder up first, writes each file whole beside its place, reads it back and puts it back if that fails. The launcher never passes --force.
  • App/ViewModels/SaveEditorViewModel.cs, SaveEditDialogs.cs, App/Views/SaveEditorView.axaml, SaveEditAskView.axaml, SaveEditConfirmView.axaml (new): the slot's page (place, hearts, rupees, the game's clock, a percentage that never says 100 while one thing is missing; every category with how many the slot has of how many; for the picked one its areas with every missing entry by name; Set all, Take all away, Set and Take away per area, Set per entry, Give…, Start place…, Copy slot…) and two dialogs. Give takes an item (counted ones an amount, within what the bags Link has hold), hearts, rupees or a dungeon's small keys. Start place takes one of the game's named places and, where the area has both, Link's age. Copy slot takes another slot or the next free one. Every edit is confirmed first with what the editor says it would change (its own --dry-run, which writes nothing), where the backup goes, and that the game must be closed; the page reads the files again after it.
  • App/ViewModels/SavesViewModel.cs, App/Views/SavesView.axaml, App/LauncherService.cs: a Progress button on each slot row (off, with the reason in its tooltip and a line under the list, when there is no editor or the slot has no progress.sav); SaveFolder() is now the one place the Saves page and the editor take the save folder from. Core/Saves.cs: SaveFailure gets the editor's reason code (Code), nothing else of it changes.
  • tests/launcher_core/SaveEditorChecks.cs, tests/fixtures/save-editor/*, tests/save_editor_fixtures.py, tests/test_launcher_core.py: see How it was tested. The fixtures are the editor's real JSON on the made-up game and made-up saves of Longshot's own tests, kept as text; the launcher's repository holds no save and no game file.
  • docs/saves.md, README.md, tools/screenshots/*: the guide's "Progress and edits", the README paragraph, and nine screenshot scenes drawn from a report authored with invented names (tools/screenshots/save-editor-report.json).
  • Size: 42 files, +6,386 / -13. Of those lines 3,983 are JSON (the editor's real answers kept as fixtures, and the authored report for the scenes), 1,728 are in Core/ and App/, and 619 are tests and tools.

What it does not do:

  • It does not read the game or a save itself, and it does not know a rule of the editor's. What counts as 100%, what a "set" writes and what it leaves (a boss set done is not a boss fight won, a heart piece set does not raise the hearts, items are not equipped) are the editor's, in its guide.
  • It edits the default build's save and game files only: with builds of different game versions it does not choose, and a slot of another game version is shown with the editor's warning and its edits are off (edit it with the build that wrote it).
  • Names are the editor's default text (USen, then EUen), whatever the game's language setting is; mapping language.txt to the editor's --language belongs in the editor.
  • New texts are in English only: 120 of them, so each catalog lacks 185 of 819 instead of 65 of 699 (main today). A translation pull request follows.

How it was tested

Environment. Linux (Arch), kernel 7.2.15, .NET SDK 10.0.113 (the repository pins 10.0.404; I changed global.json in my own copy only and did not commit it), Python 3.14.8 (it runs the editor and the fixture check), 17 Nov 2026. Head saves-editor @ e68a815 (three commits) on launcher main @ 0e96947. The editor is the head of MagicBeanDev/Longshot#1401, 6c45402bf. Headless: no window, no display, no GPU, no game. A made-up game and made-up saves in temporary folders only; no real game file or save was read. The PC was busy with other jobs (load average between about 30 and 170 while these ran), so every test, build and throwaway-program run waited for and ran in the idle priority class through the workbench's test gate (https://github.com/mooki000/ls-workbench, its harness folder), which only changes how long it waits.

Step by step:

  1. The rebase, twice. I wrote the three commits on launcher main @ f31b555. Main moved 16 commits and I rebased onto 7a4a61e (two conflicts, both kept on both sides: tests/test_launcher_core.py, my new check_save_editor beside #118's two new checks, and tools/screenshots/Program.cs, my nine scenes and their helpers next to #168's three saves-confirm-* scenes and theirs). While I was checking that head, main moved again (#171, #179, #180 and #181 merged), so I rebased once more onto 0e96947: the first two commits applied by themselves, and the docs commit conflicted in three places, again kept on both sides: README.md (the Saves row now names the .zip of #181 and Progress), docs/saves.md (the Tests list holds #181's SaveArchiveChecks.cs bullet and this branch's SaveEditorChecks.cs bullet) and tools/screenshots/Program.cs (#181's scene helpers, then this branch's). git range-diff of the three commits against the ones on 7a4a61e shows only context differences. The merged hunks of App/LauncherService.cs, App/ViewModels/SavesViewModel.cs and Core/Saves.cs are in different places from main's changes (#166, #168, #175, #176, #181). #164's privacy rule (LauncherLog.Add and BugReport.Make scrub the user's name) already covers the page's log line and its "Copy for a bug report", which go through them; #169 changed Saves.Running, which the edit's refusal calls, and its tests pass here. Every check below was run on the final head (e68a815); the first-rebase head d4acbce passed the same ones with 1,763 and 1,625 checks.
  2. The core tests, python -I -B tests/test_launcher_core.py --dotnet dotnet (it builds tests/launcher_core, which compiles Core/, and runs the checks on fixtures and scratch folders): 1,890 checks passed on the head, and the same again with --longshot at a git archive snapshot of the editor's head, with the contract check running. The same runner on main @ 0e96947 passes 1,752, so this branch adds 138 checks, all in SaveEditorChecks.cs. They parse the editor's real report and check every category and area of it, the damaged slot, the lists, each edit's answer and every refusal with its code (the editor's own words kept for a hearts count over the game's, a bag that is not there and an unknown target; the launcher's words for a copy over a slot, a running game with the games named, another game version, a damaged file, a slot that is gone, a write that failed after the backup with the files put back, and every other code it says itself), a newer schema, a wrong command's answer, an ok answer from a command that exited 1, an answer that is not JSON, argparse's and Python's own last lines, the command the launcher builds (arguments, environment, UTF-8, no window, no --force), which build gets which reason, the plans (a slot is slot_NN, nothing that could read as an option), the refusal while a game runs (the editor is never started), and the real process code over a stand-in for the tools' Python (arguments with spaces and non-ASCII reach it as they are, its output is read as UTF-8, its error: line and exit code become the refusal).
    • One failure that is main's. On plain main the check at tests/launcher_core/BuildReportChecks.cs:70 ("The home folder taken out before a line is cut: no cut leaves part of the user's name") fails on Linux and stops the whole run there, so no later check runs: I got the same failure at the same line on main and on the head (on 7a4a61e, which I ran unpatched, and the line is unchanged on 0e96947). It looks like a Windows-only expectation in #164. The check puts 290 x characters before the home folder, and on Linux the home folder is replaced by ~ only where a path starts, not after other characters, so the line keeps the home folder's path with <user> in place of the name, cut at 300 (it ends <use), where the check expects it to end ~/x.bars. The 1,890 and 1,752 above are from scratch copies of the head and of main in which I made that one check Windows-only and print the line's end instead (the same local change in both; it is not in the branch). I did not touch it here; it is #164's.
  3. The release tests, python -I -B tests/test_release.py: 37 tests OK on the head and on main.
  4. The contract check. tests/save_editor_fixtures.py --longshot <checkout> runs the editor on the made-up game and made-up saves that Longshot's own tests build and fails when its answer differs from tests/fixtures/save-editor. At the editor's head it passes. To see it fail as it should, I renamed one reason code in a copy of the fixtures (damaged to damaged_file): exit 1, "tests/fixtures/save-editor/error-damaged.json is not what Longshot's save editor prints now: the interface the launcher reads changed", with how to regenerate it. Against the Longshot commit that tests/longshot.ref pins it says the checkout has no scripts/longshot_save_editor.py and skips, so the pinned CI run skips it until the pin moves to a commit that has the editor. The editor's two scripts at 6c45402bf are byte for byte the ones the fixtures were made from (687244f5d).
  5. The launcher's code against the real editor, end to end. A throwaway console program (not in the branch) compiles Core/ and drives SaveEditing through the real process runner, with a small Python wrapper that answers only the editor's running-game check "none" (other jobs were running games on this PC; the editor refuses every edit there otherwise, which is the safety working). The made-up game and saves come from the editor's own test helpers (make_game, make_save_folder): slots 1, 2 and 4 and a damaged slot 3 (slot_02, 22 bytes). It printed: the report of four slots (three with 38 missing, one "slot_02/progress.sav is 22 bytes: not a save file"); 12 items with the dungeon's small keys and the hearts range 1 to 5; 5 places with their ages (one that cannot be loaded); a dry run (set skulltulas/TestArea: 2 of 2 changed, no backup); the refusal while a game runs (Running, code running, no process started); a real edit with the files written (slot_00/progress.sav, slot_00/caption.sav) and a backup of the whole save folder (account.sav, option.sav and every slot); the same edit again (nothing to change, no second backup); the editor's refusals with their codes (damaged, out_of_range, needs_bag, would_overwrite, unknown_target); give, start and copy into a new slot; and the report after each.
  6. The view models over the real editor. A second throwaway program (a headless Avalonia driver, not in the branch: the launcher has no UI test project on main) pushes the buttons, on a made-up game and a save of slots 1, 2 and 4: the Saves page lists the three slots with Progress on each; the page loads slot 1 and picks the first category with something missing (Equipment, one thing); the Gold Skulltulas show two areas, each with its missing ones by name; an area's Set asks first (the editor's dry run, Apply on), is refused while a game runs (said once, nothing written, Apply stays), then applies with one backup of the whole save and the page reads again in the same category; Clear and Cancel write nothing and make no backup; Give: the items come from the editor, hearts "ten" is asked again with what the game gives, 10 is the editor's own refusal in its words with Apply off, 5 is fine; a counted item asks for a number; bombs with no bag say which bag to give first; the Hookshot is given; small keys list the report's dungeons; Start place lists the places the game can load, asks Link's age only for an area both ages have, and Link is in the new place after; Copy slot lists the other slots and the next free one, copies to a new slot and over an existing one (said as a replace); one entry's Set; a damaged slot shows the launcher's words and the editor's reason ("slot_03/progress.sav is 10 bytes: not a save file") with every edit off; Back. 36 checks passed, the same 36 as before the rebase.
  7. The build. dotnet build LongshotLauncher.slnx --configuration Release --no-incremental: 0 warnings, 0 errors on the head (13 s), and no package added (the one project file this branch touches is the screenshots tool's, which copies its report JSON next to it). The repository's CI form, with -p:RestoreLockedMode=true, does not run on this PC: restore stops with four NU1004 errors (App/ and Core/: "The package references have changed for net10.0" and "The project's runtime identifiers have changed"), because the lock files were made with SDK 10.0.404 and this one is 10.0.113. Main @ 0e96947 stops with the same four, so it says nothing about this branch, which changes no lock file (the same four on the head before the first rebase). The plain build rewrites the two packages.lock.json files; I built in scratch copies, so none is in the branch.
  8. Translations. python -I scripts/translations.py prints no placeholder fault, only that each catalog lacks texts (the head: 185 of 819, es 183; main: 65 of 699, es 63), so it exits 1 on both; the 120 extra are this change's English-only texts. The core tests print the same as advice and do not fail on it.
  9. The screenshots below: dotnet run --project tools/screenshots -c Release -- <folder> saves-progress saves-progress-off save-editor save-editor-skulltulas save-editor-confirm save-editor-running save-editor-give save-editor-start save-editor-failed, headless at 960 x 600, drawn again on the final head. Nothing is run to draw them: the report behind them is authored with invented names and numbers, and the editor's answers are the few lines of text an edit says. Three of the nine are pixel for pixel the ones I drew on the first rebase; the two Saves pages differ in about 4,400 pixels (#181 added ".zip" to two descriptions on that page and the clock follows the time), and the other four in a few hundred pixels at most. I looked at every one of the nine.
  10. Overlaps. I read the 13 open launcher pull requests' file lists (pulls/N/files), fetched the heads of those that share a file with this branch and trial-merged each (git merge-tree --write-tree) against main and against this branch; a conflict that appears only with this branch is an overlap. The result and the hunks are under Overlaps.

Rebased from main f31b555 onto 0e96947; head e68a815. Patch: five hand-merged hunks over the two rebases (above), nothing else. Carried: nothing; every check above was rerun on the final head. Windows: not run. Game: not run, there is none involved.

To rerun it: python -I -B tests/test_launcher_core.py --dotnet dotnet --longshot <a checkout of MagicBeanDev/Longshot#1401's head> and python -I -B tests/test_release.py from the repository (the first stops at the BuildReportChecks.cs:70 failure on Linux, on main too), dotnet build LongshotLauncher.slnx --configuration Release, python -I scripts/translations.py, and the screenshots command above. I can attach the two throwaway programs if a reviewer wants to run them.

Not tested:

  • Windows: the editor itself is not tested there yet (MagicBeanDev/Longshot#1401 says so), and nothing of this page ran on Windows. The launcher's own part (the process, CreateNoWindow, the environment, paths) follows PerfReports, which ships.
  • The Linux AppImage's own Python (3.12 with zstandard): only this PC's Python 3.14 ran the editor.
  • A real game and a real save: how long the editor takes to read the real game's lists is unmeasured (the page reads in the background and says so; one run is capped at 3 minutes).
  • mise run ci:smoke: not run, the tools it pins (dotnet 10.0.404, shellcheck, gitleaks, pre-commit) are not installed here. Its build step was run directly (above); its lint covers scripts/package.sh and secrets, and its release tests scripts/release.py, none of which this change touches. The repository's own locked restore (-p:RestoreLockedMode=true) cannot run on this SDK. CircleCI has not run on this branch.
  • Several builds of different game versions, a portable launcher's backup folder, and a Steam Deck.

Must be tested:

  • Windows, once Longshot's editor is merged and a build's tools carry it: Saves > Progress on a slot of a real save, set one Gold Skulltula, check the backup folder (%LOCALAPPDATA%\Longshot\oot-save-backups\edit-<player>-<date>-<time>) and that the game loads the slot; start the game and try an edit (it must be refused, nothing written). Someone with a Windows PC and a real save: me by hand, or any Windows tester.
  • A Linux AppImage build with the editor in its tools (its Python 3.12): the same, by hand.

Screenshots

Launcher screenshots only (CONTRIBUTING: no game files, no saves). The report behind them is authored with invented names and numbers.

Saves: every slot has a Progress button (Slot 1 to 3, with when each was saved); the build's tools have the save editor.
The same page for a version whose tools have no save editor yet: the buttons are greyed out and the line under the list says why ("This version has no save editor yet. A newer version has it.").
A slot's progress: the place, hearts, rupees, the game's clock and when it was saved; "60%: 349 missing" with a bar and whose game files it was read from; the categories with have of total (Equipment is picked: two things missing, by name, each with Set); Give…, Start place…, Copy slot… and Back to saves.
A category with areas (Gold Skulltulas): each area with how many the slot has of how many and, for an area that is not complete, every missing one by name and where, with Set per entry and Set or Take away per area.
Setting one area asks first: what the editor says it would change and the files it would write (from its own dry run), where the whole-save backup goes, and that the game must be closed.
The same edit while a game runs: refused before anything is written, said once in its own box, the lines of what it would change kept, and Make the edit still there to try again once the game is closed.
Give: what to give (an item, hearts, rupees or a dungeon's small keys) and, for an item, which one, from the editor's list (a sword here). A counted item such as bombs also asks for an amount; that is not drawn.
Start place: one of the game's named places, from the editor. Link's age is asked only for an area both ages have; this place is one age's, so no age is asked.
The editor could not read the slot (a damaged file here): the launcher's words for the editor's damaged code and the editor's reason, Try again, Copy for a bug report; Give…, Start place… and Copy slot… are greyed out.

Risk and rollback

What could break: Nothing runs until a player presses Progress. The Saves page's slot rows change (a button added; SaveSlots() now takes its folder from the new SaveFolder(), the same folder as before). An edit writes a save, but only through the editor, after the confirmation, with the whole save backed up first, refused while a game runs, and put back if the write or the read-back fails. The editor's own rules are the main risk: a "set" writes what the game's lists name and nothing more, which the page's guide section says. A slot of another game version, a damaged file and a save folder holding a link are refused by the editor and shown in its words.

Turning it off: revert the pull request: the Saves page is as before, and every backup an edit made stays in the backup folder (edit-<player>-<date>-<time>; $XDG_DATA_HOME/longshot/save-backup on Linux, %LOCALAPPDATA%\Longshot\oot-save-backups on Windows) with the saves it kept.

Compatibility: no change to the save files' format, builds.json, settings, releases or the build; no package. The launcher still needs no Python for copying, importing or exporting saves; Python is used only by Progress, from the build's own tools, and in the optional --longshot contract check.

Overlaps

I read the open launcher pull requests' file lists on 17 Nov 2026 (13 of them at first, 11 later, after main moved), fetched the heads of the ones that share a file with this branch, and trial-merged each against main (now 0e96947) and against this branch (git merge-tree --write-tree --name-only), then read the hunks. #181 (export to one .zip), #179, #180 and #171 merged while I worked. #181 conflicted with this branch in README.md, docs/saves.md and the screenshot scenes; I resolved those in the second rebase, keeping both sides (the README's Saves row now names the .zip and Progress; both test bullets are in the guide; both groups of scene helpers are in the tool). Of the open ones, only #55, #182, #183 (with #184 and #185) and #49 conflict with this branch in a file where they do not already conflict with main.

  • #55 (player profiles and progress previews, Anarkkie; head 5d9e9d1, still on an older main, c5e27ee, so it already conflicts with main today in the same files as with this branch: App/LauncherService.cs, App/ViewModels/SavesViewModel.cs, App/Views/SavesView.axaml, docs/saves.md, README.md, the test dispatcher and others). The hunks that are this branch's, read against the first rebase: App/LauncherService.cs (1: #55's SaveSlots() with ProfileProblem against this branch's SaveFolder() and SaveEditor()), App/ViewModels/SavesViewModel.cs (1: where the slot list is built), App/Views/SavesView.axaml (2: the slot row, and the line under the list), docs/saves.md (1: the Tests list), README.md and the test dispatcher. The resolution I would make: after #55, SaveFolder() returns ProfileProblem == null ? SaveProfilePath : null, so the editor edits the selected player's save and nothing else changes, and the Progress button goes into the slot detail that #55 adds (its slot list is a selectable list with a detail, not rows). Whoever merges second rebases these.
  • #182, #183 (dyst: restore from a backup, and one slot at a time; #183 is marked WIP and stacked on #182; both were force-pushed since I first read them, heads 7c78639 and be68020), and #184, #185 (rename instances' folders; Open saves folder and Open builds folder buttons), whose conflict lists with main and with this branch are the same as #182's and #183's, so I take them to be stacked on that series (not checked further). They already conflict with main in SavesViewModel.cs, the Lang catalogs, README.md, docs/saves.md, the test dispatcher and the screenshot scenes (their base is older than #181), and with this branch also in App/MainWindow.axaml, App/Views/Views.cs (one template line and one view line each) and App/Views/SavesView.axaml (the slot row, and the line under the list). In substance two things need a decision: #183 makes each slot row selectable with its own actions (Export, Copy to another slot, Delete) under the selected row, where this branch puts a Progress button at the right of the row; and #183's "Copy to another slot…" does what this branch's "Copy slot…" does (through the editor's copy, which copies a slot's progress.sav and caption.sav). Also, #182 lists the backups folder by name (<command>-<name>-<stamp>) and an edit's backup here is edit-<player id>-<stamp>: reading its code, it would list it with the kind "Other" and could restore it (the backup is a whole save folder). I did not run that.
  • #49 (an NFC page): only App/MainWindow.axaml (one template line) is new with this branch; README.md, HomeView.axaml and MakeGameCommand.cs conflict with main already.
  • #151, #130, #59, #50, #42: not trial-merged again after main moved. At the first look (against 7a4a61e) #59 merged cleanly with this branch, and #151, #130, #50 and #42 conflicted with it only in the files where they conflicted with main already.
  • The fix for MagicBeanDev/Longshot#639 (fix/saves-shared-link, head 8670cb0 on main 7a4a61e: a build started on its own reads the shared saves through a link): it merges cleanly with this branch (also after the second rebase). It shares Core/Saves.cs, App/LauncherService.cs, README.md and docs/saves.md with it, but in other places: it adds LinkSaves and its checks to Core/Saves.cs, and a line to PlayFolder() and to GatherSaves(), while this branch adds a Code to SaveFailure and SaveFolder() and SaveEditor() at the end of LauncherService. The link it makes is in a build's own folder (user\save), not in the shared save folder the editor edits, which the editor does not read.

Questions for you

  1. #183's "Copy to another slot…" and this branch's "Copy slot…" do the same thing. Should the editor's Copy go (it is one more way to the same result), or should both stay (the editor's keeps one flow with a backup in the Progress page)? I would drop mine if #183 lands.
  2. Once #55 or #183 makes the slot rows selectable, should Progress be one of the actions under the selected slot, or stay a button on the row? I would put it under the selected slot, next to Export and Copy.
  3. May this land with the 120 new texts in English only and a translation pull request after, as #55's do? The catalogs then lack 175 of 792 instead of 55 of 672.

AI-assisted: I wrote this with Claude Sonnet 5.5; the commits carry its trailers.

New on this forge; not opened on GitHub.

**Type:** feat · **Risk:** medium · **Tested on:** Linux (Arch, kernel 7.2.15), .NET SDK 10.0.113, Python 3.14.8: the launcher's core and release tests, a build of the whole solution, and the launcher's code and view models against the real save editor on made-up saves; no Windows PC, no real game or save · **Needs:** Windows (a real save), and a Longshot release whose tools carry the save editor (MagicBeanDev/Longshot#1401 merged) ## TL;DR Finishing a save, setting one up for a test or fixing a mistake means leaving the launcher for the command line, and the launcher cannot say what a save is missing, because it reads nothing inside one. I added a Progress button to each slot of the Saves page: it shows what the slot has and is missing, by name and area, and makes the usual edits with a backup first, refused while a game runs. It runs Longshot's own save editor from the build's tools (MagicBeanDev/Longshot#1401), so the launcher carries no second copy of its rules. I checked it with the real editor on made-up saves and the launcher's tests; nothing ran on Windows. ## Breakdown - **Who it helps:** players who want to finish a save, set one up for a test or repair one, and testers. Today they use Longshot's command line or the game's Debug tools. - **What was wrong:** the launcher reads nothing inside a save. It cannot say what a save has or is missing, and it cannot change anything in one. - **What changes:** each slot of the Saves page gets a **Progress** button. Its page lists every category with how many the slot has of how many and, for the one picked, its areas and every missing entry by name. Set, Take away, Give, Start place and Copy slot each ask first (what the editor says it would change, where the backup goes), back the whole save folder up, and are refused while a game or an emulator runs. All of it is Longshot's save editor, run with `--json` from the build's own tools (`Core/SaveEditor.cs`, `SaveEditorAnswer.cs`, `SaveEditorReport.cs`). - **What does not change:** the save files and their format, `builds.json`, settings, releases, the build; no package; copying, importing and exporting saves still need no Python; nothing runs until a player presses Progress. #55's preview code (`SavePreview`, `SaveProgress`, the Home card) is not touched. - **How it was checked:** on the head, three commits on launcher main @ 0e96947: the core tests 1,890 checks passed (main: 1,752; one check that fails on Linux on main itself is skipped in both runs, see How it was tested), the release tests 37 OK, the whole solution builds with 0 warnings and 0 errors, and the editor's real answers equal the fixtures the launcher is tested on. The launcher's code and its Progress view models were driven against the real editor on a made-up game and made-up saves (36 checks), and the nine screenshots below were drawn headless and looked at. - **What is still open:** MagicBeanDev/Longshot#1401 must merge and a release must carry the editor; a run on Windows; a real game and save; the AppImage's own Python (3.12); translations (120 new texts, English only); where Progress sits once #55 and #183 change the slot row (Overlaps, Questions). - **Risk:** medium. An edit writes a player's save, but only through the editor, after a confirmation, with the whole save folder backed up first, refused while a game runs, and put back if the write or its read-back fails. The editor's rules (what a "set" writes and what it leaves) are the main risk, and they are the editor's, in its guide. ## Why Players who finish a save, set one up for a test or put right something that went wrong can only do it from Longshot's command line or the game's Debug tools, and the launcher cannot even say what a save is missing because it reads nothing inside one. I added a **Progress** button to each slot of the Saves page that shows what the slot has and is missing, by name and area, and makes the usual edits, with a backup first and refused while a game runs. It does that by running Longshot's own offline save editor from the build's tools, not by carrying a second copy of the editor's rules: what a save can hold, and where, needs the game's own lists (names, chests, Gold Skulltulas, dungeons, quests), which only the editor reads. ## Depends on MagicBeanDev/Longshot#1401, builds on #55 **Depends on [MagicBeanDev/Longshot#1401](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1401)**, the pull request that adds `scripts/longshot_save_editor.py`, its guide and its tests. It was open and mergeable on 17 Nov 2026 with head `6c45402bf`, which is the editor I tested against. I need it with `--json` on every command, schema 1, and its reason codes, as that head has them. Merge it first. This change only works for a build made from a Longshot release that carries the script in its tools (the builders copy `scripts/`, so a release after the merge has it). Until then every version shows Progress switched off with the reason "This version has no save editor yet", and nothing else changes. **Builds on [#55](https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/55)** (Anarkkie, player profiles and progress previews, open, head `5d9e9d1`). #55 gives each player a save of their own and a read-only picture of what it holds: slot pictures, a save card on Home, a grouped list of the items. As I read its code it cannot say what is *missing* (`SaveProgress` reads the table of values and not the key table at the end of `progress.sav`, where chests, Gold Skulltulas, heart pieces and bosses are), and it never edits ("Previews are read-only"). This is the other half: what is missing, by name and area, and the edits. I opened it on main, not on #55's branch (the forge opens a pull request onto main only, and #55 is large and still under review), so it works alone. After #55 the editor follows the selected player with one line, and its button sits in #55's slot detail; both are in Overlaps below. This pull request does not touch #55's preview code. ## What changed - `Core/SaveEditor.cs`, `Core/SaveEditorReport.cs`, `Core/SaveEditorAnswer.cs` (new, 556 lines): run the editor the way `PerfReports` runs `perf_report.py`: the default build's own version's pinned Python, isolated (`-I -B`), in the game's environment, with the build's game folder (`romfs` holds the lists the editor reads), the save folder the Saves page lists, and the launcher's own backup folder. Every command is run with `--json` and its answer read (the editor's guide, "For programs": `schema`, `command`, `ok`): the report into records, the item and place lists, and each edit's lines, files, backup and read-back. A refusal is `ok: false` with a reason code (`SaveFailure.Code`). For a game running, NX2navi waiting, a link, a backup folder inside the save, a failed write, a file that could not be read or written, game files or zstd the editor cannot use, another game version, a damaged file, a slot that is gone, a copy over a slot, the same slot and an area that needs Link's age, the launcher says it in its own words. For the rest (a count the game does not allow, the bag to give first, a name that fits two items, an unknown target or place) and for any code a newer editor adds, the editor's own words stay, because they hold what only it knows. An answer with a newer `schema` than 1 says the launcher is older. A build with no save, no build, no game files, no tools, or tools from before the editor gets a reason instead. A slot is always passed as `slot_NN`: the Saves page counts from 1 (`slot_00` is Slot 1), and the editor's `3` would mean `slot_03`. - Every edit is refused before the editor is started while a game or an emulator runs (`Saves.Running`, which leaves the launcher itself out). The editor checks again, backs the whole save folder up first, writes each file whole beside its place, reads it back and puts it back if that fails. The launcher never passes `--force`. - `App/ViewModels/SaveEditorViewModel.cs`, `SaveEditDialogs.cs`, `App/Views/SaveEditorView.axaml`, `SaveEditAskView.axaml`, `SaveEditConfirmView.axaml` (new): the slot's page (place, hearts, rupees, the game's clock, a percentage that never says 100 while one thing is missing; every category with how many the slot has of how many; for the picked one its areas with every missing entry by name; Set all, Take all away, Set and Take away per area, Set per entry, Give…, Start place…, Copy slot…) and two dialogs. Give takes an item (counted ones an amount, within what the bags Link has hold), hearts, rupees or a dungeon's small keys. Start place takes one of the game's named places and, where the area has both, Link's age. Copy slot takes another slot or the next free one. Every edit is confirmed first with what the editor says it would change (its own `--dry-run`, which writes nothing), where the backup goes, and that the game must be closed; the page reads the files again after it. - `App/ViewModels/SavesViewModel.cs`, `App/Views/SavesView.axaml`, `App/LauncherService.cs`: a Progress button on each slot row (off, with the reason in its tooltip and a line under the list, when there is no editor or the slot has no `progress.sav`); `SaveFolder()` is now the one place the Saves page and the editor take the save folder from. `Core/Saves.cs`: `SaveFailure` gets the editor's reason code (`Code`), nothing else of it changes. - `tests/launcher_core/SaveEditorChecks.cs`, `tests/fixtures/save-editor/*`, `tests/save_editor_fixtures.py`, `tests/test_launcher_core.py`: see How it was tested. The fixtures are the editor's real JSON on the made-up game and made-up saves of Longshot's own tests, kept as text; the launcher's repository holds no save and no game file. - `docs/saves.md`, `README.md`, `tools/screenshots/*`: the guide's "Progress and edits", the README paragraph, and nine screenshot scenes drawn from a report authored with invented names (`tools/screenshots/save-editor-report.json`). - Size: 42 files, +6,386 / -13. Of those lines 3,983 are JSON (the editor's real answers kept as fixtures, and the authored report for the scenes), 1,728 are in `Core/` and `App/`, and 619 are tests and tools. What it does not do: - It does not read the game or a save itself, and it does not know a rule of the editor's. What counts as 100%, what a "set" writes and what it leaves (a boss set done is not a boss fight won, a heart piece set does not raise the hearts, items are not equipped) are the editor's, in its guide. - It edits the default build's save and game files only: with builds of different game versions it does not choose, and a slot of another game version is shown with the editor's warning and its edits are off (edit it with the build that wrote it). - Names are the editor's default text (USen, then EUen), whatever the game's language setting is; mapping `language.txt` to the editor's `--language` belongs in the editor. - New texts are in English only: 120 of them, so each catalog lacks 185 of 819 instead of 65 of 699 (main today). A translation pull request follows. ## How it was tested **Environment.** Linux (Arch), kernel 7.2.15, .NET SDK 10.0.113 (the repository pins 10.0.404; I changed `global.json` in my own copy only and did not commit it), Python 3.14.8 (it runs the editor and the fixture check), 17 Nov 2026. Head `saves-editor` @ `e68a815` (three commits) on launcher main @ `0e96947`. The editor is the head of MagicBeanDev/Longshot#1401, `6c45402bf`. Headless: no window, no display, no GPU, no game. A made-up game and made-up saves in temporary folders only; no real game file or save was read. The PC was busy with other jobs (load average between about 30 and 170 while these ran), so every test, build and throwaway-program run waited for and ran in the idle priority class through the workbench's test gate (https://github.com/mooki000/ls-workbench, its harness folder), which only changes how long it waits. **Step by step:** 1. **The rebase, twice.** I wrote the three commits on launcher main @ `f31b555`. Main moved 16 commits and I rebased onto `7a4a61e` (two conflicts, both kept on both sides: `tests/test_launcher_core.py`, my new `check_save_editor` beside #118's two new checks, and `tools/screenshots/Program.cs`, my nine scenes and their helpers next to #168's three `saves-confirm-*` scenes and theirs). While I was checking that head, main moved again (#171, #179, #180 and #181 merged), so I rebased once more onto `0e96947`: the first two commits applied by themselves, and the docs commit conflicted in three places, again kept on both sides: `README.md` (the Saves row now names the .zip of #181 and Progress), `docs/saves.md` (the Tests list holds #181's `SaveArchiveChecks.cs` bullet and this branch's `SaveEditorChecks.cs` bullet) and `tools/screenshots/Program.cs` (#181's scene helpers, then this branch's). `git range-diff` of the three commits against the ones on `7a4a61e` shows only context differences. The merged hunks of `App/LauncherService.cs`, `App/ViewModels/SavesViewModel.cs` and `Core/Saves.cs` are in different places from main's changes (#166, #168, #175, #176, #181). #164's privacy rule (`LauncherLog.Add` and `BugReport.Make` scrub the user's name) already covers the page's log line and its "Copy for a bug report", which go through them; #169 changed `Saves.Running`, which the edit's refusal calls, and its tests pass here. Every check below was run on the final head (`e68a815`); the first-rebase head `d4acbce` passed the same ones with 1,763 and 1,625 checks. 2. **The core tests**, `python -I -B tests/test_launcher_core.py --dotnet dotnet` (it builds `tests/launcher_core`, which compiles `Core/`, and runs the checks on fixtures and scratch folders): **1,890 checks passed** on the head, and the same again with `--longshot` at a `git archive` snapshot of the editor's head, with the contract check running. The same runner on main @ `0e96947` passes **1,752**, so this branch adds 138 checks, all in `SaveEditorChecks.cs`. They parse the editor's real report and check every category and area of it, the damaged slot, the lists, each edit's answer and every refusal with its code (the editor's own words kept for a hearts count over the game's, a bag that is not there and an unknown target; the launcher's words for a copy over a slot, a running game with the games named, another game version, a damaged file, a slot that is gone, a write that failed after the backup with the files put back, and every other code it says itself), a newer schema, a wrong command's answer, an `ok` answer from a command that exited 1, an answer that is not JSON, argparse's and Python's own last lines, the command the launcher builds (arguments, environment, UTF-8, no window, no `--force`), which build gets which reason, the plans (a slot is `slot_NN`, nothing that could read as an option), the refusal while a game runs (the editor is never started), and the real process code over a stand-in for the tools' Python (arguments with spaces and non-ASCII reach it as they are, its output is read as UTF-8, its `error:` line and exit code become the refusal). - **One failure that is main's.** On plain main the check at `tests/launcher_core/BuildReportChecks.cs:70` ("The home folder taken out before a line is cut: no cut leaves part of the user's name") fails on Linux and stops the whole run there, so no later check runs: I got the same failure at the same line on main and on the head (on `7a4a61e`, which I ran unpatched, and the line is unchanged on `0e96947`). It looks like a Windows-only expectation in #164. The check puts 290 `x` characters before the home folder, and on Linux the home folder is replaced by `~` only where a path starts, not after other characters, so the line keeps the home folder's path with `<user>` in place of the name, cut at 300 (it ends `<use`), where the check expects it to end `~/x.bars`. The 1,890 and 1,752 above are from scratch copies of the head and of main in which I made that one check Windows-only and print the line's end instead (the same local change in both; it is not in the branch). I did not touch it here; it is #164's. 3. **The release tests**, `python -I -B tests/test_release.py`: 37 tests OK on the head and on main. 4. **The contract check.** `tests/save_editor_fixtures.py --longshot <checkout>` runs the editor on the made-up game and made-up saves that Longshot's own tests build and fails when its answer differs from `tests/fixtures/save-editor`. At the editor's head it passes. To see it fail as it should, I renamed one reason code in a copy of the fixtures (`damaged` to `damaged_file`): exit 1, "tests/fixtures/save-editor/error-damaged.json is not what Longshot's save editor prints now: the interface the launcher reads changed", with how to regenerate it. Against the Longshot commit that `tests/longshot.ref` pins it says the checkout has no `scripts/longshot_save_editor.py` and skips, so the pinned CI run skips it until the pin moves to a commit that has the editor. The editor's two scripts at `6c45402bf` are byte for byte the ones the fixtures were made from (`687244f5d`). 5. **The launcher's code against the real editor, end to end.** A throwaway console program (not in the branch) compiles `Core/` and drives `SaveEditing` through the real process runner, with a small Python wrapper that answers only the editor's running-game check "none" (other jobs were running games on this PC; the editor refuses every edit there otherwise, which is the safety working). The made-up game and saves come from the editor's own test helpers (`make_game`, `make_save_folder`): slots 1, 2 and 4 and a damaged slot 3 (`slot_02`, 22 bytes). It printed: the report of four slots (three with 38 missing, one "slot_02/progress.sav is 22 bytes: not a save file"); 12 items with the dungeon's small keys and the hearts range 1 to 5; 5 places with their ages (one that cannot be loaded); a dry run (`set skulltulas/TestArea: 2 of 2 changed`, no backup); the refusal while a game runs (`Running`, code `running`, no process started); a real edit with the files written (`slot_00/progress.sav`, `slot_00/caption.sav`) and a backup of the whole save folder (`account.sav`, `option.sav` and every slot); the same edit again (nothing to change, no second backup); the editor's refusals with their codes (`damaged`, `out_of_range`, `needs_bag`, `would_overwrite`, `unknown_target`); give, start and copy into a new slot; and the report after each. 6. **The view models over the real editor.** A second throwaway program (a headless Avalonia driver, not in the branch: the launcher has no UI test project on main) pushes the buttons, on a made-up game and a save of slots 1, 2 and 4: the Saves page lists the three slots with Progress on each; the page loads slot 1 and picks the first category with something missing (Equipment, one thing); the Gold Skulltulas show two areas, each with its missing ones by name; an area's Set asks first (the editor's dry run, Apply on), is refused while a game runs (said once, nothing written, Apply stays), then applies with one backup of the whole save and the page reads again in the same category; Clear and Cancel write nothing and make no backup; Give: the items come from the editor, hearts "ten" is asked again with what the game gives, 10 is the editor's own refusal in its words with Apply off, 5 is fine; a counted item asks for a number; bombs with no bag say which bag to give first; the Hookshot is given; small keys list the report's dungeons; Start place lists the places the game can load, asks Link's age only for an area both ages have, and Link is in the new place after; Copy slot lists the other slots and the next free one, copies to a new slot and over an existing one (said as a replace); one entry's Set; a damaged slot shows the launcher's words and the editor's reason ("slot_03/progress.sav is 10 bytes: not a save file") with every edit off; Back. **36 checks passed**, the same 36 as before the rebase. 7. **The build.** `dotnet build LongshotLauncher.slnx --configuration Release --no-incremental`: **0 warnings, 0 errors** on the head (13 s), and no package added (the one project file this branch touches is the screenshots tool's, which copies its report JSON next to it). The repository's CI form, with `-p:RestoreLockedMode=true`, does not run on this PC: restore stops with four NU1004 errors (`App/` and `Core/`: "The package references have changed for net10.0" and "The project's runtime identifiers have changed"), because the lock files were made with SDK 10.0.404 and this one is 10.0.113. Main @ `0e96947` stops with the same four, so it says nothing about this branch, which changes no lock file (the same four on the head before the first rebase). The plain build rewrites the two `packages.lock.json` files; I built in scratch copies, so none is in the branch. 8. **Translations.** `python -I scripts/translations.py` prints no placeholder fault, only that each catalog lacks texts (the head: 185 of 819, `es` 183; main: 65 of 699, `es` 63), so it exits 1 on both; the 120 extra are this change's English-only texts. The core tests print the same as advice and do not fail on it. 9. **The screenshots** below: `dotnet run --project tools/screenshots -c Release -- <folder> saves-progress saves-progress-off save-editor save-editor-skulltulas save-editor-confirm save-editor-running save-editor-give save-editor-start save-editor-failed`, headless at 960 x 600, drawn again on the final head. Nothing is run to draw them: the report behind them is authored with invented names and numbers, and the editor's answers are the few lines of text an edit says. Three of the nine are pixel for pixel the ones I drew on the first rebase; the two Saves pages differ in about 4,400 pixels (#181 added ".zip" to two descriptions on that page and the clock follows the time), and the other four in a few hundred pixels at most. I looked at every one of the nine. 10. **Overlaps.** I read the 13 open launcher pull requests' file lists (`pulls/N/files`), fetched the heads of those that share a file with this branch and trial-merged each (`git merge-tree --write-tree`) against main and against this branch; a conflict that appears only with this branch is an overlap. The result and the hunks are under Overlaps. **Rebased from main `f31b555` onto `0e96947`; head `e68a815`.** Patch: five hand-merged hunks over the two rebases (above), nothing else. Carried: nothing; every check above was rerun on the final head. Windows: not run. Game: not run, there is none involved. **To rerun it:** `python -I -B tests/test_launcher_core.py --dotnet dotnet --longshot <a checkout of MagicBeanDev/Longshot#1401's head>` and `python -I -B tests/test_release.py` from the repository (the first stops at the `BuildReportChecks.cs:70` failure on Linux, on main too), `dotnet build LongshotLauncher.slnx --configuration Release`, `python -I scripts/translations.py`, and the screenshots command above. I can attach the two throwaway programs if a reviewer wants to run them. **Not tested:** - Windows: the editor itself is not tested there yet (MagicBeanDev/Longshot#1401 says so), and nothing of this page ran on Windows. The launcher's own part (the process, `CreateNoWindow`, the environment, paths) follows `PerfReports`, which ships. - The Linux AppImage's own Python (3.12 with `zstandard`): only this PC's Python 3.14 ran the editor. - A real game and a real save: how long the editor takes to read the real game's lists is unmeasured (the page reads in the background and says so; one run is capped at 3 minutes). - `mise run ci:smoke`: not run, the tools it pins (dotnet 10.0.404, shellcheck, gitleaks, pre-commit) are not installed here. Its build step was run directly (above); its lint covers `scripts/package.sh` and secrets, and its release tests `scripts/release.py`, none of which this change touches. The repository's own locked restore (`-p:RestoreLockedMode=true`) cannot run on this SDK. CircleCI has not run on this branch. - Several builds of different game versions, a portable launcher's backup folder, and a Steam Deck. **Must be tested:** - Windows, once Longshot's editor is merged and a build's tools carry it: Saves > Progress on a slot of a real save, set one Gold Skulltula, check the backup folder (`%LOCALAPPDATA%\Longshot\oot-save-backups\edit-<player>-<date>-<time>`) and that the game loads the slot; start the game and try an edit (it must be refused, nothing written). Someone with a Windows PC and a real save: me by hand, or any Windows tester. - A Linux AppImage build with the editor in its tools (its Python 3.12): the same, by hand. ## Screenshots Launcher screenshots only (CONTRIBUTING: no game files, no saves). The report behind them is authored with invented names and numbers. ![Saves: every slot has a Progress button (Slot 1 to 3, with when each was saved); the build's tools have the save editor.](https://git.magicbean.dev/attachments/c853bce1-8c6a-435d-bf07-179a7ebbdf98) ![The same page for a version whose tools have no save editor yet: the buttons are greyed out and the line under the list says why ("This version has no save editor yet. A newer version has it.").](https://git.magicbean.dev/attachments/519aca37-bafc-406c-b595-236fd716397f) ![A slot's progress: the place, hearts, rupees, the game's clock and when it was saved; "60%: 349 missing" with a bar and whose game files it was read from; the categories with have of total (Equipment is picked: two things missing, by name, each with Set); Give…, Start place…, Copy slot… and Back to saves.](https://git.magicbean.dev/attachments/8cab4bd4-d914-4365-93d7-c043add043e1) ![A category with areas (Gold Skulltulas): each area with how many the slot has of how many and, for an area that is not complete, every missing one by name and where, with Set per entry and Set or Take away per area.](https://git.magicbean.dev/attachments/ba8fdeb7-2027-49a3-98e1-e6002b2635f0) ![Setting one area asks first: what the editor says it would change and the files it would write (from its own dry run), where the whole-save backup goes, and that the game must be closed.](https://git.magicbean.dev/attachments/5e7ddc41-a4a3-43a5-a7e2-60362e582e3a) ![The same edit while a game runs: refused before anything is written, said once in its own box, the lines of what it would change kept, and Make the edit still there to try again once the game is closed.](https://git.magicbean.dev/attachments/84bfc347-a197-45d1-8c99-40c49e12758b) ![Give: what to give (an item, hearts, rupees or a dungeon's small keys) and, for an item, which one, from the editor's list (a sword here). A counted item such as bombs also asks for an amount; that is not drawn.](https://git.magicbean.dev/attachments/b0837f95-d05e-4bf7-b3a0-5c8679958c63) ![Start place: one of the game's named places, from the editor. Link's age is asked only for an area both ages have; this place is one age's, so no age is asked.](https://git.magicbean.dev/attachments/5a531603-ae77-4401-9c03-f31df3aae0ba) ![The editor could not read the slot (a damaged file here): the launcher's words for the editor's `damaged` code and the editor's reason, Try again, Copy for a bug report; Give…, Start place… and Copy slot… are greyed out.](https://git.magicbean.dev/attachments/47512968-1263-4a71-8254-6788c446a983) ## Risk and rollback **What could break:** Nothing runs until a player presses Progress. The Saves page's slot rows change (a button added; `SaveSlots()` now takes its folder from the new `SaveFolder()`, the same folder as before). An edit writes a save, but only through the editor, after the confirmation, with the whole save backed up first, refused while a game runs, and put back if the write or the read-back fails. The editor's own rules are the main risk: a "set" writes what the game's lists name and nothing more, which the page's guide section says. A slot of another game version, a damaged file and a save folder holding a link are refused by the editor and shown in its words. **Turning it off:** revert the pull request: the Saves page is as before, and every backup an edit made stays in the backup folder (`edit-<player>-<date>-<time>`; `$XDG_DATA_HOME/longshot/save-backup` on Linux, `%LOCALAPPDATA%\Longshot\oot-save-backups` on Windows) with the saves it kept. **Compatibility:** no change to the save files' format, `builds.json`, settings, releases or the build; no package. The launcher still needs no Python for copying, importing or exporting saves; Python is used only by Progress, from the build's own tools, and in the optional `--longshot` contract check. ## Overlaps I read the open launcher pull requests' file lists on 17 Nov 2026 (13 of them at first, 11 later, after main moved), fetched the heads of the ones that share a file with this branch, and trial-merged each against main (now `0e96947`) and against this branch (`git merge-tree --write-tree --name-only`), then read the hunks. #181 (export to one .zip), #179, #180 and #171 merged while I worked. #181 conflicted with this branch in `README.md`, `docs/saves.md` and the screenshot scenes; I resolved those in the second rebase, keeping both sides (the README's Saves row now names the .zip and Progress; both test bullets are in the guide; both groups of scene helpers are in the tool). Of the open ones, only #55, #182, #183 (with #184 and #185) and #49 conflict with this branch in a file where they do not already conflict with main. - **#55** (player profiles and progress previews, Anarkkie; head `5d9e9d1`, still on an older main, `c5e27ee`, so it already conflicts with main today in the same files as with this branch: `App/LauncherService.cs`, `App/ViewModels/SavesViewModel.cs`, `App/Views/SavesView.axaml`, `docs/saves.md`, `README.md`, the test dispatcher and others). The hunks that are this branch's, read against the first rebase: `App/LauncherService.cs` (1: #55's `SaveSlots()` with `ProfileProblem` against this branch's `SaveFolder()` and `SaveEditor()`), `App/ViewModels/SavesViewModel.cs` (1: where the slot list is built), `App/Views/SavesView.axaml` (2: the slot row, and the line under the list), `docs/saves.md` (1: the Tests list), `README.md` and the test dispatcher. The resolution I would make: after #55, `SaveFolder()` returns `ProfileProblem == null ? SaveProfilePath : null`, so the editor edits the selected player's save and nothing else changes, and the Progress button goes into the slot detail that #55 adds (its slot list is a selectable list with a detail, not rows). Whoever merges second rebases these. - **#182, #183** (dyst: restore from a backup, and one slot at a time; #183 is marked WIP and stacked on #182; both were force-pushed since I first read them, heads `7c78639` and `be68020`), and **#184, #185** (rename instances' folders; Open saves folder and Open builds folder buttons), whose conflict lists with main and with this branch are the same as #182's and #183's, so I take them to be stacked on that series (not checked further). They already conflict with main in `SavesViewModel.cs`, the Lang catalogs, `README.md`, `docs/saves.md`, the test dispatcher and the screenshot scenes (their base is older than #181), and with this branch also in `App/MainWindow.axaml`, `App/Views/Views.cs` (one template line and one view line each) and `App/Views/SavesView.axaml` (the slot row, and the line under the list). In substance two things need a decision: #183 makes each slot row selectable with its own actions (Export, Copy to another slot, Delete) under the selected row, where this branch puts a Progress button at the right of the row; and #183's "Copy to another slot…" does what this branch's "Copy slot…" does (through the editor's `copy`, which copies a slot's `progress.sav` and `caption.sav`). Also, #182 lists the backups folder by name (`<command>-<name>-<stamp>`) and an edit's backup here is `edit-<player id>-<stamp>`: reading its code, it would list it with the kind "Other" and could restore it (the backup is a whole save folder). I did not run that. - **#49** (an NFC page): only `App/MainWindow.axaml` (one template line) is new with this branch; `README.md`, `HomeView.axaml` and `MakeGameCommand.cs` conflict with main already. - **#151, #130, #59, #50, #42:** not trial-merged again after main moved. At the first look (against `7a4a61e`) #59 merged cleanly with this branch, and #151, #130, #50 and #42 conflicted with it only in the files where they conflicted with main already. - **The fix for MagicBeanDev/Longshot#639** (`fix/saves-shared-link`, head `8670cb0` on main `7a4a61e`: a build started on its own reads the shared saves through a link): it merges cleanly with this branch (also after the second rebase). It shares `Core/Saves.cs`, `App/LauncherService.cs`, `README.md` and `docs/saves.md` with it, but in other places: it adds `LinkSaves` and its checks to `Core/Saves.cs`, and a line to `PlayFolder()` and to `GatherSaves()`, while this branch adds a `Code` to `SaveFailure` and `SaveFolder()` and `SaveEditor()` at the end of `LauncherService`. The link it makes is in a build's own folder (`user\save`), not in the shared save folder the editor edits, which the editor does not read. ## Questions for you 1. #183's "Copy to another slot…" and this branch's "Copy slot…" do the same thing. Should the editor's Copy go (it is one more way to the same result), or should both stay (the editor's keeps one flow with a backup in the Progress page)? I would drop mine if #183 lands. 2. Once #55 or #183 makes the slot rows selectable, should Progress be one of the actions under the selected slot, or stay a button on the row? I would put it under the selected slot, next to Export and Copy. 3. May this land with the 120 new texts in English only and a translation pull request after, as #55's do? The catalogs then lack 175 of 792 instead of 55 of 672. AI-assisted: I wrote this with Claude Sonnet 5.5; the commits carry its trailers. New on this forge; not opened on GitHub.
The launcher reads nothing inside a save, so it cannot say what a save is missing or change it. Longshot's offline save
editor (scripts/longshot_save_editor.py) already does both from the player's own game files. This runs it the way PerfReports
runs perf_report.py: the default build's own version's Python, isolated, with the build's game folder, the save folder and the
launcher's backup folder, always with --json, and reads its answers (its guide, "For programs"): the report, the lists give and
start take, and each edit's lines, files, backup and read-back (Core/SaveEditor.cs, SaveEditorReport.cs, SaveEditorAnswer.cs). No
second implementation of the editor's rules.

A refusal comes with the editor's reason code (SaveFailure.Code). The codes the launcher can say better (a game running, NX2navi
waiting, a link, a failed write, another game version, a damaged file and a few more) get the launcher's own words; every other
code, and any code of a newer editor, shows the editor's own words, which hold what only it knows (the most hearts, the bag to
give first). An answer with a newer schema than the launcher reads says the launcher is older.

Edits are refused here while a game or an emulator runs, before the tool is run (the tool checks again and is never given
--force), and a slot is always passed as slot_NN, never a number the page and the tool count differently. A build with no editor
in its tools, no game files, or no save says why instead.

tests/fixtures/save-editor is the editor's real JSON on the made-up game and made-up saves of Longshot's own tests;
tests/save_editor_fixtures.py, run by test_launcher_core.py --longshot, fails when the editor answers something else.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
A player finishing a save, setting one up for a test, or putting right something that went wrong had to leave the launcher for
the command line. Each slot of the Saves page now has a Progress button. Its page lists every category with how many the slot
has of how many, and for the one picked its areas and every missing entry by name; Set all, Set and Take away work on a
category, an area or one entry, and Give, Start place and Copy slot ask what they need (the items, the dungeons with small
keys, the most hearts and the places come from the editor; Link's age is asked only for an area both ages have). Each edit is
confirmed first with what the editor says it would change (its own --dry-run) and the files it would write, where the
whole-save backup goes, and that the game must be closed; it stays refused, with nothing written, while a game runs. The page
reads again after every edit.

It is off, with the reason beside the slots, for a version whose tools have no save editor yet, a build with no game files in its
folder, and a slot of another game version or a damaged file (the editor's reason is shown).

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
docs(saves): the Progress view in the saves guide and README, with its screenshot scenes
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 2s
e68a8150c6
Describes what the Progress view needs (a build whose tools have the editor, and its game files), what it shows, each edit, and
the safety of every one, and says where its tests are. Nine screenshot scenes draw the Saves page with Progress on and off, the
slot's progress, a category with areas, an edit's confirmation, the refusal while a game runs, the Give and Start place
questions and a failure; they use a report authored with invented names and answers in the editor's JSON, and nothing is run.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 2s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'saves-editor:mooki-saves-editor'
git switch 'mooki-saves-editor'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!186
No description provided.