fix(saves): say whose game settings a transfer keeps, and hide the tick when there are none #168

Merged
HumanBean merged 1 commit from riqmarmes/LongshotLauncher:fix/saves-confirm-settings-wording into main 2026-11-17 20:31:48 +00:00
Contributor

Why. On the Saves confirm screen the game-settings tick never says which side's settings survive, and its line says the wrong thing in one state:

  • "Keep 's game settings (option.sav)" can be read as keeping them from Longshot;
  • the line under it, "Camera, text speed and the game's other options stay as they are there.", shows whether the tick is on or off — so with the tick off it claims the settings stay while the source's are the ones that replace them;
  • with the tick on, "Replaced in …" only stops listing option.sav; it never says the folder's own settings are kept;
  • when the destination has no option.sav at all (an emulator folder whose game never wrote one, or a Longshot with no save yet when importing), the tick is still offered, but ticking it writes no option.sav: the copy leaves the game on its built-in defaults while the label promises to keep its settings. #167 has the report, with the current behaviour measured through Saves.Copy.

What changed.

  • App/ViewModels/SavesViewModel.cs — the label is one string, "Keep {0}'s own game settings (option.sav)" (the import-only variant is gone), the hint is a bound KeepHint that says which side wins ("Camera, text speed and other game options from Longshot replace them." / "Its camera, text speed and other game options stay as they are."), the ticked Replaced line says the settings stay ("Replaced in Lichii: 3 slots, saved today 11:41 and its account.sav. Its game settings (option.sav) stay as they are."), and the tick is not shown at all when the destination holds no option.sav (KeepVisible), so the default — the source's settings are copied — applies.
  • App/Views/SavesConfirmView.axaml — the hint under the tick binds KeepHint (and wraps); the tick's visibility binds KeepVisible.
  • Core/Lang/*.json — all 13 catalogs (12 languages plus es-419): the old keys replaced in place, the two new ones next to the tick's text, placeholders kept. The updater refuses to write unless a no-op rewrite is byte-identical, so the diffs are 8 lines each and nothing is reformatted.
  • tools/screenshots/Program.cs — the three saves-confirm-* scenes with authored, fake saves (tick off, tick on, destination with no option.sav).

Semantics are unchanged: the tick still means "keep the destination's own settings"; only a destination with no settings changes, where the tick is hidden and the source's settings are copied instead of silently omitted.

Screenshots. Posted in the comment below: tick off, tick on, and the destination with no game settings (tick not shown).

Testing.

  • dotnet build LongshotLauncher.slnx: 0 warnings, 0 errors.
  • python -I tests/test_launcher_core.py: 1440 checks passed (the same as main; the Core test harness cannot reach the App view models, so this screen is covered by the scenes, the translations check and review).
  • python -I scripts/translations.py: no fault and no leftover key (the 30 texts each catalog lacks are pre-existing on main).
  • The three scenes render through tools/screenshots.
  • Not tested: Linux (the change is text plus one visibility binding; the styles are shared), and no real save was used — the scenes make their own fake ones, as CONTRIBUTING asks.

Risks. Ticking still has exactly the effect it had; the default (unticked) still copies the source's settings, so nothing changes for a destination that has its own. What changes is a destination with no option.sav: no tick, and Longshot's settings are written (before, the only way to "keep" was to tick and end up with none). No save format, longshot_options.ini, cache, vk ABI or builder-tool change.

Compatibility with #166. Both branches are based on main @ 676e300 and share App/ViewModels/SavesViewModel.cs, but in different hunks (Replaced/label/tick vs the Saves.Locate call in Refresh). git merge-tree --write-tree on the two branches merges cleanly (exit 0), so whichever lands second rebases without conflicts.

Fixes #167

**Why.** On the Saves confirm screen the game-settings tick never says which side's settings survive, and its line says the wrong thing in one state: - "Keep *<destination>*'s game settings (option.sav)" can be read as keeping them *from* Longshot; - the line under it, "Camera, text speed and the game's other options stay as they are there.", shows whether the tick is on or off — so with the tick **off** it claims the settings stay while the source's are the ones that replace them; - with the tick **on**, "Replaced in …" only stops listing `option.sav`; it never says the folder's own settings are kept; - when the destination has no `option.sav` at all (an emulator folder whose game never wrote one, or a Longshot with no save yet when importing), the tick is still offered, but ticking it writes no `option.sav`: the copy leaves the game on its built-in defaults while the label promises to keep its settings. #167 has the report, with the current behaviour measured through `Saves.Copy`. **What changed.** - **`App/ViewModels/SavesViewModel.cs`** — the label is one string, "Keep {0}'s own game settings (option.sav)" (the import-only variant is gone), the hint is a bound `KeepHint` that says which side wins ("Camera, text speed and other game options from Longshot replace them." / "Its camera, text speed and other game options stay as they are."), the ticked `Replaced` line says the settings stay ("Replaced in Lichii: 3 slots, saved today 11:41 and its account.sav. Its game settings (option.sav) stay as they are."), and the tick is not shown at all when the destination holds no `option.sav` (`KeepVisible`), so the default — the source's settings are copied — applies. - **`App/Views/SavesConfirmView.axaml`** — the hint under the tick binds `KeepHint` (and wraps); the tick's visibility binds `KeepVisible`. - **`Core/Lang/*.json`** — all 13 catalogs (12 languages plus es-419): the old keys replaced in place, the two new ones next to the tick's text, placeholders kept. The updater refuses to write unless a no-op rewrite is byte-identical, so the diffs are 8 lines each and nothing is reformatted. - **`tools/screenshots/Program.cs`** — the three `saves-confirm-*` scenes with authored, fake saves (tick off, tick on, destination with no `option.sav`). Semantics are unchanged: the tick still means "keep the destination's own settings"; only a destination with no settings changes, where the tick is hidden and the source's settings are copied instead of silently omitted. **Screenshots.** Posted in the comment below: tick off, tick on, and the destination with no game settings (tick not shown). **Testing.** - `dotnet build LongshotLauncher.slnx`: 0 warnings, 0 errors. - `python -I tests/test_launcher_core.py`: 1440 checks passed (the same as `main`; the Core test harness cannot reach the App view models, so this screen is covered by the scenes, the translations check and review). - `python -I scripts/translations.py`: no fault and no leftover key (the 30 texts each catalog lacks are pre-existing on `main`). - The three scenes render through `tools/screenshots`. - Not tested: Linux (the change is text plus one visibility binding; the styles are shared), and no real save was used — the scenes make their own fake ones, as CONTRIBUTING asks. **Risks.** Ticking still has exactly the effect it had; the default (unticked) still copies the source's settings, so nothing changes for a destination that has its own. What changes is a destination with no `option.sav`: no tick, and Longshot's settings are written (before, the only way to "keep" was to tick and end up with none). No save format, `longshot_options.ini`, cache, vk ABI or builder-tool change. **Compatibility with #166.** Both branches are based on `main` @ `676e300` and share `App/ViewModels/SavesViewModel.cs`, but in different hunks (`Replaced`/label/tick vs the `Saves.Locate` call in `Refresh`). `git merge-tree --write-tree` on the two branches merges cleanly (exit 0), so whichever lands second rebases without conflicts. Fixes #167
fix(saves): say whose game settings a transfer keeps, and hide the tick when there are none
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Compile and test (pull_request) Blocked by required conditions
759b482d99
The confirm screen's tick read "Keep {folder}'s game settings (option.sav)" without
saying whose settings survive, and the line under it said "stay as they are there"
even when the tick was off (when the source's settings replace them). With the tick
on, the "Replaced in ..." line only stopped listing option.sav; it never said the
folder's own settings are the ones kept. A destination with no option.sav at all
(an emulator folder whose game never wrote one, a Longshot with no save yet on
import) still offered the tick, and ticking it wrote no option.sav, leaving the game
on its built-in defaults while the label promised to keep its settings.

The label is now "Keep {0}'s own game settings (option.sav)", the hint under it says
which side wins (the source's replace them, or the destination's stay as they are),
the checked "Replaced in ..." line says the game settings stay, and the tick is not
shown when the destination holds no option.sav, so the source's settings are copied.

All 13 catalogs are updated in place, and tools/screenshots gains the three scenes
the changed screen needs.

Tests: dotnet build LongshotLauncher.slnx (0 warnings, 0 errors);
python -I tests/test_launcher_core.py (1440 checks passed, the same as main);
scripts/translations.py reports no fault and no leftover key (the 30 texts each
catalog lacks are pre-existing on main); the three scenes render.

Assisted-by: DeepSeek Harness
Author
Contributor

Screenshots, drawn by tools/screenshots from authored fake saves (Windows, 960×600), one per state of the tick and of the destination:

Tick off: the folder's game settings are replaced
Tick on: the folder keeps its own option.sav
The folder has no option.sav: the tick is not shown

Screenshots, drawn by `tools/screenshots` from authored fake saves (Windows, 960×600), one per state of the tick and of the destination: ![Tick off: the folder's game settings are replaced](https://git.magicbean.dev/attachments/e43c7d73-6355-4e60-adcc-86f803dec630) ![Tick on: the folder keeps its own option.sav](https://git.magicbean.dev/attachments/a7e39e39-32e1-4415-ada5-38dc97537dad) ![The folder has no option.sav: the tick is not shown](https://git.magicbean.dev/attachments/74580ffe-150d-4f7d-9dda-56714a87da43)
HumanBean deleted branch fix/saves-confirm-settings-wording 2026-11-17 20:31:49 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Compile and test (pull_request) Blocked by required conditions
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!168
No description provided.