fix(saves): say whose game settings a transfer keeps, and hide the tick when there are none #168
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!168
Loading…
Reference in a new issue
No description provided.
Delete branch "riqmarmes/LongshotLauncher:fix/saves-confirm-settings-wording"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why. On the Saves confirm screen the game-settings tick never says which side's settings survive, and its line says the wrong thing in one state:
option.sav; it never says the folder's own settings are kept;option.savat all (an emulator folder whose game never wrote one, or a Longshot with no save yet when importing), the tick is still offered, but ticking it writes nooption.sav: the copy leaves the game on its built-in defaults while the label promises to keep its settings. #167 has the report, with the current behaviour measured throughSaves.Copy.What changed.
App/ViewModels/SavesViewModel.cs— the label is one string, "Keep {0}'s own game settings (option.sav)" (the import-only variant is gone), the hint is a boundKeepHintthat says which side wins ("Camera, text speed and other game options from Longshot replace them." / "Its camera, text speed and other game options stay as they are."), the tickedReplacedline says the settings stay ("Replaced in Lichii: 3 slots, saved today 11:41 and its account.sav. Its game settings (option.sav) stay as they are."), and the tick is not shown at all when the destination holds nooption.sav(KeepVisible), so the default — the source's settings are copied — applies.App/Views/SavesConfirmView.axaml— the hint under the tick bindsKeepHint(and wraps); the tick's visibility bindsKeepVisible.Core/Lang/*.json— all 13 catalogs (12 languages plus es-419): the old keys replaced in place, the two new ones next to the tick's text, placeholders kept. The updater refuses to write unless a no-op rewrite is byte-identical, so the diffs are 8 lines each and nothing is reformatted.tools/screenshots/Program.cs— the threesaves-confirm-*scenes with authored, fake saves (tick off, tick on, destination with nooption.sav).Semantics are unchanged: the tick still means "keep the destination's own settings"; only a destination with no settings changes, where the tick is hidden and the source's settings are copied instead of silently omitted.
Screenshots. Posted in the comment below: tick off, tick on, and the destination with no game settings (tick not shown).
Testing.
dotnet build LongshotLauncher.slnx: 0 warnings, 0 errors.python -I tests/test_launcher_core.py: 1440 checks passed (the same asmain; the Core test harness cannot reach the App view models, so this screen is covered by the scenes, the translations check and review).python -I scripts/translations.py: no fault and no leftover key (the 30 texts each catalog lacks are pre-existing onmain).tools/screenshots.Risks. Ticking still has exactly the effect it had; the default (unticked) still copies the source's settings, so nothing changes for a destination that has its own. What changes is a destination with no
option.sav: no tick, and Longshot's settings are written (before, the only way to "keep" was to tick and end up with none). No save format,longshot_options.ini, cache, vk ABI or builder-tool change.Compatibility with #166. Both branches are based on
main@676e300and shareApp/ViewModels/SavesViewModel.cs, but in different hunks (Replaced/label/tick vs theSaves.Locatecall inRefresh).git merge-tree --write-treeon the two branches merges cleanly (exit 0), so whichever lands second rebases without conflicts.Fixes #167
The confirm screen's tick read "Keep {folder}'s game settings (option.sav)" without saying whose settings survive, and the line under it said "stay as they are there" even when the tick was off (when the source's settings replace them). With the tick on, the "Replaced in ..." line only stopped listing option.sav; it never said the folder's own settings are the ones kept. A destination with no option.sav at all (an emulator folder whose game never wrote one, a Longshot with no save yet on import) still offered the tick, and ticking it wrote no option.sav, leaving the game on its built-in defaults while the label promised to keep its settings. The label is now "Keep {0}'s own game settings (option.sav)", the hint under it says which side wins (the source's replace them, or the destination's stay as they are), the checked "Replaced in ..." line says the game settings stay, and the tick is not shown when the destination holds no option.sav, so the source's settings are copied. All 13 catalogs are updated in place, and tools/screenshots gains the three scenes the changed screen needs. Tests: dotnet build LongshotLauncher.slnx (0 warnings, 0 errors); python -I tests/test_launcher_core.py (1440 checks passed, the same as main); scripts/translations.py reports no fault and no leftover key (the 30 texts each catalog lacks are pre-existing on main); the three scenes render. Assisted-by: DeepSeek HarnessScreenshots, drawn by
tools/screenshotsfrom authored fake saves (Windows, 960×600), one per state of the tick and of the destination: