Saves confirm: the game-settings tick does not say whose settings are kept, and is offered when there are none #167
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher#167
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happened?
On the Saves confirm screen the game-settings tick never says which side's settings survive, and its text is wrong in one of its two states:
option.sav; it never says the folder's own settings are kept.option.savat all (an emulator folder whose game never wrote one, or a Longshot with no save yet when importing), the tick is still offered — but ticking it writes nooption.sav, so that copy leaves the game on its built-in defaults while the label promises to keep its settings.Launcher version
v1.0.0-rc.10 (
676e300e), installed, Windows 11 (10.0.22631).Steps / frequency
option.sav, the tick is still shown; ticking it exports nooption.sav.Every copy.
What I expected
The label and the line under it to say whose settings are kept in each state, the "Replaced in …" line to say the settings stay when they do, and no tick when there are no settings in the destination to keep (the source's are copied, as the unticked state does).
Where it comes from
SavesConfirmViewModel(App/ViewModels/SavesViewModel.cs) setsKeepLabel,Replacedand an unconditional hint inApp/Views/SavesConfirmView.axaml;Saves.Copydropsoption.savfrom the files it writes whenkeepSettingsis set (Core/Saves.cs), so a destination without one ends with none.A pull request follows: the label, hint and "Replaced in …" line say what is kept or replaced, and the tick is hidden when the destination holds no
option.sav.Possibly related, for context: