Saves confirm: the game-settings tick does not say whose settings are kept, and is offered when there are none #167

Closed
opened 2026-11-17 09:51:20 +00:00 by riqmarmes · 1 comment
Contributor

What happened?

On the Saves confirm screen the game-settings tick never says which side's settings survive, and its text is wrong in one of its two states:

  • "Keep 's game settings (option.sav)" can be read as keeping them from Longshot, not as "don't replace the ones there".
  • The line under it, "Camera, text speed and the game's other options stay as they are there.", is shown whether the tick is on or off — so it also says the settings stay when the tick is off, i.e. when Longshot's settings are the ones that replace them.
  • With the tick on, the "Replaced in …" line only stops listing option.sav; it never says the folder's own settings are kept.
  • When the destination has no option.sav at all (an emulator folder whose game never wrote one, or a Longshot with no save yet when importing), the tick is still offered — but ticking it writes no option.sav, so that copy leaves the game on its built-in defaults while the label promises to keep its settings.

Launcher version

v1.0.0-rc.10 (676e300e), installed, Windows 11 (10.0.22631).

Steps / frequency

  1. Saves → Export saves… (or Import from an emulator…) → pick a destination → Continue.
  2. On the confirm screen, toggle the tick: the "Replaced in …" line changes, but nothing says whether the folder's settings or the source's are the ones that survive.
  3. With an emulator's folder that has slots but no option.sav, the tick is still shown; ticking it exports no option.sav.

Every copy.

What I expected

The label and the line under it to say whose settings are kept in each state, the "Replaced in …" line to say the settings stay when they do, and no tick when there are no settings in the destination to keep (the source's are copied, as the unticked state does).

Where it comes from

SavesConfirmViewModel (App/ViewModels/SavesViewModel.cs) sets KeepLabel, Replaced and an unconditional hint in App/Views/SavesConfirmView.axaml; Saves.Copy drops option.sav from the files it writes when keepSettings is set (Core/Saves.cs), so a destination without one ends with none.

A pull request follows: the label, hint and "Replaced in …" line say what is kept or replaced, and the tick is hidden when the destination holds no option.sav.

### What happened? On the Saves confirm screen the game-settings tick never says which side's settings survive, and its text is wrong in one of its two states: - "Keep *<destination>*'s game settings (option.sav)" can be read as keeping them *from* Longshot, not as "don't replace the ones there". - The line under it, "Camera, text speed and the game's other options stay as they are there.", is shown whether the tick is on or off — so it also says the settings stay when the tick is **off**, i.e. when Longshot's settings are the ones that replace them. - With the tick **on**, the "Replaced in …" line only stops listing `option.sav`; it never says the folder's own settings are kept. - When the destination has no `option.sav` at all (an emulator folder whose game never wrote one, or a Longshot with no save yet when importing), the tick is still offered — but ticking it writes no `option.sav`, so that copy leaves the game on its built-in defaults while the label promises to keep its settings. ### Launcher version v1.0.0-rc.10 (`676e300e`), installed, Windows 11 (10.0.22631). ### Steps / frequency 1. **Saves** → **Export saves…** (or **Import from an emulator…**) → pick a destination → Continue. 2. On the confirm screen, toggle the tick: the "Replaced in …" line changes, but nothing says whether the folder's settings or the source's are the ones that survive. 3. With an emulator's folder that has slots but no `option.sav`, the tick is still shown; ticking it exports no `option.sav`. Every copy. ### What I expected The label and the line under it to say whose settings are kept in each state, the "Replaced in …" line to say the settings stay when they do, and no tick when there are no settings in the destination to keep (the source's are copied, as the unticked state does). ### Where it comes from `SavesConfirmViewModel` (`App/ViewModels/SavesViewModel.cs`) sets `KeepLabel`, `Replaced` and an unconditional hint in `App/Views/SavesConfirmView.axaml`; `Saves.Copy` drops `option.sav` from the files it writes when `keepSettings` is set (`Core/Saves.cs`), so a destination without one ends with none. A pull request follows: the label, hint and "Replaced in …" line say what is kept or replaced, and the tick is hidden when the destination holds no `option.sav`.
Collaborator

Possibly related, for context:

  • issue #165 Export to a folder with no save yet is refused, though the picker says 'any folder' — Related save-transfer confirmation behavior for empty destinations
  • PR #166 fix(saves): export to a folder with no save yet makes the save in it — Open fix allowing export to empty folders; also concerns absent option.sav destinations
Possibly related, for context: - issue #165 Export to a folder with no save yet is refused, though the picker says 'any folder' — Related save-transfer confirmation behavior for empty destinations - PR #166 fix(saves): export to a folder with no save yet makes the save in it — Open fix allowing export to empty folders; also concerns absent option.sav destinations
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher#167
No description provided.