Export to a folder with no save yet is refused, though the picker says 'any folder' #165
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher#165
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happened?
Saves → Export saves… → Another folder… → pick an empty/new folder → the confirm page cannot run the export:
and Export stays disabled. Exporting works only when the folder already holds a save (or an emulator's empty title folder), i.e. exactly when there is something to overwrite.
Launcher version
v1.0.0-rc.10 (
676e300e), installed, Windows 11 (10.0.22631).Steps / frequency
Every time. A folder that already holds a save works.
What I expected
The export to write the save there (
account.sav,option.sav,slot_*), so I can keep a backup on another drive, or point a portable emulator at a folder before its first run. The picker says "A portable emulator's user folder, or any folder", anddocs/saves.mdsays "into any folder you pick with Choose a folder".Where it comes from
SavesConfirmViewModel.RefreshandSaves.ImportExportresolve the destination withSaves.Locate, which requires an existing save.Saves.Copyalready knows how to create a target that is not there yet (it is how the first import works), and the confirm page already has the empty-target words ("nothing saved yet", "Nothing there yet to back up.").scripts/longshot_saves.pyrefuses it too (itsside()callslocate()on the destination, andnew_save_folder()returns nothing forFOLDER; only a Hookshot/Longshot destination may be created), and the launcher'sCore/Saves.csis a rule-for-rule port of it.Question
Should the launcher allow it — a folder with no save is made into the save folder — or should the picker/docs wording change to say the folder must already hold a save? If the answer is "allow it", I would send the launcher change (and the script change too if you want one rule across both).
Possibly related, for context: