fix(saves): bringing the builds' saves together merges them slot by slot, never over a kept slot #175
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!175
Loadingβ¦
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:fix/gather-slot-by-slot"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Likely cause of #146 ("Updating to v3.0.0-rc.5 deleted all saves without a prompt"). On Windows a game started outside the launcher (Explorer, a taskbar pin, Steam) saves into its own folder's
user\save, while the launcher starts every build on the shared%APPDATA%\Longshot. At each startSaves.Gatherkept the ONE save folder with the newestprogress.savand made it the shared save whole: one newer slot replaced the player's whole adventure, the other slots surviving only in the gather backup, and the player was told afterwards, never asked. Now the gather merges slot by slot and never writes over a slot it keeps.What changes
slot_00βslot_05of its profile, or, with none free, stays only in the backup and the notice says so. A copy identical to anything kept is dropped silently (a folder whose earlier rename was refused isn't brought in twice). An empty or missingprogress.savnever wins.account.savandoption.savstay the shared save's whenever one exists, so a quick new game started outside the launcher can't swap the player's options either. They come from the save played last only when there is no shared save yet, and the notice says so then.SaveGathered.Slots): which slots came in from where, which older copies that differ are only in the backup, the profile when there is more than one, and the backup's path. List items join with a catalog text ("{0}, {1}",γin ja and zh). The texts are in all 12 full catalogs.save.moved-<stamp>..save.longshot-old, left when a gather was cut short and every copy then tied, is now backed up and removed.docs/saves.mdupdated.Testing
Windows 11, .NET SDK 10.0.404; TEMP on its long path (with the short 8.3 one, a few checks on main itself fail on Windows).
python -I tests/test_launcher_core.py: the check commit2a45f37fails on main:Merged slot by slot: every slot of both sides is in the shared save (has: slot_00 slot_01 slot_04).With the fix, 1462 checks passed. Merged with the delete PR, 1484.progress.sav, a profile only one folder has, the leftover aside folder, and a fault during the merge copies leaving the shared save as it was. The old g2 and g4 checks encoded the overwrite and were changed.changedtest, the dedupe of identical copies, the tie order, dropping the losing copies, hiding the older ones.Must be tested with the real game: a slot merged in from another folder loading next to the shared save's
account.sav. Longshot's saves-script.md says a lone slot folder loads and the game rebuildsaccount.savitself, but nobody has tried a slot beside another save's.Not checked: how many slots the game accepts; moved slots stay within
slot_00βslot_05, the six the launcher shows.π€ Generated with Claude Code