test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a map #993
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!993
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:test/import-reach-stubs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
Since #431 merged today, three checks have failed on main on every OS:
test_guest_imported,test_pending_guest_importand #431's owntest_import_reach. Each fails while its fixture compiles, so it no longer checks anything about the imports. They are the checks for the import table that row 5.6's memory work leans on. I searched the open PRs and issues for each name and found none.What changed
The checks' stand-ins now match
gpu/vk/vk_memory.cppas it is on main. What each check asserts is unchanged.tests/test_guest_imported.py,tests/test_pending_guest_import.py:memory_guest_imported's scan now callsimport_reach::beyond(live_reach, ...)(#431). The fixtures include the realgpu/vk/import_reach.h(built at C++20, which its<bit>needs, with the repository on the include path). They declarelive_reach, and the first counts its one import in it, asimported_adddoes.tests/import_reach_test.cpp(#431's fixture):bg_inflightis thestd::map<uint64_t, uint64_t>of[lo, hi)that vk_memory.cpp has had since #468, not astd::vector<uint64_t>;dead_importsthatmemory_guest_importedreads.Measurements
Verdict: nothing to measure: checks only. They fail on main and pass here.
Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.pyfrom PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.fd2e3e98test_guest_importeduse of undeclared identifier 'import_reach','live_reach'test_pending_guest_importtest_import_reachno member named 'contains' in 'std::vector<unsigned long long>', thenundeclared identifier 'dead_imports'run_all.pyin allAfter the run, main moved to
a0be15b3(#33) and the branch was rebased onto it (now3213c2a4). The three checks rerun there fail on main @a0be15b3and pass @3213c2a4.The 23 that still fail here fail on main too:
test_appimage_player_build,test_auto_handheld,test_cpp_preflight,test_crash_dialog,test_crt_options,test_env_on,test_fsr_uniform_ownership,test_lift_cleanup_error,test_linux_preflight,test_make_game_cache,test_make_game_prepare,test_missing_nup,test_options_budget_once,test_pads_after_menu,test_parallel_init_order,test_readback_late,test_release,test_replay_write_order,test_run_all_changed,test_tested_configurations,test_vk_occlusion_queries,test_vk_pgoandtest_walk_key. Some have open PRs, among them #804, #806, #144, #954, #937 and #625.Not tested: Linux and macOS. The errors were C++ type errors, the same on every compiler, and the fixtures use nothing new.
Must be tested: None. The change is to checks only.
Risks
What could break: nothing in the game: only
tests/changes.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #431
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
WIP: test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a mapto test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a mapView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.