test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a map #993

Open
d4nkn3ss wants to merge 1 commit from d4nkn3ss/Longshot:test/import-reach-stubs into main
Contributor

Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none

Why

Since #431 merged today, three checks have failed on main on every OS: test_guest_imported, test_pending_guest_import and #431's own test_import_reach. Each fails while its fixture compiles, so it no longer checks anything about the imports. They are the checks for the import table that row 5.6's memory work leans on. I searched the open PRs and issues for each name and found none.

What changed

The checks' stand-ins now match gpu/vk/vk_memory.cpp as it is on main. What each check asserts is unchanged.

  • tests: tests/test_guest_imported.py, tests/test_pending_guest_import.py: memory_guest_imported's scan now calls import_reach::beyond(live_reach, ...) (#431). The fixtures include the real gpu/vk/import_reach.h (built at C++20, which its <bit> needs, with the repository on the include path). They declare live_reach, and the first counts its one import in it, as imported_add does.
  • tests: tests/import_reach_test.cpp (#431's fixture):
    • bg_inflight is the std::map<uint64_t, uint64_t> of [lo, hi) that vk_memory.cpp has had since #468, not a std::vector<uint64_t>;
    • it declares the dead_imports that memory_guest_imported reads.

Measurements

Verdict: nothing to measure: checks only. They fail on main and pass here.

Flags and settings

None

Testing

Tested: python -I -B tests/run_all.py from PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.

main @ fd2e3e98 this PR @ e6cc13f3
test_guest_imported FAIL: use of undeclared identifier 'import_reach', 'live_reach' pass
test_pending_guest_import FAIL: the same pass
test_import_reach FAIL: no member named 'contains' in 'std::vector<unsigned long long>', then undeclared identifier 'dead_imports' pass
run_all.py in all 584 passed, 26 failed, 42 skipped 587 passed, 23 failed, 42 skipped

After the run, main moved to a0be15b3 (#33) and the branch was rebased onto it (now 3213c2a4). The three checks rerun there fail on main @ a0be15b3 and pass @ 3213c2a4.

The 23 that still fail here fail on main too: test_appimage_player_build, test_auto_handheld, test_cpp_preflight, test_crash_dialog, test_crt_options, test_env_on, test_fsr_uniform_ownership, test_lift_cleanup_error, test_linux_preflight, test_make_game_cache, test_make_game_prepare, test_missing_nup, test_options_budget_once, test_pads_after_menu, test_parallel_init_order, test_readback_late, test_release, test_replay_write_order, test_run_all_changed, test_tested_configurations, test_vk_occlusion_queries, test_vk_pgo and test_walk_key. Some have open PRs, among them #804, #806, #144, #954, #937 and #625.

Not tested: Linux and macOS. The errors were C++ type errors, the same on every compiler, and the fixtures use nothing new.

Must be tested: None. The change is to checks only.

Risks

What could break: nothing in the game: only tests/ changes.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Issues

See #431

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.

🤖 Generated with Claude Code

**Type:** test · **Risk:** low · **Tested on:** Windows 11, RTX 3080 · **Needs:** none ## Why Since #431 merged today, three checks have failed on main on every OS: `test_guest_imported`, `test_pending_guest_import` and #431's own `test_import_reach`. Each fails while its fixture compiles, so it no longer checks anything about the imports. They are the checks for the import table that row 5.6's memory work leans on. I searched the open PRs and issues for each name and found none. ## What changed The checks' stand-ins now match `gpu/vk/vk_memory.cpp` as it is on main. What each check asserts is unchanged. - tests: `tests/test_guest_imported.py`, `tests/test_pending_guest_import.py`: `memory_guest_imported`'s scan now calls `import_reach::beyond(live_reach, ...)` (#431). The fixtures include the real `gpu/vk/import_reach.h` (built at C++20, which its `<bit>` needs, with the repository on the include path). They declare `live_reach`, and the first counts its one import in it, as `imported_add` does. - tests: `tests/import_reach_test.cpp` (#431's fixture): - `bg_inflight` is the `std::map<uint64_t, uint64_t>` of `[lo, hi)` that vk_memory.cpp has had since #468, not a `std::vector<uint64_t>`; - it declares the `dead_imports` that `memory_guest_imported` reads. ## Measurements **Verdict:** nothing to measure: checks only. They fail on main and pass here. ### Flags and settings None ## Testing **Tested:** `python -I -B tests/run_all.py` from PowerShell on Windows 11, with llvm-mingw from the Longshot Builder. | | main @ fd2e3e98 | this PR @ e6cc13f3 | |---|---|---| | `test_guest_imported` | FAIL: `use of undeclared identifier 'import_reach'`, `'live_reach'` | pass | | `test_pending_guest_import` | FAIL: the same | pass | | `test_import_reach` | FAIL: `no member named 'contains' in 'std::vector<unsigned long long>'`, then `undeclared identifier 'dead_imports'` | pass | | `run_all.py` in all | 584 passed, 26 failed, 42 skipped | 587 passed, 23 failed, 42 skipped | After the run, main moved to a0be15b3 (#33) and the branch was rebased onto it (now 3213c2a4). The three checks rerun there fail on main @ a0be15b3 and pass @ 3213c2a4. The 23 that still fail here fail on main too: `test_appimage_player_build`, `test_auto_handheld`, `test_cpp_preflight`, `test_crash_dialog`, `test_crt_options`, `test_env_on`, `test_fsr_uniform_ownership`, `test_lift_cleanup_error`, `test_linux_preflight`, `test_make_game_cache`, `test_make_game_prepare`, `test_missing_nup`, `test_options_budget_once`, `test_pads_after_menu`, `test_parallel_init_order`, `test_readback_late`, `test_release`, `test_replay_write_order`, `test_run_all_changed`, `test_tested_configurations`, `test_vk_occlusion_queries`, `test_vk_pgo` and `test_walk_key`. Some have open PRs, among them #804, #806, #144, #954, #937 and #625. **Not tested:** Linux and macOS. The errors were C++ type errors, the same on every compiler, and the fixtures use nothing new. **Must be tested:** None. The change is to checks only. ## Risks **What could break:** nothing in the game: only `tests/` changes. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Issues See #431 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a map
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 11s
3213c2a489
Since #431 merged, three checks fail on main on every OS, each at compile
time. memory_guest_imported's scan now asks import_reach::beyond(live_reach,
...), which the stand-ins of test_guest_imported and test_pending_guest_import
did not declare. #431's own fixture, tests/import_reach_test.cpp, declared
bg_inflight as a vector where vk_memory.cpp has a map of [lo, hi) since #468,
and had no dead_imports.

The two checks include the real import_reach.h (C++20, the repository on the
include path) and count their import in live_reach as imported_add does. The
fixture's bg_inflight is the map and it has a dead_imports. What each check
asserts is unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
d4nkn3ss changed title from WIP: test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a map to test(vk): the import checks' stand-ins match vk_memory.cpp since #431: live_reach, dead_imports, bg_inflight a map 2026-11-16 01:21:54 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 11s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'test/import-reach-stubs:d4nkn3ss-test/import-reach-stubs'
git switch 'd4nkn3ss-test/import-reach-stubs'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!993
No description provided.