test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved it #1007

Open
d4nkn3ss wants to merge 1 commit from d4nkn3ss/Longshot:test/occ-split-part into main
Contributor

Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none

Why

test_vk_occlusion_queries has failed on main on every OS since #443, before its last checks run. Among them is the check that a recording's occlusion queries are copied after its end barrier and before its submit, wherever a recording part ends. #443 made maybe_split decide only when a part ends; the part itself now ends in split_part, which maybe_split and replay() call at the next plain draw. The check still looks for the end barrier in maybe_split and stops with ValueError: substring not found. I searched the open PRs for the check's name and for split_part. #998, #977 and others only list it among main's failures.

What changed

The check cuts split_part in place of maybe_split. Its order assertion (the end barrier, then occ_copy_part, then submit_recording) is unchanged, and so is the one for finish_recording.

  • tests: tests/test_vk_occlusion_queries.py check_wiring: the marker is void split_part(VkCommandBuffer& cmd) {, with a comment naming #443.

Measurements

Verdict: nothing to measure: a check only. It fails on main and passes here.

Flags and settings

None

Testing

Tested: python -I -B tests/run_all.py from PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.

main @ 1764fed2 this PR @ 5bd70542
test_vk_occlusion_queries FAIL: ValueError: substring not found (full_barrier(cmd, "barrier (recording end)"); in maybe_split) pass
run_all.py in all 598 passed, 19 failed, 42 skipped 599 passed, 18 failed, 42 skipped

The 18 left fail on main too: test_auto_handheld, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_fsr_uniform_ownership, test_guest_imported, test_import_reach, test_linux_preflight, test_make_game_cache, test_missing_nup, test_pads_after_menu, test_parallel_init_order, test_pending_guest_import, test_release, test_replay_write_order, test_run_all_changed, test_tested_configurations and test_walk_key. Some have open PRs: #1006, #1003, #993, #999, #592, #144, #954, #937 and #537.

Not tested: Linux and macOS. The check reads source text, the same on every OS.

Must be tested: None. The change is to a check only.

Risks

What could break: nothing in the game: only tests/ changes.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Issues

See #443

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.

🤖 Generated with Claude Code

**Type:** test · **Risk:** low · **Tested on:** Windows 11, RTX 3080 · **Needs:** none ## Why `test_vk_occlusion_queries` has failed on main on every OS since #443, before its last checks run. Among them is the check that a recording's occlusion queries are copied after its end barrier and before its submit, wherever a recording part ends. #443 made `maybe_split` decide only when a part ends; the part itself now ends in `split_part`, which `maybe_split` and `replay()` call at the next plain draw. The check still looks for the end barrier in `maybe_split` and stops with `ValueError: substring not found`. I searched the open PRs for the check's name and for `split_part`. #998, #977 and others only list it among main's failures. ## What changed The check cuts `split_part` in place of `maybe_split`. Its order assertion (the end barrier, then `occ_copy_part`, then `submit_recording`) is unchanged, and so is the one for `finish_recording`. - tests: `tests/test_vk_occlusion_queries.py` `check_wiring`: the marker is `void split_part(VkCommandBuffer& cmd) {`, with a comment naming #443. ## Measurements **Verdict:** nothing to measure: a check only. It fails on main and passes here. ### Flags and settings None ## Testing **Tested:** `python -I -B tests/run_all.py` from PowerShell on Windows 11, with llvm-mingw from the Longshot Builder. | | main @ 1764fed2 | this PR @ 5bd70542 | |---|---|---| | `test_vk_occlusion_queries` | FAIL: `ValueError: substring not found` (`full_barrier(cmd, "barrier (recording end)");` in `maybe_split`) | pass | | `run_all.py` in all | 598 passed, 19 failed, 42 skipped | 599 passed, 18 failed, 42 skipped | The 18 left fail on main too: `test_auto_handheld`, `test_bug_report_defaults`, `test_crash_dialog`, `test_crt_options`, `test_fsr_uniform_ownership`, `test_guest_imported`, `test_import_reach`, `test_linux_preflight`, `test_make_game_cache`, `test_missing_nup`, `test_pads_after_menu`, `test_parallel_init_order`, `test_pending_guest_import`, `test_release`, `test_replay_write_order`, `test_run_all_changed`, `test_tested_configurations` and `test_walk_key`. Some have open PRs: #1006, #1003, #993, #999, #592, #144, #954, #937 and #537. **Not tested:** Linux and macOS. The check reads source text, the same on every OS. **Must be tested:** None. The change is to a check only. ## Risks **What could break:** nothing in the game: only `tests/` changes. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Issues See #443 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved it
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
5bd70542c4
test_vk_occlusion_queries checks that a recording's queries are copied after
its end barrier and before its submit, in the two places a recording part
ends. Since #443, maybe_split only decides when: the part ends in split_part,
which it and replay() (at the next plain draw) call. The check still cut
maybe_split, found no end barrier there and stopped with "substring not
found" on every OS. It cuts split_part now. Its order assertion is unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
d4nkn3ss changed title from WIP: test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved it to test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved it 2026-11-16 02:04:23 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'test/occ-split-part:d4nkn3ss-test/occ-split-part'
git switch 'd4nkn3ss-test/occ-split-part'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1007
No description provided.