test(menu): test_crt_options cuts the menu as it is now: no VRAM budget rows, apply_auto(), save()'s card and file calls #1006
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1006
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:test/crt-options-after-735"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
test_crt_optionshas failed on main on every OS since #735, before checking anything. It checks that the CRT filter and CRT lines rows survive a save, a load, a preset and Auto. #735 removed the VRAM budget rows the check cuts out ofgpu/vk/vk_menu.cpp(kVramBudgets,tx_vram_budget,sync_preset_budgets), so it stops withValueError: substring not found. Under that, the code it cuts had moved on in other merges as well. I searched the open PRs for the check's name and these markers. #998 and #979 only list it among main's failures.What changed
The check cuts the menu as it is on main and gives the cut code the stand-ins it now needs. What it asserts about the CRT rows is unchanged.
tests/test_crt_options.py:/* BUDGETS */and/* SYNC_BUDGETS */cuts go, since their code is gone (#735);apply_autois declared and called withoutkeep_own, which #735 removed. The case that saidapply_auto(true)("choosing again after the hardware changes") now calls it as main's own hardware-changed path does;save():<cerrno>,<windows.h>or<sys/stat.h>and<unistd.h>,gpu_choice.handgpu_device_cards(#736). These are the linestests/test_menu_env_overrides.pyalready has;set_row:debug_warning,debug_warning_choice,menu_refreshandsync_transition_autosave().Measurements
Verdict: nothing to measure: a check only. It fails on main and passes here.
Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.pyfrom PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.1764fed20690065dtest_crt_optionsValueError: substring not found(constexpr int kVramBudgets =)run_all.pyin allThe 18 left fail on main too:
test_auto_handheld,test_bug_report_defaults,test_crash_dialog,test_fsr_uniform_ownership,test_guest_imported,test_import_reach,test_linux_preflight,test_make_game_cache,test_missing_nup,test_pads_after_menu,test_parallel_init_order,test_pending_guest_import,test_release,test_replay_write_order,test_run_all_changed,test_tested_configurations,test_vk_occlusion_queriesandtest_walk_key. Some have open PRs: #1003, #993, #999, #592, #144, #954, #937 and #537.Not tested: Linux and macOS. The POSIX branch's includes are the ones
test_menu_env_overridesuses there.Must be tested:
python -I -B tests/run_all.py test_crt_options, expecting it to pass (by hand: the check's line in run_all's table)Risks
What could break: nothing in the game: only
tests/changes.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #735
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
WIP: test(menu): test_crt_options cuts the menu as it is now: no VRAM budget rows, apply_auto(), save()'s card and file callsto test(menu): test_crt_options cuts the menu as it is now: no VRAM budget rows, apply_auto(), save()'s card and file callsView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.