test(vk): test_auto_handheld sets SteamDeck with _putenv_s on Windows, where setenv does not exist #1009
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1009
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:test/auto-handheld-windows-env"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
test_auto_handheld(#559) has failed on Windows since it was added, before checking anything: it sets and clears theSteamDeckvariable withsetenvandunsetenv, which the Windows C runtime doesn't have, so llvm-mingw stops withuse of undeclared identifier 'setenv'. The check is the one that keeps a Windows PC withSteamDeck=1from being taken for a handheld, so Windows is where it matters most. I searched the open PRs for the check's name; #910, #893 and others only list it among main's failures.What changed
A small helper in the fixture sets or clears
SteamDeck:_putenv_son Windows (an empty value removes the variable),setenv/unsetenvelsewhere. The cases are unchanged.tests/test_auto_handheld.py:steamdeck_env(), called where the two POSIX calls were.Measurements
Verdict: nothing to measure: a check only. It fails on Windows main and passes here.
Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.pyfrom PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.1764fed2bc4c0d66test_auto_handhelduse of undeclared identifier 'setenv','unsetenv'run_all.pyin allThe 18 left fail on main too:
test_bug_report_defaults,test_crash_dialog,test_crt_options,test_fsr_uniform_ownership,test_guest_imported,test_import_reach,test_linux_preflight,test_make_game_cache,test_missing_nup,test_pads_after_menu,test_parallel_init_order,test_pending_guest_import,test_release,test_replay_write_order,test_run_all_changed,test_tested_configurations,test_vk_occlusion_queries,test_walk_key. Some have open PRs: #1007, #1006, #1003, #993, #999, #592, #144, #954, #937 and #537.Not tested: Linux and macOS, where the helper calls
setenvandunsetenvas before.Must be tested: None. The change is to a check only.
Risks
What could break: nothing in the game: only
tests/changes.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #559
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
WIP: test(vk): test_auto_handheld sets SteamDeck with _putenv_s on Windows, where setenv does not existto test(vk): test_auto_handheld sets SteamDeck with _putenv_s on Windows, where setenv does not existView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.