test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved it #1007
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1007
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:test/occ-split-part"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
test_vk_occlusion_querieshas failed on main on every OS since #443, before its last checks run. Among them is the check that a recording's occlusion queries are copied after its end barrier and before its submit, wherever a recording part ends. #443 mademaybe_splitdecide only when a part ends; the part itself now ends insplit_part, whichmaybe_splitandreplay()call at the next plain draw. The check still looks for the end barrier inmaybe_splitand stops withValueError: substring not found. I searched the open PRs for the check's name and forsplit_part. #998, #977 and others only list it among main's failures.What changed
The check cuts
split_partin place ofmaybe_split. Its order assertion (the end barrier, thenocc_copy_part, thensubmit_recording) is unchanged, and so is the one forfinish_recording.tests/test_vk_occlusion_queries.pycheck_wiring: the marker isvoid split_part(VkCommandBuffer& cmd) {, with a comment naming #443.Measurements
Verdict: nothing to measure: a check only. It fails on main and passes here.
Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.pyfrom PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.1764fed25bd70542test_vk_occlusion_queriesValueError: substring not found(full_barrier(cmd, "barrier (recording end)");inmaybe_split)run_all.pyin allThe 18 left fail on main too:
test_auto_handheld,test_bug_report_defaults,test_crash_dialog,test_crt_options,test_fsr_uniform_ownership,test_guest_imported,test_import_reach,test_linux_preflight,test_make_game_cache,test_missing_nup,test_pads_after_menu,test_parallel_init_order,test_pending_guest_import,test_release,test_replay_write_order,test_run_all_changed,test_tested_configurationsandtest_walk_key. Some have open PRs: #1006, #1003, #993, #999, #592, #144, #954, #937 and #537.Not tested: Linux and macOS. The check reads source text, the same on every OS.
Must be tested: None. The change is to a check only.
Risks
What could break: nothing in the game: only
tests/changes.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #443
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
WIP: test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved itto test(vk): the occlusion check looks for a part's end barrier in split_part, where #443 moved itView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.