fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives #1046

Open
d4nkn3ss wants to merge 3 commits from d4nkn3ss/Longshot:fix/teleport-resend-dropped into main
Contributor

Type: fix · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: Linux, any GPU

Why

The debug teleport (the Cheats page, and the control bridge's teleport, which scripted runs and testers use) sometimes doesn't happen. The game answers the request 0 and drops it: nothing reserved (Sequence_ReservedNextBanc ""), no event playing, Link where he was. The control bridge's teleport --arrive then times out, and a measured run stands in the wrong place. I lost three Market measurements to that today, reported on #391 and #472. Across today's scripted runs on this PC it was 6 of 159 requests, 4 of them the first request a few frames after a save had loaded. The follow-up 1.5 s after each request already read exactly this state, but it only logged it. I searched the open PRs and issues for the teleport: #823 and #461 change the Teleport page and saving, not the request or its follow-up.

How to reproduce

Seen on: Windows 11, RTX 3080 (NVIDIA 621.14)
Settings and switches: HOS_OOT_CHEATS=1, HOS_CONTROL, an adult save, no cap (HOS_FPS_MAX=1000)
Steps: load the save, and as soon as it is in play python -I scripts/longshot_ctl.py --sock <pipe> teleport 3 --arrive 60; repeat over several starts
Expected: Link in the Market
Actual: in some starts, longshot_ctl: timeout: not met in time, with the log's cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0

What changed

The follow-up sends a dropped request once more, so the map changes and the bridge's wait sees it arrive. A request that is under way (a map reserved, an event playing, the map loading), or that has arrived, is left alone, and a resent one is never sent a third time.

  • host: host/oot_teleport_check.h (new): oot_teleport_dropped(), the decision, a pure function.
  • host: host/hos_main.c oot_teleport_followup(c, actor):
    • it also reads Sequence_IsLoadingBanc;
    • when the request was dropped, it logs cheats: teleport to <map> dropped by the game (nothing reserved, no event): sent again and calls oot_teleport for the same destination, setting the 8 s one-request guard aside for it;
    • teleport.resent marks the resend, and a new request clears it. The player's update passes Link's actor in.
  • tests: tests/test_teleport_check.py (new): compiles the decision with its cases (dropped; reserved, event or loading under way; arrived; already resent; nothing sent). It reads the follow-up for the resend. It fails on main.

Measurements

Verdict: fixed: a dropped teleport is sent again and arrives. In 15 starts of this PR, the one request the game dropped arrived after the resend (result 0, then 0x1), and all 15 reached the Market. Main dropped 4 of 19 such first requests in today's A/B runs, none of which arrived.

Hardware: Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), i9-12900K, 64 GB
Scene: an adult save in Hyrule Field; the first teleport (to the Market) the moment the save is in play, uncapped, the right stick held through the bridge, a refused request pressed through with A as the A/B scripts do
Method: one start per run, read from longshot_log.txt and the bridge's reply; each side's longshot.exe and longshot_vk.dll swapped into one game folder
Baseline: main's side is main @ 1764fed2's build, the one my A/B runs used; this PR is on main @ e4d035e9. git diff 1764fed2 e4d035e9 -- host/hos_main.c is empty: the teleport and its follow-up are the same code.
How to reproduce: the steps above, over many starts

first teleport after the save loads Before: main @ 1764fed2 After: this PR @ 47bb62b8
A/B runs today (the Market first) 4 of 19 dropped, each a timeout not run
this test, interleaved, 6 starts each 0 of 6 dropped, all arrived 0 of 6 dropped, all arrived
this test, this PR alone, 15 starts not run 1 of 15 dropped, sent again, all 15 arrived
[hos host] control: teleport to destination 3 asked for
[hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0
[hos BaseProcExecutor1] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0
[hos BaseProcExecutor1] cheats: teleport to Market_Adult dropped by the game (nothing reserved, no event): sent again
[hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0x1
[hos host] control: state play -> loading at frame 6979 (6.0 draws a frame)
[hos BaseProcExecutor2] cheats: teleport check: reserved "Market_Adult", current "Market_Adult", event playing 0
[hos BaseProcExecutor2] map: Market_Adult (adult)

The bridge said: teleport 3: in Market_Adult after 1148 frames.

Rebased after the runs onto main @ bbe421f5 (now 65987971). host/hos_main.c is the same there, and test_teleport_check passes again.

Flags and settings

None

Testing

Tested:

  • In the game, as above: 27 starts of this PR's build. 25 arrived: the 6 interleaved, the 15 alone, and 4 of 6 in a first script that didn't retry a refusal (its other 2 were refused at once with "an event is playing", the game refusing, not a drop). One resend; no device loss, VK_ERROR or FATAL line; every run closed normally.
  • python -I -B tests/test_teleport_check.py: fails on main (the follow-up has no resend), passes here.
  • python -I -B tests/run_all.py from PowerShell with llvm-mingw from the Longshot Builder: 603 passed, 19 failed, 42 skipped here, against 602 passed, 19 failed, 42 skipped on main @ e4d035e9. The same 19 fail on both: test_auto_handheld, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_fsr_uniform_ownership, test_guest_imported, test_import_reach, test_linux_preflight, test_make_game_cache, test_missing_nup, test_pads_after_menu, test_parallel_init_order, test_pending_guest_import, test_release, test_replay_write_order, test_run_all_changed, test_tested_configurations, test_vk_occlusion_queries and test_walk_key. Each has an open PR (among them #993, #999, #1003, #1006, #1007, #1009, #1011, #1012, #592, #144, #954, #937, #493 and #537), except test_bug_report_defaults (see #773).

Not tested: Linux, neither the build nor a run. The change is plain host C with no OS calls. The Cheats page's own teleport goes through the same request and follow-up, but I didn't use the page by hand.

Must be tested:

  • Linux, any GPU: build the host, then python -I -B tests/run_all.py test_teleport_check, expecting it to pass; and teleports from the Cheats page, expecting each to arrive once (by hand: the log's cheats: teleport lines)

Risks

What could break: a request the game takes more than 1.5 s to reserve, with no event playing, would be sent twice. In today's 159 requests every slow one had an event playing or a map reserved by then, and the six with neither never arrived until another request came.

Turning it off: revert the commit.

Compatibility: Nothing changes for players beyond a teleport that now arrives. The log gains the "sent again" line when it happens.

Issues

None found.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 3080 · **Needs:** Linux, any GPU ## Why The debug teleport (the Cheats page, and the control bridge's `teleport`, which scripted runs and testers use) sometimes doesn't happen. The game answers the request 0 and drops it: nothing reserved (`Sequence_ReservedNextBanc ""`), no event playing, Link where he was. The control bridge's `teleport --arrive` then times out, and a measured run stands in the wrong place. I lost three Market measurements to that today, reported on #391 and #472. Across today's scripted runs on this PC it was 6 of 159 requests, 4 of them the first request a few frames after a save had loaded. The follow-up 1.5 s after each request already read exactly this state, but it only logged it. I searched the open PRs and issues for the teleport: #823 and #461 change the Teleport page and saving, not the request or its follow-up. ## How to reproduce **Seen on:** Windows 11, RTX 3080 (NVIDIA 621.14) **Settings and switches:** `HOS_OOT_CHEATS=1`, `HOS_CONTROL`, an adult save, no cap (`HOS_FPS_MAX=1000`) **Steps:** load the save, and as soon as it is in play `python -I scripts/longshot_ctl.py --sock <pipe> teleport 3 --arrive 60`; repeat over several starts **Expected:** Link in the Market **Actual:** in some starts, `longshot_ctl: timeout: not met in time`, with the log's `cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0` ## What changed The follow-up sends a dropped request once more, so the map changes and the bridge's wait sees it arrive. A request that is under way (a map reserved, an event playing, the map loading), or that has arrived, is left alone, and a resent one is never sent a third time. - host: `host/oot_teleport_check.h` (new): `oot_teleport_dropped()`, the decision, a pure function. - host: `host/hos_main.c` `oot_teleport_followup(c, actor)`: - it also reads `Sequence_IsLoadingBanc`; - when the request was dropped, it logs `cheats: teleport to <map> dropped by the game (nothing reserved, no event): sent again` and calls `oot_teleport` for the same destination, setting the 8 s one-request guard aside for it; - `teleport.resent` marks the resend, and a new request clears it. The player's update passes Link's actor in. - tests: `tests/test_teleport_check.py` (new): compiles the decision with its cases (dropped; reserved, event or loading under way; arrived; already resent; nothing sent). It reads the follow-up for the resend. It fails on main. ## Measurements **Verdict:** fixed: a dropped teleport is sent again and arrives. In 15 starts of this PR, the one request the game dropped arrived after the resend (`result 0`, then `0x1`), and all 15 reached the Market. Main dropped 4 of 19 such first requests in today's A/B runs, none of which arrived. Hardware: Windows 11 Pro 26300, RTX 3080 10 GB (NVIDIA 621.14), i9-12900K, 64 GB Scene: an adult save in Hyrule Field; the first teleport (to the Market) the moment the save is in play, uncapped, the right stick held through the bridge, a refused request pressed through with A as the A/B scripts do Method: one start per run, read from `longshot_log.txt` and the bridge's reply; each side's `longshot.exe` and `longshot_vk.dll` swapped into one game folder Baseline: main's side is main @ 1764fed2's build, the one my A/B runs used; this PR is on main @ e4d035e9. `git diff 1764fed2 e4d035e9 -- host/hos_main.c` is empty: the teleport and its follow-up are the same code. How to reproduce: the steps above, over many starts | first teleport after the save loads | Before: main @ 1764fed2 | After: this PR @ 47bb62b8 | |---|---|---| | A/B runs today (the Market first) | 4 of 19 dropped, each a timeout | not run | | this test, interleaved, 6 starts each | 0 of 6 dropped, all arrived | 0 of 6 dropped, all arrived | | this test, this PR alone, 15 starts | not run | 1 of 15 dropped, sent again, all 15 arrived | ``` [hos host] control: teleport to destination 3 asked for [hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0 [hos BaseProcExecutor1] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0 [hos BaseProcExecutor1] cheats: teleport to Market_Adult dropped by the game (nothing reserved, no event): sent again [hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): request sent, result 0x1 [hos host] control: state play -> loading at frame 6979 (6.0 draws a frame) [hos BaseProcExecutor2] cheats: teleport check: reserved "Market_Adult", current "Market_Adult", event playing 0 [hos BaseProcExecutor2] map: Market_Adult (adult) ``` The bridge said: `teleport 3: in Market_Adult after 1148 frames`. Rebased after the runs onto main @ bbe421f5 (now 65987971). `host/hos_main.c` is the same there, and `test_teleport_check` passes again. ### Flags and settings None ## Testing **Tested:** - In the game, as above: 27 starts of this PR's build. 25 arrived: the 6 interleaved, the 15 alone, and 4 of 6 in a first script that didn't retry a refusal (its other 2 were refused at once with "an event is playing", the game refusing, not a drop). One resend; no device loss, `VK_ERROR` or FATAL line; every run closed normally. - `python -I -B tests/test_teleport_check.py`: fails on main (the follow-up has no resend), passes here. - `python -I -B tests/run_all.py` from PowerShell with llvm-mingw from the Longshot Builder: 603 passed, 19 failed, 42 skipped here, against 602 passed, 19 failed, 42 skipped on main @ e4d035e9. The same 19 fail on both: `test_auto_handheld`, `test_bug_report_defaults`, `test_crash_dialog`, `test_crt_options`, `test_fsr_uniform_ownership`, `test_guest_imported`, `test_import_reach`, `test_linux_preflight`, `test_make_game_cache`, `test_missing_nup`, `test_pads_after_menu`, `test_parallel_init_order`, `test_pending_guest_import`, `test_release`, `test_replay_write_order`, `test_run_all_changed`, `test_tested_configurations`, `test_vk_occlusion_queries` and `test_walk_key`. Each has an open PR (among them #993, #999, #1003, #1006, #1007, #1009, #1011, #1012, #592, #144, #954, #937, #493 and #537), except `test_bug_report_defaults` (see #773). **Not tested:** Linux, neither the build nor a run. The change is plain host C with no OS calls. The Cheats page's own teleport goes through the same request and follow-up, but I didn't use the page by hand. **Must be tested:** - Linux, any GPU: build the host, then `python -I -B tests/run_all.py test_teleport_check`, expecting it to pass; and teleports from the Cheats page, expecting each to arrive once (by hand: the log's `cheats: teleport` lines) ## Risks **What could break:** a request the game takes more than 1.5 s to reserve, with no event playing, would be sent twice. In today's 159 requests every slow one had an event playing or a map reserved by then, and the six with neither never arrived until another request came. **Turning it off:** revert the commit. **Compatibility:** Nothing changes for players beyond a teleport that now arrives. The log gains the "sent again" line when it happens. ## Issues None found. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The debug teleport's request, sent in the first frames after a save has
loaded, is answered 0 and then dropped by the game: nothing reserved, no
event, Link where he was, and the control bridge's teleport --arrive times
out. The follow-up 1.5 s later reads exactly that and only logs it. This
check compiles the decision (host/oot_teleport_check.h) with its cases and
reads the follow-up for the resend; it fails on main.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The debug teleport's request (the Cheats page, the control bridge's
teleport) is sometimes answered 0 and then dropped by the game: nothing
reserved, no event playing, Link where he was. In scripted runs on an RTX
3080 that was 6 of 159 requests, 4 of them the first one a few frames after
a save had loaded; the bridge's teleport --arrive then timed out and a
measured run stood in the wrong place. The follow-up 1.5 s after a request
read exactly that and only logged it.

It now sends that request once more (oot_teleport_dropped in
host/oot_teleport_check.h decides: nothing reserved, no event, the map not
loading, not there yet, not resent already), the 8 s guard set aside for it,
and logs "dropped by the game ...: sent again". A request under way or
arrived is left alone, and a resent one is not sent a third time.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
test(cheats): test_teleport_check names gcc for run_all, which has no {cc} placeholder
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
65987971ad
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: Windows 11, RTX 3080 (NVIDIA 621.14): 27 starts of this build, each loading a save and teleporting to the Market through the control bridge; one request dropped by the game was sent again and arrived, all 27 arrived, no device loss or errors

Tested in game: Windows 11, RTX 3080 (NVIDIA 621.14): 27 starts of this build, each loading a save and teleporting to the Market through the control bridge; one request dropped by the game was sent again and arrived, all 27 arrived, no device loss or errors
d4nkn3ss changed title from WIP: fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives to fix(cheats): a debug teleport the game dropped is sent once more, so the control bridge's teleport arrives 2026-11-16 04:42:28 +00:00
Author
Contributor

A correction to my in-game note above: not all 27 arrived. 25 did. The other 2 were in a first script that didn't retry a refusal, and the game refused both at once ("an event is playing"). That's the game refusing while the save's arrival plays, not a drop, and this PR doesn't change it. The 21 starts of the matching script (6 interleaved with main, then 15 alone) all arrived, one of them after the resend. The Testing section now says the same.

Posted by an AI agent (Claude Code) for d4nkn3ss.

A correction to my in-game note above: not all 27 arrived. 25 did. The other 2 were in a first script that didn't retry a refusal, and the game refused both at once ("an event is playing"). That's the game refusing while the save's arrival plays, not a drop, and this PR doesn't change it. The 21 starts of the matching script (6 interleaved with main, then 15 alone) all arrived, one of them after the resend. The Testing section now says the same. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
Author
Contributor

Seen again while testing #434 (Windows 11, RTX 3080, NVIDIA 621.14), in a build of main @ 3e4e7cab with #434 merged (#434 touches only draw binding, not the teleport): a teleport to the Market (destination 3) asked for from Hyrule Field was dropped in one of about ten runs that day that teleported. The log shows the case this PR resends:

[hos host] control: teleport to destination 3 asked for
[hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1):
[hos BaseProcExecutor2] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0

Nothing reserved, no event playing, still in Hyrule Field, and longshot_ctl teleport 3 --arrive timed out. That run's Market measurement was taken in the field and was thrown out.

Seen again while testing #434 (Windows 11, RTX 3080, NVIDIA 621.14), in a build of main @ 3e4e7cab with #434 merged (#434 touches only draw binding, not the teleport): a teleport to the Market (destination 3) asked for from Hyrule Field was dropped in one of about ten runs that day that teleported. The log shows the case this PR resends: ``` [hos host] control: teleport to destination 3 asked for [hos BaseProcExecutor1] cheats: teleport adult to Market_Adult at Market_Entrance (boot Dm_SY_BancChangeArrive_Market_02, event Dm_SY_BancChangeGo, starter 1): [hos BaseProcExecutor2] cheats: teleport check: reserved "", current "HyruleField_Adult", event playing 0 ``` Nothing reserved, no event playing, still in Hyrule Field, and `longshot_ctl teleport 3 --arrive` timed out. That run's Market measurement was taken in the field and was thrown out.
Member

Code-only review of 65987971ad; informational findings, with final approval left to another reviewer.

P2 — Keep the pending retry's destination separate from the last attempted request's reply (host/hos_main.c:1190). Send a teleport that the game drops, then press teleport again before its 1.5-second follow-up. The second call clears teleport.banc at line 1001 before rejecting the request under the 8-second guard. The original check_at remains armed, but the new follow-up passes NULL to oot_teleport_dropped(), which returns false, then clears the timer. The first request therefore never gets its promised retry. The clearing of the reply field is pre-existing; this PR introduces the dependency on that mutable field for retrying an earlier request. Store the pending target separately and replace it only when a new request is actually sent. Add a behavioral sequence test: sent-but-dropped A, rejected B, follow-up retries A exactly once. This is a source-derived case, not a reproduced game failure.

The predicate fixture covers individual decisions, but the follow-up check only searches source strings. It would still pass if the post-call teleport.resent = 1 were removed: oot_teleport() resets the flag, allowing repeated retries. Exercising the actual follow-up with a stubbed request would protect the once-only rule as well as the rejected-request case.

Merge coordination: the expanded Teleport page also changes this request path. Its oot_travel_place() temporarily sets place_target, calls oot_teleport(..., 0), and clears the override. Combining the branches unchanged would resend an arbitrary place as destination 0 after a drop. Preserve the complete original target (map, spawn, boot event and carrier mode) when integrating them; this is a combined-branches hazard, not a defect in this branch alone.

Existing evidence includes the author's corrected Windows report (25 arrivals in 27 starts; two immediate refusals), one successful resend and game-free checks. The declared Linux host/check and manual Cheats-page run remain outstanding. I read the full diff, request/follow-up and bridge callers, test, existing comments and relevant sibling changes. No tests, builds or game runs were performed.

Code-only review of 65987971ad175e9ae32d4b1d59dd2450d184a79a; informational findings, with final approval left to another reviewer. **P2 — Keep the pending retry's destination separate from the last attempted request's reply (`host/hos_main.c:1190`).** Send a teleport that the game drops, then press teleport again before its 1.5-second follow-up. The second call clears `teleport.banc` at line 1001 before rejecting the request under the 8-second guard. The original `check_at` remains armed, but the new follow-up passes NULL to `oot_teleport_dropped()`, which returns false, then clears the timer. The first request therefore never gets its promised retry. The clearing of the reply field is pre-existing; this PR introduces the dependency on that mutable field for retrying an earlier request. Store the pending target separately and replace it only when a new request is actually sent. Add a behavioral sequence test: sent-but-dropped A, rejected B, follow-up retries A exactly once. This is a source-derived case, not a reproduced game failure. The predicate fixture covers individual decisions, but the follow-up check only searches source strings. It would still pass if the post-call `teleport.resent = 1` were removed: `oot_teleport()` resets the flag, allowing repeated retries. Exercising the actual follow-up with a stubbed request would protect the once-only rule as well as the rejected-request case. **Merge coordination:** [the expanded Teleport page](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/823) also changes this request path. Its `oot_travel_place()` temporarily sets `place_target`, calls `oot_teleport(..., 0)`, and clears the override. Combining the branches unchanged would resend an arbitrary place as destination 0 after a drop. Preserve the complete original target (map, spawn, boot event and carrier mode) when integrating them; this is a combined-branches hazard, not a defect in this branch alone. Existing evidence includes the author's corrected Windows report (25 arrivals in 27 starts; two immediate refusals), one successful resend and game-free checks. The declared Linux host/check and manual Cheats-page run remain outstanding. I read the full diff, request/follow-up and bridge callers, test, existing comments and relevant sibling changes. No tests, builds or game runs were performed.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 3s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/teleport-resend-dropped:d4nkn3ss-fix/teleport-resend-dropped'
git switch 'd4nkn3ss-fix/teleport-resend-dropped'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1046
No description provided.