test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWait #1003
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1003
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:test/fps-rt-wait-stubs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
Since #928 (the FPS counter's Breakdown),
test_fsr_uniform_ownershipandtest_parallel_init_orderhave failed on main on every OS. They fail while compiling their fixtures, so they no longer check the upscalers' uniform buffers or the order of the parallel init's submits. The code they cut fromgpu/vk/vk_replay.cpp(recording_wait, the replay's segment jobs) now times its waits withFpsRtWait rt_wait(fps_stats::kRtGpu)and the like, and neither fixture declares those. #952 and #937 list both checks as failing on main for this reason but don't change them. I searched the open PRs forFpsRtWaitand both check names.What changed
Each fixture gets a stand-in for the FPS counter's render-lane timer that times nothing, ahead of the code it cuts. What the checks assert is unchanged.
tests/fsr_uniform_ownership_test.cpp(before/* RECORDING_WAIT */) andtests/parallel_init_order_test.cpp(before the cut.incfiles):fps_stats::RenderPartwith the valuesgpu/vk/fps_stats.hgives it, andstruct FpsRtWait { explicit FpsRtWait(int) {} };.Measurements
Verdict: nothing to measure: checks only. Both fail on main and pass here.
Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.pyfrom PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.9f8958a55b286f18test_fsr_uniform_ownershipunknown type name 'FpsRtWait',use of undeclared identifier 'fps_stats'test_parallel_init_orderinit_jobs.incrun_all.pyin allAfter the run, main moved to
1764fed2(#998) and the branch was rebased onto it (now2c967d9c). The two checks rerun there fail on main @1764fed2and pass @2c967d9c.The 17 left fail on main too:
test_auto_handheld,test_bug_report_defaults,test_crash_dialog,test_crt_options,test_guest_imported,test_import_reach,test_linux_preflight,test_make_game_cache,test_missing_nup,test_pads_after_menu,test_pending_guest_import,test_release,test_replay_write_order,test_run_all_changed,test_tested_configurations,test_vk_occlusion_queriesandtest_walk_key. Some have open PRs: #993, #999, #592, #144, #954, #937 and #537.Not tested: Linux and macOS. The errors were undeclared names, the same on every compiler.
Must be tested: None. The change is to checks only.
Risks
What could break: nothing in the game: only
tests/changes.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #928
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Rebased on main @
1764fed2(#998), now2c967d9c. Both checks fail on main there and pass here.Posted by an AI agent (Claude Code) for d4nkn3ss.
5b286f18732c967d9c33WIP: test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWaitto test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWaitLinux (Arch, clang, Vulkan headers from /usr/include via LONGSHOT_VULKAN_HEADERS):
run_all.py test_fsr_uniform_ownership test_parallel_init_order. On main @1764fed2both fail compiling the fixtures (unknown type name 'FpsRtWait',use of undeclared identifier 'fps_stats'); on this PR @2c967d9cboth pass. The stand-in'sRenderPartmatches gpu/vk/fps_stats.h's. Without LONGSHOT_VULKAN_HEADERS (no CPM cache in the checkout) run_all skips both here, which is why they didn't show as failing on this PC.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.