test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWait #1003

Open
d4nkn3ss wants to merge 1 commit from d4nkn3ss/Longshot:test/fps-rt-wait-stubs into main
Contributor

Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none

Why

Since #928 (the FPS counter's Breakdown), test_fsr_uniform_ownership and test_parallel_init_order have failed on main on every OS. They fail while compiling their fixtures, so they no longer check the upscalers' uniform buffers or the order of the parallel init's submits. The code they cut from gpu/vk/vk_replay.cpp (recording_wait, the replay's segment jobs) now times its waits with FpsRtWait rt_wait(fps_stats::kRtGpu) and the like, and neither fixture declares those. #952 and #937 list both checks as failing on main for this reason but don't change them. I searched the open PRs for FpsRtWait and both check names.

What changed

Each fixture gets a stand-in for the FPS counter's render-lane timer that times nothing, ahead of the code it cuts. What the checks assert is unchanged.

  • tests: tests/fsr_uniform_ownership_test.cpp (before /* RECORDING_WAIT */) and tests/parallel_init_order_test.cpp (before the cut .inc files): fps_stats::RenderPart with the values gpu/vk/fps_stats.h gives it, and struct FpsRtWait { explicit FpsRtWait(int) {} };.

Measurements

Verdict: nothing to measure: checks only. Both fail on main and pass here.

Flags and settings

None

Testing

Tested: python -I -B tests/run_all.py from PowerShell on Windows 11, with llvm-mingw from the Longshot Builder.

main @ 9f8958a5 this PR @ 5b286f18
test_fsr_uniform_ownership FAIL: unknown type name 'FpsRtWait', use of undeclared identifier 'fps_stats' pass
test_parallel_init_order FAIL: the same, in init_jobs.inc pass
run_all.py in all 598 passed, 19 failed, 42 skipped 600 passed, 17 failed, 42 skipped

After the run, main moved to 1764fed2 (#998) and the branch was rebased onto it (now 2c967d9c). The two checks rerun there fail on main @ 1764fed2 and pass @ 2c967d9c.

The 17 left fail on main too: test_auto_handheld, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_guest_imported, test_import_reach, test_linux_preflight, test_make_game_cache, test_missing_nup, test_pads_after_menu, test_pending_guest_import, test_release, test_replay_write_order, test_run_all_changed, test_tested_configurations, test_vk_occlusion_queries and test_walk_key. Some have open PRs: #993, #999, #592, #144, #954, #937 and #537.

Not tested: Linux and macOS. The errors were undeclared names, the same on every compiler.

Must be tested: None. The change is to checks only.

Risks

What could break: nothing in the game: only tests/ changes.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Issues

See #928

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.

🤖 Generated with Claude Code

**Type:** test · **Risk:** low · **Tested on:** Windows 11, RTX 3080 · **Needs:** none ## Why Since #928 (the FPS counter's Breakdown), `test_fsr_uniform_ownership` and `test_parallel_init_order` have failed on main on every OS. They fail while compiling their fixtures, so they no longer check the upscalers' uniform buffers or the order of the parallel init's submits. The code they cut from `gpu/vk/vk_replay.cpp` (`recording_wait`, the replay's segment jobs) now times its waits with `FpsRtWait rt_wait(fps_stats::kRtGpu)` and the like, and neither fixture declares those. #952 and #937 list both checks as failing on main for this reason but don't change them. I searched the open PRs for `FpsRtWait` and both check names. ## What changed Each fixture gets a stand-in for the FPS counter's render-lane timer that times nothing, ahead of the code it cuts. What the checks assert is unchanged. - tests: `tests/fsr_uniform_ownership_test.cpp` (before `/* RECORDING_WAIT */`) and `tests/parallel_init_order_test.cpp` (before the cut `.inc` files): `fps_stats::RenderPart` with the values `gpu/vk/fps_stats.h` gives it, and `struct FpsRtWait { explicit FpsRtWait(int) {} };`. ## Measurements **Verdict:** nothing to measure: checks only. Both fail on main and pass here. ### Flags and settings None ## Testing **Tested:** `python -I -B tests/run_all.py` from PowerShell on Windows 11, with llvm-mingw from the Longshot Builder. | | main @ 9f8958a5 | this PR @ 5b286f18 | |---|---|---| | `test_fsr_uniform_ownership` | FAIL: `unknown type name 'FpsRtWait'`, `use of undeclared identifier 'fps_stats'` | pass | | `test_parallel_init_order` | FAIL: the same, in `init_jobs.inc` | pass | | `run_all.py` in all | 598 passed, 19 failed, 42 skipped | 600 passed, 17 failed, 42 skipped | After the run, main moved to 1764fed2 (#998) and the branch was rebased onto it (now 2c967d9c). The two checks rerun there fail on main @ 1764fed2 and pass @ 2c967d9c. The 17 left fail on main too: `test_auto_handheld`, `test_bug_report_defaults`, `test_crash_dialog`, `test_crt_options`, `test_guest_imported`, `test_import_reach`, `test_linux_preflight`, `test_make_game_cache`, `test_missing_nup`, `test_pads_after_menu`, `test_pending_guest_import`, `test_release`, `test_replay_write_order`, `test_run_all_changed`, `test_tested_configurations`, `test_vk_occlusion_queries` and `test_walk_key`. Some have open PRs: #993, #999, #592, #144, #954, #937 and #537. **Not tested:** Linux and macOS. The errors were undeclared names, the same on every compiler. **Must be tested:** None. The change is to checks only. ## Risks **What could break:** nothing in the game: only `tests/` changes. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Issues See #928 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWait
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
5b286f1873
Since #928 (the FPS counter's Breakdown), recording_wait and the replay's
segment jobs, which test_fsr_uniform_ownership and test_parallel_init_order cut
from vk_replay.cpp, time their waits with an FpsRtWait of an
fps_stats::RenderPart. Neither fixture declared them, so both checks failed
to compile on every OS. Each now has a stand-in that times nothing, the
enum's values as fps_stats.h has them, ahead of the code it cuts. What the
checks assert is unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Rebased on main @ 1764fed2 (#998), now 2c967d9c. Both checks fail on main there and pass here.

Posted by an AI agent (Claude Code) for d4nkn3ss.

Rebased on main @ 1764fed2 (#998), now 2c967d9c. Both checks fail on main there and pass here. *Posted by an AI agent (Claude Code) for d4nkn3ss.*
d4nkn3ss force-pushed test/fps-rt-wait-stubs from 5b286f1873
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 2c967d9c33
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Has been cancelled
2026-11-16 01:50:55 +00:00
Compare
d4nkn3ss changed title from WIP: test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWait to test(vk): the upscaler-uniform and parallel-init fixtures know #928's FpsRtWait 2026-11-16 01:50:55 +00:00
Contributor

Linux (Arch, clang, Vulkan headers from /usr/include via LONGSHOT_VULKAN_HEADERS): run_all.py test_fsr_uniform_ownership test_parallel_init_order. On main @ 1764fed2 both fail compiling the fixtures (unknown type name 'FpsRtWait', use of undeclared identifier 'fps_stats'); on this PR @ 2c967d9c both pass. The stand-in's RenderPart matches gpu/vk/fps_stats.h's. Without LONGSHOT_VULKAN_HEADERS (no CPM cache in the checkout) run_all skips both here, which is why they didn't show as failing on this PC.

Linux (Arch, clang, Vulkan headers from /usr/include via LONGSHOT_VULKAN_HEADERS): `run_all.py test_fsr_uniform_ownership test_parallel_init_order`. On main @ 1764fed2 both fail compiling the fixtures (`unknown type name 'FpsRtWait'`, `use of undeclared identifier 'fps_stats'`); on this PR @ 2c967d9c both pass. The stand-in's `RenderPart` matches gpu/vk/fps_stats.h's. Without LONGSHOT_VULKAN_HEADERS (no CPM cache in the checkout) run_all skips both here, which is why they didn't show as failing on this PC.
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Has been cancelled
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'test/fps-rt-wait-stubs:d4nkn3ss-test/fps-rt-wait-stubs'
git switch 'd4nkn3ss-test/fps-rt-wait-stubs'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1003
No description provided.