test(build): the fake .nup extractions hold the files #863 requires of a romfs #999
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!999
Loading…
Reference in a new issue
No description provided.
Delete branch "d4nkn3ss/Longshot:test/nup-start-files"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 3080 · Needs: none
Why
Since #863,
nx2/make_game.pyrefuses a romfs read from a.nupthat lacksPack/ZsDic.pack.zs,System/Resourceor the heap definition. That is right for a player's dump. Buttest_missing_nupandtest_linux_preflightgive make_game a stand-in extraction with an empty romfs, so their cases now stop at "Your .nup file ... does not hold all of the game's files" before the step each one checks.test_missing_nupfails on main on every OS, and so do 8 oftest_linux_preflight's 9 failing cases. #863 gavetest_make_game_cacheits stand-ins and missed these two. I searched the open PRs for both names and forZsDic. #592 fixes a different cause intest_linux_preflight(the renderer profile's compile probe) and doesn't touch the romfs.What changed
Both checks' fake romfs now hold the files
make_game.ROMFS_NEEDEDlists. These are authored stand-ins, as intest_make_game_cache'sgame_files(). What each case asserts is unchanged.tests/test_missing_nup.py:game_files()fills the cached romfs thatsetUpwrites. That fixestest_existing_package_still_reuses_matching_cache.tests/test_linux_preflight.py:game_files()fills the romfs ofgame_step's fake extraction. That fixes 8 cases:test_bundled_static_ffmpeg_avoids_system_pkg_config,test_cpm_wins_over_explicit_and_system,test_cross_build_uses_windows_toolchain_not_linux_packages,test_explicit_include_roots,test_explicit_package_roots,test_missing_optional_prompt_packages_are_never_required,test_selected_work_cache_not_checkouts_defaultandtest_valid_cpm_reaches_read_then_lift.Measurements
Verdict: nothing to measure: checks only.
test_missing_nupfails on main and passes here;test_linux_preflightgoes from 9 failing cases to 1.Flags and settings
None
Testing
Tested: on Windows 11 from PowerShell, with llvm-mingw from the Longshot Builder.
cefce0d1test_missing_nup.pytest_linux_preflight.pytest_injected_toolchain_check_keeps_game_free_steps_hermetic, the profile probe that #592 fixes)run_all.pyin allAfter the run, main moved to
9f8958a5(#773) and the branch was rebased onto it (now6c1f306a). Both checks rerun there give the same results.The 17 left fail on main too:
test_auto_handheld,test_crash_dialog,test_crt_options,test_fsr_uniform_ownership,test_guest_imported,test_import_reach,test_linux_preflight,test_make_game_cache,test_pads_after_menu,test_parallel_init_order,test_pending_guest_import,test_release,test_replay_write_order,test_run_all_changed,test_tested_configurations,test_vk_occlusion_queriesandtest_walk_key. #993 fixes three, #592 fixestest_make_game_cacheand the lasttest_linux_preflightcase, #144 fixestest_releaseand #954 fixestest_run_all_changed.Not tested: Linux. The refusal and the stand-ins are plain file checks, the same on every OS. This branch together with #592 wasn't run.
Must be tested: None. The change is to checks only.
Risks
What could break: nothing in the game or the builder: only
tests/changes.Turning it off: revert the commit.
Compatibility: Nothing changes.
Issues
See #863
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
WIP: test(build): the fake .nup extractions hold the files #863 requires of a romfsto test(build): the fake .nup extractions hold the files #863 requires of a romfsView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.