fix(website): refresh the Graphics guide and document Custom HUD controls #2013

Merged
HumanBean merged 10 commits from Phishinabowl/Longshot:fix/graphics-guide-hud into main 2026-11-21 06:04:30 +00:00
Member

Summary

Continues Mooki's Graphics guide refresh. This branch preserves all of Mooki's commits, including the capture helper fixes for the banner and modular Insert menu.

The Settings guide now shows a fresh Graphics capture from main f1f2dc5b (nightly 680), with matching caption and source provenance. The website recognizes the condition shared by the nine Custom HUD sliders and Reset HUD placement. It renders the registered reset action, and the guide tests now count only generated setting disclosures and check the canonical image URLs.

The visible HUD badge includes the HOS_WIDE_UI override condition. The guide uses neutral wording for the Sprint note-wait behavior so the published Settings page passes the site's terminology audit. The capture helper reports unsupported older source layouts, checks logo dimensions before allocation, and cleans up the PNG, SDL and ImGui resources when capture fails.

Read first: docs/user/images/guide/source-review-fullscreen-monitor.md, website/src/repo-docs/graphics-settings.ts, and website/tests/hud-visibility.test.ts.

How to reproduce

On main at f1f2dc5b, run python -I -B scripts/check_guide_screenshots.py --review-sources and run npm run build from website/ after installing the locked dependencies. The guide guard reports 37 source or fixture mismatches, and Astro stops at the missing visibility condition for Hearts and magic horizontal. With this branch, the Longshot guide check passes and the Settings page builds.

Testing

Tested: Windows and Linux (WSL), using Node 24.22.2. The website build generated 20 pages, the site audit passed, and the complete Linux website suite passed 90 of 90 tests. Windows passed 89 of 90. The save ZIP fixture expects LF in Python stdout and receives CRLF on both main and this branch. The HUD regression reproduced the missing-condition error on main and passes with the fix.

The Linux SDL2 software fixture rendered Graphics at 1280×720. The guide integrity and Longshot source checks and all 14 checker regressions passed. Launcher source review was outside this capture and was reported as not checked. The Settings preview was verified in Edge at desktop and mobile widths in light and dark mode. The caption, alt text, and link to the full-size PNG were checked.

The live Graphics view was also compared on Windows using the prepared Sprint test build (game at cd57d785, renderer with the UI changes in cbfa7a18). The Graphics tab's source is unchanged between those revisions and the fixture's source f1f2dc5b. The maintainer checked the six tabs, first setting labels and order, Quality preset help and keyboard prompts against the guide image and confirmed they match. The guide image is still the nightly 680 game-free capture.

The Linux capture smoke check on the review fixes linked the modular menu, verified that the logo drew, and rendered a PNG identical to the published guide image. The guide check passed with the verified fixture hashes. The site build, site audit, 90 Linux website tests and desktop/mobile light/dark preview passed with the revised badge.

Forgejo's guide screenshot check and website build and checks both passed on d8d9edcd.

The strict game-free runner used by mise run test completed on WSL for d8d9edcd and main 2b3de5b2. Both recorded 769 passed, 119 failed and 17 skipped, with the same result for every check in the two JUnit reports. Shared failures include unavailable test tools (29 checks), GCC rejecting _Static_assert in C++ fixtures, and the 600-second limit on the million-sample vector fixture. The Windows runner stopped before producing a complete report. The focused Windows guide and website checks are recorded above. Ruff on the changed Python files and workflow actionlint passed.

Strict game-free checks that failed or timed out on both revisions
  • nx2/test_coop_spirv.py
  • nx2/test_default_point_size.py
  • nx2/test_depth_sample_types.py
  • nx2/test_draw_parameters.py
  • nx2/test_image_arrays.py
  • nx2/test_nup_codec.py
  • nx2/test_nup_read_name.py
  • nx2/test_nup_stand_in.py
  • nx2/test_nup_verify.py
  • nx2/test_spirv_struct_identity.py
  • nx2/test_texture_phi_dominance.py
  • nx2/test_unsigned_image_types.py
  • tests/test_appimage_player_build.py
  • tests/test_bug_report_defaults.py
  • tests/test_capture_read_once.py
  • tests/test_capture_readback_visibility.py
  • tests/test_check_third_party.py
  • tests/test_crash_dialog.py
  • tests/test_crash_record.py
  • tests/test_crt_options.py
  • tests/test_crt_shaders.py
  • tests/test_damage_debug_menu.py
  • tests/test_dav1d_av1.py
  • tests/test_dev_ab.py
  • tests/test_dev_packs.py
  • tests/test_device_lost_exit.py
  • tests/test_discover.py
  • tests/test_display_startup_failure.py
  • tests/test_dlss_feature_size.py
  • tests/test_draw_binds.py
  • tests/test_draw_stream_visibility.py
  • tests/test_failed_compile_keeps_objects.py
  • tests/test_flush_nothing_held.py
  • tests/test_frame_overlap.py
  • tests/test_fsr_image_retirement.py
  • tests/test_fsr_uniform_ownership.py
  • tests/test_fsr3_shaders.py
  • tests/test_fsr3fi_hud_layer.py
  • tests/test_fsr3fi_hudless_colour.py
  • tests/test_fsr4_tune.py
  • tests/test_gpu_wait_stats.py
  • tests/test_guest_imported.py
  • tests/test_high_fps_fixes.py
  • tests/test_host_guest_writes.py
  • tests/test_host_shaders.py
  • tests/test_image_reaper_threads.py
  • tests/test_insn_fixed_convert.py
  • tests/test_libc_hooks.py
  • tests/test_lift_cache.py
  • tests/test_lift_lookups.py
  • tests/test_linux_preflight.py
  • tests/test_linux_pressure.py
  • tests/test_linux_tools.py
  • tests/test_linux_update.py
  • tests/test_log_open_failure.py
  • tests/test_longshot_saves.py
  • tests/test_low_vram_texture_mips.py
  • tests/test_make_game_cache.py
  • tests/test_make_game_ngx.py
  • tests/test_menu_module_slots.py
  • tests/test_menu_modules.py
  • tests/test_menu_sections.py
  • tests/test_mesh_conv.py
  • tests/test_mesh_fallback_layout.py
  • tests/test_mesh_unreachable_outputs.py
  • tests/test_mise_build.py
  • tests/test_missing_nup.py
  • tests/test_mma_software.py
  • tests/test_mods_list.py
  • tests/test_mods_size_table.py
  • tests/test_native_float_atomic_add.py
  • tests/test_native_zstd.py
  • tests/test_ngx_sdk.py
  • tests/test_nonuniform_image_arrays.py
  • tests/test_obj_cache_size.py
  • tests/test_oot_shadow_fit.py
  • tests/test_pads_after_menu.py
  • tests/test_pass_barrier.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_play_cache.py
  • tests/test_pipelines_outlive_cache_format.py
  • tests/test_prepare_cache_save.py
  • tests/test_present_queue_default.py
  • tests/test_present_source_crop.py
  • tests/test_profiling_mode.py
  • tests/test_program_cache_cleanup.py
  • tests/test_program_cache_one_variant.py
  • tests/test_prompt_guide_lines.py
  • tests/test_prompt_hand_guides.py
  • tests/test_prompt_picture_tint.py
  • tests/test_prompt_speed.py
  • tests/test_psychov35_fsr3_fg.py
  • tests/test_readback_timeout_source.py
  • tests/test_recorder_own_idle.py
  • tests/test_recorder_sync.py
  • tests/test_reflex_swapchain_lifetime.py
  • tests/test_renderer_new_handler.py
  • tests/test_renhdrum.py
  • tests/test_replay_write_order.py
  • tests/test_sampler_admission.py
  • tests/test_settings_table.py
  • tests/test_slow_frames.py
  • tests/test_song_note_cue.py
  • tests/test_sparse_mirror.py
  • tests/test_spirv_pack.py
  • tests/test_split_giants.py
  • tests/test_sprint.py
  • tests/test_staging_burst.py
  • tests/test_target_reuse_memory.py
  • tests/test_texel_buffer_ownership.py
  • tests/test_ub_update_batch.py
  • tests/test_ui_record.py
  • tests/test_upscaler_rows.py
  • tests/test_vbytes.py (600 s timeout on both)
  • tests/test_vcore_escape.py
  • tests/test_vcore_mask0.py
  • tests/test_vendor_translation.py
  • tests/test_vk_occlusion_queries.py
  • tests/test_walk.py

Same Graphics view in the previous guide on main and the updated guide in this PR.

Still to test:

None for the guide and website behavior. Review and CI are tracked in the checklist.

Measurements

Verdict: the Longshot guide source check and website build now pass. There is no gameplay performance change to measure.

Setup: Windows site build with Node 24.22.2, Linux website tests in WSL, and a 1280×720 English Graphics capture with the SDL2 software fixture. Main 2b3de5b2 adds a save fixture to the measured baseline f1f2dc5b without changing the guide, capture fixture, Graphics menu or website.

Check Before: main @ 2b3de5b2 After: this PR @ d8d9edcd
Longshot guide source check 37 mismatches Pass
Website build Stops at the first Custom HUD slider 20 pages built
Website tests on Linux Settings tests blocked by HUD condition 90 passed

Risks

The Graphics image could drift from the live menu as the frontend changes. The guide records the capture revision and retains the source guard. The website still rejects a hidden setting without a documented condition and rejects an unregistered Graphics action. Reverting the PR restores the previous guide and website behavior.

Review follow-up

The opening review was against d5b9df01. The fixes are in 8608978a and are included in the current head.

  • L1–L4. The helper rejects older source layouts up front and the guide identifies the pinned historical fixture. The logo loader rejects oversized dimensions and pixel counts before allocation. PNG, SDL, ImGui and texture registration use scoped cleanup. The Linux smoke check covers the older-layout error and verifies native compilation, module linkage and a drawn logo in a real Graphics capture.
  • L5–L7. The visible HUD badge covers HOS_WIDE_UI. The guide records nightly 680 as the current capture, identifies the rc.8 comparison as historical and explains how to verify the Git revision and source hashes.
  • L8–L10. Measurements now records the verdict and setup. The PR explains the Sprint wording for the site audit, links both Graphics images, and records the completed live comparison and CI checks.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit. Verified a conflict-free merge against 85a59e6f. Main's intervening camera, renderer and synchronization fixes do not touch the PR's files.
  • Tested on my own PC, as Testing says. No game code changes.
  • mise run test passes (any failure that also fails on main is named). This is satisfied under the baseline-failure exception: the strict run exited 1 on both revisions, and all 119 matching failures or timeouts are named above.
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Screenshots of the same spot on main and here, for a change that shows on screen. Both guide images are linked in Testing. The live comparison passed by hand.
  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested. No runtime hardware changes apply to this PR.
  • Approved in review, every comment answered.
  • CI passes on the new head. No runtime measurements apply to the website and guide changes.
## Summary Continues [Mooki's Graphics guide refresh](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1501). This branch preserves all of Mooki's commits, including the capture helper fixes for the banner and modular Insert menu. The Settings guide now shows a fresh Graphics capture from main `f1f2dc5b` (nightly 680), with matching caption and source provenance. The website recognizes the condition shared by the nine Custom HUD sliders and Reset HUD placement. It renders the registered reset action, and the guide tests now count only generated setting disclosures and check the canonical image URLs. The visible HUD badge includes the `HOS_WIDE_UI` override condition. The guide uses neutral wording for the Sprint note-wait behavior so the published Settings page passes the site's terminology audit. The capture helper reports unsupported older source layouts, checks logo dimensions before allocation, and cleans up the PNG, SDL and ImGui resources when capture fails. Read first: `docs/user/images/guide/source-review-fullscreen-monitor.md`, `website/src/repo-docs/graphics-settings.ts`, and `website/tests/hud-visibility.test.ts`. ## How to reproduce On main at `f1f2dc5b`, run `python -I -B scripts/check_guide_screenshots.py --review-sources` and run `npm run build` from `website/` after installing the locked dependencies. The guide guard reports 37 source or fixture mismatches, and Astro stops at the missing visibility condition for Hearts and magic horizontal. With this branch, the Longshot guide check passes and the Settings page builds. ## Testing **Tested:** Windows and Linux (WSL), using Node 24.22.2. The website build generated 20 pages, the site audit passed, and the complete Linux website suite passed 90 of 90 tests. Windows passed 89 of 90. The save ZIP fixture expects LF in Python stdout and receives CRLF on both main and this branch. The HUD regression reproduced the missing-condition error on main and passes with the fix. The Linux SDL2 software fixture rendered Graphics at 1280×720. The guide integrity and Longshot source checks and all 14 checker regressions passed. Launcher source review was outside this capture and was reported as not checked. The Settings preview was verified in Edge at desktop and mobile widths in light and dark mode. The caption, alt text, and link to the full-size PNG were checked. The live Graphics view was also compared on Windows using the prepared Sprint test build (game at `cd57d785`, renderer with the UI changes in `cbfa7a18`). The Graphics tab's source is unchanged between those revisions and the fixture's source `f1f2dc5b`. The maintainer checked the six tabs, first setting labels and order, Quality preset help and keyboard prompts against the guide image and confirmed they match. The guide image is still the nightly 680 game-free capture. The Linux capture smoke check on the review fixes linked the modular menu, verified that the logo drew, and rendered a PNG identical to the published guide image. The guide check passed with the verified fixture hashes. The site build, site audit, 90 Linux website tests and desktop/mobile light/dark preview passed with the revised badge. Forgejo's [guide screenshot check](https://git.magicbean.dev/MagicBeanDev/Longshot/actions/runs/45069/jobs/0) and [website build and checks](https://git.magicbean.dev/MagicBeanDev/Longshot/actions/runs/45068/jobs/5) both passed on `d8d9edcd`. The strict game-free runner used by `mise run test` completed on WSL for `d8d9edcd` and main `2b3de5b2`. Both recorded 769 passed, 119 failed and 17 skipped, with the same result for every check in the two JUnit reports. Shared failures include unavailable test tools (29 checks), GCC rejecting `_Static_assert` in C++ fixtures, and the 600-second limit on the million-sample vector fixture. The Windows runner stopped before producing a complete report. The focused Windows guide and website checks are recorded above. Ruff on the changed Python files and workflow actionlint passed. <details> <summary>Strict game-free checks that failed or timed out on both revisions</summary> - `nx2/test_coop_spirv.py` - `nx2/test_default_point_size.py` - `nx2/test_depth_sample_types.py` - `nx2/test_draw_parameters.py` - `nx2/test_image_arrays.py` - `nx2/test_nup_codec.py` - `nx2/test_nup_read_name.py` - `nx2/test_nup_stand_in.py` - `nx2/test_nup_verify.py` - `nx2/test_spirv_struct_identity.py` - `nx2/test_texture_phi_dominance.py` - `nx2/test_unsigned_image_types.py` - `tests/test_appimage_player_build.py` - `tests/test_bug_report_defaults.py` - `tests/test_capture_read_once.py` - `tests/test_capture_readback_visibility.py` - `tests/test_check_third_party.py` - `tests/test_crash_dialog.py` - `tests/test_crash_record.py` - `tests/test_crt_options.py` - `tests/test_crt_shaders.py` - `tests/test_damage_debug_menu.py` - `tests/test_dav1d_av1.py` - `tests/test_dev_ab.py` - `tests/test_dev_packs.py` - `tests/test_device_lost_exit.py` - `tests/test_discover.py` - `tests/test_display_startup_failure.py` - `tests/test_dlss_feature_size.py` - `tests/test_draw_binds.py` - `tests/test_draw_stream_visibility.py` - `tests/test_failed_compile_keeps_objects.py` - `tests/test_flush_nothing_held.py` - `tests/test_frame_overlap.py` - `tests/test_fsr_image_retirement.py` - `tests/test_fsr_uniform_ownership.py` - `tests/test_fsr3_shaders.py` - `tests/test_fsr3fi_hud_layer.py` - `tests/test_fsr3fi_hudless_colour.py` - `tests/test_fsr4_tune.py` - `tests/test_gpu_wait_stats.py` - `tests/test_guest_imported.py` - `tests/test_high_fps_fixes.py` - `tests/test_host_guest_writes.py` - `tests/test_host_shaders.py` - `tests/test_image_reaper_threads.py` - `tests/test_insn_fixed_convert.py` - `tests/test_libc_hooks.py` - `tests/test_lift_cache.py` - `tests/test_lift_lookups.py` - `tests/test_linux_preflight.py` - `tests/test_linux_pressure.py` - `tests/test_linux_tools.py` - `tests/test_linux_update.py` - `tests/test_log_open_failure.py` - `tests/test_longshot_saves.py` - `tests/test_low_vram_texture_mips.py` - `tests/test_make_game_cache.py` - `tests/test_make_game_ngx.py` - `tests/test_menu_module_slots.py` - `tests/test_menu_modules.py` - `tests/test_menu_sections.py` - `tests/test_mesh_conv.py` - `tests/test_mesh_fallback_layout.py` - `tests/test_mesh_unreachable_outputs.py` - `tests/test_mise_build.py` - `tests/test_missing_nup.py` - `tests/test_mma_software.py` - `tests/test_mods_list.py` - `tests/test_mods_size_table.py` - `tests/test_native_float_atomic_add.py` - `tests/test_native_zstd.py` - `tests/test_ngx_sdk.py` - `tests/test_nonuniform_image_arrays.py` - `tests/test_obj_cache_size.py` - `tests/test_oot_shadow_fit.py` - `tests/test_pads_after_menu.py` - `tests/test_pass_barrier.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_play_cache.py` - `tests/test_pipelines_outlive_cache_format.py` - `tests/test_prepare_cache_save.py` - `tests/test_present_queue_default.py` - `tests/test_present_source_crop.py` - `tests/test_profiling_mode.py` - `tests/test_program_cache_cleanup.py` - `tests/test_program_cache_one_variant.py` - `tests/test_prompt_guide_lines.py` - `tests/test_prompt_hand_guides.py` - `tests/test_prompt_picture_tint.py` - `tests/test_prompt_speed.py` - `tests/test_psychov35_fsr3_fg.py` - `tests/test_readback_timeout_source.py` - `tests/test_recorder_own_idle.py` - `tests/test_recorder_sync.py` - `tests/test_reflex_swapchain_lifetime.py` - `tests/test_renderer_new_handler.py` - `tests/test_renhdrum.py` - `tests/test_replay_write_order.py` - `tests/test_sampler_admission.py` - `tests/test_settings_table.py` - `tests/test_slow_frames.py` - `tests/test_song_note_cue.py` - `tests/test_sparse_mirror.py` - `tests/test_spirv_pack.py` - `tests/test_split_giants.py` - `tests/test_sprint.py` - `tests/test_staging_burst.py` - `tests/test_target_reuse_memory.py` - `tests/test_texel_buffer_ownership.py` - `tests/test_ub_update_batch.py` - `tests/test_ui_record.py` - `tests/test_upscaler_rows.py` - `tests/test_vbytes.py` (600 s timeout on both) - `tests/test_vcore_escape.py` - `tests/test_vcore_mask0.py` - `tests/test_vendor_translation.py` - `tests/test_vk_occlusion_queries.py` - `tests/test_walk.py` </details> Same Graphics view in the [previous guide on main](https://git.magicbean.dev/MagicBeanDev/Longshot/src/commit/2b3de5b27a7745629adf7d68df882c38fca18f13/docs/user/images/guide/settings-graphics.png) and the [updated guide in this PR](https://git.magicbean.dev/MagicBeanDev/Longshot/src/commit/d8d9edcd4e7daad5636786e0683af5a9a7ff1576/docs/user/images/guide/settings-graphics.png). **Still to test:** None for the guide and website behavior. Review and CI are tracked in the checklist. ## Measurements **Verdict:** the Longshot guide source check and website build now pass. There is no gameplay performance change to measure. Setup: Windows site build with Node 24.22.2, Linux website tests in WSL, and a 1280×720 English Graphics capture with the SDL2 software fixture. Main `2b3de5b2` adds a save fixture to the measured baseline `f1f2dc5b` without changing the guide, capture fixture, Graphics menu or website. | Check | Before: main @ 2b3de5b2 | After: this PR @ d8d9edcd | | --- | --- | --- | | Longshot guide source check | 37 mismatches | Pass | | Website build | Stops at the first Custom HUD slider | 20 pages built | | Website tests on Linux | Settings tests blocked by HUD condition | 90 passed | ## Risks The Graphics image could drift from the live menu as the frontend changes. The guide records the capture revision and retains the source guard. The website still rejects a hidden setting without a documented condition and rejects an unregistered Graphics action. Reverting the PR restores the previous guide and website behavior. ## Review follow-up The [opening review](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/2013#issuecomment-63785) was against `d5b9df01`. The fixes are in `8608978a` and are included in the current head. - L1–L4. The helper rejects older source layouts up front and the guide identifies the pinned historical fixture. The logo loader rejects oversized dimensions and pixel counts before allocation. PNG, SDL, ImGui and texture registration use scoped cleanup. The Linux smoke check covers the older-layout error and verifies native compilation, module linkage and a drawn logo in a real Graphics capture. - L5–L7. The visible HUD badge covers `HOS_WIDE_UI`. The guide records nightly 680 as the current capture, identifies the rc.8 comparison as historical and explains how to verify the Git revision and source hashes. - L8–L10. Measurements now records the verdict and setup. The PR explains the Sprint wording for the site audit, links both Graphics images, and records the completed live comparison and CI checks. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. Verified a conflict-free merge against `85a59e6f`. Main's intervening camera, renderer and synchronization fixes do not touch the PR's files. - [x] Tested on my own PC, as Testing says. No game code changes. - [x] `mise run test` passes (any failure that also fails on `main` is named). This is satisfied under the baseline-failure exception: the strict run exited 1 on both revisions, and all 119 matching failures or timeouts are named above. - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. Both guide images are linked in Testing. The live comparison passed by hand. - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [x] Everything in Still to test has run, its results in Tested. - [x] Tier 1 hardware it can affect is tested. No runtime hardware changes apply to this PR. - [ ] Approved in review, every comment answered. - [x] CI passes on the new head. No runtime measurements apply to the website and guide changes.
#1629 put the Longshot logo in the menu's banner: draw_options calls ui::logo, which gpu/vk/vk_imgui.cpp defines and the
fixture does not compile, so scripts/screenshots/capture_menu.py stopped linking on main ("undefined reference to
mkwvk::ui::logo(float*)"). Before, only the start-up screen called it and the linker dropped that as unreachable.

The fixture now defines ui::logo with assets/longshot.png's pixels, decoded by libpng to straight RGBA bytes, which is what
the renderer's header holds (nx2/logo_rgba.py), as a colour texture its SDL renderer uploads like the font atlas. The helper
passes the picture's path to the fixture and records assets/longshot.png among the capture inputs, so the compiler-found list
and the review record name it and a changed logo asks for a review. Rendering 310e7c9df (before #1629) with main's
fixture and with the new one gives byte-identical PNGs: nothing a source without the logo draws changes.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
The guide-screenshot check is red on main: 22 of settings-graphics.png's recorded sources changed since #1466,
gpu/vk/vk_vendor.h was deleted (#1390) and the capture fixture changed (#1486). The first Graphics view the helper renders
from main differs from the published picture in rows 0 to 54 only: the tab strip lists the NFC tab (#280) and is spaced for
six, and #1629 moved the banner (the Longshot logo and name at the left of the tabs, the version at the right). Every row,
value, help sentence, button prompt and the scrollbar below it is pixel-identical from 415a8944c (the last commit the check
passed on) to main now.

So the picture is replaced by the render of v3.0.0-rc.8 (2f1c0c9c1), and its record advances with it: the image hash, the
capture revision, version, date and toolchain, the compiler-found source list (77 files: vk_vendor.h gone, assets/longshot.png
new), the review revision (the SHA-256 of the sorted path=hash lines) with the hashes of the tree after #1675, and the fixture
hashes. source-review-fullscreen-monitor.md records the comparison and a line for each recorded input and why it does or
does not change the picture; the caption and the README's provenance line name the new capture.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Retained, not recaptured: after main moved to abd4894a6 the check named six recorded sources of settings-graphics.png (upscaler_rows.h, vk_api.h, vk_internal.h, vk_menu.cpp, vk_menu.h, vk_temporal.h: #1678, #1701, #919, #902, #1502) and the fixture, which frees its logo texture on a read error now. The new DLAA before the bloom row (#1678) is hidden in the fixture (dlss_why() is DLSS_NOT_BUILT); the Graphics view rendered from 1013b4347 differs from the published picture in 444 pixels, x 1184 to 1261, y 25 to 35, the version text only, and the fixture renders 2f1c0c9c1 byte-identically to the picture. The capture revision, the PNG and the capture inputs are unchanged.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Retained, not recaptured: after the rebase onto main a433db328 the check named eight recorded sources of settings-graphics.png (longshot_env.h, device_policy.h, menu_i18n.h, vk_api.h, vk_internal.h, vk_menu.cpp, vk_menu.h, vk_recorder.h: #134, #405, #755, #980, #1556, #1586, #1590). The Mods tab (#134) is listed only when the host has mods and the fixture has no host, so the tab strip is still six tabs; #405 reworks the Controls tab's rows only. The maintained helper's Graphics view of this branch differs from the published picture in 1109 of 921,600 pixels, all inside x 1065 to 1261, y 25 to 38, the build's version text; the helper's compiler pass lists no new or dropped input. The capture revision, the PNG and the fixture are unchanged.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
The Insert menu's rows are now in feature modules (gpu/vk/menu/*.cpp) described through the model (gpu/vk/menu_model.cpp), and the
menu's headers are found beside gpu/vk. The helper compiles the model and every module with the fixture, draws the rows from the
model's table (std::size(rows) in place of the removed row count), gives the modules' renderer hooks stand-ins that do nothing
(no window, no device, no listed file, no bug report) and fails closed where a module would list a folder or post to a window.
The fixture's host is empty but for an idle NFC scan: the Scan row asks the host whether a scan is under way until its text says
no more, which a missing host never did.

The helper's render of this tree differs from the published Graphics picture in 308 of 921,600 pixels, all inside x 1207 to 1261,
y 25 to 38, the banner's version text.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
docs(guides): the Graphics guide image is retained after #1633, #1802 and the helper's module build
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Website build and checks (pull_request) Failing after 4m42s
beanstalk/approval approved by mooki (reviewed)
beanstalk/any 1/1 pass
cd012b899b
Retained, not recaptured: after the rebase onto main 068fb8ebe2 the check named 21 recorded sources and the fixture. #1802's comments-only sweep changed 20 headers (code unchanged, compared with comments stripped); #1633 moved the Insert menu's rows into 41 modules and a model, which join the record (44 files, none leave). The helper, which no longer linked, builds the model and the modules; its render of this tree differs from the published picture in 308 of 921,600 pixels, all inside x 1207 to 1261, y 25 to 38, the banner's version text. The reviewed-source hashes, the fixture hashes and the review revision advance; the capture revision and the PNG are unchanged.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
fix(website): publish current Graphics guide and Custom HUD settings
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 15s
PR description / Description follows the template (pull_request_target) Successful in 19s
CI / Workflow lint (actionlint) (pull_request) Successful in 18s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 18s
Third-party parts / As their notes say (pull_request) Successful in 14s
CI / Website build and checks (pull_request) Successful in 3m9s
d5b9df0195
Recapture Graphics on current main and record the source and preview checks. Document the Custom HUD condition, render the registered reset action, and correct the website guide assertions.

Validated the combined site build and audit, 90 Linux website tests, and the Longshot guide screenshot check. The live Graphics comparison is still pending.

Assisted-by: OpenAI Codex

Co-Authored-By: OpenAI Codex <[email protected]>
Member

Possibly related, for context:

  • PR #1585 feat(menu): add a 45 FPS game frame rate cap — Open Graphics-menu change also updates/reviews the Graphics guide illustration; possible image/manifest overlap.
Possibly related, for context: - PR #1585 feat(menu): add a 45 FPS game frame rate cap — Open Graphics-menu change also updates/reviews the Graphics guide illustration; possible image/manifest overlap.
BeanBot left a comment

Recommendation: Request changes. The reported checks show the Settings page builds and the guide source check passes. The capture helper breaks the documented workflow for comparing older revisions, and the new logo loader needs a dimension check before allocating pixels.

Players get a newer Graphics illustration and can look up all nine Custom HUD sliders and Reset HUD placement on the Settings page. The fixture now builds the same menu modules as Longshot, which improves fidelity and adds maintenance work whenever those modules gain renderer dependencies.

@fix will do (9)

  1. L1 scripts/screenshots/capture_menu.py:46: The helper unconditionally compiles menu_model.cpp and its C++ fixture assumes the modular row table. (more on the line)
  2. L2 scripts/screenshots/menu.cpp:152: The decoded PNG dimensions go straight into ImTextureData::Create, which multiplies width, height and four bytes per pixel as signed ints. (more on the line)
  3. L3 scripts/screenshots/capture_menu.py:72: The reported checker regressions verify recorded files and hashes. They would still pass if the module inputs were omitted from the compile or the fixture lost its logo hook. Add a game-free smoke check for the Linux capture helper that links and renders the Graphics view in a temporary directory, honors the selected compiler, and fails if either fixture fix is undone.
  4. L4 (minor) scripts/screenshots/menu.cpp:149: A missing or corrupt logo now throws after SDL, the surface, the renderer and ImGui have initialized. (more on the line)
  5. L5 (minor) website/src/repo-docs/graphics-settings.ts:25: The visible badge omits the HOS_WIDE_UI condition. (more on the line)
  6. L6 docs/user/images/guide/README.md:13: The provenance section identifies rc.8 at 2f1c0c9c as the current Graphics capture. (more on the line)
  7. L7 (minor) docs/user/images/guide/manifest.json:957: The README says reviewed_source.revision is the SHA-256 of the sorted file/hash pairs, but this entry stores the Git commit. (more on the line)
  8. L8: The Measurements section has a comparison table without the template’s Verdict or Setup, and Still to test leaves the manual comparison and CI as prose entries without the required runner format. Add the verdict and setup, assign the live comparison to a maintainer by hand with an expected result, and track pending CI in its checklist box.
  9. L9 (minor) docs/user/graphics-and-controls.md:268: The Sprint wording also changes, but the summary gives no reason for it. (more on the line)

For the author (1) (a run, a measurement or a decision)

  • L10 (minor) docs/user/images/guide/source-review-fullscreen-monitor.md:246: The current record compares the new PNG with the proposed rc.8 fixture image. (more on the line)

Checks: Still running: PR description / Description follows the template (pull_request_target), CI / Conventional Commit title (pull_request), CI / Workflow lint (actionlint) (pull_request), CI / Website build and checks (pull_request).

More: does it help, other systems, switches, what was read

Does it help: Yes. The PR reports 37 guide source or fixture mismatches on f1f2dc5b and a passing local source check on d5b9df01. Astro goes from stopping at the first HUD slider to building 20 pages, with 90 of 90 Linux website tests and 89 of 90 on Windows. The Windows failure is reported on both revisions. The live menu comparison remains open.

Other systems: The shared Graphics PNG changes in the repository guide and on the website. The optional Linux fixture also serves Audio, Controls and the focused Fullscreen view, and the current-head report describes a Graphics capture. The launcher images and their records are unchanged, and Launcher source review was skipped. Steam Deck, GPU vendors, drivers, saves, audio, input and game builds use unchanged runtime code.

Switches: No switch or option changes. The guide documents the existing HOS_WIDE_UI override. An unset or empty value leaves control with the HUD layout row, which defaults to Screen’s edges.

Reviewed: d5b9df0195 against f1f2dc5bd2: Read AGENTS.md, CONTRIBUTING.md, the Forgejo template, the developer standards, the range log and all 11 file diffs. Read the changed Python, C++ and TypeScript files and tests in full and traced their menu, ImGui, website and screenshot-checker dependencies. Read the guide README and capture review, inspected the changed guide passages and PNG, and skimmed manifest fingerprints and recorded runs. The adjacent Tooling checkout and docs/review-checklist.md were absent.; nothing run (a code review).

Checked and fine:

  • The current menu source uses the same visibility predicate for all nine sliders and Reset HUD placement. The new HUD test exercises the catalogue and rejects a missing condition or a substituted reset callback.
  • The disclosure count targets generated settings cards, and the image test checks the rendered image and full-size link at the canonical URL.
  • The PNG and both fixture files match their recorded SHA-256 hashes. The inspected capture uses bundled UI fonts, repository branding and a synthetic background.
  • The fixture draws on one thread and uses the menu model’s guarded initialization. No thread ownership, renderer API, shader, generated header or third-party changes were found.
  • The AI-assisted commits include attribution trailers.

Testing: Read-only review. The diff whitespace check passed. Website, browser and fixture results are author-reported. The full repository suite, the current-head default Audio and Controls captures, the live Graphics comparison and the listed CI checks have no completed result in the supplied record.

Overlaps and merge order: The description identifies #1501 as the predecessor whose commits are included here. This branch carries that work, so there is no prerequisite merge order with #1501.


Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The reported checks show the Settings page builds and the guide source check passes. The capture helper breaks the documented workflow for comparing older revisions, and the new logo loader needs a dimension check before allocating pixels. Players get a newer Graphics illustration and can look up all nine Custom HUD sliders and Reset HUD placement on the Settings page. The fixture now builds the same menu modules as Longshot, which improves fidelity and adds maintenance work whenever those modules gain renderer dependencies. **`@fix` will do (9)** 1. **L1** `scripts/screenshots/capture_menu.py:46`: The helper unconditionally compiles menu_model.cpp and its C++ fixture assumes the modular row table. (more on the line) 2. **L2** `scripts/screenshots/menu.cpp:152`: The decoded PNG dimensions go straight into ImTextureData::Create, which multiplies width, height and four bytes per pixel as signed ints. (more on the line) 3. **L3** `scripts/screenshots/capture_menu.py:72`: The reported checker regressions verify recorded files and hashes. They would still pass if the module inputs were omitted from the compile or the fixture lost its logo hook. Add a game-free smoke check for the Linux capture helper that links and renders the Graphics view in a temporary directory, honors the selected compiler, and fails if either fixture fix is undone. 4. **L4** (minor) `scripts/screenshots/menu.cpp:149`: A missing or corrupt logo now throws after SDL, the surface, the renderer and ImGui have initialized. (more on the line) 5. **L5** (minor) `website/src/repo-docs/graphics-settings.ts:25`: The visible badge omits the HOS_WIDE_UI condition. (more on the line) 6. **L6** `docs/user/images/guide/README.md:13`: The provenance section identifies rc.8 at 2f1c0c9c as the current Graphics capture. (more on the line) 7. **L7** (minor) `docs/user/images/guide/manifest.json:957`: The README says reviewed_source.revision is the SHA-256 of the sorted file/hash pairs, but this entry stores the Git commit. (more on the line) 8. **L8**: The Measurements section has a comparison table without the template’s Verdict or Setup, and Still to test leaves the manual comparison and CI as prose entries without the required runner format. Add the verdict and setup, assign the live comparison to a maintainer by hand with an expected result, and track pending CI in its checklist box. 9. **L9** (minor) `docs/user/graphics-and-controls.md:268`: The Sprint wording also changes, but the summary gives no reason for it. (more on the line) **For the author (1)** (a run, a measurement or a decision) - **L10** (minor) `docs/user/images/guide/source-review-fullscreen-monitor.md:246`: The current record compares the new PNG with the proposed rc.8 fixture image. (more on the line) **Checks:** Still running: `PR description / Description follows the template (pull_request_target)`, `CI / Conventional Commit title (pull_request)`, `CI / Workflow lint (actionlint) (pull_request)`, `CI / Website build and checks (pull_request)`. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes. The PR reports 37 guide source or fixture mismatches on f1f2dc5b and a passing local source check on d5b9df01. Astro goes from stopping at the first HUD slider to building 20 pages, with 90 of 90 Linux website tests and 89 of 90 on Windows. The Windows failure is reported on both revisions. The live menu comparison remains open. **Other systems:** The shared Graphics PNG changes in the repository guide and on the website. The optional Linux fixture also serves Audio, Controls and the focused Fullscreen view, and the current-head report describes a Graphics capture. The launcher images and their records are unchanged, and Launcher source review was skipped. Steam Deck, GPU vendors, drivers, saves, audio, input and game builds use unchanged runtime code. **Switches:** No switch or option changes. The guide documents the existing HOS_WIDE_UI override. An unset or empty value leaves control with the HUD layout row, which defaults to Screen’s edges. **Reviewed:** d5b9df019572 against f1f2dc5bd282: Read AGENTS.md, CONTRIBUTING.md, the Forgejo template, the developer standards, the range log and all 11 file diffs. Read the changed Python, C++ and TypeScript files and tests in full and traced their menu, ImGui, website and screenshot-checker dependencies. Read the guide README and capture review, inspected the changed guide passages and PNG, and skimmed manifest fingerprints and recorded runs. The adjacent Tooling checkout and docs/review-checklist.md were absent.; nothing run (a code review). **Checked and fine:** - The current menu source uses the same visibility predicate for all nine sliders and Reset HUD placement. The new HUD test exercises the catalogue and rejects a missing condition or a substituted reset callback. - The disclosure count targets generated settings cards, and the image test checks the rendered image and full-size link at the canonical URL. - The PNG and both fixture files match their recorded SHA-256 hashes. The inspected capture uses bundled UI fonts, repository branding and a synthetic background. - The fixture draws on one thread and uses the menu model’s guarded initialization. No thread ownership, renderer API, shader, generated header or third-party changes were found. - The AI-assisted commits include attribution trailers. **Testing:** Read-only review. The diff whitespace check passed. Website, browser and fixture results are author-reported. The full repository suite, the current-head default Audio and Controls captures, the live Graphics comparison and the listed CI checks have no completed result in the supplied record. **Overlaps and merge order:** The description identifies #1501 as the predecessor whose commits are included here. This branch carries that work, so there is no prerequisite merge order with #1501. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
@ -266,3 +266,3 @@
without the roll. Hold <kbd>Shift</kbd> while you move, or on a controller hold the left stick pressed in; let go and
he moves as before. He runs past people, signs and pots without talking, reading or picking up; tap A to roll or
act as usual. While the ocarina waits for a note, Sprint does nothing. Turning the row on moves <kbd>Shift</kbd> from B
act as usual. Sprint is disabled while the instrument is waiting for a note. Turning the row on moves <kbd>Shift</kbd> from B
Member

L9 (minor): The Sprint wording also changes, but the summary gives no reason for it. The website audit rejects the old instrument name in the published page, so identify this edit as part of restoring publication.

**L9** (minor): The Sprint wording also changes, but the summary gives no reason for it. The website audit rejects the old instrument name in the published page, so identify this edit as part of restoring publication.
@ -11,3 +11,3 @@
source hashes. All six launcher images are UI-only captures built from Launcher nightly-52-b1d9f7a9 source
`b1d9f7a9b19fa99b91ec3e8cd24455d4703d6d25`; they replace the earlier official-AppImage and rc.3 fixture captures.
The Graphics image is recaptured from fullscreen monitor PR #1277, `54d25c79ead4d07e22cdcf5f07e481e19f90f78c`, on main `e335bd5c`.
The Graphics image is recaptured from main `2f1c0c9c19ce922a9d86dc95c3f56653340d70c3` (v3.0.0-rc.8), after the NFC tab (#280) joined the menu's tab strip and #1629 moved its banner; its earlier capture, from fullscreen monitor PR #1277 (`54d25c79`), remains in repository history.
Member

L6: The provenance section identifies rc.8 at 2f1c0c9c as the current Graphics capture. The committed PNG, caption and manifest identify nightly 680 at f1f2dc5b. Name f1f2dc5b here and identify the rc.8 sections in the linked review as historical comparisons.

**L6**: The provenance section identifies rc.8 at 2f1c0c9c as the current Graphics capture. The committed PNG, caption and manifest identify nightly 680 at f1f2dc5b. Name f1f2dc5b here and identify the rc.8 sections in the linked review as historical comparisons.
@ -897,3 +955,3 @@
"reviewed_source": {
"repository": "https://git.magicbean.dev/MagicBeanDev/Longshot",
"revision": "sha256:4179c3f3d6f121635148401ca32b40133749c113f3ceb4032215aae45e54316b",
"revision": "f1f2dc5bd2821cef061798ba40a043d281ac1707",
Member

L7 (minor): The README says reviewed_source.revision is the SHA-256 of the sorted file/hash pairs, but this entry stores the Git commit. A maintainer following that verification instruction cannot reproduce the recorded value. Record the source-map digest here or document that this review uses the exact main commit and explain how to verify it.

**L7** (minor): The README says reviewed_source.revision is the SHA-256 of the sorted file/hash pairs, but this entry stores the Git commit. A maintainer following that verification instruction cannot reproduce the recorded value. Record the source-map digest here or document that this review uses the exact main commit and explain how to verify it.
@ -116,0 +243,4 @@
The game-free fixture rendered the first Graphics view at 1280×720 from main `f1f2dc5b` (nightly 680). Compared with the previous proposed rc.8 image, 61,552 of 921,600 pixels differ. The visible setting labels, values, Quality preset help and keyboard commands still match. The banner version, scrollbar and layout pixels changed, so the guide uses the new capture and its matching caption.
The manifest records the compiler-discovered source files and fixture hashes for this capture. This review uses the SDL2 software renderer and bundled fonts. The in-game Graphics comparison remains pending.
Member

L10 (minor): The current record compares the new PNG with the proposed rc.8 fixture image. The pending live comparison still needs to confirm the visible rows, selected help and keyboard and tab prompts at the corresponding menu scale, and record any differences due to hardware or the synthetic defaults.

**L10** (minor): The current record compares the new PNG with the proposed rc.8 fixture image. The pending live comparison still needs to confirm the visible rows, selected help and keyboard and tab prompts at the corresponding menu scale, and record any differences due to hardware or the synthetic defaults.
@ -45,2 +44,3 @@
'-I' + str(source), '-I' + str(source / 'gpu/vk'), '-I' + str(source / 'host/posix'), '-I' + str(source / 'gpu/vk/compat'),
'-I' + str(source / 'third_party/imgui'), '-I' + str(args.vulkan_headers.resolve()),
str(Path(__file__).with_name('menu.cpp')), str(source / 'gpu/vk/vk_menu_i18n.cpp')]
str(Path(__file__).with_name('menu.cpp')), str(source / 'gpu/vk/vk_menu_i18n.cpp'), str(source / 'gpu/vk/menu_model.cpp')]
Member

L1: The helper unconditionally compiles menu_model.cpp and its C++ fixture assumes the modular row table. Pointing the documented --source option at v3.0.0-rc.8 fails because that checkout has no menu_model.cpp. Preserve the cross-revision workflow with a compatible fixture for each layout, or reject pre-module sources up front and document which pinned helper to use for each side.

**L1**: The helper unconditionally compiles menu_model.cpp and its C++ fixture assumes the modular row table. Pointing the documented --source option at v3.0.0-rc.8 fails because that checkout has no menu_model.cpp. Preserve the cross-revision workflow with a compatible fixture for each layout, or reject pre-module sources up front and document which pinned helper to use for each side.
@ -119,0 +146,4 @@
{ // The banner's logo: the repository's own picture, decoded to straight RGBA bytes, as the renderer's header holds it.
png_image logo{};
logo.version = PNG_IMAGE_VERSION;
if (!png_image_begin_read_from_file(&logo, argv[2])) throw std::runtime_error(logo.message);
Member

L4 (minor): A missing or corrupt logo now throws after SDL, the surface, the renderer and ImGui have initialized. The catch exits without running their shutdown, and failures after texture registration also bypass the logo cleanup. Give those resources scoped ownership so each successful init is unwound and the logo is unregistered before destroying the ImGui context.

**L4** (minor): A missing or corrupt logo now throws after SDL, the surface, the renderer and ImGui have initialized. The catch exits without running their shutdown, and failures after texture registration also bypass the logo cleanup. Give those resources scoped ownership so each successful init is unwound and the logo is unregistered before destroying the ImGui context.
@ -119,0 +149,4 @@
if (!png_image_begin_read_from_file(&logo, argv[2])) throw std::runtime_error(logo.message);
logo.format = PNG_FORMAT_RGBA;
auto* texture = IM_NEW(ImTextureData)();
texture->Create(ImTextureFormat_RGBA32, int(logo.width), int(logo.height));
Member

L2: The decoded PNG dimensions go straight into ImTextureData::Create, which multiplies width, height and four bytes per pixel as signed ints. A 32,768 by 32,768 replacement logo overflows that calculation before libpng decodes the pixels. Check both dimensions and the RGBA byte count before narrowing or allocating, and reject an oversized logo with a clear error.

**L2**: The decoded PNG dimensions go straight into ImTextureData::Create, which multiplies width, height and four bytes per pixel as signed ints. A 32,768 by 32,768 replacement logo overflows that calculation before libpng decodes the pixels. Check both dimensions and the RGBA byte count before narrowing or allocating, and reject an oversized logo with a clear error.
@ -22,6 +22,7 @@ export const BADGES = [
{ test: /\bshown with NVIDIA DLSS\b/i, label: 'With NVIDIA DLSS', shown: true },
{ test: /\bshown while Frame generation is on\b/i, label: 'While Frame generation is on', shown: true },
{ test: /\bshown with a CRT filter on\b/i, label: 'With a CRT filter on', shown: true },
{ test: /\bshown with HUD layout set to Custom and no `HOS_WIDE_UI` override\b/i, label: 'With HUD layout set to Custom', shown: true },
Member

L5 (minor): The visible badge omits the HOS_WIDE_UI condition. A player whose saved HUD layout is Custom and whose longshot_env.txt still sets HOS_WIDE_UI=0 sees a badge implying Reset HUD placement is available, while the only caveat is inside its collapsed disclosure. Put both conditions in the visible badge and assert the rendered text.

**L5** (minor): The visible badge omits the HOS_WIDE_UI condition. A player whose saved HUD layout is Custom and whose longshot_env.txt still sets HOS_WIDE_UI=0 sees a badge implying Reset HUD placement is available, while the only caveat is inside its collapsed disclosure. Put both conditions in the visible badge and assert the rendered text.
Document the older capture helper, check logo dimensions before allocation, and unwind PNG, SDL and ImGui resources on failure. Smoke-test the Graphics render and record the unchanged screenshot. Show the HUD override condition on every affected website badge.

Assisted-by: OpenAI Codex

Co-Authored-By: OpenAI Codex <[email protected]>
chore: sync Graphics guide review with main
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 22s
CI / Workflow lint (actionlint) (pull_request) Successful in 30s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 32s
Third-party parts / As their notes say (pull_request) Successful in 36s
CI / Website build and checks (pull_request) Successful in 4m15s
PR description / Description follows the template (pull_request_target) Successful in 19s
d8d9edcd4e
Phishinabowl changed title from WIP: fix(website): refresh the Graphics guide and document Custom HUD controls to fix(website): refresh the Graphics guide and document Custom HUD controls 2026-11-21 06:01:14 +00:00
llun approved these changes 2026-11-21 06:03:31 +00:00
Dismissed
llun scheduled this pull request to auto merge when all checks succeed 2026-11-21 06:03:34 +00:00
llun approved these changes 2026-11-21 06:03:47 +00:00
HumanBean deleted branch fix/graphics-guide-hud 2026-11-21 06:04:30 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2013
No description provided.