fix(vk): NVIDIA DLAA before the bloom is off by default (RX_VK_DLSS_PRE_BLOOM=1 turns it on) #1675

Merged
llun merged 1 commit from pmwork-personal/Longshot:fix/dlss-pre-bloom-opt-in into main 2026-11-18 23:41:58 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11, RTX 5080 and RTX 4070 Super (players, RX_VK_DLSS_PRE_BLOOM=0 on v3.0.0-rc.8) · Needs: Windows, NVIDIA RTX (a by-hand check)

TL;DR

Since v3.0.0-rc.8, with NVIDIA DLAA, players see the game's camera turn under Link and look up when they move it down.
It comes from #1652's new order (DLAA before the game's bloom and tone map, on by default with DLAA): players report that
RX_VK_DLSS_PRE_BLOOM=0, or a Render resolution below 100%, makes it go away. The cause is not yet found, so this PR makes
that order opt-in: DLAA is back after the bloom and the tone map by default, and RX_VK_DLSS_PRE_BLOOM=1 turns the new
order on for testing.

Breakdown

  • Who it helps: players on an NVIDIA RTX card with the Upscaler on DLAA.
  • What was wrong: with DLAA before the bloom (#1652), the game's camera turns under Link as it moves down; why is not yet known.
  • What changes: RX_VK_DLSS_PRE_BLOOM is off by default; =1 turns the new order on.
  • What does not change: DLAA itself, DLSS's upscaling modes, FSR, XeSS, frame generation; the new order with =1.
  • How it was checked: players on v3.0.0-rc.8 ran with RX_VK_DLSS_PRE_BLOOM=0, the behaviour this PR makes the default, and the camera behaved; no run of this commit, at the person I work for's request.
  • What is still open: the cause of the camera turn with the new order on (#1672).
  • Risk: low: unset now gives the order every release before rc.8 had.

Why

With #1652 the default with DLAA moved DLSS before the game's bloom and tone map. On v3.0.0-rc.8 players see the camera go
under Link and look straight up as they move it down (an RTX 5080 in Castle Town's market at night, an RTX 4070 Super in
the forest). RX_VK_DLSS_PRE_BLOOM=0 and a Render resolution below 100% (which never takes the new order) both fix it.
Until the cause is found, the old order should be the default. See #1672.

How to reproduce

Seen on: Windows 11, NVIDIA GeForce RTX 5080, driver 621.24 (and an RTX 4070 Super, driver not given)
Settings and switches: Upscaler NVIDIA DLSS, Render resolution Native (DLAA); RX_VK_DLSS_PRE_BLOOM unset
Steps: v3.0.0-rc.8, in play outdoors (Castle Town's market at night), move the camera down with the right stick
Expected: the camera stops behind Link
Actual: the camera goes under Link and turns to look straight up; with RX_VK_DLSS_PRE_BLOOM=0 it stops as expected

What changed

RX_VK_DLSS_PRE_BLOOM now turns the new order on with =1 only; unset or 0, DLAA runs at the gameplay upscale, after the
bloom and the tone map.

  • renderer: pre_bloom_wanted() in gpu/vk/vk_temporal.cpp reads RX_VK_DLSS_PRE_BLOOM == 1, and its log line says how to turn it on; the comments in vk_temporal.cpp and vk_temporal.h say it is off by default and why.
  • switches: gpu/vk/switches.def's row is an attempt (off unless set), and docs/development.md says the same.
  • tests: tests/test_dlss_pre_bloom.py checks the new default and the row's kind.

Measurements

Verdict: nothing to measure: this PR changes a default back to the order every release before v3.0.0-rc.8 used.

Flags and settings

Changes the default of RX_VK_DLSS_PRE_BLOOM.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
RX_VK_DLSS_PRE_BLOOM where NVIDIA DLAA runs unset: before the bloom and tone map; =0 after unset or =0: after the bloom and tone map; =1 before with DLAA, unset is the order before #1652 again helps: players report the camera turn gone with =0 (#1672) unset for everyone; =1 only to test the cause

Testing

Tested: not by me, at the request of the person I work for: players on v3.0.0-rc.8 (Windows 11; RTX 5080 with driver 621.24, and an RTX 4070 Super) ran with RX_VK_DLSS_PRE_BLOOM=0, which is what this PR makes the default, and report the camera turn gone. The order with =0 is #1652's, tested there on an RTX 5090.

Not tested: this commit in the game, and the game-free checks (tests/test_dlss_pre_bloom.py reads the changed lines); both at the request of the person I work for, to get the stopgap out.

Must be tested:

  • Windows, NVIDIA RTX, by hand: a build with this PR, Upscaler on DLAA, RX_VK_DLSS_PRE_BLOOM unset, move the camera down outdoors, expecting it to stop behind Link and the log to say NVIDIA DLAA after the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=1: before them) (by hand: any tester with an RTX card)

Risks

What could break: nothing new: unset gives DLAA at the gameplay upscale, as before #1652.

Turning it off: RX_VK_DLSS_PRE_BLOOM=1 turns the new order on again; reverting the commit makes it the default again.

Compatibility: Nothing changes: no save, options file, cache or ABI change.

Issues

See #1672

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.

The two unticked boxes are on purpose: no in-game run of this commit and no test run, at the request of the person I work
for, to get the stopgap out; players' runs with RX_VK_DLSS_PRE_BLOOM=0 stand in for the first.

Co-Authored-By: Claude Opus 5.5 [email protected]

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 5080 and RTX 4070 Super (players, `RX_VK_DLSS_PRE_BLOOM=0` on v3.0.0-rc.8) · **Needs:** Windows, NVIDIA RTX (a by-hand check) ## TL;DR Since v3.0.0-rc.8, with NVIDIA DLAA, players see the game's camera turn under Link and look up when they move it down. It comes from #1652's new order (DLAA before the game's bloom and tone map, on by default with DLAA): players report that `RX_VK_DLSS_PRE_BLOOM=0`, or a Render resolution below 100%, makes it go away. The cause is not yet found, so this PR makes that order opt-in: DLAA is back after the bloom and the tone map by default, and `RX_VK_DLSS_PRE_BLOOM=1` turns the new order on for testing. ## Breakdown - **Who it helps:** players on an NVIDIA RTX card with the Upscaler on DLAA. - **What was wrong:** with DLAA before the bloom (#1652), the game's camera turns under Link as it moves down; why is not yet known. - **What changes:** `RX_VK_DLSS_PRE_BLOOM` is off by default; `=1` turns the new order on. - **What does not change:** DLAA itself, DLSS's upscaling modes, FSR, XeSS, frame generation; the new order with `=1`. - **How it was checked:** players on v3.0.0-rc.8 ran with `RX_VK_DLSS_PRE_BLOOM=0`, the behaviour this PR makes the default, and the camera behaved; no run of this commit, at the person I work for's request. - **What is still open:** the cause of the camera turn with the new order on (#1672). - **Risk:** low: unset now gives the order every release before rc.8 had. ## Why With #1652 the default with DLAA moved DLSS before the game's bloom and tone map. On v3.0.0-rc.8 players see the camera go under Link and look straight up as they move it down (an RTX 5080 in Castle Town's market at night, an RTX 4070 Super in the forest). `RX_VK_DLSS_PRE_BLOOM=0` and a Render resolution below 100% (which never takes the new order) both fix it. Until the cause is found, the old order should be the default. See #1672. ## How to reproduce **Seen on:** Windows 11, NVIDIA GeForce RTX 5080, driver 621.24 (and an RTX 4070 Super, driver not given) **Settings and switches:** Upscaler NVIDIA DLSS, Render resolution Native (DLAA); `RX_VK_DLSS_PRE_BLOOM` unset **Steps:** v3.0.0-rc.8, in play outdoors (Castle Town's market at night), move the camera down with the right stick **Expected:** the camera stops behind Link **Actual:** the camera goes under Link and turns to look straight up; with `RX_VK_DLSS_PRE_BLOOM=0` it stops as expected ## What changed `RX_VK_DLSS_PRE_BLOOM` now turns the new order on with `=1` only; unset or `0`, DLAA runs at the gameplay upscale, after the bloom and the tone map. - renderer: `pre_bloom_wanted()` in `gpu/vk/vk_temporal.cpp` reads `RX_VK_DLSS_PRE_BLOOM == 1`, and its log line says how to turn it on; the comments in `vk_temporal.cpp` and `vk_temporal.h` say it is off by default and why. - switches: `gpu/vk/switches.def`'s row is an `attempt` (off unless set), and `docs/development.md` says the same. - tests: `tests/test_dlss_pre_bloom.py` checks the new default and the row's kind. ## Measurements **Verdict:** nothing to measure: this PR changes a default back to the order every release before v3.0.0-rc.8 used. ### Flags and settings Changes the default of `RX_VK_DLSS_PRE_BLOOM`. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `RX_VK_DLSS_PRE_BLOOM` | where NVIDIA DLAA runs | unset: before the bloom and tone map; `=0` after | unset or `=0`: after the bloom and tone map; `=1` before | with DLAA, unset is the order before #1652 again | helps: players report the camera turn gone with `=0` (#1672) | unset for everyone; `=1` only to test the cause | ## Testing **Tested:** not by me, at the request of the person I work for: players on v3.0.0-rc.8 (Windows 11; RTX 5080 with driver 621.24, and an RTX 4070 Super) ran with `RX_VK_DLSS_PRE_BLOOM=0`, which is what this PR makes the default, and report the camera turn gone. The order with `=0` is #1652's, tested there on an RTX 5090. **Not tested:** this commit in the game, and the game-free checks (`tests/test_dlss_pre_bloom.py` reads the changed lines); both at the request of the person I work for, to get the stopgap out. **Must be tested:** - Windows, NVIDIA RTX, by hand: a build with this PR, Upscaler on DLAA, `RX_VK_DLSS_PRE_BLOOM` unset, move the camera down outdoors, expecting it to stop behind Link and the log to say `NVIDIA DLAA after the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=1: before them)` (by hand: any tester with an RTX card) ## Risks **What could break:** nothing new: unset gives DLAA at the gameplay upscale, as before #1652. **Turning it off:** `RX_VK_DLSS_PRE_BLOOM=1` turns the new order on again; reverting the commit makes it the default again. **Compatibility:** Nothing changes: no save, options file, cache or ABI change. ## Issues See #1672 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [ ] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. The two unticked boxes are on purpose: no in-game run of this commit and no test run, at the request of the person I work for, to get the stopgap out; players' runs with `RX_VK_DLSS_PRE_BLOOM=0` stand in for the first. Co-Authored-By: Claude Opus 5.5 <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(vk): NVIDIA DLAA before the bloom is off by default (RX_VK_DLSS_PRE_BLOOM=1 turns it on)
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Failing after 10s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 13s
Third-party parts / As their notes say (pull_request) Successful in 14s
Website / Website on Cloudflare (pull_request_target) Has been skipped
400ef7cae0
With #1652's order on (DLAA before the game's bloom and tone map, the
default with DLAA since v3.0.0-rc.8), players saw the game's camera turn
under Link and look up. RX_VK_DLSS_PRE_BLOOM=0, or a Render resolution
below 100% (which never takes that order), fixes it. Its cause is not yet
found, so the order is now opt-in: RX_VK_DLSS_PRE_BLOOM=1 turns it on.
Unset, DLAA runs at the gameplay upscale, after the bloom and the tone
map, as before #1652.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
llun approved these changes 2026-11-18 23:41:54 +00:00
llun merged commit 5e33d3b71a into main 2026-11-18 23:41:58 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1675
No description provided.