fix(vk): DLAA before the bloom keeps the game's upside-down viewport, and a DLAA before the bloom row turns it on #1678

Merged
HumanBean merged 2 commits from pmwork-personal/Longshot:fix/dlss-pre-bloom-viewport into main 2026-11-19 00:56:18 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11, RTX 5090 · Needs: Windows, other NVIDIA RTX cards (by hand)

TL;DR

With DLAA before the bloom on (#1652), the 3D picture could turn upside down while the HUD stayed upright, mostly when the
camera moved down (#1672). The cause: DLSS's own passes, run in the middle of the frame, set an upright viewport, and the
replay then skipped setting the game's upside-down one for the tone map. This PR resets the replay's bound state after
DLSS's passes, as it already does after the game's upscale. The order stays off by default, and a new Graphics row, DLAA
before the bloom, turns it on. On my PC the build without the fix flipped and the build with it did not.

Breakdown

  • Who it helps: players on NVIDIA RTX with the Upscaler on DLAA who turn DLAA before the bloom on.
  • What was wrong: after DLAA ran in the middle of a frame, the replay still thought the game's upside-down viewport was bound, so the tone map drew with DLSS's upright one.
  • What changes: the replay binds everything again after DLAA's commands; a Graphics row, DLAA before the bloom, turns the order on and off at once.
  • What does not change: the default (off, as since #1675); DLSS's other modes, FSR, XeSS and frame generation; RX_VK_DLSS_PRE_BLOOM still sets it for one run.
  • How it was checked: on my screen, the camera moved down and up outdoors: the build without the fix flipped, with it not; the row through the control bridge; a game-free test; the changed-files checks.
  • What is still open: other RTX cards on screen.
  • Risk: low: the reset is the one the game's upscale already does, and the order is off unless the row turns it on.

Why

#1652 runs DLAA on the scene before the game's bloom and tone map, at a place learned each frame. Players on v3.0.0-rc.8
saw the 3D upside down with the HUD upright when the camera moved down (RTX 5080, RTX 4070 Super), and #1675 turned the
order off by default. The cause is in the replay, not in the order: this fixes it, and gives players a row to turn the
order on. Fixes #1672.

How to reproduce

Seen on: Windows 11, NVIDIA GeForce RTX 5090, driver 621.24 (players: RTX 5080 with 621.24, RTX 4070 Super)
Settings and switches: Upscaler NVIDIA DLSS, Render resolution Native (DLAA), Threaded rendering Auto (On here); RX_VK_DLSS_PRE_BLOOM=1 on main
Steps: outdoors (Kakariko Village, Castle Town's market at night), move the camera down and up with the right stick
Expected: the picture stays upright
Actual: the 3D picture turns upside down while the HUD stays upright, in the frames where DLAA ran before the tone map (the log's the first pass to read the scene after its last draw is program ab3681946f93594a)

What changed

The replay draws every game draw with an upside-down viewport (vk_draw.cpp dynamic_state: NVN's +y is up, Vulkan's
down) and sets it only when it differs from what it thinks bound. DLAA's commands in the middle of a draw (the pass ended,
DLSS's passes, the actor motion's draws with an upright viewport) changed that state behind its back. Where DLAA ran before
the tone map, a draw the scene's size, the tone map skipped its viewport and drew upside down. The game's upscale stand-in
already resets the bound state after the upscaler (temporal_stand_in); the new place now does too.

  • renderer: temporal_pre_bloom() in gpu/vk/vk_temporal.cpp returns whether it recorded commands; draw() in gpu/vk/vk_draw.cpp then calls cb.reset() and pushes its descriptors again. pre_bloom_wanted() reads the row at each call and logs each change.
  • menu: gpu/vk/vk_menu.cpp gets the row DLAA before the bloom under DLSS model (opts.dlss_pre_bloom in vk_menu.h, saved as dlss_pre_bloom); upscaler_rows.h pre_bloom_shown() (NVIDIA DLSS where it runs) and pre_bloom_fixed() (changeable at DLAA only, or fixed while the switch sets it); its hint says why; RX_VK_DLSS_PRE_BLOOM overrides it for one run.
  • docs: README.md options table, docs/development.md, gpu/vk/switches.def (the switch is now the row's, player).
  • log: gpu/vk/vk_dlss.cpp names why DLSS's feature takes HDR colour (the game's native HDR, or DLAA before the bloom); it said "the game's native HDR" for both.
  • tests: tests/test_dlss_pre_bloom.py/.cpp check the reset, the descriptor push, the row and its rules; test_audio_output_menu.py and test_stick_dead_zone.py stand-ins get the new option, as ini_key names it.

Measurements

Verdict: nothing to measure: a fix of a wrong picture and a menu row; the order's cost and quality are in #1652.

Flags and settings

Adds the DLAA before the bloom row (dlss_pre_bloom= in longshot_options.ini); RX_VK_DLSS_PRE_BLOOM now overrides it.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
DLAA before the bloom (dlss_pre_bloom) Graphics row: where DLAA runs none Off by default; On runs DLAA before the bloom and tone map (DLAA only) the order of #1652, now without the upside-down picture fixed on an RTX 5090 on screen; other cards untested Off by default until more players have tried it
RX_VK_DLSS_PRE_BLOOM the same, for one run =1 on, else off =1 on, =0 off, over the row as the row as above for tests only

Testing

Tested: on my PC (Windows 11 Pro build 26300, RTX 5090, driver 621.24, Threaded rendering On, my own settings with DLAA), on screen, outdoors with the camera moved down and up: a build of #1652 as merged (order on) showed the 3D upside down; the same build with this PR's viewport fix did not. Both runs' logs had DLAA learned before the tone map (ab3681946f93594a) 7 times and before the bloom's first pass 7 times, so the frames that flipped came in both. This PR's whole change, built on the shared base (main c507b98c with #1652 and #1675), off-screen through the control bridge: the row reads Off at the start; option set dlss_pre_bloom 1 logs NVIDIA DLAA before the game's bloom and tone map (DLAA before the bloom: on) and the next status counts frames drawn before the bloom; 0 logs after ... again; DLSS's feature is made again for each, with no restart. The same build on my screen (my own settings: NVIDIA DLSS at Native (DLAA), frame generation 3x by DLSS FG): the row shows under DLSS model with its help and line, and On, Off and On again each applied at once (the log's place line, and DLSS's feature made again with HDR colour on, off and on); in that run DLAA ran before the tone map at least 6 times, the picture stayed upright at every camera angle, and the log has no error. tests/test_dlss_pre_bloom.py passes; tests/run_all.py --changed: 229 pass, 20 fail, and the same 20 fail on main @ 1055077d on this PC (test_bug_report, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_damage_debug_menu, test_dev_packs, test_dlss_feature_size, test_draw_stream_visibility, test_fsr_uniform_ownership, test_hud_layout_row, test_linux_pressure, test_pipeline_play_cache, test_prepare_cache_save, test_psychov35_fsr3_fg, test_recorder_sync, test_switch_table, test_tested_configurations, test_upscaler_rows, test_vk_occlusion_queries, test_walk_key).

Not tested: other RTX cards; native HDR and PsychoV35 with the order on.

Must be tested:

  • Windows, an NVIDIA RTX 40 or 30 card, by hand: Upscaler NVIDIA DLSS at Native (DLAA), DLAA before the bloom On, move the camera down and up outdoors, expecting the picture upright at every angle and the row greyed out with its "DLAA only" line at other Render resolutions (by hand: any tester with an RTX card)

Risks

What could break: with the row On only: a draw after DLAA binds its pipeline, viewport and descriptors again, as after the game's upscale already; nothing changes with it Off (the default).

Turning it off: the row Off (the default), or RX_VK_DLSS_PRE_BLOOM=0; or revert the commit.

Compatibility: a new key, dlss_pre_bloom=, in longshot_options.ini (absent: Off); no save, cache or ABI change.

Issues

Fixes #1672

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.

Co-Authored-By: Claude Opus 5.5 [email protected]

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 5090 · **Needs:** Windows, other NVIDIA RTX cards (by hand) ## TL;DR With DLAA before the bloom on (#1652), the 3D picture could turn upside down while the HUD stayed upright, mostly when the camera moved down (#1672). The cause: DLSS's own passes, run in the middle of the frame, set an upright viewport, and the replay then skipped setting the game's upside-down one for the tone map. This PR resets the replay's bound state after DLSS's passes, as it already does after the game's upscale. The order stays off by default, and a new Graphics row, DLAA before the bloom, turns it on. On my PC the build without the fix flipped and the build with it did not. ## Breakdown - **Who it helps:** players on NVIDIA RTX with the Upscaler on DLAA who turn DLAA before the bloom on. - **What was wrong:** after DLAA ran in the middle of a frame, the replay still thought the game's upside-down viewport was bound, so the tone map drew with DLSS's upright one. - **What changes:** the replay binds everything again after DLAA's commands; a Graphics row, DLAA before the bloom, turns the order on and off at once. - **What does not change:** the default (off, as since #1675); DLSS's other modes, FSR, XeSS and frame generation; `RX_VK_DLSS_PRE_BLOOM` still sets it for one run. - **How it was checked:** on my screen, the camera moved down and up outdoors: the build without the fix flipped, with it not; the row through the control bridge; a game-free test; the changed-files checks. - **What is still open:** other RTX cards on screen. - **Risk:** low: the reset is the one the game's upscale already does, and the order is off unless the row turns it on. ## Why #1652 runs DLAA on the scene before the game's bloom and tone map, at a place learned each frame. Players on v3.0.0-rc.8 saw the 3D upside down with the HUD upright when the camera moved down (RTX 5080, RTX 4070 Super), and #1675 turned the order off by default. The cause is in the replay, not in the order: this fixes it, and gives players a row to turn the order on. Fixes #1672. ## How to reproduce **Seen on:** Windows 11, NVIDIA GeForce RTX 5090, driver 621.24 (players: RTX 5080 with 621.24, RTX 4070 Super) **Settings and switches:** Upscaler NVIDIA DLSS, Render resolution Native (DLAA), Threaded rendering Auto (On here); `RX_VK_DLSS_PRE_BLOOM=1` on main **Steps:** outdoors (Kakariko Village, Castle Town's market at night), move the camera down and up with the right stick **Expected:** the picture stays upright **Actual:** the 3D picture turns upside down while the HUD stays upright, in the frames where DLAA ran before the tone map (the log's `the first pass to read the scene after its last draw is program ab3681946f93594a`) ## What changed The replay draws every game draw with an upside-down viewport (`vk_draw.cpp` `dynamic_state`: NVN's +y is up, Vulkan's down) and sets it only when it differs from what it thinks bound. DLAA's commands in the middle of a draw (the pass ended, DLSS's passes, the actor motion's draws with an upright viewport) changed that state behind its back. Where DLAA ran before the tone map, a draw the scene's size, the tone map skipped its viewport and drew upside down. The game's upscale stand-in already resets the bound state after the upscaler (`temporal_stand_in`); the new place now does too. - renderer: `temporal_pre_bloom()` in `gpu/vk/vk_temporal.cpp` returns whether it recorded commands; `draw()` in `gpu/vk/vk_draw.cpp` then calls `cb.reset()` and pushes its descriptors again. `pre_bloom_wanted()` reads the row at each call and logs each change. - menu: `gpu/vk/vk_menu.cpp` gets the row DLAA before the bloom under DLSS model (`opts.dlss_pre_bloom` in `vk_menu.h`, saved as `dlss_pre_bloom`); `upscaler_rows.h` `pre_bloom_shown()` (NVIDIA DLSS where it runs) and `pre_bloom_fixed()` (changeable at DLAA only, or fixed while the switch sets it); its hint says why; `RX_VK_DLSS_PRE_BLOOM` overrides it for one run. - docs: `README.md` options table, `docs/development.md`, `gpu/vk/switches.def` (the switch is now the row's, `player`). - log: `gpu/vk/vk_dlss.cpp` names why DLSS's feature takes HDR colour (the game's native HDR, or DLAA before the bloom); it said "the game's native HDR" for both. - tests: `tests/test_dlss_pre_bloom.py/.cpp` check the reset, the descriptor push, the row and its rules; `test_audio_output_menu.py` and `test_stick_dead_zone.py` stand-ins get the new option, as `ini_key` names it. ## Measurements **Verdict:** nothing to measure: a fix of a wrong picture and a menu row; the order's cost and quality are in #1652. ### Flags and settings Adds the DLAA before the bloom row (`dlss_pre_bloom=` in `longshot_options.ini`); `RX_VK_DLSS_PRE_BLOOM` now overrides it. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | DLAA before the bloom (`dlss_pre_bloom`) | Graphics row: where DLAA runs | none | Off by default; On runs DLAA before the bloom and tone map (DLAA only) | the order of #1652, now without the upside-down picture | fixed on an RTX 5090 on screen; other cards untested | Off by default until more players have tried it | | `RX_VK_DLSS_PRE_BLOOM` | the same, for one run | `=1` on, else off | `=1` on, `=0` off, over the row | as the row | as above | for tests only | ## Testing **Tested:** on my PC (Windows 11 Pro build 26300, RTX 5090, driver 621.24, Threaded rendering On, my own settings with DLAA), on screen, outdoors with the camera moved down and up: a build of #1652 as merged (order on) showed the 3D upside down; the same build with this PR's viewport fix did not. Both runs' logs had DLAA learned before the tone map (`ab3681946f93594a`) 7 times and before the bloom's first pass 7 times, so the frames that flipped came in both. This PR's whole change, built on the shared base (main c507b98c with #1652 and #1675), off-screen through the control bridge: the row reads Off at the start; `option set dlss_pre_bloom 1` logs `NVIDIA DLAA before the game's bloom and tone map (DLAA before the bloom: on)` and the next status counts frames drawn before the bloom; `0` logs `after ...` again; DLSS's feature is made again for each, with no restart. The same build on my screen (my own settings: NVIDIA DLSS at Native (DLAA), frame generation 3x by DLSS FG): the row shows under DLSS model with its help and line, and On, Off and On again each applied at once (the log's place line, and DLSS's feature made again with HDR colour on, off and on); in that run DLAA ran before the tone map at least 6 times, the picture stayed upright at every camera angle, and the log has no error. `tests/test_dlss_pre_bloom.py` passes; `tests/run_all.py --changed`: 229 pass, 20 fail, and the same 20 fail on main @ 1055077d on this PC (test_bug_report, test_bug_report_defaults, test_crash_dialog, test_crt_options, test_damage_debug_menu, test_dev_packs, test_dlss_feature_size, test_draw_stream_visibility, test_fsr_uniform_ownership, test_hud_layout_row, test_linux_pressure, test_pipeline_play_cache, test_prepare_cache_save, test_psychov35_fsr3_fg, test_recorder_sync, test_switch_table, test_tested_configurations, test_upscaler_rows, test_vk_occlusion_queries, test_walk_key). **Not tested:** other RTX cards; native HDR and PsychoV35 with the order on. **Must be tested:** - Windows, an NVIDIA RTX 40 or 30 card, by hand: Upscaler NVIDIA DLSS at Native (DLAA), DLAA before the bloom On, move the camera down and up outdoors, expecting the picture upright at every angle and the row greyed out with its "DLAA only" line at other Render resolutions (by hand: any tester with an RTX card) ## Risks **What could break:** with the row On only: a draw after DLAA binds its pipeline, viewport and descriptors again, as after the game's upscale already; nothing changes with it Off (the default). **Turning it off:** the row Off (the default), or `RX_VK_DLSS_PRE_BLOOM=0`; or revert the commit. **Compatibility:** a new key, `dlss_pre_bloom=`, in `longshot_options.ini` (absent: Off); no save, cache or ABI change. ## Issues Fixes #1672 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. Co-Authored-By: Claude Opus 5.5 <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(vk): DLAA before the bloom keeps the game's upside-down viewport, and a DLAA before the bloom row turns it on
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
PR description / Description follows the template (pull_request_target) Successful in 9s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 13s
Website / Website on Cloudflare (pull_request_target) Has been skipped
882eec119a
With #1652's order on, the 3D could draw upside down (#1672). DLAA's
passes and its actor motion's draws, recorded in the middle of a draw,
bind a pipeline, an upright viewport and descriptors of their own, and
the replay's bound state was not reset after them (it is after the
network's stand-in). Where DLAA ran before the tone map, a draw of the
scene's size, the tone map's viewport matched the one the replay thought
bound, was not set, and the tone map drew with the actor motion's
upright viewport instead of the game's upside-down one. temporal_pre_bloom
now says when it recorded commands, and draw() then resets its bound
state and pushes its descriptors again.

The order stays off by default. A Graphics row, DLAA before the bloom
(saved as dlss_pre_bloom), turns it on: shown with NVIDIA DLSS,
changeable with Render resolution Native (DLAA) only, as DLSS's other
modes draw the 3D smaller than the picture. It changes at once;
RX_VK_DLSS_PRE_BLOOM sets it for one run over the row.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Tested in game: Windows 11 Pro build 26300, NVIDIA GeForce RTX 5090, driver 621.24, Threaded rendering On, NVIDIA DLSS at Native (DLAA), on screen: outdoors with the camera moved down and up, a build of #1652 as merged (the order on) drew the 3D upside down and the same build with this PR's viewport fix did not; both logs had DLAA learned before the tone map (ab3681946f93594a) 7 times. This PR's whole change on the shared base (main c507b98c with #1652 and #1675), off-screen through the control bridge: the DLAA before the bloom row reads Off, option set 1 logs DLAA before the bloom and counts frames before the bloom, 0 logs it after again.

Tested in game: Windows 11 Pro build 26300, NVIDIA GeForce RTX 5090, driver 621.24, Threaded rendering On, NVIDIA DLSS at Native (DLAA), on screen: outdoors with the camera moved down and up, a build of #1652 as merged (the order on) drew the 3D upside down and the same build with this PR's viewport fix did not; both logs had DLAA learned before the tone map (ab3681946f93594a) 7 times. This PR's whole change on the shared base (main c507b98c with #1652 and #1675), off-screen through the control bridge: the DLAA before the bloom row reads Off, option set 1 logs DLAA before the bloom and counts frames before the bloom, 0 logs it after again.
fix(vk): the DLSS feature's log says why it takes HDR colour (the game's native HDR, or DLAA before the bloom)
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
PR description / Description follows the template (pull_request_target) Successful in 12s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 14s
Third-party parts / As their notes say (pull_request) Successful in 13s
a248a730a5
It said "the game's native HDR" for both, also when DLAA before the bloom
asked for HDR colour with the game's picture not PQ.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

New commit a248a730: the DLSS feature's log now says why it takes HDR colour (the game's native HDR, or DLAA before the bloom); it said "the game's native HDR" for both. Testing updated: this PR's build on my screen (the row under DLSS model, On, Off and On again at once with frame generation on, the picture upright at every camera angle while DLAA ran before the tone map), and the checks: 229 pass, the same 20 fail on main.

New commit a248a730: the DLSS feature's log now says why it takes HDR colour (the game's native HDR, or DLAA before the bloom); it said "the game's native HDR" for both. Testing updated: this PR's build on my screen (the row under DLSS model, On, Off and On again at once with frame generation on, the picture upright at every camera angle while DLAA ran before the tone map), and the checks: 229 pass, the same 20 fail on main.
Author
Member

The Graphics tab on my screen (Windows 11, RTX 5090, 5120x2160, NVIDIA DLSS at Native (DLAA), frame generation 3x by DLSS FG).

After: this PR (its change on the shared base, main c507b98c with #1652 and #1675): the DLAA before the bloom row under DLSS model, On, with its help and line.

after: the DLAA before the bloom row

Before: #1652 as merged (the same base): no such row; the order is set by RX_VK_DLSS_PRE_BLOOM only.

before: no row

The Graphics tab on my screen (Windows 11, RTX 5090, 5120x2160, NVIDIA DLSS at Native (DLAA), frame generation 3x by DLSS FG). **After: this PR** (its change on the shared base, main c507b98c with #1652 and #1675): the DLAA before the bloom row under DLSS model, On, with its help and line. ![after: the DLAA before the bloom row](https://git.magicbean.dev/attachments/54d86c2b-8007-4f1f-a561-6efa9276ae1f) **Before: #1652 as merged** (the same base): no such row; the order is set by `RX_VK_DLSS_PRE_BLOOM` only. ![before: no row](https://git.magicbean.dev/attachments/b34ab582-5bf4-40d6-90fe-0e4ae163342f)
HumanBean deleted branch fix/dlss-pre-bloom-viewport 2026-11-19 00:56:18 +00:00
First-time contributor

Another case of the same order, for context: crawling through the low tunnel at the start of Bottom of the Well (child Link, the camera close and low), the 3D flickered; it stopped with RX_VK_DLSS_PRE_BLOOM=0. v3.0.0-rc.8 (source a74a6465, plus my input-only change from #1349), Windows 11, RTX 5090, 5120x2880, NVIDIA DLSS at Native (DLAA), frame generation off. Two runs at the same spot, the order on and off; the lines that matter from each log:

order on (flickers)
vk: upscaler: NVIDIA DLAA before the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=0: after them)
map: BottomOfTheWell (child)
vk: status: 600 frames, the slowest 27.7 ms; VRAM 9.8 of 30.7 GB; NVIDIA DLAA: 600 frames drawn (599 before the bloom), 1 made
order off (no flicker)
vk: upscaler: NVIDIA DLAA after the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=0)
map: BottomOfTheWell (child)
vk: status: 600 frames, the slowest 24.1 ms; VRAM 9.8 of 30.7 GB; NVIDIA DLAA: 600 frames drawn, 1 made

The full logs are kept if you want them. I can run this PR's build in that tunnel with the row On if that helps.

Another case of the same order, for context: crawling through the low tunnel at the start of Bottom of the Well (child Link, the camera close and low), the 3D flickered; it stopped with `RX_VK_DLSS_PRE_BLOOM=0`. v3.0.0-rc.8 (source a74a6465, plus my input-only change from #1349), Windows 11, RTX 5090, 5120x2880, NVIDIA DLSS at Native (DLAA), frame generation off. Two runs at the same spot, the order on and off; the lines that matter from each log: <details><summary>order on (flickers)</summary> ``` vk: upscaler: NVIDIA DLAA before the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=0: after them) map: BottomOfTheWell (child) vk: status: 600 frames, the slowest 27.7 ms; VRAM 9.8 of 30.7 GB; NVIDIA DLAA: 600 frames drawn (599 before the bloom), 1 made ``` </details> <details><summary>order off (no flicker)</summary> ``` vk: upscaler: NVIDIA DLAA after the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=0) map: BottomOfTheWell (child) vk: status: 600 frames, the slowest 24.1 ms; VRAM 9.8 of 30.7 GB; NVIDIA DLAA: 600 frames drawn, 1 made ``` </details> The full logs are kept if you want them. I can run this PR's build in that tunnel with the row On if that helps.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1678
No description provided.