docs(guides): recapture the Graphics guide image for the NFC tab and advance its review record #1501

Open
mooki wants to merge 1 commit from mooki/Longshot:docs/guide-review-graphics into main
Member

Type: docs · Risk: low · Tested on: Linux x86-64, no GPU (the picture is drawn in memory by SDL2's software renderer; the checks need no game) · Needs: any PC with a browser (the site's Settings page, once the site's tests pass again), and a maintainer's look at the pictures

TL;DR

The guide-screenshot check is red on main, so every pull request inherits the failure: the Graphics picture in the Settings guide was last reviewed before thirteen of its source files changed. I did that review with the project's own capture helper. The picture now differs in one visible way, the NFC tab that #280 added to the menu's tab strip; every row, value and help sentence is pixel-identical. So this PR replaces the picture with a fresh capture of main and advances its record: the check passes and its 14 tests pass.

Breakdown

  • Who it helps: every author with an open pull request, whose red check is main's and not theirs (a pull request that itself edits a recorded file still needs its own review, see Overlaps), and readers of the Settings guide, whose picture now shows the tabs the menu has.
  • What was wrong: the picture is recorded against the SHA-256 of 77 source files; since its last review (#1466) thirteen changed, one was deleted (#1390) and the capture fixture changed (#1486), and nobody compared the picture with them. It also lacked the NFC tab (#280).
  • What changes: the picture is the capture helper's render of main 310e7c9df (a strip of six tabs), and its manifest entry, the guide's caption, the guide README's provenance line and the review note move with it.
  • What does not change: the Launcher's six pictures and entries, the checker, the workflow, the capture helper and fixture, every source file, the guide's alt text and steps, and what the picture shows below the tab strip.
  • How it was checked: the guide check prints 15 REVIEW REQUIRED lines and exits 1 on main, and exits 0 here; six renders of five commits compared pixel by pixel and looked at; 14, 4 and 51 tests; the whole suite here and on main (below).
  • What is still open: the site's Settings page does not render in the site's tests on main (its tab list does not know NFC; two site tests fail on main and here alike), so the page and caption were not looked at; a maintainer's look at the pictures; Windows; a render with the toolchain the old PNG recorded; #1488 and #1489 each edit a recorded file, so after a rebase onto this the check still names those files until each carries its own review.
  • Risk: low: nothing the game runs changes. The one way to be wrong is a difference I did not see, and the pixel comparison rules that out for this view; the PNG is 3,720 bytes larger.

Why

main fails its own Guide images check, and every pull request shows the same red status, which has nothing to do with it. The Graphics picture in the Settings guide is recorded against the files it is drawn from (reviewed_source.files); when one changes, scripts/check_guide_screenshots.py --review-sources prints REVIEW REQUIRED and exits 1 until someone compares the picture with a rendering of the new source and either retains it or recaptures it (docs/images/guide/README.md, "Capture and maintenance", step 5). #1466 did that at 21:18 UTC on 17 Nov (415a8944c). Since then 43 commits reached main and 15 of them changed a recorded file or the capture fixture, the first of them (#1388, 21:43 UTC) about 25 minutes later; none carried a review, so the check has been red since. The tracker was searched by five phrases (guide screenshot, guide images, REVIEW REQUIRED, settings-graphics, the check's name): no issue and no open pull request carries this review; #1467 and #68 replace the picture too, for their own changes (see Overlaps).

Doing the review found that the picture is no longer what the menu draws: #280 added an NFC tab, so the tab strip has six tabs and the guide's picture shows five. A retention (the pattern of #1466) would have recorded a stale picture as current, so this PR recaptures it.

What changed

The Graphics picture is replaced by a render of main, and everything that records where it came from moves with it: the manifest entry, the caption and the provenance paragraph. The comparison that justifies it, and a line for each recorded source, is in source-review-fullscreen-monitor.md and below.

  • docs/images/guide/settings-graphics.png: the helper's render of main 310e7c9df, 1280x720, sha256 1b0d6de3… (96,658 bytes; was 3531f6ab…, 92,938).
  • docs/images/guide/manifest.json, settings-graphics.png's entry: sha256; captured_at 2026-11-17; game_version nightly-464-310e7c9d; captured_source (revision 310e7c9d…, the 76 files the helper's compiler pass lists); reviewed_source (the same 76 files, revision sha256:9617d811…, the SHA-256 of the sorted path=hash lines, a formula I checked first on the old 77 entries: it gives exactly the old sha256:006bc251…); the fixture's menu.cpp hash; capture.toolchain (clang 23.1.3, SDL2 2.32.74, libpng 1.6.59: the render's real ones); review.notes. vk_vendor.h leaves both lists (#1390 deleted it), and no file joins them.
  • docs/images/guide/source-review-fullscreen-monitor.md: a "Recapture after #280 (2026-11-17)" section (+75 lines): the renders compared, a line for each recorded source and what is not claimed.
  • docs/graphics-and-controls.md: the caption names the new build ("development build 310e7c9d (Nightly 464)"); the alt text is unchanged, since the view still shows the same things.
  • docs/images/guide/README.md: the provenance paragraph says the Graphics image comes from main 310e7c9d… after #280, and where the earlier capture is.

Measurements

Verdict: the guide check fails on main (exit 1, 15 REVIEW REQUIRED lines) and passes with this PR (exit 0). The first Graphics view rendered from 415a8944c (the last commit it passed on) and from main differs in 13,009 of 921,600 pixels, all in the top 55 rows: the banner's version text and the tab strip, which now has the NFC tab. Nothing below the strip differs. Nothing else to measure: a record, a note and a picture change no code.

Hardware: Linux 7.2.15 (Arch, x86-64), Intel Core i9-13900K, 94 GB; the PC has a GPU, which nothing here opens
Scene: none; the Graphics view of the menu fixture, 1280x720, Medium menu scale, English, SDL2's software renderer
Method: scripts/check_guide_screenshots.py --review-sources on main and on this PR; the capture helper's renders of 415a8944c, c7db6c026, 6d949cf95 (#280) and 310e7c9df compared pixel by pixel (any channel differs) with a script of a dozen lines (below); one run each, the render of 310e7c9df twice (byte-identical)
How to reproduce: below, "How to rerun it"

Before: main @ 310e7c9df After: this PR @ 0ce593910
scripts/check_guide_screenshots.py --review-sources exit 1: 15 REVIEW REQUIRED (13 changed sources, vk_vendor.h gone, the fixture changed) exit 0
tests/test_guide_screenshots.py passes (in the whole suite) 14 tests OK
tests/test_launcher_capture.py passes (in the whole suite) 4 tests OK
whole tests/run_all.py 638 passed, 34 failed, 95 skipped 637 passed, 35 failed, 95 skipped: the same 34 fail, by name, and the 35th, test_prepare_stall, passes when rerun alone
the site's tests/guide-screenshots.test.ts 2 of 4 fail: "README menu table has an unknown tab" the same 2 fail, the same 2 pass
the picture (settings-graphics.png) 3531f6ab…, tabs: Graphics, Audio, Gameplay, Controls, Debug 1b0d6de3…, tabs: Graphics, Audio, Gameplay, Controls, NFC, Debug

The check on main, whole, as the program printed it (python3 -I -B scripts/check_guide_screenshots.py --review-sources, exit 1; the checkout's folder name is cut from the vk_vendor.h line):

ASSET OK: launcher-home.png (960x600)
NOT CHECKED: launcher-home.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-saves.png (960x600)
NOT CHECKED: launcher-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-import.png (960x600)
NOT CHECKED: launcher-import.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: settings-graphics.png (1280x720)
ASSET OK: launcher-manage-saves.png (960x600)
NOT CHECKED: launcher-manage-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-game-files.png (960x600)
NOT CHECKED: launcher-game-files.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-import-confirm.png (960x600)
NOT CHECKED: launcher-import-confirm.png: Launcher UI sources; supply --launcher-source CHECKOUT
REVIEW REQUIRED: settings-graphics.png: gpu/vk/device_policy.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/fallback_size_policy.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/menu_i18n.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_api.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_dlss.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_draw.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_framegen.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_fsr3fi.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_internal.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_menu.cpp changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_menu.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_temporal.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_texture.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_vendor.h: [Errno 2] No such file or directory: '.../gpu/vk/vk_vendor.h'
REVIEW REQUIRED: settings-graphics.png: fixture scripts/screenshots/menu.cpp changed
Guide screenshot check failed: 15 issue(s). Review the affected UI and guide before updating review hashes.

On this PR's head (exit 0; the six Launcher pictures are NOT CHECKED here and on main alike: there is no Launcher checkout in CI):

ASSET OK: launcher-home.png (960x600)
NOT CHECKED: launcher-home.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-saves.png (960x600)
NOT CHECKED: launcher-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-import.png (960x600)
NOT CHECKED: launcher-import.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: settings-graphics.png (1280x720)
ASSET OK: launcher-manage-saves.png (960x600)
NOT CHECKED: launcher-manage-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-game-files.png (960x600)
NOT CHECKED: launcher-game-files.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-import-confirm.png (960x600)
NOT CHECKED: launcher-import-confirm.png: Launcher UI sources; supply --launcher-source CHECKOUT
Guide screenshot checks passed for the inputs checked above; NOT CHECKED items remain outstanding.

The renders (the capture helper from this PR's checkout for every one, so the fixture is the same unless said; clang 23.1.3, SDL2 2.32.74, libpng 1.6.59):

Pair Differing pixels of 921,600 Where
415a8944c, with its own fixture and with the new one 0 the fixture's two new stubs change nothing drawn
415a8944c and 310e7c9df 13,009 x 72 to 1047, y 0 to 54: the version text and the tab strip
415a8944c and c7db6c026 (everything before #280) 1,192 x 72 to 261, y 25 to 38: the version text only
c7db6c026 and 6d949cf95 (#280 alone) 12,345 the version text and the tab strip
6d949cf95 and 310e7c9df (everything after #280) 454 x 122 to 191, y 25 to 35: the version text only
310e7c9df rendered twice 0 byte-identical PNG and menu-capture.json
the published PNG and the render of 415a8944c 60,449 glyph edges and borders a pixel off, everywhere: a different toolchain (the manifest recorded clang 23.1.6, SDL2 2.32.10, libpng 1.6.57); inferred, not tested

The last row is why the comparison is between renders, and why the new picture is a render on the current toolchain, recorded as such.

compare_renders.py
import sys
import numpy as np
from PIL import Image

def load(path):
    im = Image.open(path).convert('RGB')
    assert im.size == (1280, 720)
    return np.asarray(im).astype(np.int16)

a, b = load(sys.argv[1]), load(sys.argv[2])
d = np.abs(a - b).max(axis=2)
ys, xs = np.nonzero(d)
print(f'{len(ys)} of {d.size} pixels differ, largest channel difference {d.max()}')
if len(ys):
    print(f'bounding box x {xs.min()}..{xs.max()}, y {ys.min()}..{ys.max()}')

Pictures

The top of the Graphics view in three pictures. Top: the published picture (tabs Graphics, Audio, Gameplay, Controls, Debug). Middle: the helper's render of 415a8944c, the last commit the check passed on (the same five tabs; the version text differs because it is the build's). Bottom: the render of main 310e7c9df, the new picture: Graphics, Audio, Gameplay, Controls, NFC, Debug, spaced for six.
The new picture dimmed, with the 13,009 pixels that differ from the render of 415a8944c in red: all of them are in the banner's version text and the tab strip, none in a row, the help panel, the scrollbar or the key prompts.
The new picture itself, as committed (1280x720, sha256 1b0d6de3…): Quality preset selected on Custom, Aspect ratio 16:9, Output resolution 2048x1152 (reduced), Custom output size None, Profile Docked, Upscaler Game's own, Render resolution Auto (dynamic), Sharpness 0%, Frame generation Off, Game frame rate cap 60 (the console's), the Quality preset help and the key prompts, as before.

Flags and settings

None.

Review of the recorded sources

What each of the 14 sources and the fixture changed since 415a8944c, and whether it alters what the picture shows (the full reading is in source-review-fullscreen-monitor.md):

  • gpu/vk/vk_menu.cpp (#1486, #280, #1318, #1442, #1388): yes, one thing: tab_titles and TAB_COUNT gain the NFC tab, so the strip shows six tabs. The rest is on rows or help this view does not show (Frame generation's help, the Frame pacing hints, Layout preset, the Controller menu button, the NFC rows, the pipeline-list message, menu_memory_tier).
  • gpu/vk/vk_menu.h (#280, #1388): no. Options::pad_menu (default 1) and a comment; the declarations of menu_memory_tier and menu_rumble_tick.
  • gpu/vk/menu_i18n.h (#1486, #1318, #1442): no. The other languages' tables and a helper that takes each table's length; the English strings are keys in vk_menu.cpp.
  • gpu/vk/vk_framegen.h (#1486): no. Declares framegen_capped and framegen_now; the fixture's framegen_capped returns the value as set, so Frame generation stays "Off".
  • gpu/vk/vk_dlss.h (#1486): no. Declares dlss_fg_most and rewords comments; the fixture answers 0.
  • gpu/vk/vk_api.h (#280, #1150): no. ABI 30 to 33: new host callbacks (rumble test, NFC) and nvn_invalidate_quick; the fixture's host is null.
  • gpu/vk/vk_internal.h (#1484, #1390, #560, #1150, #1442, #426): no. The vk_vendor.h include and Device::fixes go, memory_priority and declarations for frame overlap, memory sync and the preparation watchdog arrive; the fixture's Device is empty.
  • gpu/vk/device_policy.h (#1390, #1296, #426): no. The vendor fixes move here, networks_left_out is new, the Radeon 860M joins ASTC on the CPU, Mesa's Intel driver gets a phi limit: rules and log text the menu does not read.
  • gpu/vk/fallback_size_policy.h (#426): no. Phi and call limits for Mesa's Intel driver, used by the shader preparation.
  • gpu/vk/vk_fsr3fi.h (#1487): no. Inputs::present, an image view for FSR 3.1 frame generation's HUD-less mode.
  • gpu/vk/vk_draw.h (#391): no. ub_overlay takes a function pointer and an alignment.
  • gpu/vk/vk_temporal.h (#1447): no. Two declarations for the hidden-mesh rule.
  • gpu/vk/vk_texture.h (#1122, #1150): no. The texture_ahead_* declarations and texture_gpu_written_ever.
  • gpu/vk/vk_vendor.h (#1390): deleted, no. Its three fixes are in device_policy.h and nothing includes it; the helper's compiler pass lists 76 files, the previous 77 less this one.
  • fixture scripts/screenshots/menu.cpp (#1486): no. Two stubs (dlss_fg_most 0, framegen_capped the value as set) so the menu links; the old source rendered with the old and the new fixture gives identical PNGs.

Each "no" rests on reading the change and on the pixel comparison above: the renders differ in the top 55 rows only, and #280 alone accounts for the tab strip.

How to rerun it

git fetch forge main
git worktree add --detach ../ls-before 415a8944c
git worktree add --detach ../ls-main 310e7c9df
python -I scripts/screenshots/capture_menu.py --source ../ls-before --vulkan-headers /usr/include --output /tmp/render-before --views graphics
python -I scripts/screenshots/capture_menu.py --source ../ls-main --vulkan-headers /usr/include --output /tmp/render-main --views graphics
python compare_renders.py /tmp/render-before/settings-graphics.png /tmp/render-main/settings-graphics.png
cmp /tmp/render-main/settings-graphics.png docs/images/guide/settings-graphics.png
python -I -B scripts/check_guide_screenshots.py --review-sources
python -I -B tests/test_guide_screenshots.py && python -I -B tests/test_launcher_capture.py

(capture_menu.py is run from the checkout that has this PR, so the fixture is the same for both renders; it needs a C++20 compiler, pkg-config, SDL2 and libpng development files and the Vulkan headers. cmp is silent when the committed picture is the render of main, given the same toolchain: clang 23.1.3, SDL2 2.32.74, libpng 1.6.59.)

Testing

Tested: on Linux x86-64 (kernel 7.2.15), clang 23.1.3, SDL2 2.32.74 (sdl2-compat), libpng 1.6.59, Python 3.12.16, Node 22.23.5, no GPU, on 17 Nov 2026, base main 310e7c9df, head 0ce593910. For this docs-only change "tested on my own PC" is the checks I ran: the Guide images check on main and here (above); the capture helper's renders from five commits, compared by pixel and looked at (the three pictures at full size, and three rows of the old and new at twice the size); tests/test_guide_screenshots.py (14), tests/test_launcher_capture.py (4) and tests/test_check_pr_description.py (51) pass; the whole tests/run_all.py through the idle gate, here and in a worktree of main 310e7c9df (below); the site's tests/guide-screenshots.test.ts, with the site's packages from an unrelated checkout of the same lockfile: 2 of 4 pass here and on main (the two failures are the same on both, below). The suite, the launcher-capture and description-checker tests and the site test ran on this patch's first commit, 518d7f8de; the head differs from it in one paragraph of the review note only, and the guide check and its 14 tests were rerun on the head.

The whole suite, python -I -B tests/run_all.py --jobs 8 --junit FILE, here and on main: 637 passed, 35 failed, 95 skipped here (296 s), 638 passed, 34 failed, 95 skipped on main. The two JUnit files compared by test name: the same 767 tests in both, one status differs, test_prepare_stall (the watchdog's timing test of the shader preparation: it failed here at a load average near 40 on the PC, "the log lacks 'STOPPED: nothing moved for 12 s'", passed on main in its run, and passes here when run alone: 1 passed, 101 s). The 34 that fail on both, by name: test_bug_report_defaults, test_compute_warm_apart, test_cpu_report, test_crt_options, test_damage_debug_menu, test_dev_packs, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_hud_layout_row, test_invalidate_quick, test_invalidate_vcore, test_libc_hooks, test_linux_preflight, test_linux_pressure, test_linux_update, test_log_open_failure, test_mirror_budget, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_slow_frames, test_switch_table, test_target_image_pool, test_upscaler_rows, test_vcore_escape, test_walk_key. They fail on main too, with the same status; I did not look into why they fail on this PC. The 95 skipped are the same tests on both (the run's log gives, for some, "not found here: vulkan_headers").

Not tested: the website's Settings page rendered: the site's own renderPage for it throws "README menu table has an unknown tab" (website/src/repo-docs/graphics-settings.ts) for the README's NFC rows, so tests/guide-screenshots.test.ts fails its two tests that render that page, on main and here alike (#280 added the tab without the site's list knowing it, which this PR does not touch); I did not run the site's build itself, and the caption and the picture on the page were not looked at; Windows and Intel (the picture is the UI-only fixture, not a live Vulkan frame, as its caption says); a render with the toolchain recorded for the old PNG (clang 23.1.6, SDL2 2.32.10, libpng 1.6.57); rows below the first Graphics view and the other tabs (the picture does not show them); no game was run, none is needed for a record, a note and a picture.

Must be tested:

  • Any PC with a browser, by hand, once the site's tab list knows NFC: build and open the Settings page as website/README.md says, at desktop width and at 360 to 390 px, in both themes, expecting the new Graphics picture to load from the site's own files with its caption "development build 310e7c9d (Nightly 464)" and the six tabs readable (look at the picture and its caption, as the guide README's "Completing a refresh" asks).
  • A maintainer, by hand: look at the three pictures above and say whether "only the version text and the NFC tab differ" is a recapture you accept, expecting a yes or a change request (a person; the README says a hash match is not a visual review).

Risks

What could break: nothing at run time: a PNG, a JSON record and Markdown files. The one way to be wrong is the review itself: a difference I did not see between the old picture and the menu. I compared every pixel of the first Graphics view across five commits and read the rows, so the first view is the same except the tab strip; rows below it and the other tabs are not shown by the picture and not claimed. Costs: the PNG is 96,658 bytes, 3,720 more than before, on the Settings page of the site; nothing else, since nothing the game runs changes.

Turning it off: revert the commit; the check is red again on main, as now.

Compatibility: nothing changes for a player or for a saved setting. The site copies the PNG unchanged; its guide caption names the new build.

Overlaps

By the open pull requests' file lists (the forge's pulls/N/files), and for #1488 and #1489 a trial merge onto this PR's head with the check run on the result: #1467 (Reset to defaults at the top of the Graphics tab) and #68 (the co-op tab) also replace settings-graphics.png and edit its manifest entry, the caption and the provenance paragraph; each takes its own entry on rebase and renders the view again (the helper command above), now with six tabs underneath it. #1358, #1408, #1411 and #1426 also edit manifest.json (and #1358, #1411 and #1426 the review note), so each needs a rebase onto this; no trial merge was run for them. #1488 and #1489 merge onto this PR without a conflict, and the check on the result still fails, with exactly the files they themselves edit: #1488 names gpu/vk/device_policy.h (it includes module_drop.h and a rule that now covers Windows) and gpu/vk/vk_draw.h (CommitNow and private_bytes_now declarations), and its new include would add module_drop.h to the helper's dependency list (read from the include, not rendered); #1489 names gpu/vk/vk_texture.h (two members of the texture's eviction bookkeeping). Those are declarations and rules the menu does not draw, but each PR needs its own review line and hash update; this PR cannot carry them.

Issues

See #1466 (the last review of this picture) and #280 (the NFC tab).

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why. (Docs only, nothing the game runs: the checks I ran are what Testing's Tested says.)
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks. (Nothing the game runs changes; the one cost, the PNG's 3,720 bytes, is in Risks.)
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. (Based on 310e7c9df, forge main when this was written.)
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). (34 tests fail here and on main, named under Testing; the 35th, test_prepare_stall, failed once under load and passes alone.)
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (The three pictures above: the same view rendered from 415a8944c and from main, and the new picture.)
  • Docs updated.

New on this forge; not opened on GitHub.

**Type:** docs · **Risk:** low · **Tested on:** Linux x86-64, no GPU (the picture is drawn in memory by SDL2's software renderer; the checks need no game) · **Needs:** any PC with a browser (the site's Settings page, once the site's tests pass again), and a maintainer's look at the pictures ## TL;DR The guide-screenshot check is red on main, so every pull request inherits the failure: the Graphics picture in the Settings guide was last reviewed before thirteen of its source files changed. I did that review with the project's own capture helper. The picture now differs in one visible way, the NFC tab that #280 added to the menu's tab strip; every row, value and help sentence is pixel-identical. So this PR replaces the picture with a fresh capture of main and advances its record: the check passes and its 14 tests pass. ## Breakdown - **Who it helps:** every author with an open pull request, whose red check is main's and not theirs (a pull request that itself edits a recorded file still needs its own review, see Overlaps), and readers of the Settings guide, whose picture now shows the tabs the menu has. - **What was wrong:** the picture is recorded against the SHA-256 of 77 source files; since its last review (#1466) thirteen changed, one was deleted (#1390) and the capture fixture changed (#1486), and nobody compared the picture with them. It also lacked the NFC tab (#280). - **What changes:** the picture is the capture helper's render of main `310e7c9df` (a strip of six tabs), and its manifest entry, the guide's caption, the guide README's provenance line and the review note move with it. - **What does not change:** the Launcher's six pictures and entries, the checker, the workflow, the capture helper and fixture, every source file, the guide's alt text and steps, and what the picture shows below the tab strip. - **How it was checked:** the guide check prints 15 `REVIEW REQUIRED` lines and exits 1 on main, and exits 0 here; six renders of five commits compared pixel by pixel and looked at; 14, 4 and 51 tests; the whole suite here and on main (below). - **What is still open:** the site's Settings page does not render in the site's tests on main (its tab list does not know NFC; two site tests fail on main and here alike), so the page and caption were not looked at; a maintainer's look at the pictures; Windows; a render with the toolchain the old PNG recorded; #1488 and #1489 each edit a recorded file, so after a rebase onto this the check still names those files until each carries its own review. - **Risk:** low: nothing the game runs changes. The one way to be wrong is a difference I did not see, and the pixel comparison rules that out for this view; the PNG is 3,720 bytes larger. ## Why `main` fails its own Guide images check, and every pull request shows the same red status, which has nothing to do with it. The Graphics picture in the Settings guide is recorded against the files it is drawn from (`reviewed_source.files`); when one changes, `scripts/check_guide_screenshots.py --review-sources` prints `REVIEW REQUIRED` and exits 1 until someone compares the picture with a rendering of the new source and either retains it or recaptures it (`docs/images/guide/README.md`, "Capture and maintenance", step 5). #1466 did that at 21:18 UTC on 17 Nov (`415a8944c`). Since then 43 commits reached main and 15 of them changed a recorded file or the capture fixture, the first of them (#1388, 21:43 UTC) about 25 minutes later; none carried a review, so the check has been red since. The tracker was searched by five phrases (guide screenshot, guide images, REVIEW REQUIRED, settings-graphics, the check's name): no issue and no open pull request carries this review; #1467 and #68 replace the picture too, for their own changes (see Overlaps). Doing the review found that the picture is no longer what the menu draws: #280 added an **NFC** tab, so the tab strip has six tabs and the guide's picture shows five. A retention (the pattern of #1466) would have recorded a stale picture as current, so this PR recaptures it. ## What changed The Graphics picture is replaced by a render of main, and everything that records where it came from moves with it: the manifest entry, the caption and the provenance paragraph. The comparison that justifies it, and a line for each recorded source, is in `source-review-fullscreen-monitor.md` and below. - `docs/images/guide/settings-graphics.png`: the helper's render of main `310e7c9df`, 1280x720, `sha256 1b0d6de3…` (96,658 bytes; was `3531f6ab…`, 92,938). - `docs/images/guide/manifest.json`, `settings-graphics.png`'s entry: `sha256`; `captured_at` 2026-11-17; `game_version` `nightly-464-310e7c9d`; `captured_source` (revision `310e7c9d…`, the 76 files the helper's compiler pass lists); `reviewed_source` (the same 76 files, `revision` `sha256:9617d811…`, the SHA-256 of the sorted `path=hash` lines, a formula I checked first on the old 77 entries: it gives exactly the old `sha256:006bc251…`); the fixture's `menu.cpp` hash; `capture.toolchain` (clang 23.1.3, SDL2 2.32.74, libpng 1.6.59: the render's real ones); `review.notes`. `vk_vendor.h` leaves both lists (#1390 deleted it), and no file joins them. - `docs/images/guide/source-review-fullscreen-monitor.md`: a "Recapture after #280 (2026-11-17)" section (+75 lines): the renders compared, a line for each recorded source and what is not claimed. - `docs/graphics-and-controls.md`: the caption names the new build ("development build 310e7c9d (Nightly 464)"); the alt text is unchanged, since the view still shows the same things. - `docs/images/guide/README.md`: the provenance paragraph says the Graphics image comes from main `310e7c9d…` after #280, and where the earlier capture is. ## Measurements **Verdict:** the guide check fails on main (exit 1, 15 `REVIEW REQUIRED` lines) and passes with this PR (exit 0). The first Graphics view rendered from `415a8944c` (the last commit it passed on) and from main differs in 13,009 of 921,600 pixels, all in the top 55 rows: the banner's version text and the tab strip, which now has the NFC tab. Nothing below the strip differs. Nothing else to measure: a record, a note and a picture change no code. Hardware: Linux 7.2.15 (Arch, x86-64), Intel Core i9-13900K, 94 GB; the PC has a GPU, which nothing here opens Scene: none; the Graphics view of the menu fixture, 1280x720, Medium menu scale, English, SDL2's software renderer Method: `scripts/check_guide_screenshots.py --review-sources` on main and on this PR; the capture helper's renders of `415a8944c`, `c7db6c026`, `6d949cf95` (#280) and `310e7c9df` compared pixel by pixel (any channel differs) with a script of a dozen lines (below); one run each, the render of `310e7c9df` twice (byte-identical) How to reproduce: below, "How to rerun it" | | Before: main @ 310e7c9df | After: this PR @ 0ce593910 | |---|---|---| | `scripts/check_guide_screenshots.py --review-sources` | exit 1: 15 `REVIEW REQUIRED` (13 changed sources, `vk_vendor.h` gone, the fixture changed) | exit 0 | | `tests/test_guide_screenshots.py` | passes (in the whole suite) | 14 tests OK | | `tests/test_launcher_capture.py` | passes (in the whole suite) | 4 tests OK | | whole `tests/run_all.py` | 638 passed, 34 failed, 95 skipped | 637 passed, 35 failed, 95 skipped: the same 34 fail, by name, and the 35th, `test_prepare_stall`, passes when rerun alone | | the site's `tests/guide-screenshots.test.ts` | 2 of 4 fail: "README menu table has an unknown tab" | the same 2 fail, the same 2 pass | | the picture (`settings-graphics.png`) | `3531f6ab…`, tabs: Graphics, Audio, Gameplay, Controls, Debug | `1b0d6de3…`, tabs: Graphics, Audio, Gameplay, Controls, NFC, Debug | The check on main, whole, as the program printed it (`python3 -I -B scripts/check_guide_screenshots.py --review-sources`, exit 1; the checkout's folder name is cut from the `vk_vendor.h` line): ``` ASSET OK: launcher-home.png (960x600) NOT CHECKED: launcher-home.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-saves.png (960x600) NOT CHECKED: launcher-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-import.png (960x600) NOT CHECKED: launcher-import.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: settings-graphics.png (1280x720) ASSET OK: launcher-manage-saves.png (960x600) NOT CHECKED: launcher-manage-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-game-files.png (960x600) NOT CHECKED: launcher-game-files.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-import-confirm.png (960x600) NOT CHECKED: launcher-import-confirm.png: Launcher UI sources; supply --launcher-source CHECKOUT REVIEW REQUIRED: settings-graphics.png: gpu/vk/device_policy.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/fallback_size_policy.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/menu_i18n.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_api.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_dlss.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_draw.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_framegen.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_fsr3fi.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_internal.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_menu.cpp changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_menu.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_temporal.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_texture.h changed since reviewed revision sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_vendor.h: [Errno 2] No such file or directory: '.../gpu/vk/vk_vendor.h' REVIEW REQUIRED: settings-graphics.png: fixture scripts/screenshots/menu.cpp changed Guide screenshot check failed: 15 issue(s). Review the affected UI and guide before updating review hashes. ``` On this PR's head (exit 0; the six Launcher pictures are `NOT CHECKED` here and on main alike: there is no Launcher checkout in CI): ``` ASSET OK: launcher-home.png (960x600) NOT CHECKED: launcher-home.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-saves.png (960x600) NOT CHECKED: launcher-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-import.png (960x600) NOT CHECKED: launcher-import.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: settings-graphics.png (1280x720) ASSET OK: launcher-manage-saves.png (960x600) NOT CHECKED: launcher-manage-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-game-files.png (960x600) NOT CHECKED: launcher-game-files.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-import-confirm.png (960x600) NOT CHECKED: launcher-import-confirm.png: Launcher UI sources; supply --launcher-source CHECKOUT Guide screenshot checks passed for the inputs checked above; NOT CHECKED items remain outstanding. ``` The renders (the capture helper from this PR's checkout for every one, so the fixture is the same unless said; clang 23.1.3, SDL2 2.32.74, libpng 1.6.59): | Pair | Differing pixels of 921,600 | Where | |---|---|---| | `415a8944c`, with its own fixture and with the new one | 0 | the fixture's two new stubs change nothing drawn | | `415a8944c` and `310e7c9df` | 13,009 | x 72 to 1047, y 0 to 54: the version text and the tab strip | | `415a8944c` and `c7db6c026` (everything before #280) | 1,192 | x 72 to 261, y 25 to 38: the version text only | | `c7db6c026` and `6d949cf95` (#280 alone) | 12,345 | the version text and the tab strip | | `6d949cf95` and `310e7c9df` (everything after #280) | 454 | x 122 to 191, y 25 to 35: the version text only | | `310e7c9df` rendered twice | 0 | byte-identical PNG and `menu-capture.json` | | the published PNG and the render of `415a8944c` | 60,449 | glyph edges and borders a pixel off, everywhere: a different toolchain (the manifest recorded clang 23.1.6, SDL2 2.32.10, libpng 1.6.57); inferred, not tested | The last row is why the comparison is between renders, and why the new picture is a render on the current toolchain, recorded as such. <details><summary>compare_renders.py</summary> ```python import sys import numpy as np from PIL import Image def load(path): im = Image.open(path).convert('RGB') assert im.size == (1280, 720) return np.asarray(im).astype(np.int16) a, b = load(sys.argv[1]), load(sys.argv[2]) d = np.abs(a - b).max(axis=2) ys, xs = np.nonzero(d) print(f'{len(ys)} of {d.size} pixels differ, largest channel difference {d.max()}') if len(ys): print(f'bounding box x {xs.min()}..{xs.max()}, y {ys.min()}..{ys.max()}') ``` </details> ### Pictures ![The top of the Graphics view in three pictures. Top: the published picture (tabs Graphics, Audio, Gameplay, Controls, Debug). Middle: the helper's render of `415a8944c`, the last commit the check passed on (the same five tabs; the version text differs because it is the build's). Bottom: the render of main `310e7c9df`, the new picture: Graphics, Audio, Gameplay, Controls, NFC, Debug, spaced for six.](https://git.magicbean.dev/attachments/0c62fe8d-ad49-4e78-946e-1b0d053c7f6e) ![The new picture dimmed, with the 13,009 pixels that differ from the render of `415a8944c` in red: all of them are in the banner's version text and the tab strip, none in a row, the help panel, the scrollbar or the key prompts.](https://git.magicbean.dev/attachments/1a1bed5b-7123-42d1-9588-0aea2a715dea) ![The new picture itself, as committed (1280x720, `sha256 1b0d6de3…`): Quality preset selected on Custom, Aspect ratio 16:9, Output resolution 2048x1152 (reduced), Custom output size None, Profile Docked, Upscaler Game's own, Render resolution Auto (dynamic), Sharpness 0%, Frame generation Off, Game frame rate cap 60 (the console's), the Quality preset help and the key prompts, as before.](https://git.magicbean.dev/attachments/948dd605-52cc-4439-beca-41fb8cd50dc8) ### Flags and settings None. ## Review of the recorded sources What each of the 14 sources and the fixture changed since `415a8944c`, and whether it alters what the picture shows (the full reading is in `source-review-fullscreen-monitor.md`): - `gpu/vk/vk_menu.cpp` (#1486, #280, #1318, #1442, #1388): **yes, one thing:** `tab_titles` and `TAB_COUNT` gain the NFC tab, so the strip shows six tabs. The rest is on rows or help this view does not show (Frame generation's help, the Frame pacing hints, Layout preset, the Controller menu button, the NFC rows, the pipeline-list message, `menu_memory_tier`). - `gpu/vk/vk_menu.h` (#280, #1388): no. `Options::pad_menu` (default 1) and a comment; the declarations of `menu_memory_tier` and `menu_rumble_tick`. - `gpu/vk/menu_i18n.h` (#1486, #1318, #1442): no. The other languages' tables and a helper that takes each table's length; the English strings are keys in `vk_menu.cpp`. - `gpu/vk/vk_framegen.h` (#1486): no. Declares `framegen_capped` and `framegen_now`; the fixture's `framegen_capped` returns the value as set, so Frame generation stays "Off". - `gpu/vk/vk_dlss.h` (#1486): no. Declares `dlss_fg_most` and rewords comments; the fixture answers 0. - `gpu/vk/vk_api.h` (#280, #1150): no. ABI 30 to 33: new host callbacks (rumble test, NFC) and `nvn_invalidate_quick`; the fixture's host is null. - `gpu/vk/vk_internal.h` (#1484, #1390, #560, #1150, #1442, #426): no. The `vk_vendor.h` include and `Device::fixes` go, `memory_priority` and declarations for frame overlap, memory sync and the preparation watchdog arrive; the fixture's `Device` is empty. - `gpu/vk/device_policy.h` (#1390, #1296, #426): no. The vendor fixes move here, `networks_left_out` is new, the Radeon 860M joins ASTC on the CPU, Mesa's Intel driver gets a phi limit: rules and log text the menu does not read. - `gpu/vk/fallback_size_policy.h` (#426): no. Phi and call limits for Mesa's Intel driver, used by the shader preparation. - `gpu/vk/vk_fsr3fi.h` (#1487): no. `Inputs::present`, an image view for FSR 3.1 frame generation's HUD-less mode. - `gpu/vk/vk_draw.h` (#391): no. `ub_overlay` takes a function pointer and an alignment. - `gpu/vk/vk_temporal.h` (#1447): no. Two declarations for the hidden-mesh rule. - `gpu/vk/vk_texture.h` (#1122, #1150): no. The `texture_ahead_*` declarations and `texture_gpu_written_ever`. - `gpu/vk/vk_vendor.h` (#1390): deleted, no. Its three fixes are in `device_policy.h` and nothing includes it; the helper's compiler pass lists 76 files, the previous 77 less this one. - fixture `scripts/screenshots/menu.cpp` (#1486): no. Two stubs (`dlss_fg_most` 0, `framegen_capped` the value as set) so the menu links; the old source rendered with the old and the new fixture gives identical PNGs. Each "no" rests on reading the change and on the pixel comparison above: the renders differ in the top 55 rows only, and #280 alone accounts for the tab strip. ## How to rerun it ```sh git fetch forge main git worktree add --detach ../ls-before 415a8944c git worktree add --detach ../ls-main 310e7c9df python -I scripts/screenshots/capture_menu.py --source ../ls-before --vulkan-headers /usr/include --output /tmp/render-before --views graphics python -I scripts/screenshots/capture_menu.py --source ../ls-main --vulkan-headers /usr/include --output /tmp/render-main --views graphics python compare_renders.py /tmp/render-before/settings-graphics.png /tmp/render-main/settings-graphics.png cmp /tmp/render-main/settings-graphics.png docs/images/guide/settings-graphics.png python -I -B scripts/check_guide_screenshots.py --review-sources python -I -B tests/test_guide_screenshots.py && python -I -B tests/test_launcher_capture.py ``` (`capture_menu.py` is run from the checkout that has this PR, so the fixture is the same for both renders; it needs a C++20 compiler, pkg-config, SDL2 and libpng development files and the Vulkan headers. `cmp` is silent when the committed picture is the render of main, given the same toolchain: clang 23.1.3, SDL2 2.32.74, libpng 1.6.59.) ## Testing **Tested:** on Linux x86-64 (kernel 7.2.15), clang 23.1.3, SDL2 2.32.74 (sdl2-compat), libpng 1.6.59, Python 3.12.16, Node 22.23.5, no GPU, on 17 Nov 2026, base main `310e7c9df`, head `0ce593910`. For this docs-only change "tested on my own PC" is the checks I ran: the Guide images check on main and here (above); the capture helper's renders from five commits, compared by pixel and looked at (the three pictures at full size, and three rows of the old and new at twice the size); `tests/test_guide_screenshots.py` (14), `tests/test_launcher_capture.py` (4) and `tests/test_check_pr_description.py` (51) pass; the whole `tests/run_all.py` through the idle gate, here and in a worktree of main `310e7c9df` (below); the site's `tests/guide-screenshots.test.ts`, with the site's packages from an unrelated checkout of the same lockfile: 2 of 4 pass here and on main (the two failures are the same on both, below). The suite, the launcher-capture and description-checker tests and the site test ran on this patch's first commit, `518d7f8de`; the head differs from it in one paragraph of the review note only, and the guide check and its 14 tests were rerun on the head. The whole suite, `python -I -B tests/run_all.py --jobs 8 --junit FILE`, here and on main: 637 passed, 35 failed, 95 skipped here (296 s), 638 passed, 34 failed, 95 skipped on main. The two JUnit files compared by test name: the same 767 tests in both, one status differs, `test_prepare_stall` (the watchdog's timing test of the shader preparation: it failed here at a load average near 40 on the PC, "the log lacks 'STOPPED: nothing moved for 12 s'", passed on main in its run, and passes here when run alone: 1 passed, 101 s). The 34 that fail on both, by name: `test_bug_report_defaults`, `test_compute_warm_apart`, `test_cpu_report`, `test_crt_options`, `test_damage_debug_menu`, `test_dev_packs`, `test_display_startup_failure`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_guest_imported`, `test_hud_layout_row`, `test_invalidate_quick`, `test_invalidate_vcore`, `test_libc_hooks`, `test_linux_preflight`, `test_linux_pressure`, `test_linux_update`, `test_log_open_failure`, `test_mirror_budget`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_pipeline_play_cache`, `test_present_thread`, `test_profiling_mode`, `test_psychov35_fsr3_fg`, `test_readback_timeout_source`, `test_run_all_changed`, `test_slow_frames`, `test_switch_table`, `test_target_image_pool`, `test_upscaler_rows`, `test_vcore_escape`, `test_walk_key`. They fail on main too, with the same status; I did not look into why they fail on this PC. The 95 skipped are the same tests on both (the run's log gives, for some, "not found here: vulkan_headers"). **Not tested:** the website's Settings page rendered: the site's own `renderPage` for it throws "README menu table has an unknown tab" (`website/src/repo-docs/graphics-settings.ts`) for the README's NFC rows, so `tests/guide-screenshots.test.ts` fails its two tests that render that page, on main and here alike (#280 added the tab without the site's list knowing it, which this PR does not touch); I did not run the site's build itself, and the caption and the picture on the page were not looked at; Windows and Intel (the picture is the UI-only fixture, not a live Vulkan frame, as its caption says); a render with the toolchain recorded for the old PNG (clang 23.1.6, SDL2 2.32.10, libpng 1.6.57); rows below the first Graphics view and the other tabs (the picture does not show them); no game was run, none is needed for a record, a note and a picture. **Must be tested:** - Any PC with a browser, by hand, once the site's tab list knows NFC: build and open the Settings page as `website/README.md` says, at desktop width and at 360 to 390 px, in both themes, expecting the new Graphics picture to load from the site's own files with its caption "development build 310e7c9d (Nightly 464)" and the six tabs readable (look at the picture and its caption, as the guide README's "Completing a refresh" asks). - A maintainer, by hand: look at the three pictures above and say whether "only the version text and the NFC tab differ" is a recapture you accept, expecting a yes or a change request (a person; the README says a hash match is not a visual review). ## Risks **What could break:** nothing at run time: a PNG, a JSON record and Markdown files. The one way to be wrong is the review itself: a difference I did not see between the old picture and the menu. I compared every pixel of the first Graphics view across five commits and read the rows, so the first view is the same except the tab strip; rows below it and the other tabs are not shown by the picture and not claimed. **Costs:** the PNG is 96,658 bytes, 3,720 more than before, on the Settings page of the site; nothing else, since nothing the game runs changes. **Turning it off:** revert the commit; the check is red again on main, as now. **Compatibility:** nothing changes for a player or for a saved setting. The site copies the PNG unchanged; its guide caption names the new build. ## Overlaps By the open pull requests' file lists (the forge's `pulls/N/files`), and for #1488 and #1489 a trial merge onto this PR's head with the check run on the result: #1467 (Reset to defaults at the top of the Graphics tab) and #68 (the co-op tab) also replace `settings-graphics.png` and edit its manifest entry, the caption and the provenance paragraph; each takes its own entry on rebase and renders the view again (the helper command above), now with six tabs underneath it. #1358, #1408, #1411 and #1426 also edit `manifest.json` (and #1358, #1411 and #1426 the review note), so each needs a rebase onto this; no trial merge was run for them. #1488 and #1489 merge onto this PR without a conflict, and the check on the result still fails, with exactly the files they themselves edit: #1488 names `gpu/vk/device_policy.h` (it includes `module_drop.h` and a rule that now covers Windows) and `gpu/vk/vk_draw.h` (`CommitNow` and `private_bytes_now` declarations), and its new include would add `module_drop.h` to the helper's dependency list (read from the include, not rendered); #1489 names `gpu/vk/vk_texture.h` (two members of the texture's eviction bookkeeping). Those are declarations and rules the menu does not draw, but each PR needs its own review line and hash update; this PR cannot carry them. ## Issues See #1466 (the last review of this picture) and #280 (the NFC tab). ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. (Docs only, nothing the game runs: the checks I ran are what Testing's Tested says.) - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. (Nothing the game runs changes; the one cost, the PNG's 3,720 bytes, is in Risks.) - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. (Based on `310e7c9df`, forge main when this was written.) - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). (34 tests fail here and on main, named under Testing; the 35th, `test_prepare_stall`, failed once under load and passes alone.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (The three pictures above: the same view rendered from `415a8944c` and from main, and the new picture.) - [x] Docs updated. New on this forge; not opened on GitHub.
docs(guides): recapture the Graphics guide image for the NFC tab and advance its review record
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 10s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Workflow lint (actionlint) (pull_request) Successful in 17s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 18s
Third-party parts / As their notes say (pull_request) Successful in 18s
PR description / Description follows the template (pull_request_target) Successful in 6s
0ce5939107
The guide-screenshot check was red on main: thirteen of settings-graphics.png's recorded sources changed since #1466,
gpu/vk/vk_vendor.h was deleted (#1390) and the capture fixture changed (#1486). Rendering the first Graphics view with the
project's capture helper from 415a8944c (the last commit the check passed on) and from main 310e7c9df, on one toolchain,
shows two differences, both in the top 55 rows: the build's version text, and the tab strip, which now lists the NFC tab
(#280) and is spaced for six tabs. Every row, value, help sentence, button prompt and the scrollbar are pixel-identical,
and the fixture's two new stubs change nothing drawn.

So the picture is replaced by the render of main, and its capture and review records advance with it: the image hash, the
capture revision, version and toolchain, the compiler-discovered source list (76 files, vk_vendor.h gone, nothing new), the
review revision (the SHA-256 of the sorted path=hash lines) and the fixture hash. The guide's caption names the new build,
the guide README's provenance paragraph says where the image comes from, and source-review-fullscreen-monitor.md records the
comparison and a line for each recorded source.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
mooki changed title from WIP: docs(guides): recapture the Graphics guide image for the NFC tab and advance its review record to docs(guides): recapture the Graphics guide image for the NFC tab and advance its review record 2026-11-18 01:36:37 +00:00
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 10s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Workflow lint (actionlint) (pull_request) Successful in 17s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 18s
Third-party parts / As their notes say (pull_request) Successful in 18s
PR description / Description follows the template (pull_request_target) Successful in 6s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'docs/guide-review-graphics:mooki-docs/guide-review-graphics'
git switch 'mooki-docs/guide-review-graphics'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1501
No description provided.