feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu #280

Open

airdamien wants to merge 5 commits from airdamien/Longshot:feat/nfc-tags into main

pull from: airdamien/Longshot:feat/nfc-tags

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 4 Commits 5 Files changed 30 +2000 -28

airdamien commented 2026-11-13 19:12:54 +00:00

First-time contributor

• Copy link
• Copy Markdown

Why

Where the game asks for a figure's NFC tag, nothing happens in Longshot: the console's NFC library (nn::nfp, 23 functions the game imports) is not there. This gives the game that library on tags of the player's own: dump files in a folder, chosen and "tapped" from a new NFC tab in the Insert menu, and real tags on a Switch 2 Pro Controller's reader.

What changed

• runtime: host/nn_nfp.c (new): nn::nfp on a pretended reader. The tags are files in the player's NFC folder (hos_nfc_dir: %LOCALAPPDATA%\Longshot\nfc, $XDG_DATA_HOME/longshot/nfc, or LONGSHOT_NFC_DIR): an NTAG215's 540 bytes (.bin) or a Flipper Zero NFC file (.nfc), checked in load_tag. Only the tag's ID and the figure's model are read from one (both plain on a tag): no key is needed or used. What the game writes to a tag (its application area) is kept in a file beside the saves (area_load, area_save), and no tag is written. The device's states follow what the game polls (GetDeviceState: searching, found, mounted).
• runtime: the Switch 2 Pro Controller's reader (reader_main, reader_read, scan_run, Windows, over the controller pull request's hos_switch2_command): while the game waits for a tag and none of the files is held to the reader, a real tag on the controller is read and, when it is a figure's, given to the game; a scan copies one into the folder. The reader's commands are in the file's comment as the controller answered them.
• runtime: host/nn_os_sync.c hos_event_init (an event of the OS layer's own making); host/rx_backend.c and gpu/vk/vk_api.h: MkwVkHost gets nfc_count, nfc_name, nfc_tap, nfc_state, nfc_dir, nfc_scan, nfc_scan_name (MKWVK_API_VERSION 23: the controller pull request takes 22).
• menu: gpu/vk/vk_menu.cpp: an NFC tab: the NFC tag row (the folder's files by name, listed again each time the menu opens: refresh_nfc), Tap tag, Remove tag, Scan tag on controller (nfc_press, nfc_scan_says).
• docs: docs/nfc.md (new), README (the tab's rows and a paragraph), docs/development.md (three switches).
• runtime: the list is the first 256 tag files by name (add_file): it stopped at 256 while the folder was still being read and sorted after, so past 256 files it held whichever the folder gave first. Asked for in the review of the launcher's page (MagicBeanDev/LongshotLauncher#49 (comment)).
• tests: tests/test_readme_menu_rows.py covers the NFC tab's rows; tests/test_menu_keys.py gets a stub for refresh_nfc. tests/test_nfc_list_cap.py (new): tag_ending, by_name and add_file as they are in the source, fed 300 names in three orders; fails on the code before.

Flags and settings

Flag	What it does	Default now	Recommendation	Helps on	Doesn't help on	Untested on
Insert menu, NFC tab: NFC tag (nfc_tag), Tap tag, Remove tag, Scan tag on controller	Choose one of the folder's tags, hold it to the game's reader, take it away; read one from a controller into the folder	The first tag; nothing held	As it is	Any PC	-	Linux at run time
LONGSHOT_NFC_DIR=<folder>	Another folder of tag files	Unset: the user's own	Unset	Tests; a portable set-up	-	-
HOS_NFP_TRACE=1	The application area's calls in the log	Off	Off	Debugging	-	-
HOS_NFP_SEARCH=1	A test's: the reader looks for a tag from the start	Off	Off	Checking the controller's reader without the game's NFC screen	-	-

Measurements

main: fbd42024 (2026-11-13)
this PR: feat/nfc-tags @ 1dd5ec73 (the measured commit; b99145e0 after it added only the row in docs/tested-configurations.md)
Hardware: NVIDIA GeForce RTX 5080 (Vulkan driver 0x93cec000), Windows 11; a Switch 2 Pro Controller (firmware 1.1.5) plugged in over USB
Scene: the save's load point, Link standing still; 3840x2160 output, DLSS, frame generation 3x, the game's frame rate cap 60
Method: 150 s runs, the first 60 s left out, two interleaved runs each (main, this PR, ...). The numbers are RX_VK_FRAME_LOG's frame times, a line per present (made frames included); the game's own rate is longshot_log.txt's vi: line.
How to reproduce: the builds from the same dump with nx2/make_game.py, the same longshot_options.ini and save, HOS_INPUT_SCRIPT=12:A,15:A,...,42:A HOS_INPUT_SCRIPT_BACKGROUND=1 RX_VK_FRAME_LOG=<csv>.

	main @ fbd42024	this PR @ 1dd5ec73
presents per second (run 1 / run 2)	179.18 / 179.81	179.92 / 180.00
median frame time (run 1 / run 2)	5.556 / 5.563 ms	5.551 / 5.548 ms
p99 frame time (run 1 / run 2)	6.676 / 5.708 ms	6.079 / 5.796 ms
the game's own rate	60.0 fps	60.0 fps

main1: 16085 frames in 89.8 s after 60 s warm-up: 179.18 fps, median 5.556 ms, p99 6.676 ms, max 67.70 ms
main2: 16115 frames in 89.6 s after 60 s warm-up: 179.81 fps, median 5.563 ms, p99 5.708 ms, max 67.95 ms
nfc1:  16146 frames in 89.7 s after 60 s warm-up: 179.92 fps, median 5.551 ms, p99 6.079 ms, max 82.08 ms
nfc2:  16157 frames in 89.8 s after 60 s warm-up: 180.00 fps, median 5.548 ms, p99 5.796 ms, max 22.22 ms
[hos Presentation Thread] vi: 8321 frames presented (60.0 fps over the last 5.0 s, interval 1)   (main)
[hos Presentation Thread] vi: 8412 frames presented (60.0 fps over the last 5.0 s, interval 1)   (this PR)

The measured build was made before the branch was put on the controller pull request's last commit (a docs row); its code is the same.

Rebased since onto main @ 514591a3 (the branch's head is now ea2cbd4b) and not measured again: main's ten commits since fbd42024 are the website, docs, the forge script, a Damage taken row, an HDR route for FSR 4 that is opt-in, occlusion query numbering, quick pipelines and two input fixes; none is in this change's path, and the rebase of this pull request's own commit had no conflict. The rebased branch was built whole (nx2/make_game.py) and its checks run. Rebased again onto main @ cf605c85 (the head is now f15350db) and not measured again: main's 34 commits since 514591a3 are renderer, host and docs work none of which is in this change's path (sparse VRAM mirrors, late readbacks, the recorder thread, Intel fixes, hold-to-toggle, a Mono choice, the caches' and logs' folders); this pull request's own commit conflicted only with the controller pull request's new rumble_test (the NFC functions follow it in MkwVkHost, MKWVK_API_VERSION 23), and the measured run is now a file under docs/tested/.

Testing

Tested:

• python -I -B tests/run_all.py on Windows 11 (llvm-mingw): 478 passed, 7 failed, at the head (85d27e5e). The same 7 fail on main @ cf605c85 on this PC (test_bake_portability, test_fpx_sticky, test_module_ids, test_oot_state_tap, test_pad_layout, test_spawn_emit, test_tested_configurations): local tools and packages, line endings in a pipe, and a fixture of main's that does not compile here, not this change.
• Linux (WSL, Ubuntu 24.04, clang): RX_VK_ONLY=1 nx2/build.py --standalone compiles and links longshot_vk.so; host/nn_nfp.c, host/nn_os_sync.c, host/rx_backend.c compile (-fsyntax-only with the build's includes).
• In the game (RTX 5080, Windows 11): the game starts its reader (nfp: the game uses NFC tags: ...); the NFC tab lists the folder's files; Tap tag holds one to the reader (nfp: the NFC tag "..." held to the reader (model ...); the game is not asking for one now), Remove tag takes it away.
• The controller's reader, on a real controller (firmware 1.1.5) with a real, blank NTAG215 on it: found, read whole without the password after the password is refused, and turned down as no figure's tag, both while the game waits (HOS_NFP_SEARCH=1) and from the Scan row (nfp: scan: the tag (UID ...) was read, but it is not a figure's tag: not saved).
• The game reading tags to the end, by the author in play (RTX 5080, Windows 11, a build of this code that also has the VR and controller pull requests' changes, 35c10356): at the game's NFC screen, six tags in one session, from the menu and from the controller. The log of that session: nfp: the game waits for an NFC tag six times, each followed by nfp: the game reads the NFC tag "..." and nfp: the game stopped waiting for an NFC tag; once nfp: a tag read on the controller (model 0105000003580902): given to the game, a figure's real tag on the Switch 2 Pro Controller; tags tapped both ahead (... the game is not asking for one now: it stays there until it does) and while it waited (... the game was waiting for one). No nn::nfp import was left unimplemented and nothing crashed.
• Scan tag on controller saving a figure's tag, by the author (the same build and PC, a figure's real tag on the Switch 2 Pro Controller): nfp: scan: waiting ten seconds for a tag on the controller, then nfp: the tag on the controller was scanned into the folder as "Scanned <ID>" (model 0105000003580902); the 540-byte file is in the folder.

Not tested:

• What the game writes to a tag over several days or saves (the application area's file beside the saves was not looked at across sessions).
• Linux at run time.

Needs other testers:

• Linux, any GPU: the NFC tab lists a folder's tags and the game takes a tapped one, expecting the same as on Windows (T-KZYU)

Screenshots

The NFC tab, this PR @ 1dd5ec73, on pretended tags (main has no such tab):

Risk and rollback

• The game called nn::nfp::Initialize and AttachAvailabilityChangeEvent at start before (logged as unimplemented imports, returning as they were); now they do something: a reader that is always there. A game path that waited on the reader's event now goes on.
• MKWVK_API_VERSION goes to 23: the exe and the renderer must be of one build, as at every bump.
• The NFC tag row's choice is written to the options file as nfc_tag=<its place in the list>, as any row's; it means nothing to another build.
• No dump is in the repository, and the docs say none may be. The checks need none.
• Reverting the commit is enough.

Reviewer notes

• Sits on the controller pull request (#279): review that one first; this one's own commit is the second.
• The launcher's NFC page (MagicBeanDev/LongshotLauncher#49) fills the same folder.
• The word for the figures' tags is "NFC tag" everywhere a player or a reader of the code sees it.
• Not claimed in #dev-work beforehand.

Issues

None.

Checklist

For everyone

• One topic.
• The title is a Conventional Commit (type(scope): description).
• Rebased on current main.
• python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
• Tested in the game, or what wasn't is named under Testing.
• Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
• Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• Flags noted, and the switch reference updated (docs/development.md, the README).
• Screenshots for a change that shows on screen.
• A row in docs/tested-configurations.md for each measured run (now a file under docs/tested/: 2026-11-13-nfc-tags-airdamien-run01.md).
• MKWVK_API_VERSION bumped (gpu/vk/vk_api.h's MkwVkHost or MkwVkRenderer changed).
• A check under tests/ that reads changed source updated in this PR, not weakened.
• Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
• Docs updated.

🤖 Generated with Claude Code

## Why Where the game asks for a figure's NFC tag, nothing happens in Longshot: the console's NFC library (`nn::nfp`, 23 functions the game imports) is not there. This gives the game that library on tags of the player's own: dump files in a folder, chosen and "tapped" from a new NFC tab in the Insert menu, and real tags on a Switch 2 Pro Controller's reader. ## What changed - runtime: `host/nn_nfp.c` (new): `nn::nfp` on a pretended reader. The tags are files in the player's NFC folder (`hos_nfc_dir`: `%LOCALAPPDATA%\Longshot\nfc`, `$XDG_DATA_HOME/longshot/nfc`, or `LONGSHOT_NFC_DIR`): an NTAG215's 540 bytes (`.bin`) or a Flipper Zero NFC file (`.nfc`), checked in `load_tag`. Only the tag's ID and the figure's model are read from one (both plain on a tag): no key is needed or used. What the game writes to a tag (its application area) is kept in a file beside the saves (`area_load`, `area_save`), and no tag is written. The device's states follow what the game polls (`GetDeviceState`: searching, found, mounted). - runtime: the Switch 2 Pro Controller's reader (`reader_main`, `reader_read`, `scan_run`, Windows, over the controller pull request's `hos_switch2_command`): while the game waits for a tag and none of the files is held to the reader, a real tag on the controller is read and, when it is a figure's, given to the game; a scan copies one into the folder. The reader's commands are in the file's comment as the controller answered them. - runtime: `host/nn_os_sync.c` `hos_event_init` (an event of the OS layer's own making); `host/rx_backend.c` and `gpu/vk/vk_api.h`: `MkwVkHost` gets `nfc_count`, `nfc_name`, `nfc_tap`, `nfc_state`, `nfc_dir`, `nfc_scan`, `nfc_scan_name` (`MKWVK_API_VERSION` 23: the controller pull request takes 22). - menu: `gpu/vk/vk_menu.cpp`: an **NFC** tab: the NFC tag row (the folder's files by name, listed again each time the menu opens: `refresh_nfc`), Tap tag, Remove tag, Scan tag on controller (`nfc_press`, `nfc_scan_says`). - docs: `docs/nfc.md` (new), README (the tab's rows and a paragraph), `docs/development.md` (three switches). - runtime: the list is the first 256 tag files by name (`add_file`): it stopped at 256 while the folder was still being read and sorted after, so past 256 files it held whichever the folder gave first. Asked for in the review of the launcher's page (https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/49#issuecomment-15451). - tests: `tests/test_readme_menu_rows.py` covers the NFC tab's rows; `tests/test_menu_keys.py` gets a stub for `refresh_nfc`. `tests/test_nfc_list_cap.py` (new): `tag_ending`, `by_name` and `add_file` as they are in the source, fed 300 names in three orders; fails on the code before. ## Flags and settings | Flag | What it does | Default now | Recommendation | Helps on | Doesn't help on | Untested on | |---|---|---|---|---|---|---| | Insert menu, NFC tab: NFC tag (`nfc_tag`), Tap tag, Remove tag, Scan tag on controller | Choose one of the folder's tags, hold it to the game's reader, take it away; read one from a controller into the folder | The first tag; nothing held | As it is | Any PC | - | Linux at run time | | `LONGSHOT_NFC_DIR=<folder>` | Another folder of tag files | Unset: the user's own | Unset | Tests; a portable set-up | - | - | | `HOS_NFP_TRACE=1` | The application area's calls in the log | Off | Off | Debugging | - | - | | `HOS_NFP_SEARCH=1` | A test's: the reader looks for a tag from the start | Off | Off | Checking the controller's reader without the game's NFC screen | - | - | ## Measurements main: fbd42024 (2026-11-13) this PR: feat/nfc-tags @ 1dd5ec73 (the measured commit; b99145e0 after it added only the row in docs/tested-configurations.md) Hardware: NVIDIA GeForce RTX 5080 (Vulkan driver 0x93cec000), Windows 11; a Switch 2 Pro Controller (firmware 1.1.5) plugged in over USB Scene: the save's load point, Link standing still; 3840x2160 output, DLSS, frame generation 3x, the game's frame rate cap 60 Method: 150 s runs, the first 60 s left out, two interleaved runs each (main, this PR, ...). The numbers are `RX_VK_FRAME_LOG`'s frame times, a line per present (made frames included); the game's own rate is `longshot_log.txt`'s `vi:` line. How to reproduce: the builds from the same dump with `nx2/make_game.py`, the same `longshot_options.ini` and save, `HOS_INPUT_SCRIPT=12:A,15:A,...,42:A HOS_INPUT_SCRIPT_BACKGROUND=1 RX_VK_FRAME_LOG=<csv>`. | | main @ fbd42024 | this PR @ 1dd5ec73 | |---|---|---| | presents per second (run 1 / run 2) | 179.18 / 179.81 | 179.92 / 180.00 | | median frame time (run 1 / run 2) | 5.556 / 5.563 ms | 5.551 / 5.548 ms | | p99 frame time (run 1 / run 2) | 6.676 / 5.708 ms | 6.079 / 5.796 ms | | the game's own rate | 60.0 fps | 60.0 fps | ``` main1: 16085 frames in 89.8 s after 60 s warm-up: 179.18 fps, median 5.556 ms, p99 6.676 ms, max 67.70 ms main2: 16115 frames in 89.6 s after 60 s warm-up: 179.81 fps, median 5.563 ms, p99 5.708 ms, max 67.95 ms nfc1: 16146 frames in 89.7 s after 60 s warm-up: 179.92 fps, median 5.551 ms, p99 6.079 ms, max 82.08 ms nfc2: 16157 frames in 89.8 s after 60 s warm-up: 180.00 fps, median 5.548 ms, p99 5.796 ms, max 22.22 ms [hos Presentation Thread] vi: 8321 frames presented (60.0 fps over the last 5.0 s, interval 1) (main) [hos Presentation Thread] vi: 8412 frames presented (60.0 fps over the last 5.0 s, interval 1) (this PR) ``` The measured build was made before the branch was put on the controller pull request's last commit (a docs row); its code is the same. Rebased since onto main @ 514591a3 (the branch's head is now ea2cbd4b) and not measured again: main's ten commits since fbd42024 are the website, docs, the forge script, a Damage taken row, an HDR route for FSR 4 that is opt-in, occlusion query numbering, quick pipelines and two input fixes; none is in this change's path, and the rebase of this pull request's own commit had no conflict. The rebased branch was built whole (`nx2/make_game.py`) and its checks run. Rebased again onto main @ cf605c85 (the head is now f15350db) and not measured again: main's 34 commits since 514591a3 are renderer, host and docs work none of which is in this change's path (sparse VRAM mirrors, late readbacks, the recorder thread, Intel fixes, hold-to-toggle, a Mono choice, the caches' and logs' folders); this pull request's own commit conflicted only with the controller pull request's new `rumble_test` (the NFC functions follow it in `MkwVkHost`, `MKWVK_API_VERSION` 23), and the measured run is now a file under `docs/tested/`. ## Testing **Tested:** - `python -I -B tests/run_all.py` on Windows 11 (llvm-mingw): 478 passed, 7 failed, at the head (85d27e5e). The same 7 fail on `main` @ cf605c85 on this PC (`test_bake_portability`, `test_fpx_sticky`, `test_module_ids`, `test_oot_state_tap`, `test_pad_layout`, `test_spawn_emit`, `test_tested_configurations`): local tools and packages, line endings in a pipe, and a fixture of main's that does not compile here, not this change. - Linux (WSL, Ubuntu 24.04, clang): `RX_VK_ONLY=1 nx2/build.py --standalone` compiles and links `longshot_vk.so`; `host/nn_nfp.c`, `host/nn_os_sync.c`, `host/rx_backend.c` compile (`-fsyntax-only` with the build's includes). - In the game (RTX 5080, Windows 11): the game starts its reader (`nfp: the game uses NFC tags: ...`); the NFC tab lists the folder's files; Tap tag holds one to the reader (`nfp: the NFC tag "..." held to the reader (model ...); the game is not asking for one now`), Remove tag takes it away. - The controller's reader, on a real controller (firmware 1.1.5) with a real, blank NTAG215 on it: found, read whole without the password after the password is refused, and turned down as no figure's tag, both while the game waits (`HOS_NFP_SEARCH=1`) and from the Scan row (`nfp: scan: the tag (UID ...) was read, but it is not a figure's tag: not saved`). - **The game reading tags to the end, by the author in play** (RTX 5080, Windows 11, a build of this code that also has the VR and controller pull requests' changes, 35c10356): at the game's NFC screen, six tags in one session, from the menu and from the controller. The log of that session: `nfp: the game waits for an NFC tag` six times, each followed by `nfp: the game reads the NFC tag "..."` and `nfp: the game stopped waiting for an NFC tag`; once `nfp: a tag read on the controller (model 0105000003580902): given to the game`, a figure's real tag on the Switch 2 Pro Controller; tags tapped both ahead (`... the game is not asking for one now: it stays there until it does`) and while it waited (`... the game was waiting for one`). No `nn::nfp` import was left unimplemented and nothing crashed. - **Scan tag on controller saving a figure's tag, by the author** (the same build and PC, a figure's real tag on the Switch 2 Pro Controller): `nfp: scan: waiting ten seconds for a tag on the controller`, then `nfp: the tag on the controller was scanned into the folder as "Scanned <ID>" (model 0105000003580902)`; the 540-byte file is in the folder. **Not tested:** - What the game writes to a tag over several days or saves (the application area's file beside the saves was not looked at across sessions). - Linux at run time. **Needs other testers:** - Linux, any GPU: the NFC tab lists a folder's tags and the game takes a tapped one, expecting the same as on Windows (T-KZYU) ## Screenshots The NFC tab, this PR @ 1dd5ec73, on pretended tags (`main` has no such tab):  ## Risk and rollback - The game called `nn::nfp::Initialize` and `AttachAvailabilityChangeEvent` at start before (logged as unimplemented imports, returning as they were); now they do something: a reader that is always there. A game path that waited on the reader's event now goes on. - `MKWVK_API_VERSION` goes to 23: the exe and the renderer must be of one build, as at every bump. - The NFC tag row's choice is written to the options file as `nfc_tag=<its place in the list>`, as any row's; it means nothing to another build. - No dump is in the repository, and the docs say none may be. The checks need none. - Reverting the commit is enough. ## Reviewer notes - Sits on the controller pull request (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/279): review that one first; this one's own commit is the second. - The launcher's NFC page (https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/49) fills the same folder. - The word for the figures' tags is "NFC tag" everywhere a player or a reader of the code sees it. - Not claimed in `#dev-work` beforehand. ## Issues None. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Flags noted, and the switch reference updated (docs/development.md, the README). - [x] Screenshots for a change that shows on screen. - [x] A row in `docs/tested-configurations.md` for each measured run (now a file under `docs/tested/`: `2026-11-13-nfc-tags-airdamien-run01.md`). - [x] `MKWVK_API_VERSION` bumped (`gpu/vk/vk_api.h`'s `MkwVkHost` or `MkwVkRenderer` changed). - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nfc-tab.png

713 KiB

airdamien referenced this pull request 2026-11-13 19:13:31 +00:00

feat(input): the Nintendo Switch 2 Pro Controller over USB, read by the game itself #279

airdamien referenced this pull request from MagicBeanDev/LongshotLauncher 2026-11-13 19:13:34 +00:00

feat(nfc): an NFC page for the tag dumps the game's NFC tab lists #49

airdamien commented 2026-11-13 19:24:13 +00:00

Author

First-time contributor

• Copy link
• Copy Markdown

Tested in play by the author: at the game's NFC screen the game read six tags in one session, from the Insert menu's NFC tab and, once, a figure's real tag on the Switch 2 Pro Controller's reader (the log's lines are in the description). The two requests that asked for that (T-3UQZ, T-LHBX) are withdrawn; one for Linux is open (T-KZYU). Marking it ready.

Tested in play by the author: at the game's NFC screen the game read six tags in one session, from the Insert menu's NFC tab and, once, a figure's real tag on the Switch 2 Pro Controller's reader (the log's lines are in the description). The two requests that asked for that (T-3UQZ, T-LHBX) are withdrawn; one for Linux is open (T-KZYU). Marking it ready.

airdamien changed title from WIP: feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu to feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu 2026-11-13 19:24:15 +00:00

airdamien force-pushed feat/nfc-tags from b99145e0ba to ea2cbd4bb9 2026-11-13 19:55:46 +00:00 Compare

airdamien commented 2026-11-13 19:56:11 +00:00

Author

First-time contributor

• Copy link
• Copy Markdown

Rebased with the controller pull request onto main @ 514591a3 (head ea2cbd4b), no conflict in this one's own commit. Built whole and the checks run. Also tested since, by the author: Scan tag on controller saved a figure's real tag into the folder (nfp: the tag on the controller was scanned into the folder as "Scanned <ID>").

Rebased with the controller pull request onto main @ 514591a3 (head ea2cbd4b), no conflict in this one's own commit. Built whole and the checks run. Also tested since, by the author: Scan tag on controller saved a figure's real tag into the folder (`nfp: the tag on the controller was scanned into the folder as "Scanned <ID>"`).

HumanBean referenced this pull request from MagicBeanDev/LongshotLauncher 2026-11-14 00:32:31 +00:00

feat(nfc): an NFC page for the tag dumps the game's NFC tab lists #49

HumanBean referenced this pull request from MagicBeanDev/LongshotLauncher 2026-11-14 01:07:40 +00:00

feat(nfc): an NFC page for the tag dumps the game's NFC tab lists #49

mooki added the

area/input

area/menu

area/saves

kind

feature

platform/windows

labels 2026-11-14 01:45:38 +00:00

airdamien force-pushed feat/nfc-tags from ea2cbd4bb9 to f15350db31 2026-11-14 03:30:16 +00:00 Compare

airdamien commented 2026-11-14 03:30:54 +00:00

Author

First-time contributor

• Copy link
• Copy Markdown

Rebased with the controller pull request onto main @ cf605c85 (head f15350db). The NFC functions now follow that pull request's rumble_test in MkwVkHost: MKWVK_API_VERSION 23. The measured run is a file under docs/tested/. 477 passed; the 7 that fail also fail on main here.

Rebased with the controller pull request onto main @ cf605c85 (head f15350db). The NFC functions now follow that pull request's `rumble_test` in `MkwVkHost`: `MKWVK_API_VERSION` 23. The measured run is a file under `docs/tested/`. 477 passed; the 7 that fail also fail on main here.

mooki added the

priority

low

label 2026-11-14 04:18:28 +00:00

APusija04 referenced this pull request 2026-11-14 05:05:21 +00:00

[RX 6600] Game crashes with GPU timeout #365

airdamien added 1 commit 2026-11-14 05:25:15 +00:00

fix(nfc): the list is the first 256 tag files by name, not the first 256 the folder gave ... 85d27e5ef8

add_file stopped taking files at NFC_MAX while the folder was still being read, and list_files sorted after: past 256
files the menu had whichever the folder gave first. Once the list is full, a file now takes the place of the last by
name when it comes before it, so the list is the first 256 by name whatever the order. Asked for in the review of the
launcher's NFC page (LongshotLauncher#49), whose note about the 256 can say "the first 256 by name" again.

tests/test_nfc_list_cap.py: tag_ending, by_name and add_file as they are in the source, fed 300 names as sorted, the
other way round and shuffled; fails on the code before (place 0 "Tag 0044", not "Tag 0000").

Assisted-by: Claude Code
Co-Authored-By: Claude Fable 5.2 <[email protected]>

airdamien commented 2026-11-14 05:25:15 +00:00

Author

First-time contributor

• Copy link
• Copy Markdown

The review of the launcher's NFC page (MagicBeanDev/LongshotLauncher#49 (comment)) found that the game did not list "the first 256 by name": add_file() stopped at NFC_MAX while the folder was still being read and list_files() sorted after, so past 256 files the menu had whichever the folder gave first. Fixed here as asked (sort, then cap, in effect): 85d27e5e. Once the list is full, a file takes the place of the last by name when it comes before it, so the list is the first 256 by name whatever order the folder gives. key_ files and files that are no tag's by their ending are left out before that, as they were. tests/test_nfc_list_cap.py runs the three functions as they are in the source on 300 names as sorted, reversed and shuffled, and fails on the code before (place 0 "Tag 0044", not "Tag 0000"). tests/run_all.py: 478 passed; the 7 that fail also fail on main here. Not built whole or run in the game since this commit: the change is those few lines, compiled by the check with -Wall -Werror.

The review of the launcher's NFC page (https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/49#issuecomment-15451) found that the game did not list "the first 256 by name": `add_file()` stopped at `NFC_MAX` while the folder was still being read and `list_files()` sorted after, so past 256 files the menu had whichever the folder gave first. Fixed here as asked (sort, then cap, in effect): 85d27e5e. Once the list is full, a file takes the place of the last by name when it comes before it, so the list is the first 256 by name whatever order the folder gives. `key_` files and files that are no tag's by their ending are left out before that, as they were. `tests/test_nfc_list_cap.py` runs the three functions as they are in the source on 300 names as sorted, reversed and shuffled, and fails on the code before (place 0 "Tag 0044", not "Tag 0000"). `tests/run_all.py`: 478 passed; the 7 that fail also fail on main here. Not built whole or run in the game since this commit: the change is those few lines, compiled by the check with `-Wall -Werror`.

airdamien referenced this pull request from MagicBeanDev/LongshotLauncher 2026-11-14 05:25:15 +00:00

feat(nfc): an NFC page for the tag dumps the game's NFC tab lists #49

airdamien force-pushed feat/nfc-tags from 85d27e5ef8 to 80cfd9c512 2026-11-14 05:37:20 +00:00 Compare

mooki added the

gpu/nvidia

label 2026-11-14 18:22:43 +00:00

SocialWare referenced this pull request 2026-11-15 13:27:34 +00:00

Game: Crash in Hyrule field after opening and closing map #809

Some checks are pending

Hide checks

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request) Blocked by required conditions

Details

PR description / Description follows the template (pull_request_target) Successful in 20s

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

This pull request has changes conflicting with the target branch.

• README.md
• gpu/vk/vk_api.h
• gpu/vk/vk_menu.cpp
• host/rx_backend.c

Some workflows are waiting to be reviewed.

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu (#280)

Merge commit body Reviewed-on: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/280

feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu (#280) Reviewed-on: https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/280 Copy merge commit message

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'feat/nfc-tags:airdamien-feat/nfc-tags'

git switch 'airdamien-feat/nfc-tags'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/upscaling

DLSS, FSR, frame generation

  

beanstalk: approved @ 1697603

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 2c5a62e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 4fd82b7

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 64d6d09

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 6f91fae

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 70a78f9

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8d361dc

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 9d8356e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ abf2227

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ d82f202

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ e5f1e40

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ ee8ab5f

Set by Beanstalk for show; the farm's database is what counts

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/upscaling

beanstalk: approved @ 1697603

beanstalk: approved @ 2c5a62e

beanstalk: approved @ 4fd82b7

beanstalk: approved @ 64d6d09

beanstalk: approved @ 6f91fae

beanstalk: approved @ 70a78f9

beanstalk: approved @ 8d361dc

beanstalk: approved @ 9d8356e

beanstalk: approved @ abf2227

beanstalk: approved @ d82f202

beanstalk: approved @ e5f1e40

beanstalk: approved @ ee8ab5f

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!280

No description provided.