test(pacing): characterize current cap and present policy #1591

Open
futondestroyer wants to merge 1 commit from futondestroyer/Longshot:test/issue-1519-pacing-policy into main
Member

Type: test · Risk: low · Tested on: Windows, llvm-mingw · Needs: none

TL;DR

Pacing choices made by the game host, renderer, and FPS overlay are easy to change independently. A new game-free check records their current behavior so later changes can identify which decisions moved. All 12 focused checks passed.

Breakdown

  • Who it helps: Players who use caps, V-Sync, and frame generation, and the maintainers testing those settings.
  • What was wrong: Existing checks did not compare these pacing decisions side by side.
  • What changes: The test suite checks host caps, movie overrides, present-mode selection, and fixed frame-generation budgets.
  • What does not change: Runtime behavior and player settings.
  • How it was checked: Twelve focused Windows llvm-mingw checks passed. The broader run had 616 passes, 44 failures reproduced on main, and 121 skips.
  • What is still open: Display cadence and VRR engagement need hardware evidence before runtime policy changes.
  • Risk: Low. A source move can require updating a fixture cut point.

Why

Several owners make timing decisions from the same settings. The pacing rewrite needs a reference for the current policy before changing who owns those decisions. See #1519.

What changed

tests/test_pacing_policy.py compiles selected production statements using the existing source-cut fixture helper. It exercises 13 host and overlay cases, 192 present-mode combinations plus fallback, and 16 fixed frame-generation allocation cases. The results capture the host's temporary 240 FPS movie cap with a 60 FPS overlay target, and FIFO selected under V-Sync Auto for fixed DLSS frame generation.

  • Pacing fixture: host_row, mode_rows, and fg_rows in tests/test_pacing_policy.py compare the expected host, present, and fixed-FG decisions.

Measurements

Verdict: Game-free fixture only. Performance measurement does not apply.

Flags and settings

None.

Testing

Tested: All 12 focused Windows llvm-mingw checks passed. The game-free suite at 48f608ca recorded 616 passes, 44 failures reproduced on main, and 121 skips. Each failing check was rerun against exact main 876dc360 with the same compiler configuration.

All 44 reproduced main failures
  • tests/test_auto_handheld.py
  • tests/test_bake_ds.py
  • tests/test_bug_report_defaults.py
  • tests/test_build_long_paths.py
  • tests/test_cpu_report.py
  • tests/test_crash_dialog.py
  • tests/test_crt_options.py
  • tests/test_damage_debug_menu.py
  • tests/test_dev_packs.py
  • tests/test_discover.py
  • tests/test_display_startup_failure.py
  • tests/test_dlss_feature_size.py
  • tests/test_failed_compile_keeps_objects.py
  • tests/test_fastfp_fma.py
  • tests/test_fpx_sticky.py
  • tests/test_game_menu_mouse_buttons.py
  • tests/test_guest_imported.py
  • tests/test_hud_layout_row.py
  • tests/test_invalidate_quick.py
  • tests/test_invalidate_vcore.py
  • tests/test_job_queue.py
  • tests/test_libc_hooks.py
  • tests/test_lift_lookups.py
  • tests/test_linux_preflight.py
  • tests/test_linux_pressure.py
  • tests/test_mirror_budget.py
  • tests/test_missing_nup.py
  • tests/test_pads_after_menu.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_play_cache.py
  • tests/test_present_thread.py
  • tests/test_profiling_mode.py
  • tests/test_psychov35_fsr3_fg.py
  • tests/test_readback_timeout_source.py
  • tests/test_release.py
  • tests/test_run_all_changed.py
  • tests/test_sdiv_overflow.py
  • tests/test_slow_frames.py
  • tests/test_spawn_emit.py
  • tests/test_switch_table.py
  • tests/test_tested_configurations.py
  • tests/test_upscaler_rows.py
  • tests/test_walk.py
  • tests/test_walk_key.py

The Guide screenshots job also fails on main. The local checker lists the same Graphics guide review items on the baseline and rebase candidate. The screenshot update is tracked in #1501.

Not tested: Displayed cadence and VRR engagement. The fixture exercises policy decisions, and hardware coverage belongs to the follow-on runtime work.

Must be tested: None for this fixture.

Risks

What could break: A source refactor can invalidate a fixture extraction anchor.

Turning it off: Revert the commit.

Compatibility: Runtime and player data are unaffected.

Issues

See #1519.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit of the status line's type.
  • Why gives the reason plainly and links the issues that fit.
  • Tested on my own PC where it runs.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of. Risks describes the test maintenance cost.
  • Testing names what was tested, what wasn't, and what must still be tested.
  • Rebased on current main (876dc360).
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK.

When it applies

  • AI assistance recorded with an Assisted-by: trailer.
**Type:** test · **Risk:** low · **Tested on:** Windows, llvm-mingw · **Needs:** none ## TL;DR Pacing choices made by the game host, renderer, and FPS overlay are easy to change independently. A new game-free check records their current behavior so later changes can identify which decisions moved. All 12 focused checks passed. ## Breakdown - **Who it helps:** Players who use caps, V-Sync, and frame generation, and the maintainers testing those settings. - **What was wrong:** Existing checks did not compare these pacing decisions side by side. - **What changes:** The test suite checks host caps, movie overrides, present-mode selection, and fixed frame-generation budgets. - **What does not change:** Runtime behavior and player settings. - **How it was checked:** Twelve focused Windows llvm-mingw checks passed. The broader run had 616 passes, 44 failures reproduced on main, and 121 skips. - **What is still open:** Display cadence and VRR engagement need hardware evidence before runtime policy changes. - **Risk:** Low. A source move can require updating a fixture cut point. ## Why Several owners make timing decisions from the same settings. The pacing rewrite needs a reference for the current policy before changing who owns those decisions. See #1519. ## What changed `tests/test_pacing_policy.py` compiles selected production statements using the existing source-cut fixture helper. It exercises 13 host and overlay cases, 192 present-mode combinations plus fallback, and 16 fixed frame-generation allocation cases. The results capture the host's temporary 240 FPS movie cap with a 60 FPS overlay target, and FIFO selected under V-Sync Auto for fixed DLSS frame generation. - Pacing fixture: `host_row`, `mode_rows`, and `fg_rows` in `tests/test_pacing_policy.py` compare the expected host, present, and fixed-FG decisions. ## Measurements **Verdict:** Game-free fixture only. Performance measurement does not apply. ### Flags and settings None. ## Testing **Tested:** All 12 focused Windows llvm-mingw checks passed. The game-free suite at `48f608ca` recorded 616 passes, 44 failures reproduced on main, and 121 skips. Each failing check was rerun against exact main `876dc360` with the same compiler configuration. <details> <summary>All 44 reproduced main failures</summary> - `tests/test_auto_handheld.py` - `tests/test_bake_ds.py` - `tests/test_bug_report_defaults.py` - `tests/test_build_long_paths.py` - `tests/test_cpu_report.py` - `tests/test_crash_dialog.py` - `tests/test_crt_options.py` - `tests/test_damage_debug_menu.py` - `tests/test_dev_packs.py` - `tests/test_discover.py` - `tests/test_display_startup_failure.py` - `tests/test_dlss_feature_size.py` - `tests/test_failed_compile_keeps_objects.py` - `tests/test_fastfp_fma.py` - `tests/test_fpx_sticky.py` - `tests/test_game_menu_mouse_buttons.py` - `tests/test_guest_imported.py` - `tests/test_hud_layout_row.py` - `tests/test_invalidate_quick.py` - `tests/test_invalidate_vcore.py` - `tests/test_job_queue.py` - `tests/test_libc_hooks.py` - `tests/test_lift_lookups.py` - `tests/test_linux_preflight.py` - `tests/test_linux_pressure.py` - `tests/test_mirror_budget.py` - `tests/test_missing_nup.py` - `tests/test_pads_after_menu.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_play_cache.py` - `tests/test_present_thread.py` - `tests/test_profiling_mode.py` - `tests/test_psychov35_fsr3_fg.py` - `tests/test_readback_timeout_source.py` - `tests/test_release.py` - `tests/test_run_all_changed.py` - `tests/test_sdiv_overflow.py` - `tests/test_slow_frames.py` - `tests/test_spawn_emit.py` - `tests/test_switch_table.py` - `tests/test_tested_configurations.py` - `tests/test_upscaler_rows.py` - `tests/test_walk.py` - `tests/test_walk_key.py` </details> The Guide screenshots job also fails on main. The local checker lists the same Graphics guide review items on the baseline and rebase candidate. The screenshot update is tracked in #1501. **Not tested:** Displayed cadence and VRR engagement. The fixture exercises policy decisions, and hardware coverage belongs to the follow-on runtime work. **Must be tested:** None for this fixture. ## Risks **What could break:** A source refactor can invalidate a fixture extraction anchor. **Turning it off:** Revert the commit. **Compatibility:** Runtime and player data are unaffected. ## Issues See #1519. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit of the status line's type. - [x] Why gives the reason plainly and links the issues that fit. - [x] Tested on my own PC where it runs. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of. Risks describes the test maintenance cost. - [x] Testing names what was tested, what wasn't, and what must still be tested. - [x] Rebased on current `main` (`876dc360`). - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK. ### When it applies - [x] AI assistance recorded with an `Assisted-by:` trailer.
test(pacing): characterize current cap and present policy
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
14dd5f4de5
Exercise source-cut host caps, movie override, guest time and swapchain
selection, and keep the existing acquire-fence invariant in the check set.

Assisted-by: OpenAI Codex (gpt-6.2-sol)
futondestroyer changed title from WIP: test(pacing): characterize current cap and present policy to test(pacing): characterize current cap and present policy 2026-11-18 14:53:42 +00:00
futondestroyer force-pushed test/issue-1519-pacing-policy from 14dd5f4de5
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
to 48f608ca5c
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 5s
2026-11-18 16:25:18 +00:00
Compare
Author
Member

Rebased onto main 876dc360. The new head is 48f608ca and the fixture is byte-identical to the reviewed 14dd5f4d. All 12 focused Windows checks passed. The full game-free suite recorded 616 passes, 44 failures reproduced on main, and 121 skips. The Guide screenshots failure also occurs on main and is tracked in #1501. Please confirm the new head against the existing review.

Rebased onto main `876dc360`. The new head is `48f608ca` and the fixture is byte-identical to the reviewed `14dd5f4d`. All 12 focused Windows checks passed. The full game-free suite recorded 616 passes, 44 failures reproduced on main, and 121 skips. The Guide screenshots failure also occurs on main and is tracked in #1501. Please confirm the new head against the existing review.
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 5s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'test/issue-1519-pacing-policy:futondestroyer-test/issue-1519-pacing-policy'
git switch 'futondestroyer-test/issue-1519-pacing-policy'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1591
No description provided.