test(pacing): characterize current cap and present policy #1591
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1591
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/Longshot:test/issue-1519-pacing-policy"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows, llvm-mingw · Needs: none
TL;DR
Pacing choices made by the game host, renderer, and FPS overlay are easy to change independently. A new game-free check records their current behavior so later changes can identify which decisions moved. All 12 focused checks passed.
Breakdown
Why
Several owners make timing decisions from the same settings. The pacing rewrite needs a reference for the current policy before changing who owns those decisions. See #1519.
What changed
tests/test_pacing_policy.pycompiles selected production statements using the existing source-cut fixture helper. It exercises 13 host and overlay cases, 192 present-mode combinations plus fallback, and 16 fixed frame-generation allocation cases. The results capture the host's temporary 240 FPS movie cap with a 60 FPS overlay target, and FIFO selected under V-Sync Auto for fixed DLSS frame generation.host_row,mode_rows, andfg_rowsintests/test_pacing_policy.pycompare the expected host, present, and fixed-FG decisions.Measurements
Verdict: Game-free fixture only. Performance measurement does not apply.
Flags and settings
None.
Testing
Tested: All 12 focused Windows llvm-mingw checks passed. The game-free suite at
48f608carecorded 616 passes, 44 failures reproduced on main, and 121 skips. Each failing check was rerun against exact main876dc360with the same compiler configuration.All 44 reproduced main failures
tests/test_auto_handheld.pytests/test_bake_ds.pytests/test_bug_report_defaults.pytests/test_build_long_paths.pytests/test_cpu_report.pytests/test_crash_dialog.pytests/test_crt_options.pytests/test_damage_debug_menu.pytests/test_dev_packs.pytests/test_discover.pytests/test_display_startup_failure.pytests/test_dlss_feature_size.pytests/test_failed_compile_keeps_objects.pytests/test_fastfp_fma.pytests/test_fpx_sticky.pytests/test_game_menu_mouse_buttons.pytests/test_guest_imported.pytests/test_hud_layout_row.pytests/test_invalidate_quick.pytests/test_invalidate_vcore.pytests/test_job_queue.pytests/test_libc_hooks.pytests/test_lift_lookups.pytests/test_linux_preflight.pytests/test_linux_pressure.pytests/test_mirror_budget.pytests/test_missing_nup.pytests/test_pads_after_menu.pytests/test_pending_guest_import.pytests/test_pipeline_play_cache.pytests/test_present_thread.pytests/test_profiling_mode.pytests/test_psychov35_fsr3_fg.pytests/test_readback_timeout_source.pytests/test_release.pytests/test_run_all_changed.pytests/test_sdiv_overflow.pytests/test_slow_frames.pytests/test_spawn_emit.pytests/test_switch_table.pytests/test_tested_configurations.pytests/test_upscaler_rows.pytests/test_walk.pytests/test_walk_key.pyThe Guide screenshots job also fails on main. The local checker lists the same Graphics guide review items on the baseline and rebase candidate. The screenshot update is tracked in #1501.
Not tested: Displayed cadence and VRR engagement. The fixture exercises policy decisions, and hardware coverage belongs to the follow-on runtime work.
Must be tested: None for this fixture.
Risks
What could break: A source refactor can invalidate a fixture extraction anchor.
Turning it off: Revert the commit.
Compatibility: Runtime and player data are unaffected.
Issues
See #1519.
Checklist
Everyone
main(876dc360).python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:trailer.WIP: test(pacing): characterize current cap and present policyto test(pacing): characterize current cap and present policy14dd5f4de548f608ca5cRebased onto main
876dc360. The new head is48f608caand the fixture is byte-identical to the reviewed14dd5f4d. All 12 focused Windows checks passed. The full game-free suite recorded 616 passes, 44 failures reproduced on main, and 121 skips. The Guide screenshots failure also occurs on main and is tracked in #1501. Please confirm the new head against the existing review.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.