fix(vk): NVIDIA DLAA before the bloom is off by default (RX_VK_DLSS_PRE_BLOOM=1 turns it on) #1675
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1675
Loading…
Reference in a new issue
No description provided.
Delete branch "pmwork-personal/Longshot:fix/dlss-pre-bloom-opt-in"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Windows 11, RTX 5080 and RTX 4070 Super (players,
RX_VK_DLSS_PRE_BLOOM=0on v3.0.0-rc.8) · Needs: Windows, NVIDIA RTX (a by-hand check)TL;DR
Since v3.0.0-rc.8, with NVIDIA DLAA, players see the game's camera turn under Link and look up when they move it down.
It comes from #1652's new order (DLAA before the game's bloom and tone map, on by default with DLAA): players report that
RX_VK_DLSS_PRE_BLOOM=0, or a Render resolution below 100%, makes it go away. The cause is not yet found, so this PR makesthat order opt-in: DLAA is back after the bloom and the tone map by default, and
RX_VK_DLSS_PRE_BLOOM=1turns the neworder on for testing.
Breakdown
RX_VK_DLSS_PRE_BLOOMis off by default;=1turns the new order on.=1.RX_VK_DLSS_PRE_BLOOM=0, the behaviour this PR makes the default, and the camera behaved; no run of this commit, at the person I work for's request.Why
With #1652 the default with DLAA moved DLSS before the game's bloom and tone map. On v3.0.0-rc.8 players see the camera go
under Link and look straight up as they move it down (an RTX 5080 in Castle Town's market at night, an RTX 4070 Super in
the forest).
RX_VK_DLSS_PRE_BLOOM=0and a Render resolution below 100% (which never takes the new order) both fix it.Until the cause is found, the old order should be the default. See #1672.
How to reproduce
Seen on: Windows 11, NVIDIA GeForce RTX 5080, driver 621.24 (and an RTX 4070 Super, driver not given)
Settings and switches: Upscaler NVIDIA DLSS, Render resolution Native (DLAA);
RX_VK_DLSS_PRE_BLOOMunsetSteps: v3.0.0-rc.8, in play outdoors (Castle Town's market at night), move the camera down with the right stick
Expected: the camera stops behind Link
Actual: the camera goes under Link and turns to look straight up; with
RX_VK_DLSS_PRE_BLOOM=0it stops as expectedWhat changed
RX_VK_DLSS_PRE_BLOOMnow turns the new order on with=1only; unset or0, DLAA runs at the gameplay upscale, after thebloom and the tone map.
pre_bloom_wanted()ingpu/vk/vk_temporal.cppreadsRX_VK_DLSS_PRE_BLOOM == 1, and its log line says how to turn it on; the comments invk_temporal.cppandvk_temporal.hsay it is off by default and why.gpu/vk/switches.def's row is anattempt(off unless set), anddocs/development.mdsays the same.tests/test_dlss_pre_bloom.pychecks the new default and the row's kind.Measurements
Verdict: nothing to measure: this PR changes a default back to the order every release before v3.0.0-rc.8 used.
Flags and settings
Changes the default of
RX_VK_DLSS_PRE_BLOOM.RX_VK_DLSS_PRE_BLOOM=0after=0: after the bloom and tone map;=1before=0(#1672)=1only to test the causeTesting
Tested: not by me, at the request of the person I work for: players on v3.0.0-rc.8 (Windows 11; RTX 5080 with driver 621.24, and an RTX 4070 Super) ran with
RX_VK_DLSS_PRE_BLOOM=0, which is what this PR makes the default, and report the camera turn gone. The order with=0is #1652's, tested there on an RTX 5090.Not tested: this commit in the game, and the game-free checks (
tests/test_dlss_pre_bloom.pyreads the changed lines); both at the request of the person I work for, to get the stopgap out.Must be tested:
RX_VK_DLSS_PRE_BLOOMunset, move the camera down outdoors, expecting it to stop behind Link and the log to sayNVIDIA DLAA after the game's bloom and tone map (RX_VK_DLSS_PRE_BLOOM=1: before them)(by hand: any tester with an RTX card)Risks
What could break: nothing new: unset gives DLAA at the gameplay upscale, as before #1652.
Turning it off:
RX_VK_DLSS_PRE_BLOOM=1turns the new order on again; reverting the commit makes it the default again.Compatibility: Nothing changes: no save, options file, cache or ABI change.
Issues
See #1672
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.The two unticked boxes are on purpose: no in-game run of this commit and no test run, at the request of the person I work
for, to get the stopgap out; players' runs with
RX_VK_DLSS_PRE_BLOOM=0stand in for the first.Co-Authored-By: Claude Opus 5.5 [email protected]
🤖 Generated with Claude Code
mooki referenced this pull request2026-11-19 00:27:16 +00:00