feat(input): a Toggle for Sprint on the Controls page, Off (held) by default #1977
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1977
Loading…
Reference in a new issue
No description provided.
Delete branch "llun/Longshot:feat/sprint-toggle"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
A follow-up to #1948 (Sprint held on L3, on the Controls tab), from a hand test of it: the Controls page's Toggle column showed
-for Sprint. Sprint now has a Toggle, as the Switch's buttons do:sprint_toggle_step,host/nn_hid.c). Opening Insert, pressing Plus or Minus, or the window losing the focus ends it, as the buttons' toggles are ended.It is saved as
toggle_sprint=(opts.sprint_toggle: the separate field keeps Sprint out of the Switch-button mask and avoids its sign bit) and read by the host asHOS_OPT_SPRINT_TOGGLE(98). Sprint's bindings stay rebindable in the Input 1, Input 2 and Keyboard columns; the Controls page's Reset turns the Toggle off with the others. The Xbox binding cells use L3 and R3 labels, Sprint appears after Walk, and binding help explains Sprint's inputs and when L3 moves to Sprint. The binding cells use L3 and R3 labels, including for Xbox prompts; Sprint follows Walk in the list, and the page gives more specific binding help.Also:
tests/test_walk_key.pyfailed onmainafter #1948 (its stand-ins leftsprint_frameset but never read); it builds again. The Graphics guide repair supports the Reset HUD placement action and documents that Custom HUD controls appear when HUD layout is Custom andHOS_WIDE_UIdoes not override it. Website tests cover the visibility condition and reset action.Read first:
sprint_toggle_stepand its call innpad_states(host/nn_hid.c),has_toggle/toggle_on/toggle_setingpu/vk/vk_menu.cpp.Testing
Tested: Windows 11, llvm-mingw:
tests/test_sprint.py(sprint_toggle_stepon its own: Toggle off passes held through; on, a press latches and the next unlatches; a reset ends it and a press held across the reset doesn't restart it; and the wiring: the Toggle column,toggle_sprintsaved, the host's option),test_input_background,test_walk_key,test_upscaler_round_trip,test_menu_env_overrides,test_bound_keys,test_option_ids,test_menu_modules,test_menu_i18n,test_settings_table: all pass.test_pads_after_menufails onmaintoo (#1721's stand-inpad_count_now, unused). The game is built from this commit; it has not run in the game yet: opened at the user's request before the run.The full suite and lint have not been run on the updated head; their results are pending. The earlier targeted run named
test_pads_after_menuas a failure onmaintoo.Still to test:
@BeanstalkLinux build and start).Measurements
Nothing to measure: with the Toggle off, one more compare per input read; #1929 measured Sprint against
mainwithin the spread.Risks
longshot_options.inigains atoggle_sprint=line.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). Full suite and lint still need to run on the updated head;test_pads_after_menuwas reported failing onmain(#1721's unusedpad_count_now).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.mainand here, for a change that shows on screen.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
Possibly related, for context:
Recommendation: Request changes. Sprint can latch again when focus returns, carry a note-button press into gameplay, or inject Sprint into an exclusive test run. The renderer also shares the new setting with the game thread without synchronization, and three existing test fixtures need updates.
Adds a saved Toggle cell to Sprint’s Controls-page binding. Off preserves hold-to-sprint, and On lets players take their finger off the key or stick click while running. The UI follows the existing binding grid, but the new input latch needs to respect menu, focus, note, and automation boundaries.
@fixwill do (16)gpu/vk/vk_replay.cpp:7739: The game thread readsopts.sprint_togglethroughrx_optionwhile the present thread can write it from Controls. (more on the line)host/nn_hid.c:1472: During Insert or focus loss,read_inputhides the held Sprint key, so the reset recordswas = 0. (more on the line)host/nn_hid.c:1474: The note-wait check happens after the latch has already advanced. (more on the line)host/nn_hid.c:1431: Script and bridgeSPRINTnow feed the player’s latch. A timedSPRINT+LUPfollowed by plainLUPkeeps Sprint on after the timed press ends, contrary to the documented held input. An exclusive bridge movement can also inherit a latch set by a physical press before the request. Keep synthetic Sprint as a timed hold and suppress the player latch’s output while physical input is excluded.host/nn_hid.c:1468: The latch only observes Sprint being disabled when a poll seessprint_enabledfalse. (more on the line)tests/test_menu_keys.py:343: The compiled fixture extracts the new load block withouthas_toggleortoggle_set, so compilation fails. Its checks at lines 356 and 358 also require the old inline predicates. Include the real helpers and keep coverage that Plus and Minus cannot be loaded, drawn, or selected as toggleable.tests/test_crt_options.py:370: The compiled CRT fixture extractssaveand the options loader without their newtoggle_on,has_toggle, andtoggle_setdependencies. The fixture fails to compile even though it only exercises CRT settings. Include the toggle helpers in its extracted code.tests/test_menu_save_atomic.py:386: The Linux atomic-save fixture extractssave()withouttoggle_on. Its generated C++ fails to compile before exercising any disk-failure case. Include the getter and its Sprint setting in the fixture.tests/test_sprint.py:491: The new wiring test matches source text, so removing the reset assignment or breaking the loader still passes. (more on the line)tests/test_walk_key.py:336: The updated Walk fixture still ignoresCCand can skip on a machine whose configured compiler has a different executable name or lives outside PATH. Reuse the Sprint fixture’s compiler selection. Apply the same selection to the default for the updated input-background fixture, whose suite declaration currently forcesgcc.gpu/vk/vk_menu.cpp:3709: The new saved key is accepted throughatoi. (more on the line)docs/user/graphics-and-controls.md:266: The main Sprint instructions and settings-table entry still say to hold the input and release it to stop. The Controls-tab Sprint help and the binding-cell help make the same unconditional claim. A player reading those after enabling Toggle gets the wrong instructions. Qualify the hold behavior as the default, point to the Toggle cell, and explain that the parent Sprint setting must be On.gpu/vk/vk_menu.cpp:2559: The new whole-string help has no matching translation, so a player using a translated Controls page gets the Sprint Toggle instructions in English. (more on the line)gpu/vk/vk_menu.cpp:1396:HOS_KEY_SPRINTis 31, which is the sign-bit position of a 32-bitint. (more on the line)mise run testbut lists only targeted results, and the source shows additional fixtures that now cannot compile. Clear that box until the full suite has run on the updated head. Record lint and named base failures, and restore the template’s before-and-after screenshot item for the visible Toggle cell.host/nn_hid.c:1468: Publish the toggle mode with the existing Sprint input snapshot and avoid a separate renderer option dispatch on each poll.For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1468: The Measurements section calls this one extra compare, but with Sprint enabled and Toggle Off each poll also calls the renderer option dispatcher and updates edge state. (more on the line)Checks: Still running:
PR description / Description follows the template (pull_request_target),CI / Conventional Commit title (pull_request),CI / Workflow lint (actionlint) (pull_request),CI / Website build and checks (pull_request),Guide screenshots / Guide images and local UI source review (pull_request),Third-party parts / As their notes say (pull_request).More: does it help, other systems, switches, what was read
Does it help: Unproven in game. The author reports a Windows 11 llvm-mingw build and passing targeted fixtures. The isolated latch test covers press, release, and reset with an input still visible to the helper. There is no physical-input run on this head, Linux build or start, or frame-time comparison against the base. The #1929 measurements predate this toggle.
Other systems: Windows and Linux share the changed Npad polling path, including Steam Deck controller input. The pad and keyboard binding formats and existing Sprint A-press handoff are preserved in the diff. The new latch affects ocarina input and scripted or bridge-driven runs as detailed below. The renderer change is confined to the menu, settings and option callback. No render pass, save-game format, audio path, GPU capability check, or build configuration changes.
Switches: No environment switches added or changed. The player setting
toggle_sprintdefaults to 0 (Off), which preserves held Sprint for existing settings files.HOS_OPT_SPRINT_TOGGLEis the host option ID for that setting.Reviewed:
f73c817a5bagainst6e1521a70a: Read AGENTS.md, CONTRIBUTING.md, the Forgejo template, developer standards, the sole commit, the full eleven-file diff twice, and the surrounding code at each change. Followed the input and focus callers, binding snapshot, menu save/load and rollback, renderer option callback, and dependent test fixtures. Skimmed the guide manifest and translation tables. Unrelated portions of the large renderer, menu, and HID files and older recorded runs outside Sprint were outside the review. No local review checklist or sibling Tooling checkout was present. The supplied comments and reviews were empty.; nothing run (a code review).Checked and fine:
MkwVkHostandMkwVkRendererlayouts are unchanged, so the repository’s ABI-bump rule does not apply.toggle_sprint=1. This binding-grid key is outside the module-row key registry.CCand only compiles and runs its temporary authored fixture. The diff adds no downloads or test actions outside the fixture’s temporary files.Testing: Read-only review. The author reports a Windows 11 llvm-mingw build and targeted test passes, with
test_pads_after_menufailing on main too. There is no game run or Linux build result on this head. The supplied CI snapshot has six pending checks and no reported failures.Overlaps and merge order: #1948 is already merged into the base. No pending overlap was identified from the checkout or supplied PR context.
Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.
@ -1392,2 +1393,4 @@controls[i].button == HOS_KEY_WALK);}// (the controls with a Toggle column: the Switch's buttons but Plus and Minus (opts.hold_toggle, a bit each), and Sprint// (opts.sprint_toggle: its index is past an int's bits))L14 (minor):
HOS_KEY_SPRINTis 31, which is the sign-bit position of a 32-bitint. Update the comment and PR summary to say the separate field keeps Sprint out of the Switch-button mask and avoids using its sign bit.@ -2545,2 +2556,4 @@const char* help = listening ? (listening == 1 ? "Press the gamepad button to use. Esc cancels." : "Press the key to use. Esc cancels."): page_row ? page_row->help: sel_i < kControls && controls[sel_i].button == HOS_KEY_SPRINT && ccol == kCtlToggle? "Toggle for Sprint: On, a press of its key or button starts Sprint and the next ends it; Off, Link "L13 (minor): The new whole-string help has no matching translation, so a player using a translated Controls page gets the Sprint Toggle instructions in English. Add the help to the menu translation tables once its wording is settled.
@ -3696,2 +3708,2 @@opts.hold_toggle = atoi(eq + 1) == 1 ? opts.hold_toggle | bit : opts.hold_toggle & ~bit;}for (int i = 0; i < HOS_KEY_N; i++)if (has_toggle(i) && !strcmp(line + 7, bind_names[i])) toggle_set(i, atoi(eq + 1) == 1);L11 (minor): The new saved key is accepted through
atoi. An out-of-range value such astoggle_sprint=4294967297has undefined conversion behavior and can be mistaken for 1. Parse the numeric toggle value with a range-checked conversion and treat invalid values as Off.@ -7736,6 +7736,7 @@ void fill_replay_table(MkwVkRenderer& t) {if (id == HOS_OPT_MUTE_BACKGROUND) return opts.mute_background;if (id == HOS_OPT_DISABLE_CAMERA_CENTERING) return opts.disable_camera_centering;if (id == HOS_OPT_SPRINT) return opts.sprint;if (id == HOS_OPT_SPRINT_TOGGLE) return opts.sprint_toggle;L1: The game thread reads
opts.sprint_togglethroughrx_optionwhile the present thread can write it from Controls. The game-side read takes neithermenu_munor another lock, so changing or resetting the Toggle while Npad polls is a C++ data race. The bridge’s whole-Optionsrollback also writes the field. Publish the host-facing value separately through an atomic or use one synchronization scheme for every read and write, including rollback.@ -1455,2 +1471,4 @@!pads_in_background(getenv("HOS_INPUT_BACKGROUND"), rx_option(4, 0)));const int sprint_held = sprint_toggle_step(sprint_enabled ? sprint_now : 0, sprint_toggle, sprint_reset);/* (the ocarina's note wait, as oc_notes left it this read: Sprint lets go) */sprint_step(&buttons, sprint_held, steered, menu_open || hos_oc_wait == 1, hos_now_ns());L3: The note-wait check happens after the latch has already advanced. A pad button shared by Sprint and a note can latch Sprint during the song and then start it when Link moves afterward, even if the button was released during the song. A shared keyboard key can also look newly pressed when note consumption ends while it is still held. Suppress latch changes during the note wait and require release of inputs carried out of it.
@ -1454,1 +1466,3 @@const int sprint_held = sprint_enabled ? sprint_now : 0;/* Sprint's Toggle (the Controls page): a press starts it and the next ends it, ended as the buttons' toggles are(opening Insert, Plus or Minus, the focus lost) */const int sprint_toggle = sprint_enabled && rx_option(HOS_OPT_SPRINT_TOGGLE, 0) == 1;L5 (minor): The latch only observes Sprint being disabled when a poll sees
sprint_enabledfalse. With custom bindings, the bridge can set the Sprint row Off and back On between polls without any remap callinghos_input_clear_toggles, so a previous latch survives. Invalidate the latch when the host publishes a disable, even when the layout has no slots to move.L17 (minor): The Measurements section calls this one extra compare, but with Sprint enabled and Toggle Off each poll also calls the renderer option dispatcher and updates edge state. The standards ask for frame-time or FPS evidence with the feature on and off. Compare this head in both modes with the base in the same scene and build conditions, with repeated runs.
@ -1455,0 +1469,4 @@const int sprint_reset = reset || pause != 0 ||(sprint_toggle && !game_in_front() &&!pads_in_background(getenv("HOS_INPUT_BACKGROUND"), rx_option(4, 0)));const int sprint_held = sprint_toggle_step(sprint_enabled ? sprint_now : 0, sprint_toggle, sprint_reset);L2: During Insert or focus loss,
read_inputhides the held Sprint key, so the reset recordswas = 0. Hold Shift through an Insert open and close, or through an Alt-Tab away and back. The first visible sample sees a rising edge and restarts Sprint without a new press. Reuse the release-blocking behavior ofHoldToggleor add equivalent rearming across suppressed input, including the first sample after focus or menu return.@ -443,0 +488,4 @@self.assertEqual(build.returncode, 0, build.stderr)run = subprocess.run([str(binary)], text=True, capture_output=True, timeout=30)self.assertEqual(run.returncode, 0, run.stdout + run.stderr)L9: The new wiring test matches source text, so removing the reset assignment or breaking the loader still passes. The reset unit test supplies an uninterrupted held sample, and the Npad fixture keeps Sprint Toggle Off, so neither catches the actual focus or menu sequence. Exercise Toggle On through Npad with simulated input and menu/focus changes, and round-trip the real settings code through save, load, and Reset.
@fix
@fix
@fix
I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is
38a9751023. It was already up to date withmain.Changed
Changed in part (the rest is for the author)
Left for the author
Still for the author (no edit does these)
Nothing was built or run: check the change. Its review follows.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
Recommendation: Request changes. A held Sprint key can still restart Sprint when focus returns during an input poll, and an exclusive bridge request can inherit the player's Sprint-to-A handoff. The new fixture covers steady focus transitions and timed synthetic Sprint, but misses both cases.
Adds a saved Sprint Toggle to Controls so players can start and stop Sprint with a press. Held mode remains the default. The follow-up removes the renderer option dispatch from Npad polling and adds input transition coverage, at the cost of more state around focus, menus and synthetic input.
@fixwill do (9)host/nn_hid.c:1486: Rearming uses a later focus check than the one that gated the keyboard sample. Hold Shift through Alt-Tab and regain focus after read_input takes the background path but before npad_states checks focus. The hidden zero sample clears blocked, and the next poll latches Sprint without a new press. Carry the sample's suppression state from read_input into the latch and rearm only after a readable release.host/nn_hid.c:1489: Masking the physical latch leaves its A-button handoff state active. While moving with Sprint latched, start an exclusive bridge A press without SPRINT. sprint_step sees running from the physical Sprint and clears the bridge's A for the 50 ms roll gap. A pending handoff can also inject A into a movement-only request. Clear the previous source's handoff state when entering exclusive input, then process the current synthetic input normally.tests/test_menu_keys.py:285: The loader test starts from hand-written settings, so it still passes if production save omits the key or Controls Reset leaves the previous value on disk or in the host. Exercise the real save and reload with Toggle On, then exercise production Reset and verify the reloaded and host-facing values are Off.gpu/vk/menu_i18n.h:2474: The three new Sprint help strings are translated only in French. A player using Spanish, for example, sees the Toggle help in English. Add the complete strings to the remaining language tables and extend the translation check to each table.gpu/vk/vk_menu.cpp: The code comment is fixed, but the PR summary still says Sprint's index is past the mask's bits. Index 31 is the sign-bit position of a 32-bit int. Update the summary to say the separate field keeps Sprint out of the Switch-button mask and avoids its sign bit.mise run testbut lists only targeted results, and the source shows additional fixtures that now cannot compile. Clear that box until the full suite has run on the updated head. Record lint and named base failures, and restore the template’s before-and-after screenshot item for the visible Toggle cell.host/nn_hid.c:1482: Reuse the focus state from the input sample and consume the Sprint reset only when needed.Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.tests/run_all.py:137: Suite preflight treats CC as a single executable, while the standalone fixture accepts a compiler command with flags. (more on the line)For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1482: The dispatch is gone, but the polling path now takes a reset exchange even with Toggle Off and can query focus twice with Toggle On. Compare base and head with repeated interleaved runs in the same scene and build conditions. Report FPS and frame times for both head modes.Since the last review (on
f73c817a5b)Resolved: L1 (The game thread reads
opts.sprint_togglethroughrx_optionwhile the present thread ca…); L3 (The note-wait check happens after the latch has already advanced. A pad button shared by S…); L5 (The latch only observes Sprint being disabled when a poll seessprint_enabledfalse. Wit…); L6 (The compiled fixture extracts the new load block withouthas_toggleortoggle_set, so…); L7 (The compiled CRT fixture extractssaveand the options loader without their newtoggle_…); L8 (The Linux atomic-save fixture extractssave()withouttoggle_on. Its generated C++ fai…); L10 (The updated Walk fixture still ignoresCCand can skip on a machine whose configured com…); L11 (The new saved key is accepted throughatoi. An out-of-range value such astoggle_sprint…); L12 (The main Sprint instructions and settings-table entry still say to hold the input and rele…)Still open: L2 (Rearming uses a later focus check than the one that gated the keyboard sample. Hold Shift…); L4 (Masking the physical latch leaves its A-button handoff state active. While moving with Spr…); L9 (The loader test starts from hand-written settings, so it still passes if production save o…); L13 (The three new Sprint help strings are translated only in French. A player using Spanish, f…); L14 (The code comment is fixed, but the PR summary still says Sprint's index is past the mask's…); L15 (The PR ticks
mise run testbut lists only targeted results, and the source shows additio…); L16 (The reported build and game-free tests leave the physical input path unverified. Record a…); L17 (The dispatch is gone, but the polling path now takes a reset exchange even with Toggle Off…)New: L18 (The check
Guide screenshots / Guide images and local UI source review (pull_request)fai…); L19 (Disabling Sprint now clears all button latches. With custom Sprint bindings and ZL latched…); L20 (With no CC, GCC or Clang available, compiler selection returns[None]and the fixture pa…); L21 (Suite preflight treats CC as a single executable, while the standalone fixture accepts a c…)Checks: Still running:
CI / Website build and checks (pull_request).More: does it help, other systems, switches, what was read
Does it help: Unproven. The PR reports a Windows build and targeted game-free checks for the original commit. No physical-input game run or repeated, same-scene FPS or frame-time comparison was supplied for base
6e1521a7and head 2ad82e2a with Toggle On and Off. The #1929 result predates this change.Other systems: Windows and Linux share the Npad path, including Steam Deck and background controller input. The change also touches ocarina note waits, the control bridge, scripted input, settings persistence and the guide's recorded UI sources. Host and renderer must be updated together for API version 40. The diff leaves GPU rendering passes, audio and game save data alone.
Switches:
toggle_sprintis a saved Controls preference, Off by default. Off preserves the previous held behavior for existing settings files. The Controls tab's Sprint enable setting still defaults to Off. The player guide documents the new preference. No environment switch was added or changed.Reviewed:
38a9751023against6e1521a70a: Read AGENTS.md, CONTRIBUTING.md, the Forgejo PR template and the developer standards in full. No docs/review-checklist.md was present. Read the three PR commits and the changed sections of all 20 files, including the surrounding option publication, save/load, Reset, focus, note wait, bridge and fixture code. Skimmed unchanged translation tables, guide capture records and unrelated renderer code. Local Tooling rules were unavailable. The supplied PR body identifiesf73c817a, while the checkout and range-diff end at 2ad82e2a. Ledger findings use the checkout head.; nothing run (a code review).Checked and fine:
Testing: Read-only review. The PR reports targeted llvm-mingw checks and a Windows build for the original commit, with test_pads_after_menu named as a base failure. Head lint, the full suite, Linux build and physical-device runs remain unverified. Supplied CI reports the guide screenshot source review failed and the website check is still running.
Overlaps and merge order: #1948 is already in the base. No other overlap was found in the supplied record.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -708,6 +709,11 @@ static void bind_one(int set, int button, int slot, int code) {}if (set == HOS_BIND_SPRINT_ON) {InterlockedExchange(&sprint_on, code != 0);L19 (minor): Disabling Sprint now clears all button latches. With custom Sprint bindings and ZL latched, turning Sprint Off through the bridge drops Link's shield even when no binding moves and the menu stays closed. Use a Sprint-specific pending reset and leave the shared reset for events that should release all buttons.
@ -134,6 +134,7 @@ def find_tools():"spirv_val": which("spirv-val"),"glslang": which("glslangValidator", "glslang"),"dotnet": which("dotnet"),"cc": which(os.environ.get("CC", ""), "gcc", "clang"),L21 (minor): Suite preflight treats CC as a single executable, while the standalone fixture accepts a compiler command with flags. With CC='clang -m64' and both GCC and Clang installed, the suite silently selects GCC and drops the requested flags. Use the same compiler command parsing for preflight and execution.
@ -142,3 +145,3 @@exe = folder / "fixture.exe"# Production's button table deliberately leaves its unused axis fields zero-initialized.run([a.cc, "-std=c11", "-include", ENV_ON_H, "-Wall", "-Wextra", "-Werror", "-Wno-missing-field-initializers",cc = [a.cc] if a.cc else compiler_command("CC", "gcc", "clang")L20 (minor): With no CC, GCC or Clang available, compiler selection returns
[None]and the fixture passes it to subprocess. The suite previously reported the missing compiler during preflight. Check the selection before invoking subprocess and report the missing dependency through the suite's check handling.@fix
I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is
2079d6469f. It was already up to date withmain.Changed
Changed in part (the rest is for the author)
Left for the author
Still for the author (no edit does these)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Nothing was built or run: check the change. Its review follows.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
Recommendation: Request changes. A second exclusive takeover can still erase a bridge A tap before the game sees it. The updated input fixture also expects a Sprint press to count before the key has been rearmed.
The Controls page lets players choose press-to-toggle Sprint while keeping held Sprint as the default. HEAD preserves the physical latch during foreground exclusive input, adds an A release and replay, and skips latch bookkeeping in steady held mode. The extra handoff state still needs to distinguish physical taps from bridge taps.
@fixwill do (7)host/nn_hid.c:1498: Start a one-frame exclusive bridge A tap immediately after Sprint supplied A. The first packet correctly releases A. If a second exclusive movement request starts after one nonexclusive sample and before the 50 ms gap expires, it clears the queued bridge tap and the game never sees A pressed. Track the source of the pending tap so takeover discards stale physical input and preserves an accepted bridge replay. Add a fixture case that drops bridge A during the gap and checks the press edge across the second takeover.tests/test_menu_keys.py:285: The loader test starts from hand-written settings, so it still passes if production save omits the key or Controls Reset leaves the previous value on disk or in the host. Exercise the real save and reload with Toggle On, then exercise production Reset and verify the reloaded and host-facing values are Off.gpu/vk/menu_i18n.h:2474: The three new Sprint help strings are translated only in French. A player using Spanish, for example, sees the Toggle help in English. Add the complete strings to the remaining language tables and extend the translation check to each table.gpu/vk/vk_menu.cpp: The code comment is fixed, but the PR summary still says Sprint's index is past the mask's bits. Index 31 is the sign-bit position of a 32-bit int. Update the summary to say the separate field keeps Sprint out of the Switch-button mask and avoids its sign bit.mise run testbut lists only targeted results, and the source shows additional fixtures that now cannot compile. Clear that box until the full suite has run on the updated head. Record lint and named base failures, and restore the template’s before-and-after screenshot item for the visible Toggle cell.Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.tests/input_background_test.c:254: The fixture ends exclusion and presses G on the same sample, then expects Sprint to turn off. (more on the line)For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Since the last review (on
38a9751023)Resolved: L2 (Rearming uses a later focus check than the one that gated the keyboard sample. Hold Shift…); L21 (Suite preflight treats CC as a single executable, while the standalone fixture accepts a c…)
Still open: L4 (Start a one-frame exclusive bridge A tap immediately after Sprint supplied A. The first pa…); L9 (The loader test starts from hand-written settings, so it still passes if production save o…); L13 (The three new Sprint help strings are translated only in French. A player using Spanish, f…); L14 (The code comment is fixed, but the PR summary still says Sprint's index is past the mask's…); L15 (The PR ticks
mise run testbut lists only targeted results, and the source shows additio…); L16 (The reported build and game-free tests leave the physical input path unverified. Record a…); L17 (The held path now skips the latch helper and still loads the toggle snapshot. Run the base…); L18 (The checkGuide screenshots / Guide images and local UI source review (pull_request)fai…)New: L22 (Both exclusive paths return before assigning input_in_front, so a skipped focus query now…); L23 (On Linux, a CC value with an unmatched quote raises ValueError in shlex.split during prefl…); L24 (The trailing blank line is flagged by git diff --check. Remove it.); L25 (The fixture ends exclusion and presses G on the same sample, then expects Sprint to turn o…)
Checks: Still running:
CI / Website build and checks (pull_request).More: does it help, other systems, switches, what was read
Does it help: Unproven on 9842f922. The PR reports an earlier Windows build and targeted checks, with no in-game run or frame timings for this head. The cited #1929 measurements cover the earlier Sprint implementation.
Other systems: The shared Npad path affects keyboard, controllers, Steam Deck, background input, and scripted and bridge input on Windows and Linux. The renderer API bump requires matching host and renderer builds. The diff touches no GPU pass, save format, or audio path. Physical-device and frame-pacing evidence is still missing.
Switches: Sprint's Controls-page Toggle is saved as toggle_sprint and defaults to Off, preserving held input for existing profiles. This is a player preference, with no new environment switch. The guide documents it.
Reviewed:
2079d6469fagainst6e1521a70a: Reviewed checkout HEAD 9842f922 against ledger head 9482fb1760a5. Read the six changed files through their affected functions and fixtures, the full base-to-HEAD diff, repository rules and PR template, and the relevant menu save, load, Reset, focus, bridge and A-edge code. Skimmed translation tables and screenshot maintenance records. Unchanged portions of large files, screenshot pixels and external Tooling rules were outside the read.; nothing run (a code review).Checked and fine:
Testing: Read-only review. Both git diff --check comparisons passed. The PR reports earlier Windows llvm-mingw and targeted check results. No builds, tests or game runs were performed here. The supplied CI lists the guide screenshot check as failing and the website check as running.
Overlaps and merge order: The prerequisite #1948 is merged at the base. No other overlap found in the checkout or supplied review data.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -1455,0 +1482,4 @@/* Sprint's Toggle (the Controls page): a press starts it and the next ends it, ended as the buttons' toggles are(opening Insert, Plus or Minus, the focus lost) */const int sprint_toggle = sprint_enabled && sprint_toggle_frame;const int sprint_front = sprint_toggle && sprint_excluded ? game_in_front() : input_in_front;L22 (minor): Both exclusive paths return before assigning input_in_front, so a skipped focus query now counts as focus loss. If a movement-only exclusive bridge request runs while the game stays foreground, physical Sprint is cleared and stays off when the request ends. Distinguish an excluded sample from a background sample. Suppress physical input during exclusion and clear the latch on an actual reset.
@ -214,0 +251,4 @@bridge_up = 1;bridge_buttons = 1ULL << B_SPRINT; packet(a, 0, 32767, 0);bridge_buttons = 0; packet(0, 0, 32767, 0);bridge_active = 0; held_keys['G'] = 1; packet(0, 0, 32767, 0); /* turn the latch off */L25: The fixture ends exclusion and presses G on the same sample, then expects Sprint to turn off. Exclusion left the latch on and blocked key edges until an unsuppressed sample sees G up. This packet therefore still contains Sprint's A. Sample G released after exclusion ends before pressing it, and assert that the latch is still on at that released sample.
@ -264,2 +267,2 @@if a in ("--cc", "--cxx") and not which(args[i + 1]):missing.append(args[i + 1])if a in ("--cc", "--cxx"):try:L23 (minor): On Linux, a CC value with an unmatched quote raises ValueError in shlex.split during preflight and aborts the suite before checks start. Catch the parse error and report the invalid compiler setting for the affected fixture through the existing preflight result.
@fix
I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is
ca90e48b2f. It was already up to date withmain.Changed
Left for the author
Still for the author (no edit does these)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Nothing was built or run: check the change. Its review follows.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
Recommendation: Request changes. The fix preserves a bridge tap that opens Sprint’s A-release gap. An exclusive takeover can still drop a bridge tap that arrives during a gap opened by physical A.
Players can choose press-to-start and press-to-stop Sprint on the Controls page. The setting persists and defaults to held behavior. The feature adds a Sprint latch and tracks the source of queued A presses so exclusive input can discard stale physical input.
@fixwill do (4)host/nn_hid.c:1047: While Sprint supplies A, tap and release physical A, send a one-frame nonexclusive bridge A tap during the 50 ms gap, then start an exclusive movement-only request before the gap expires. No A press reaches the game. Retain injected A as a source when it arrives during a pending gap, and add this sequence to the packet fixture alongside the physical-only discard case.gpu/vk/vk_menu.cpp: The code comment is fixed, but the PR summary still says Sprint's index is past the mask's bits. Index 31 is the sign-bit position of a 32-bit int. Update the summary to say the separate field keeps Sprint out of the Switch-button mask and avoids its sign bit.mise run testbut lists only targeted results, and the source shows additional fixtures that now cannot compile. Clear that box until the full suite has run on the updated head. Record lint and named base failures, and restore the template’s before-and-after screenshot item for the visible Toggle cell.Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Since the last review (on
2079d6469f)Resolved: L9 (The call to
block()raisesUnboundLocalErroron both platforms becausemain()assign…); L13 (The three new Sprint help strings are translated only in French. A player using Spanish, f…); L25 (The fixture ends exclusion and presses G on the same sample, then expects Sprint to turn o…)Still open: L4 (While Sprint supplies A, tap and release physical A, send a one-frame nonexclusive bridge…); L14 (The code comment is fixed, but the PR summary still says Sprint's index is past the mask's…); L15 (The PR ticks
mise run testbut lists only targeted results, and the source shows additio…); L16 (The reported build and game-free tests leave the physical input path unverified. Record a…); L17 (The held path now skips the latch helper and still loads the toggle snapshot. Run the base…); L18 (The checkGuide screenshots / Guide images and local UI source review (pull_request)fai…)Checks: Still running:
CI / Website build and checks (pull_request).More: does it help, other systems, switches, what was read
Does it help: Unproven on this head. The PR reports a Windows build and targeted checks from before the follow-up. There is no in-game result or repeated comparison of average FPS, 1% lows and frame times for the merge base and both head modes. The cited #1929 measurement predates this change.
Other systems: Windows keyboard and XInput, Linux and Deck SDL controllers, background input, host taps and the control bridge converge in the same Npad path. The packet fixture covers injected-only and physical-only takeovers. It misses the two sources arriving during the same gap. No shader, audio or save-format files changed. The host and renderer API version is now 40.
Switches: Sprint’s Controls-page Toggle is saved as toggle_sprint and defaults to Off, preserving held behavior when Sprint is enabled. That default preserves the existing controls. No environment switches changed.
Reviewed:
ca90e48b2fagainst6e1521a70a: Reviewed checkout ef83bfd896aa against ledger head c96439a2f81e and merge base6e1521a70a. Read AGENTS.md, CONTRIBUTING.md, the PR template, developer standards, all six follow-up diffs, and the affected code and fixture sections. Traced the input merge, packet writer, menu persistence, and host API. Skimmed the surrounding translation data and guide provenance. The guide PNG and unrelated portions of large files were outside this re-check.; nothing run (a code review).Checked and fine:
Testing: Read-only review. git diff --check passed. No builds or tests were run. The supplied CI snapshot reports the guide screenshot source review failing and the website checks still running. Its applicability to ef83bfd8 is unverified.
Overlaps and merge order: #1948 is already in the merge base. No sibling merge dependency was identified in the supplied record.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@fix
I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is
cd57d785dd. It was already up to date withmain.Changed
Left for the author
mise run testcheckbox, record lint and the named base failures, and restore the template’s before-and-after screenshot item. The PR description and those results are not available in the checkout.Still for the author (no edit does these)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Nothing was built or run: check the change. Its review follows.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
Recommendation: Request changes. The fix preserves the injected A tap through exclusive takeover. Merge should wait for current-head game runs, held-mode timing comparisons, and the guide screenshot check. (It stands on L18: The check
Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.)Sprint gains a saved press-to-start, press-to-stop option on the Controls page. The latest change keeps a bridge A tap queued when it arrives during a physical A handoff, at the cost of one source check in the shared input path.
@fixwill do (3)gpu/vk/vk_menu.cpp: The code comment is fixed, but the PR summary still says Sprint's index is past the mask's bits. Index 31 is the sign-bit position of a 32-bit int. Update the summary to say the separate field keeps Sprint out of the Switch-button mask and avoids its sign bit.mise run testbut lists only targeted results, and the source shows additional fixtures that now cannot compile. Clear that box until the full suite has run on the updated head. Record lint and named base failures, and restore the template’s before-and-after screenshot item for the visible Toggle cell.Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Since the last review (on
ca90e48b2f)Resolved: L4 (While Sprint supplies A, tap and release physical A, send a one-frame nonexclusive bridge…)
Still open: L14 (The code comment is fixed, but the PR summary still says Sprint's index is past the mask's…); L15 (The PR ticks
mise run testbut lists only targeted results, and the source shows additio…); L16 (The reported build and game-free tests leave the physical input path unverified. Record a…); L17 (The held path now skips the latch helper and still loads the toggle snapshot. Run the base…); L18 (The checkGuide screenshots / Guide images and local UI source review (pull_request)fai…)Checks: Still running:
CI / Website build and checks (pull_request).More: does it help, other systems, switches, what was read
Does it help: Unproven in game. The new fixture covers the 50 ms handoff by inspection, and the PR reports earlier Windows build and targeted test passes. There are no repeated FPS, 1% low, or frame-time results for
6e1521a7against 8d2c7b53 with the toggle off and on. The #1929 result predates this change.Other systems: The handoff code is shared by Windows and Linux and handles physical input, scripts, host taps, and the control bridge. The fixture covers exclusive bridge takeover. Windows keyboard and controller behavior and Linux or Steam Deck controller behavior still need game runs. The host and renderer need matching API versions. The guide source review also affects the published Longshot docs.
Switches: Sprint Toggle adds toggle_sprint=, default Off, which preserves hold-to-sprint for existing settings. This is a player input preference. The Controls reset restores Off and the guide documents it. No environment switches changed.
Reviewed:
cd57d785ddagainst6e1521a70a: Read the repository rules and PR template, the commit log, and the complete ca90e48b-to-8d2c7b53 diff. Read the changed handoff and packet fixture in full with their input routing, callers, packet bounds, and test wiring. Checked the relevant menu, persistence, API, and timing code at HEAD. Skimmed the rest of the base diff, translations, and guide records. The sibling Tooling checkout was unavailable.; nothing run (a code review).Checked and fine:
Testing: Read-only review. The latest fix report records no test execution. The PR reports earlier Windows llvm-mingw targeted passes and names test_pads_after_menu as a base failure. The supplied CI reports the guide screenshot check failing only on the head and the website check still running.
Overlaps and merge order: #1948 is already the basis for this follow-up. No other overlap was identified in the supplied material.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@fix
I didn't change this pull request: what is left needs the author. It was already up to date with
main.Left for the author
Still for the author (no edit does these)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
@fix
I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is
9b662678d3. I rebased it ontomain(ed602b9468). I edited the pull request's description too (5 edits).Changed
Changed in part (the rest is for the author)
Left for the author
Still for the author (no edit does these)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.CI / Website build and checks (pull_request)fails on this head and passes on the base branch: Failing after 16s.Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
cbfa7a18119b662678d3Recommendation: Request changes. The Sprint Toggle preserves held mode as the default and adds a useful input choice. Merge should wait for physical-input coverage, both-mode frame timings, matching Controls captures, and passing head checks. (It stands on L18: The check
Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.)Players can press once to start Sprint and again to stop it, with the choice saved across launches. The latest commits put Sprint next to Walk and label physical stick clicks L3 and R3. The feature adds one saved setting and host state for the latch and its handoffs.
@fixwill do (4)Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.gpu/vk/vk_menu.cpp:2559: The new Left stick press hint checks Sprint's stored bindings alone. (more on the line)CI / Website build and checks (pull_request)fails on this head and passes on the base branch: Failing after 23s.For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Since the last review (on
cd57d785dd)Resolved: L14 (The code comment is fixed, but the PR summary still says Sprint's index is past the mask's…); L15 (The PR ticks
mise run testbut lists only targeted results, and the source shows additio…)Still open: L16 (The reported build and game-free tests leave the physical input path unverified. Record a…); L17 (The held path now skips the latch helper and still loads the toggle snapshot. Run the base…); L18 (The check
Guide screenshots / Guide images and local UI source review (pull_request)fai…)New: L26 (The new Left stick press hint checks Sprint's stored bindings alone. If the player also as…); L27 (The summary and Risks omit visible changes with Sprint Toggle Off. For example, the Xbox b…); L28 (The check
CI / Website build and checks (pull_request)fails on this head and passes on…)More: does it help, other systems, switches, what was read
Does it help: Unproven on the current head. Earlier Windows fixture passes and an in-game renderer smoke test are reported. There are no repeated interleaved runs of the base and both head modes with average FPS, 1% lows, and frame times. The #1929 comparison predates this Toggle.
Other systems: The shared host input path affects keyboard and controller on Windows and Linux, including Steam Deck, and shares A-button handling with physical input, scripts, the control bridge, and the ocarina. Fixtures cover focus and injected A handoffs. The latest renderer changes affect Controls labels and layout across prompt styles and languages. The diff leaves save data, audio, and GPU submission paths untouched.
Switches: Sprint Toggle defaults Off, keeps Sprint held while enabled, and resets to Off with Controls defaults. That preserves the existing input behavior by default. The separate Sprint enable setting still defaults Off. No runtime environment switches were added or changed.
Reviewed:
9b662678d3againsted602b9468: Read AGENTS.md, CONTRIBUTING.md, the Forgejo PR template, and tests/test_menu_i18n.py in full. Read the changed regions of vk_menu.cpp and nn_hid.c, the Sprint module, and related binding, save, load, reset, and host API code. Reviewed fixture changes and skimmed translation entries and reported runs. No docs/review-checklist.md was present. Unchanged portions of large files and individual translations were not exhaustively reviewed.; nothing run (a code review).Checked and fine:
Testing: Read-only review. The Windows build and targeted fixture passes come from the PR description. Commit
c786908creports a Windows in-game renderer smoke test and 12 passing menu translation checks before the final wording change. The full suite and lint are pending. Supplied CI reports head-only failures for Guide screenshots and Website build and checks.Overlaps and merge order: #1948 is the merged Sprint predecessor. No pending overlap or merge-order dependency is identified in the supplied material.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -2541,19 +2556,28 @@ void draw_controls(ui::Ctx& c) {const ui::Prompt wait[] = {{ui::kBack, "Cancel"}};const float bar_top = ui::prompt_bar_top(c); // (the strip itself drawn last, over all: below)const Row* page_row = sel_i < 0 ? &rows[tab_row_to_global(TAB_PAGE, csel)] : nullptr;const bool l3_sprints = opts.sprint && sel_i >= 0 && sel_i < kControls && controls[sel_i].button == HOS_SW_LS &&L26 (minor): The new Left stick press hint checks Sprint's stored bindings alone. If the player also assigns L3 to Toggle HUD, the host keeps both assignments but masks L3 out of Sprint. The hint still tells the player L3 is assigned to Sprint without explaining why it fails. Check both Toggle HUD pad slots before showing the Sprint-specific hint.
@fix
I changed this pull request where an edit could (the rest needs runs, measurements or decisions): the new head is
07d779e387. I rebased it ontomain(40bfceb055).Conflicts resolved
Changed
Already done
Left for the author
Still for the author (no edit does these)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Guide screenshots / Guide images and local UI source review (pull_request)fails on this head and passes on the base branch: Failing after 11s.Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
9b662678d307d779e387WIP: feat(input): a Toggle for Sprint on the Controls page, Off (held) by defaultto feat(input): a Toggle for Sprint on the Controls page, Off (held) by defaultThe branch is current with main
40bfceb0, including the website and Graphics guide fix from #2013. The latest update fixes the Walk fixture on Windows llvm-mingw and records the Graphics source comparison. The Graphics view matched the existing guide image outside the version label, so the image stays as captured.The Controls images below render the same selected Sprint binding at 1280×720 with synthetic Shift and left-stick bindings. They show the move under Walk, L3 and the new Toggle cell with its default Off state. These are game-free UI captures. The PR image uses the
2a74b3f2menu source. The only subsequent rendering change is a help condition shown when the separate left-stick row is selected.Before · main
40bfceb0After · Sprint Toggle
Recommendation: Wait. The L3 hint now respects both Toggle HUD bindings, and the PR description covers the visible Controls changes. Merge readiness still depends on physical input runs and the matched timing comparison in the ledger.
Sprint gains an opt-in press-to-toggle mode while retaining held input by default. The change reuses the Controls page’s Toggle column and adds a saved setting, host latch state, and A-button handoff logic.
@fixwill do (2)website/tests/graphics-settings.test.ts:35: The new test repeats HUD visibility and reset-hook coverage already present on the rebased base in website/tests/hud-visibility.test.ts. (more on the line)40bfceb055will find the reset parser and Custom HUD visibility text already on the base. Remove that claim so the Summary matches the rebased diff.For the author (2) (a run, a measurement or a decision)
host/nn_hid.c:1245: The held path now skips the latch helper and still loads the toggle snapshot. Run the base and both head modes on the same hardware, scene, settings and build type, with repeated interleaved runs. Report average FPS, 1% lows and frame times.Since the last review (on
9b662678d3)Resolved: L18 (The check
Guide screenshots / Guide images and local UI source review (pull_request)fai…); L26 (The new Left stick press hint checks Sprint's stored bindings alone. If the player also as…); L27 (The summary and Risks omit visible changes with Sprint Toggle Off. For example, the Xbox b…); L28 (The checkCI / Website build and checks (pull_request)fails on this head and passes on…)Still open: L16 (The reported build and game-free tests leave the physical input path unverified. Record a…); L17 (The held path now skips the latch helper and still loads the toggle snapshot. Run the base…)
New: L29 (The new test repeats HUD visibility and reset-hook coverage already present on the rebased…); L30 (The Summary credits this PR with repairing Graphics guide support for Reset HUD placement.…)
Checks: Still running:
PR description / Description follows the template (pull_request_target).More: does it help, other systems, switches, what was read
Does it help: Unproven in game. The reported Windows build and targeted tests support the toggle logic, but the Windows renderer smoke test does not establish physical input behavior. The #1929 numbers cover the earlier Sprint implementation. This PR has no repeated base/head FPS, 1% low, or frame-time results for its two modes.
Other systems: The host changes affect keyboard, controller, focus and background input, scripted input, and the control bridge. The fixtures cover focus changes and injected A taps during handoffs. Physical controller behavior on Linux and Steam Deck and applicable Tier 1 coverage remain unverified. The website’s Graphics guide parser and HUD visibility documentation came in through the rebased base.
Switches: The player setting
toggle_sprintdefaults to 0, which preserves held Sprint when Sprint is enabled. That is the right compatibility default. The guide documents it and the menu fixture covers persistence and reset. No environment switch changes.Reviewed:
07d779e387against40bfceb055: Read AGENTS.md, CONTRIBUTING.md, the Forgejo PR template, and the hardware tiers in docs/dev/standards.md. Read the changed-since hunks for vk_menu.cpp, the player guide, and the website test, plus the host input and website parser code those hunks rely on. Skimmed the remaining PR diff, translations, commit history, and reported runs. The unchanged files from earlier rounds were not reread in full. No docs/review-checklist.md exists in the checkout.; nothing run (a code review).Checked and fine:
Testing: Read-only review. The PR reports a Windows llvm-mingw build and earlier targeted fixture passes. Updated-head full-suite and lint results, physical input runs, and timing measurements are still outstanding. The supplied CI snapshot lists the description check as running and no failures.
Overlaps and merge order: #1948 is the Sprint prerequisite and is already in the base. The rebased base also contains the Graphics guide repair. No sibling merge dependency was identified.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -32,6 +32,17 @@ test('CRT-line visibility has a badge and still requires its documented conditioassert.throws(() => readGraphicsSettings(undocumented, menu), /no condition for CRT lines/);});test('Custom HUD rows require their visibility condition and the registered reset action', () => {L29 (minor): The new test repeats HUD visibility and reset-hook coverage already present on the rebased base in website/tests/hud-visibility.test.ts. For example, renaming the registered reset hook now triggers the same coverage assertion in both files. Drop the duplicate test and leave the existing HUD test as the single place for these cases.