feat(input): Sprint on L3 only while it is held, and its row on the Controls tab #1948
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1948
Loading…
Reference in a new issue
No description provided.
Delete branch "llun/Longshot:feat/sprint-hold-l3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
A follow-up to #1929 (Sprint, built on thegrandao's #196), from a hand test of it:
sprint_step(host/nn_hid.c) loses its latch:wantis the stick pushed and the key or the button held.gpu/vk/menu/sprint.cpp). Its saved key,sprint=, is unchanged, so players' settings carry over.The texts (the row's help, the Controls page's Sprint line), the user guide's settings table and Sprint paragraph, and
tests/test_sprint.pyfollow.Read first:
sprint_stepinhost/nn_hid.c,gpu/vk/menu/sprint.cpp.Testing
Tested: Windows 11, RTX 5080 (621.24), this change at
main@eee3e1d5(the same code on #1929's merge), headless through the control bridge from thekokiri-startsave, child Link in Hyrule Field: the option'stabiscontrols; holding Sprint (SPRINT) while running forward: 5.30-5.32 m/s, the fast run; let go at frame 100 with the stick still held: 3.45-3.67 m/s, the fast run over.tests/test_sprint.pypasses (the pad held, let go while moving, held standing, held again), withtest_settings_table,test_menu_modules,test_menu_ini_keys,test_input_background,test_pads_after_menu,test_walk_keyand the other menu checks. The whole suite (Windows, llvm-mingw):main@fc4a6769712 passed, 64 failed, 128 skipped; this branch the same, the same 64 failing (environment ones here: POSIX-only fixtures, no Vulkan headers, lz4).Still to test:
Measurements
Nothing to measure: the per-frame work is one fewer compare (the latch is gone), and #1929 measured Sprint against
mainwithin the spread.Risks
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
Tested in game: Windows 11, RTX 5080, headless from the kokiri-start save, child Link in Hyrule Field: the Sprint row's tab is controls; Sprint held while running: 5.30-5.32 m/s, the fast run; let go with the stick still held: 3.45-3.67 m/s, the fast run over.
WIP: feat(input): Sprint on L3 only while it is held, and its row on the Controls tabto feat(input): Sprint on L3 only while it is held, and its row on the Controls tabPossibly related, for context:
Back to WIP: the Linux build box applies (host code changed) and can't be settled on this PC; it waits for a Test Farm Linux report on this head. Everything else is ready.
feat(input): Sprint on L3 only while it is held, and its row on the Controls tabto WIP: feat(input): Sprint on L3 only while it is held, and its row on the Controls tab@fix
Recommendation: Request changes. Hold-to-sprint simplifies the input logic and makes the setting easier to find, but releasing L3 and pressing A in the same input sample can swallow the roll or action. Fix that handoff and verify physical L3 on the reviewed build.
Players with Sprint enabled now hold L3 while steering and find Sprint below Walk speed on the Controls tab. The change removes the latch and keeps existing settings and bindings. Players who used the toggle now have to keep the stick clicked while steering.
Does it help: Unproven for physical L3. The reported Windows 11 run on an RTX 5080 showed 5.30–5.32 m/s while scripted Sprint was held and 3.45–3.67 m/s after release. The bridge injects SPRINT_KEY, which already used hold behavior on the base. The report names
eee3e1d5, which precedes #1929, so it needs to identify the patched build. This is an input behavior change.Other systems: The same host path serves Windows and Linux, including Steam Deck. SDL and XInput feed the pad state before Sprint is applied, so physical controller coverage matters. The HUD shortcut and post-menu release gates still filter pad input, and the Insert menu and ocarina note wait still suppress Sprint. The diff changes no GPU command, memory allocation, audio, save or build path. The menu edits do affect the guide screenshot source check.
Switches: No environment switches added, changed or removed. The existing Sprint setting keeps sprint= and defaults to Off, which preserves stock bindings for players who leave it disabled. Existing enabled settings now use hold behavior for gamepad Sprint.
Reviewed:
3bc1dbfb0fagainstfc4a6769fd: Read all six file diffs and the sole commit, AGENTS.md, CONTRIBUTING.md, the Forgejo template and developer standards. Read sprint.cpp, test_sprint.py and graphics-and-controls.md in full. Read the changed regions and relevant surrounding code in nn_hid.c, vk_api.h and vk_menu.cpp, including binding setup, controller sampling, the A-press patch, menu writes, bridge dispatch and the renderer option read. Read the screenshot review rules and checker, and skimmed the manifest, translation tables, related test fixtures and recorded results. Unrelated regions of the larger host and renderer files were outside the review. No separate review checklist was present.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Waiting on the author (a run, a measurement or a decision; no edit does it)
Testing: Read-only review. The author reports passing Sprint and related input and menu checks, and 712 passed, 64 failed and 128 skipped on both Windows runs. The controller and keyboard hand test is still pending. Read the release assertion against the base latch and the new hold condition to verify that it distinguishes them.
Overlaps and merge order: #1929 is already merged at the review base and supplies Sprint. #196 is the original implementation carried by #1929. No additional merge dependency was identified from the checkout and supplied discussion.
Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.
@ -75,3 +75,3 @@MENU_MODULE(sprint) {menu::tab("gameplay")menu::tab("controls")The developer guide and control bridge reference still tell testers to enable Sprint on Gameplay. Update both to Controls.
@ -79,3 +79,2 @@.label = "Sprint",.help = "Link runs while you move: Shift held, or the left stick pressed once until you stop, without rolling, ""talking or picking things up. Turning it on changes your controls: Shift moves from B to Sprint (B goes ".help = "Link runs while you move and hold Shift, or the left stick pressed in, without rolling, talking or "Consider “Hold Shift or click and hold the left stick while moving.”
@ -2547,3 +2547,2 @@: sel_i < kControls && controls[sel_i].button == HOS_KEY_SPRINT? "Link runs while you move: the key while it is held, the gamepad button pressed once until you ""stop, without rolling, talking or picking things up. Only with the Gameplay tab's Sprint row on, "? "Link runs while you move and hold the key or the gamepad button, without rolling, talking or "The guide screenshot workflow fingerprints this file and vk_api.h. Review the published Graphics view and update the recorded source review.
@ -974,3 +972,1 @@else if (pad && !was_pad) latched = 1; /* (pressed while he moves) */was_pad = pad;const int want = steered && !paused && (latched || (held & SPRINT_KEY));const int want = steered && !paused && (held & (SPRINT_KEY | SPRINT_PAD)); /* (only while held) */Releasing L3 and tapping A in the same sample skips the A gap. Preserve the press based on whether Sprint supplied A on the previous sample, and test this transition.
@ -1401,1 +1394,4 @@/* Sprint (the Controls page's line; the Controls tab's Sprint row on gives it Shift and the left stick's press): Aheld, only while Sprint's key or button is held and the left stick is pushed (standing still, A would talk, open,pick up), started without the roll (sprint_step). The row off (the default): its key and button do nothing */const int sprint_held = rx_option(HOS_OPT_SPRINT, 0) ? sprint_now : 0;This reads opts.sprint without synchronizing with the bridge or menu writer. Publish the runtime flag and its binding layout together so input sees one consistent state.
@ -13,2 +12,3 @@wants a new press while he moves, hos_sprint_press_mask A's bit while it is Sprint's A (not the player's own), thesprint_step is compiled alone: A only while steered and the key or the gamepad input held (let go, the plain run again),hos_sprint_press_mask A's bit while it is Sprint's A (not the player's own), theplayer's own A mid-sprint a gap and then a press of theirs (a tap shorter than the gap too). nx2/oot_patches.py patch_sprint_press runs on lifted text: the mask goesReplace the inherited lifted-text sample with independently authored synthetic input. The repository rule covers sampled lift output in fixtures.
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
d1ad085193. It was already up to date withmain.Changed
Left for the author
Still for the author (from the review)
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
Recommendation: Request changes. The A-button handoff now preserves a tap when L3 is released, but input polling can still race a Sprint setting change and see a partial binding layout. The reported bridge run leaves physical L3 behavior on the updated head unverified.
Players with Sprint enabled now hold L3 while steering and find Sprint under Controls, directly after Walk speed. The change removes the pad latch, preserves saved settings and bindings, and adds coverage for the A-button handoff. Players who used the toggle now have to keep the stick clicked while steering.
Since the last review (on
3bc1dbfb0f)Resolved:
Still open:
eee3e1d5and bridge SPRINT. Physical input results, menu screenshots, Linux build coverage and the requested check results for the updated head are pending.)New:
Does it help: Unproven for physical L3. The reported Windows 11 and RTX 5080 run in Hyrule Field measured 5.30–5.32 m/s with bridge Sprint held and 3.45–3.67 m/s after release. The bridge injects the keyboard-equivalent bit, which already used hold behavior on the base. The named revision
eee3e1d5predates #1929. This is an input behavior change.Other systems: Windows SDL and XInput and Linux SDL, including Steam Deck, feed the shared Sprint path. The HUD shortcut and post-menu release gates still filter pad inputs, and the Insert menu and ocarina note wait still suppress Sprint. The diff leaves GPU commands, allocations, audio, saves and the game build path unchanged. Shared menu inputs also affect the Graphics screenshot source check and the published guide.
Switches: No environment switches. The existing Sprint option keeps sprint= and defaults to Off, which preserves stock bindings by default. Saved On values now use hold behavior for gamepad Sprint.
Reviewed:
d1ad085193againstfc4a6769fd: Read AGENTS.md, CONTRIBUTING.md, the Forgejo template and developer standards. Reviewed both commits, the eight file diffs againstfc4a6769fdand the four changed diffs against3bc1dbfb0f. Read sprint.cpp and test_sprint.py in full, the affected guide and developer documentation sections, and the changed regions and relevant callers in nn_hid.c, vk_api.h, vk_menu.cpp, vk_replay.cpp, oot_patches.py and the binding fixture. Skimmed screenshot records, translations and reported runs. The separate review checklist and sibling Tooling checkout were absent. Unrelated portions of the larger source files were outside the review.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Waiting on the author (a run, a measurement or a decision; no edit does it)
Testing: Read-only review. git diff --check passed. The author reported 712 passed, 64 failed and 128 skipped on both Windows revisions, with the same failure count and broad environment categories. No build, lint, tests or game runs were performed for this review. The supplied evidence includes no final-head Linux, physical-controller or CI result.
Overlaps and merge order: #1929 is already in the merge base and includes the Sprint work from #196. No additional merge dependency was identified. Issue #1047 is related.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -1401,1 +1394,4 @@/* Sprint (the Controls page's line; the Controls tab's Sprint row on gives it Shift and the left stick's press): Aheld, only while Sprint's key or button is held and the left stick is pushed (standing still, A would talk, open,pick up), started without the roll (sprint_step). The row off (the default): its key and button do nothing */const int sprint_held = rx_option(HOS_OPT_SPRINT, 0) ? sprint_now : 0;Publish Sprint enable and its binding layout together. A bridge update can race this read and expose a partial Shift/L3 remap.
@ -30,0 +35,4 @@if configured:if os.path.isfile(configured) or shutil.which(configured):return [configured]return [part.strip('"') for part in shlex.split(configured, posix=sys.platform != "win32")]Windows shlex splits an argument like -I"C:\Program Files\SDK" inside the path. Use Windows-compatible parsing for configured compiler commands with flags.
Pushed
bfa4c5bd, on BeanBot's review ofd1ad0851(#1948 (comment)):HOS_BIND_SPRINT_ON,MKWVK_API_VERSION38): off before any binding moves, on only once the layout is whole, through an atomic exchange.npad_statesreads it with acquire, and the row's value, beforeread_inputsamples the bindings, so on means the layout is whole and either off turns Sprint off at once. At the first use the host takes it from the options file'ssprint=line.tests/test_sprint.pychecks that no binding the layout moves moves while Sprint is on for the input, and that it is on after the layout (fails ond1ad0851).tests/test_audio_volume.py,tests/test_discord_activity.py): no splitting, so a Windows path with spaces stays whole.d1ad0851checked: its handoff test fails on3bc1dbfb(the tap lost) and passes on it.main@fc4a6769and here (37 issues each,vk_menu.cppandvk_api.hamong them already onmain); the image is the Graphics tab, which this PR doesn't change.tests/test_sprint.pyonmain(from #1929, and #196 before it) has aLIFTEDfixture in the lifter's C format with the game's function names, asnx2/oot_patches.py's anchors are; this PR replaces it with independently written matcher input.Not run in the game:
main@fc4a6769doesn't build on Windows (thevk_replay.cppnamespace break, already reported), so this head is checked game-free only (test_sprint,test_input_background,test_pads_after_menu,test_walk_key, the menu checks). The earlier hold run (5.30-5.32 m/s held, 3.45-3.67 after letting go) was on 3bc1dbfb's code,v3.0.0-131-g9229f098, which includes #1929.@fix
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
8e51501b1b. I rebased it ontomain(ae8e78b091).Changed
Changed in part (the rest is for the author)
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
bfa4c5bd178e51501b1b8e51501b1b98ea4101c3Recommendation: Request changes. Hold-to-sprint gives players direct control over when the fast run ends, but the new input lock can deadlock the game even with Sprint Off. The same change also breaks input test fixtures, and physical L3 behavior remains unverified on this head.
Sprint moves below Walk speed on Controls and keeps its saved key. Players who used the toggle now keep L3 clicked while steering. The patch removes the latch, adds coverage for releasing Sprint and tapping A together, and adds a host-side binding transaction that needs a narrower lock scope.
Since the last review (on
d1ad085193)Resolved:
bfa4c5bdfollow-up explicitly flagged the existing main-branch fixture to maintainers in the PR.)Still open:
New:
Does it help: Unproven on physical L3. The author’s Windows 11 and RTX 5080 run in Hyrule Field used v3.0.0-131-g9229f098 with the earlier patch and reported 5.30–5.32 m/s held and 3.45–3.67 m/s after release. The bridge injects the keyboard-equivalent Sprint bit, which already used hold behavior on the base. The current head has no physical-device comparison or input timing evidence for the new lock.
Other systems: SDL, XInput, keyboard and mouse, background input, and bridge input share the changed input path. The new lock affects Windows and Linux, including Steam Deck, with Sprint Off as well as On. The menu binding callbacks use API version 39, which requires a matching host and renderer in the shipped runtime. The diff leaves GPU replay, audio, save data, and game build steps untouched.
Switches: No environment switches changed. The existing sprint= option stays Off by default and keeps its saved key. Off preserves the default binding layout for new profiles. The host and menu must agree on how they interpret the saved value.
Reviewed:
8e51501b1bagainstae8e78b091: Read AGENTS.md, CONTRIBUTING.md, developer standards, and the Forgejo template. No separate review checklist or sibling Tooling checkout was present. Read all nine file diffs and four commits at8e51501b1bagainstae8e78b091and compared the re-review changes against the rebased earlier commits. Read sprint.cpp, test_sprint.py, and test_input_background.py in full and traced the changed host, menu, API, bridge, and fixture paths. Read the screenshot maintenance rules and skimmed the manifest, translation references, recorded runs, and related fixtures. Unrelated sections of the larger host, renderer, and guide files were outside the review.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Waiting on the author (a run, a measurement or a decision; no edit does it)
ae8e78b091and the updated head with a physical Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck. Cover release while steering, the A handoff, Sprint Off and On, and before-and-after menu screenshots. Report the Linux build, applicable Tier 1 coverage, lint, CI, and named baseline-equivalent suite failures for the updated head.Suggestions (the author may take or leave)
Testing: Read-only review. git diff --check was clean. No builds or tests were run. The author reported older Windows game-free checks and a suite comparison of 712 passed, 64 failed, and 128 skipped. The rebased base includes #1949’s fix for the reported Windows compile break, so fresh results should use that base. After shortening the lock scope, compare input timing with Sprint Off and On as well as exercising the physical inputs.
Overlaps and merge order: #1929 is already in the base and provides the Sprint behavior this PR changes. #1949 is also in the base and fixes the previously reported Windows build break.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -606,6 +611,7 @@ static void binds_load(void) {if (!eq) continue;*eq = 0;if (!strcmp(line, "options_version")) version = atoi(eq + 1);if (!strcmp(line, "sprint")) InterlockedExchange(&sprint_on, atoi(eq + 1) == 1);With sprint=2 the menu clamps to On but the host stays Off and ignores the saved binding. Share one saved-value interpretation.
@ -748,6 +759,23 @@ void hos_bind(int set, int button, int slot, int code) {hos_input_clear_toggles();}void hos_bind(int set, int button, int slot, int code) {The new function boundary breaks the Sprint, bound-keys, Walk, and pad-layout source cutters. Extract both binding functions in full and exactly once.
@ -1189,2 +1208,3 @@void hos_mouse_native_stick(int held);scripted_input(buttons, taps, stick);binds_load();AcquireSRWLockShared(&input_bind_lock);Mouse sensitivity takes menu_mu from inside this lock. A bridge Sprint change takes the locks in reverse order and can freeze the game. Sample from a short locked copy.
@ -87,2 +87,4 @@cheat_state += "\n" + block(hid, "enum { SPRINT_KEY") + ";\n" # (Sprint; its gamepad input leaves the HUD shortcut's out)cheat_state += "static uint64_t hud_pad_mask(void);\n" + block(hid, "static int pad_sprint_down(")# (Sprint on for the input, as the row's layout publishes it: the fixture's rx_option says the row is on)cheat_state += "\nstatic volatile LONG sprint_on = 1;\n"The extracted functions also need input_bind_lock and sprint_frame. Both are missing from the generated fixture.
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
ca7099c88e. It was already up to date withmain.Changed
Changed in part (the rest is for the author)
ae8e78b091and the updated head with an Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck, cover the requested Sprint and A handoff cases and screenshots, and report the Linux build, applicable Tier 1 coverage, lint, CI, and named baseline-equivalent suite failures.Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
Recommendation: Request changes. The binding snapshot removes the input/menu lock inversion, but a concurrent rebind can still mix two layouts in one ocarina input report. Physical L3 behavior on the updated head also needs verification.
Players with Sprint enabled hold L3 while steering and find Sprint below Walk speed on the Controls tab. The saved setting and custom bindings carry over. Removing the latch simplifies Sprint itself, while publishing and sampling the binding layout together adds synchronization to shared input code.
Since the last review (on
8e51501b1b)Resolved:
Still open:
ae8e78b091and the updated head with a physical Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck. Cover release while steering, the A handoff, Sprint Off and On, and before-an (The older bridge revision is identified. The new fixture note records the requested checks, and no physical-device, screenshot, Linux build or current-head CI results were supplied.)New:
Does it help: Unproven for physical L3. The older Windows 11 run on an RTX 5080 measured 5.30–5.32 m/s with bridge Sprint held and 3.45–3.67 m/s after release. That run used v3.0.0-131-g9229f098 and injected the keyboard-equivalent input, which already used hold behavior on the base. No physical comparison or input timing results were supplied for
ca7099c88e.Other systems: Windows and Linux, including Steam Deck, share the binding snapshot. SDL and XInput still feed the same pad path, and cached raw pad input is now mapped against the current sample's layout. Ocarina serialization can still consult live bindings after sampling. No GPU replay, audio, save, or build-script changes appear in the diff. The host and renderer API advances from 37 to 39 for the new binding operations.
Switches: Sprint keeps its saved sprint= key and defaults to Off, preserving the stock layout for players who leave it disabled. Enabled gamepad Sprint now requires a hold. No environment switches changed.
Reviewed:
ca7099c88eagainst00e0dc93a9: Read the repository rules, developer standards, Forgejo template, commit history, current diff and re-review delta. Read sprint.cpp and the changed host, renderer and fixture regions with their relevant callers and source cutters. Skimmed the screenshot manifest and reported runs. Unrelated code in the large host and renderer files and translation tables was outside this re-review. The separate review checklist and local Tooling checkout were absent.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Waiting on the author (a run, a measurement or a decision; no edit does it)
00e0dc93a9and updated head with a physical Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck. Cover release while steering, the A handoff, Sprint Off and On, and before-and-after menu screenshots. Report the Linux build, applicable Tier 1 coverage, lint, CI and named baseline-equivalent suite failures.Suggestions (the author may take or leave)
Testing: Read-only review. git diff --check passed. No project code, builds or tests were run. The author reported game-free checks on an earlier head and a Windows suite result of 712 passed, 64 failed and 128 skipped with matching baseline failures. Current-head results are pending.
Overlaps and merge order: #1929 is the merged Sprint implementation this follows. Issue #1047 is related. No competing pull request was identified in the supplied material.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -1138,3 +1166,3 @@for (int i = 0; i < 5; i++) {const int row = HOS_KEY_OC_NOTE_L + i;if (pad_bind[row][0] < 0 && pad_bind[row][1] < 0 && !key_bind[row][0] && !key_bind[row][1])if (sampled_pad(row, 0) < 0 && sampled_pad(row, 1) < 0 && !sampled_key(row, 0) && !sampled_key(row, 1))The snapshot is inactive by the time oc_pad_word runs. Use the same note-slot layout that produced the sampled note bits so a concurrent rebind cannot change this report.
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
2778447da6. I rebased it ontomain(75317e1f31).Changed
Left for the author
00e0dc93a9and the updated head using an Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck; cover release while steering, the A handoff, Sprint Off and On, and before-and-after menu screenshots. Report the Linux build, applicable Tier 1 coverage, lint, CI, and named failures also present on the baseline. No builds or tests were run here.Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
ca7099c88e2778447da6Recommendation: Wait. The controller report now uses one binding snapshot through ocarina serialization. Merge should wait for physical-input and build validation on the updated head and for the Graphics screenshot review.
With Sprint enabled, players hold L3 while steering and release it to return to the normal run. The row moves below Walk speed on Controls and keeps its saved setting. The Sprint state machine loses its latch, while the shared input path adds a locked copy of the bindings per connected read.
Since the last review (on
ca7099c88e)Resolved:
Still open:
00e0dc93a9and updated head with a physical Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck. Cover release while steering, the A handoff, Sprint Off and On, and before-and-after menu screenshots. Report the Linux build, applicable Tier 1 cov (The author identified the older bridge build. The physical-device comparison, menu captures, Linux build and current-head check results remain pending. The rebased comparison base is75317e1f31.)Does it help: Unproven for physical L3 on this head. The author's older Windows 11 bridge run on an RTX 5080 reported 5.30–5.32 m/s held and 3.45–3.67 m/s after release. It injected the keyboard-equivalent Sprint bit, which already used hold behavior on the base, and predates the binding snapshot.
Other systems: Windows XInput, SDL on Windows and Linux, and Steam Deck use the shared input path. Ocarina serialization now retains the sampled bindings across the report. The diff leaves GPU replay, audio, and saves untouched. The menu and API edits affect the Graphics guide's recorded source inputs.
Switches: No environment switches changed. Sprint keeps sprint= and defaults to Off, preserving stock controls for players who leave it disabled. Existing enabled settings now use hold-to-sprint on the gamepad. The host binding API advances from 37 to 39.
Reviewed:
2778447da6against75317e1f31: Read the repository rules, developer standards, Forgejo template, commit history, Sprint menu module, and changed host input code through report serialization. Inspected the other diff hunks, affected fixture excerpts, screenshot maintenance rules and manifest entry, and supplied comments and reviews. Unrelated regions of large files and the rendered screenshot were outside this review. No separate review checklist was found.; nothing run (a code review).Checked and fine:
Waiting on the author (a run, a measurement or a decision; no edit does it)
2778447da6. Compare75317e1f31and this head with an Xbox controller and keyboard on Windows and a controller on Linux or Steam Deck. Cover Sprint Off and On, release while steering, and the A handoff. Include before-and-after menu screenshots, Linux build results, applicable Tier 1 coverage, lint, CI, and named suite failures reproduced on the base.Suggestions (the author may take or leave)
Testing: Read-only review. git diff --check passed. No builds, tests, game runs, or screenshot captures were performed. The supplied game-free results are from an earlier revision.
Overlaps and merge order: #1929 supplied the original Sprint feature and is already in the base. No pending merge order was identified.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
WIP: feat(input): Sprint on L3 only while it is held, and its row on the Controls tabto feat(input): Sprint on L3 only while it is held, and its row on the Controls tabsiantm referenced this pull request2026-11-21 02:18:11 +00:00
siantm referenced this pull request2026-11-21 02:30:01 +00:00