feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main) #1929
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1929
Loading…
Reference in a new issue
No description provided.
Delete branch "llun/Longshot:feat/sprint"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Sprint: Link runs the game's own fast run, the one after a roll while A stays held, without the roll. Hold
Shift while you move, or press the left stick (L3) once on a controller and Link runs until he stops. It is a
row on the Insert menu's Gameplay tab, off by default, and Sprint has its own line on the Controls page, so its
key and gamepad button can be rebound like any other control.
This is thegrandao's #196, carried onto current
main:#196 has been idle since 2026-11-13 and conflicts with
mainin 9 files. Their work is the first commit, under their name(Guilherme Bueno), with what the rebase had to change listed in its message; my changes are separate commits after it.
If thegrandao comes back to #196, this can close in its favour, or they can take these commits.
How it gets the game's own state, not a speed multiplier. In this game Link's run with A held is the fast run (the
one a roll leads into while A stays down); A pressed while he moves is a roll, and in front of someone it talks, opens
or picks up.
sprint_step(host/nn_hid.c) holds A while Sprint is held and the left stick is pushed, andpatch_sprint_press(nx2/oot_patches.py) clears A's bit from what the game's controllers count as pressed this frame(
f_8038a220, the four the game plays with;f_834a3680, the menus') while it is Sprint's A. The game sees A held andnever pressed: its own fast run, its own animations and transitions, no roll and no action. Everything else is the
game's: stopping, letting go, a roll, Z-targeting, cutscenes and every other state change end or take over the run as
they do with A held. The player's own A mid-sprint is let through as a press (a 50 ms gap in Sprint's A), so tapping A
still rolls. Sprint holds nothing while the Insert menu is open or the ocarina waits for a note. Child and adult Link
both run it (numbers below).
The bindings, and what was already on them. Longshot's defaults give Shift to B on the keyboard and the
left stick's press to the game's LS (in this game, hiding the text box in a conversation). So Sprint starts with
nothing: turning the row on moves Shift from B to Sprint (B goes to V when no control has V) and the left
stick's press from LS to Sprint, only where they are still the defaults and Sprint has none of its own; turning it off
puts them back. Controls the player rebound are left alone (
apply_sprint_layout). Sprint goes through Longshot's owninput mapping:
pad_sprint=andkey_sprint=inlongshot_options.ini, rebindable on the Controls page, tradinggamepad inputs with the Switch's buttons by the same slot rules.
What changed from #196:
gpu/vk/menu/sprint.cpp, on the Gameplay tab (#1633's modules; #196 had it invk_menu.cpp's table on the Controls tab), its keysprintintests/test_menu_ini_keys.py's FROZEN, its textsunchanged but for the tab's name.
HOS_OPT_SPRINTis 97 (54 is hold-to-toggle's onmain);MKWVK_API_VERSION37 (mainis at 36).main's Walk and HUD shortcut controls, and its gamepad read leaves out the inputs the HUD shortcutowns, as the Switch's buttons do.
HOS_SPRINT_STILL_MSis gone: it was the way round the roll for a game built without the patch, which the supportedbuild always has, and a switch is only for an A/B or a kill switch (standards).
SPRINTin input scripts and the control bridge: Sprint reads its own key or pad input, which a headless test runhas neither of;
SPRINTholds Sprint's key there (bit 48, past HidNpadButton's, taken out before the game, the cheatsor the toggles see the buttons). It is how this PR was tested, and how the Test Farm can.
docs/user/graphics-and-controls.md): the settings table's row, what Sprint does, its ini lines.still held from the Insert menu (
pad_after_menu), as every other control does; an A tap during Sprint's 50 ms gap isdelivered even when Sprint ends or a frame runs long; the bindings the row moved are recorded (
sprint_auto_bind=inlongshot_options.ini,HOS_BIND_SPRINT_AUTO), checked against the real bindings and dropped by any edit of theplayer's, so turning the row off restores only untouched automatic moves, across restarts too. And mine, found in the
game: B's move back to Shift stands on its own, so rebinding only Sprint's key no longer leaves B on V.
Read first:
sprint_stepandpad_sprint_downinhost/nn_hid.c,patch_sprint_pressinnx2/oot_patches.py,gpu/vk/menu/sprint.cpp.See #196, #1005, #1881.
Testing
Tested: Windows 11, RTX 5080 (driver 621.24), headless runs through the job queue and the control bridge, from the
repository's scrubbed
kokiri-startsave (its own user folder: my saves and options checked unchanged withdiff -rqafterwards), the game never saved by me (its own transition autosave wrote the run's copy). Link's speed from the
bridge's
statuspositions, Hyrule Field's forest entrance, child and adult (the Debug age switch); screenshots attachedbelow.
oot_patches: Sprint's A without its press at 1 function(s) in code_042.c, andin code_hot.c).6.33; A held from a standstill: 6.36; Sprint 6.34, Sprint started mid-run 6.35. Child: plain run ≈4.45, the post-roll
run ≈5.3, Sprint ≈5.3 (the child's narrow field entrance cut the steady windows short; the peaks agree across two
runs). The frames show the same forward-leaning run with pumping arms as the post-roll run, unlike the plain run's.
SPRINTheld runs the plain run (adult 5.38, child ≈4.5). Released: back to the plain run (adult 5.37).Standing still with Sprint held: no movement (0.0, both ages, and the same with nothing held).
Sprint: rolls as on
main. Z-targeting mid-sprint (ZL held): the Z-targeting movement takes over (≈3.5 m/s, bothages), and Sprint resumes after. A cutscene (Saria's farewell, reached by running into the forest exit) with Sprint
held: the cutscene plays, Sprint does nothing in it.
longshot_options.inihadsprint=1,key_sprint=16,0(Shift),pad_sprint=7(the left stick's press),key_b=86,0(V),pad_ls=-1.mainand here: each trial from a fresh teleport to the same spawn: the plain run 4.5 m/s on both;main's post-roll run and this PR's Sprint at the same place and pose at frame 90 (screenshots).main@66dc0a51(the frames and fps above), onmain@e0ef1b57(the same-spotruns) and
297f977donmain@dda8b119, with the reviewers' changes: the same speeds again (child: plain run4.44-4.5 m/s, A held 5.21-5.35, Sprint 5.28-5.37, row off 4.45; adult: A held 6.3, Sprint 6.34, row off 5.25-5.36,
Sprint released and A tapped mid-sprint as before).
297f977d): row on (sprint_auto_bind=7, B on V, Sprint on Shift and L3), the gamestarted again (
relaunch), row off: B back on Shift, L3 back on LS, Sprint with nothing,sprint_auto_bindgone.With Sprint rebound to G before a start (
key_sprint=71, as the Controls page saves it), row off kept G on Sprint andput L3 back, but left B on V: fixed in
2bfa4b22(B back on Shift; a game-free case that fails before). My saves andoptions checked unchanged after each run (
diff -rq).press, swimming, Epona, pushing and pulling a block, carrying, the ocarina taken out mid-sprint.
tests/test_sprint.py(the binding table compiled with the module's layout against options files;sprint_stepcompiled alone; the patch on lifted text; the sources: the Gameplay row, its key, the bridge's
SPRINT, the HUDshortcut's inputs), and the checks that cut the changed sources updated. Whole suite on Windows (llvm-mingw),
297f977dagainstmain@dda8b119:main708 passed, 64 failed, 128skipped; this PR 709 passed (
test_sprint), the same 64 failing (environment ones here: POSIX-only fixtures, no Vulkanheaders, lz4 and the like). On
2bfa4b22tests/test_sprint.pypasses, with its two new cases.Still to test:
moving, and press L3 once while moving, expecting the fast run at once with no roll, ending when you let go (Shift) or
stop (L3); then rebind Sprint on the Controls page to another key and pad button, expecting those to sprint (by hand:
a headless run has no physical key or pad, so this PR's runs held Sprint through
SPRINT).Boots (expecting their slow walk, as A held gives) and with Hover Boots (their slide), on Epona and swimming, expecting
each as with A held (the repository's saves have no sword or boots).
@BeanstalkLinux, Sprint row on, theSPRINTinput held while running inHyrule Field: the fast run, no roll).
Measurements
Verdict: no cost with Sprint off (its default): this PR against
mainwithin the spread in Hyrule Field (median8.30 ms against 8.32 ms, p99 11.01 against 10.87, 1% low 90.9 against 92.0 fps,
main's first run the outlier). Thoseruns were held at the game's 120 fps cap; an uncapped A/B (Game frame rate cap Uncapped) is running and goes in a comment.
Setup: Windows 11, RTX 5080 (621.24);
dev.py ab --scene hyrule-field --runs 3 --seconds 60(child Linkin Hyrule Field, the repository save, every row at its default, V-Sync off,
HOS_FPS_MAX=1000, the frame rate cap row atits default), interleaved A1 B1 A2 B2 A3 B3, each 60 s after the warm-up, the frame trace; the median of the three.
dda8b119297f977dWith the row on against off on this PR (
04f1485f, the 60 fps cap, child standing in Hyrule Field, three interleavedpairs of 25 s): 59.9 / 60.0 / 59.9 fps off, 60.2 / 59.9 / 60.1 on.
Risks
oot_patches: WARNING: the controllers' press was found in N of 2 functions), and Sprint's A would roll and act like a press. Turning the rowoff undoes it; reverting the PR removes it.
who used LS to hide a conversation's text box loses that until they rebind it.
MKWVK_API_VERSION37: the game and the renderer must come from the same build (they always ship together).longshot_options.inigainssprint=, andpad_sprint=/key_sprint=lines.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.MKWVK_API_VERSIONbumped (MkwVkHostorMkwVkRendereringpu/vk/vk_api.hchanged).mainand here, for a change that shows on screen.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.Built on thegrandao's #196: their commit is the first here, under their name. When squash-merging, please keep them as a
co-author:
Co-authored-by: Guilherme Bueno <[email protected]>.🤖 Generated with Claude Code
Tested in game: Windows 11, RTX 5080 (621.24), headless through the control bridge from the kokiri-start save, child and adult in Hyrule Field: with the Gameplay tab's Sprint row on, Sprint runs at the game's post-roll speed (adult 6.34 m/s against the post-roll run's 6.33 and the plain run's 5.32; child about 5.3 against 4.45) with the same forward-leaning animation, no roll as it starts; row off, released and standing still give the plain run or nothing; tapping A mid-sprint rolls; Z-targeting and a cutscene take over; the row lays out key_sprint=16 and pad_sprint=7. No fps change on/off (59.9-60.2 at the 60 cap).
Possibly related, for context:
Screenshots (Windows 11, RTX 5080, headless runs from the
kokiri-startsave, 1280x720 bridge shots).Same spot,
mainand this PR, each from a fresh teleport to Hyrule Field's child spawn, frame 90 of the run:main@e0ef1b57, the game's own roll with A held after it; this PR @04f1485f, Sprint held. Same place, same pose, same speed (about 1.1 m/s on both in this stretch).The run's animation, child Link (this PR): the plain run (upright), the game's post-roll run, and Sprint: the last two the same forward-leaning run with pumping arms.
Tapping A mid-sprint still rolls (adult, this PR):
Recommendation: Request changes. Sprint bypasses the existing release-after-menu protection for controller input and can erase a player's custom bindings when disabled. The reported headless runs demonstrate the fast run, but do not cover either physical-input case.
Adds an optional fast run using the game's held-A behavior, with keyboard and controller bindings. The reported run shows the intended speed and animation, but the input transitions need fixes before this is safe to merge.
Does it help: Yes, for the tested headless path: on Windows with an RTX 5080, adult Sprint measured 6.34 m/s versus 6.33 m/s after a roll and 5.32 m/s for the plain run. Physical bindings and the current head remain unverified. The capped on/off FPS measurements do not establish that there is no performance cost.
Other systems: Linux, Steam Deck and physical keyboard/controller input remain untested on this head. Sword use, boots, Epona and swimming also need the listed runs. The injected A affects game input and menus; the ocarina wait and Insert menu have explicit guards, but controller input held across the Insert menu bypasses its release guard.
Switches: No environment switch added, changed or removed. The player-facing Sprint setting defaults off; that is appropriate for an optional control change. Enabling it moves default bindings, subject to the binding issue noted below.
Reviewed:
d887dd2752against51f5f9da56: Read the repository rules, PR template, standards, commits, input and binding paths, Sprint module, patch implementation, and the available review and testing reports. Skimmed the remaining diffs and test fixtures; did not read every changed code file in full. docs/review-checklist.md and the adjacent Tooling checkout were absent.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: No commands from the project, builds or tests were run, as requested. The author reports a Windows headless game run on an earlier commit and matching baseline test failures; the current head, physical controls, Linux and remaining listed scenarios still need results.
Overlaps and merge order: #196 is the original implementation and remains open according to the description; coordinate with its author and retain one implementation. The checkout cannot establish its current status.
Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.
@ -0,0 +49,4 @@host->bind(HOS_BIND_KEY, HOS_SW_B, 0, kShift); // (taken from Sprint; V is free again)for (int s = 0; s < 2; s++)if (key(S, s) == kShift) host->bind(HOS_BIND_KEY, S, s, 0);if (pad(S, 0) == HOS_PAD_LSTICK || pad(S, 1) == HOS_PAD_LSTICK) {This clears Shift even when the player assigned it to Sprint themselves; the L3 branch below has the same problem. Please record which bindings the automatic layout moved and restore only those, preserving player changes.
@ -890,0 +905,4 @@static int pad_sprint_down(void) {int down = 0;AcquireSRWLockShared(&pad_bind_lock);const uint64_t raw = (uint64_t)(uint32_t)pad_raw_now & ~hud_pad_mask();Please also exclude
pad_after_menuhere. Closing Insert while holding the Sprint button and moving can otherwise latch Sprint before the player releases the button, unlike the other controller bindings. A behavioral menu-close test would cover this.Checks on the head (
d887dd27) against main @51f5f9da, Windows, llvm-mingw: main: 701 passed, 63 failed, 127 skipped in 155 s (windows, 24 at once); this PR: 702 passed, 63 failed, 127 skipped in 168 s (windows, 24 at once). The same tests fail on both (environment ones here); the extra passes are this PR's. The in-game run on the head is still building.@fix
I changed this pull request where the review's points could be done here: the new head is
8d50b816fc.Changed
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
Recommendation: Request changes. A short A tap can be lost when Sprint ends during its delayed-press gap. The two blockers from the previous review also remain in the supplied checkout.
Sprint adds an optional fast run using the game’s held-A behavior, with keyboard and controller bindings. The reported headless run shows the intended run, but the delayed A transition can discard an action, and the previous review’s menu-release and binding-restoration issues remain at this checkout’s head.
Does it help: Yes, for the tested headless path: the author reports adult Sprint at 6.34 m/s, compared with 6.33 m/s after a roll and 5.32 m/s for a plain run on Windows. Physical bindings and in-game behavior on the supplied head remain unverified. The capped 59.9–60.2 FPS measurements do not establish the per-frame cost.
Other systems: Linux, Steam Deck, physical keyboard and controller input, sword use, boots, Epona and swimming remain unverified on this head. The patch changes the game’s A-press handling; the Insert menu and ocarina have guards, but the input transitions still need correction.
Switches: No environment switch added, changed or removed. The player-facing Sprint setting defaults off, appropriate for an optional control change; enabling it changes default bindings.
Reviewed:
d887dd2752against51f5f9da56: Reviewed checkoutd887dd27against51f5f9daand the supplied comments and prior review. The later fix reported at8d50b816is not in this checkout, so its changes could not be reviewed. Read the repository rules, PR template, commits, Sprint module and changed input paths; skimmed the remaining diffs and test fixtures rather than reading every changed code file in full. docs/review-checklist.md and the adjacent Tooling checkout were absent.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
d887dd27. The reported later fix is not available in this checkout for verification.Suggestions (the author may take or leave)
Testing: No project commands, builds or tests were run. The author reports matching baseline test failures on this head and an in-game headless run on an earlier commit; physical play, Linux and the remaining listed scenarios still need results.
Overlaps and merge order: #196 is the original implementation, described as still open; coordinate with its author and retain one implementation. Its current status could not be verified offline.
Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -890,0 +938,4 @@const int own = (int)(*buttons >> B_A & 1); /* (the player's own A: the pads', the keys', a script's) */const int own_down = own && !own_was;own_was = own;if (!want) {If A is tapped during Sprint and the player releases Sprint or stops within the 50 ms gap, this clears the pending press before the game sees it, so the roll or action is lost. Please deliver the pending press even when Sprint ends and cover that transition with a behavioral test.
@fix
I changed this pull request where the review's points could be done here: the new head is
b2ddd2b05d.Changed
Already done
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
Recommendation: Request changes. Sprint can lose an A action after a long frame, and the supplied head still has the previously identified binding-restoration and delayed-action problems. The reported run shows the intended sprint on an earlier commit, but does not establish the current head’s physical-input behavior or per-frame cost.
Adds an optional, rebindable sprint using the game’s held-A run. It gives players a faster run without rolling, but introduces input-transition and binding-restoration failures that need correction before merge. Since the earlier reviews, the supplied head adds the controller release-after-menu guard and session-only binding tracking; it does not contain the later
b2ddd2b05dfix described in the comments.Does it help: Yes, on the tested headless path: the author reports adult Sprint at 6.34 m/s, versus 6.33 m/s after a roll and 5.32 m/s for the plain run on Windows. Those runs used an earlier commit. The capped 59.9–60.2 FPS measurements do not establish the cost against the base or show frame times and lows.
Other systems: Linux, Steam Deck and physical keyboard and controller input remain unverified on this head. Sword use, boots, Epona and swimming also need the listed runs. The patch changes A-press handling in gameplay and menus; the Insert menu and ocarina have explicit guards. Tier 1 coverage, the Linux build, current-head in-game results and CI remain outstanding.
Switches: No environment switch added, changed or removed. The player-facing Sprint setting defaults off, appropriate for an optional control; enabling it moves default bindings, subject to the unresolved restoration issue.
Reviewed:
8d50b816fcagainst51f5f9da56: Compared8d50b816fcwith51f5f9da56and read the supplied comments and reviews, AGENTS.md, CONTRIBUTING.md, the PR template, standards, commits, Sprint module, Sprint test and changed input paths. Inspected the remaining diffs and relevant binding and menu callers; the larger changed code files and remaining test fixtures were not read in full. docs/review-checklist.md and the adjacent Tooling checkout were absent. Attached screenshots were unavailable offline.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: No project code, builds or tests were run. The author reports matching baseline test failures on
d887dd27and headless game runs on an earlier commit; the supplied head has no reported in-game run.Overlaps and merge order: #196 is the original implementation. Coordinate with its author and retain one implementation; its current status cannot be verified offline.
Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -890,0 +953,4 @@__atomic_store_n(&hos_sprint_press_mask, 0, __ATOMIC_RELAXED);return;}__atomic_store_n(&hos_sprint_press_mask, own || now < owed_until ? 0u : 1u, __ATOMIC_RELAXED);A short A tap is lost if the next input read arrives after
owed_until, such as after a stall over 100 ms: the mask is restored before the press is emitted. Keep the press pending until an input update has delivered it, and cover a long interval between reads.@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
d42354ed72. I rebased it ontomain(3df5c13ed2).Changed
Already done
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
b2ddd2b05dd42354ed72WIP: feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main)to feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main)Recommendation: Request changes. The binding-restoration issue from the earlier review remains: automatically moved controls are not restored after a restart, and later player edits can be mistaken for automatic moves. The reported runs demonstrate the intended sprint on an earlier commit, but the current head and physical controls remain unverified.
Adds an optional, rebindable sprint using the game's held-A run. Since the last review, the controller menu-release guard and delayed-A handling have changed, with behavioral cases added; automatic binding provenance remains process-local.
Does it help: Yes, for the earlier tested headless path: the author reports adult Sprint at 6.34 m/s, versus 6.33 m/s after a roll and 5.32 m/s for the plain run on Windows. The current head has no reported in-game run. The capped 59.9–60.2 FPS on/off measurements do not establish frame-time cost against the base.
Other systems: Physical keyboard and controller input, Linux, Steam Deck, sword use, boots, Epona and swimming remain unverified on this head. The Linux build, Tier 1 coverage and current-head CI results are also outstanding. The patch affects A-press handling in gameplay and menus; Insert-menu and ocarina guards are present.
Switches: No environment switch added, changed or removed. The player-facing Sprint setting defaults off, appropriate for an optional control; enabling it moves default bindings, subject to the unresolved restoration issue.
Reviewed:
d42354ed72against3df5c13ed2: Comparedd42354ed72against3df5c13ed2and read the supplied comments and prior reviews, repository rules, PR template, commit list, Sprint module and changed input and patch paths. Inspected the remaining diffs and test cases; the larger changed code files and fixtures were not read in full. The review checklist and adjacent Tooling checkout were unavailable; screenshots were unavailable offline.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: No project code, builds or tests were run. The author reports matching baseline test failures on an earlier head and headless in-game runs on an earlier commit; the current head still needs the reported outstanding runs.
Overlaps and merge order: #196 is the original implementation. Coordinate with its author and retain one implementation; its current status cannot be verified from the checkout.
Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -0,0 +22,4 @@/// its own. Off: those go back to B and LS. A control the player rebound is left as it isvoid apply_sprint_layout(bool on) {if (!can_bind()) return;static bool moved_key, moved_b, moved_pad;The earlier restoration issue remains: these flags vanish on restart, so disabling Sprint in a later session leaves the automatically moved bindings in place. They also cannot detect a later edit back to the same value. Please persist the move provenance and track later edits before restoring only untouched automatic moves.
@fix
I didn't change this pull request: what the review asks needs the author (runs, measurements or decisions, which can't be done here).
Already done
Left for the author
Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
@Beanstalk Test Sprint on head
8083880eagainst merge base3df5c13e. Please target Linux and Windows for build and scripted gameplay coverage. Use the repositorykokiri-startsave, teleport to Hyrule Field, and run a short uncapped same-scene A/B with at least two starts per side. Keep Sprint at its default Off for this comparison and hold graphics settings fixed. Report median and p99 frame time and 1% lows. Check normal movement and A presses for regressions and surface launch failures, crashes, and device loss.If the plan supports a candidate-only functional scenario, enable the Gameplay Sprint row on the PR, use the bridge's
SPRINTinput while steering, then release it. Check that Sprint starts without a roll and returns to the ordinary run on release, as observable through supported probes.SPRINTand the Sprint setting are new on this PR, so do not send them to the baseline or fail the baseline for lacking them. Leave physical Shift/L3, same-value rebinding across a real restart, and short physical A taps for a separate hands-on run.Beanstalk test farm · an earlier run: commit
8083880(the newer results are in a comment below)Commit
8083880· approved by futondestroyer (reviewed) · dashboard⚠️ Note: The plan compares the PR build with main; the schema cannot pin the requested head and merge-base hashes.
⚠️ Note: A candidate-only Sprint-on scenario is not supported: Sprint is not an available plan setting, and scenarios cannot run only on the PR. Physical controls, rebinding across restart, and short physical A taps are also outside this plan.
⚠️ Note: The frame-time segment is stationary after the scripted inputs; the pictures compare their outcomes, but cannot prove a roll or movement speed on their own.
Started at 2026-11-20 23:07 UTC.
Estimate: done in about 1 h 15 min, from the queue and the testers online now.
linuxwindowsCouldn't be judged: the tester's PC could not finish the test. The farm tries another PC, or the same one after a fix; it says nothing about the PR on its own.
linux, report 1:the main base failed (exit 1): build.py stopped (exit status 1): <data>/longshot/nx2/../gpu/vk/vk_vma.cpp:421:9: error: return type 'unsigned long' must match previous return type 'unsigned long long' when lambda expression has unspecifiedlinux, report 2:the main base failed (exit 1): build.py stopped (exit status 1): <data>/longshot/nx2/../gpu/vk/vk_vma.cpp:421:9: error: return type 'unsigned long' must match previous return type 'unsigned long long' when lambda expression has unspecifiedWhat was tested
What will be tested · AI plan (
gpt-6.1-terra)On Linux and Windows, both revisions are built and run twice in uncapped Hyrule Field gameplay with Sprint left off. Scripted movement and A presses produce comparison pictures, followed by measurements of median and p99 frame time and 1% lows. Crashes, device loss, significant frame-time regressions, or picture differences fail; gameplay takes about 20 minutes per target, in addition to timed lift builds.
kokiri-start(settings vsync=2, frame_rate_cap=6, quality_preset=3), then teleport to Hyrule Field, move the stick, take the picture after-movement to compare with main, press buttons, take the picture after-a to compare with main, measure field for 30 s (after 5 s warm-up); 2 runs on each side.Measurements on `linux`, for the PR description
Verdict: could not be judged on linux (2 reports).
Hardware: 1: linux+nvidia+nvidia-proprietary+dgpu
NVIDIA GeForce RTX 5070, 620.70.6AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM; 2: linux+amd+radv+dgpuAMD Radeon RX 9070 (RADV GFX1201), 26.0.8AMD Ryzen 7 5800X 8-Core Processor, 32 GB RAMScene: field-default, from the repository's save kokiri-start (vsync=2, frame_rate_cap=6, quality_preset=3); each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); field-default: 2 game starts a side, field 30 s after 5 s warm-up; timed builds: main and this PR each built 2 times a cache, alternating, each a whole build in a fresh folder (lift; shader preparation not timed); each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (
@Beanstalkon this PR runs it again)Build times (each a median of the timed builds; caches: lift = the lift again (no kept lift, main's compiled objects kept))
3df5c138083880Flags and settings
None: the plan varied no setting, switch or build option.
As Markdown for the PR description:
The testers' hardware
linuxNVIDIA GeForce RTX 5070, 620.70.6AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAMlinuxAMD Radeon RX 9070 (RADV GFX1201), 26.0.8AMD Ryzen 7 5800X 8-Core Processor, 32 GB RAM@fix
I didn't change this pull request: what the review asks needs the author (runs, measurements or decisions, which can't be done here).
Already done
Left for the author
Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
@fix
8083880e5d297f977dd9Beanstalk test farm
Commit
2bfa4b2· approved by nobody yet · dashboardA member of
BigBeanscan review this commit and comment@Beanstalkto test it.I didn't fix this pull request: the push was refused (error: failed to push some refs to 'http://magicbean-git:3000/llun/Longshot.git'). Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
@fix
Rebased onto
main@dda8b119(297f977d), then2bfa4b22. What changed and what ran:sprint_auto_bind). I read each against the code; they hold.297f977d(Windows 11, RTX 5080, headless): Sprint's speeds as before (child Sprint 5.28-5.37 m/s against A held 5.21-5.35 and the plain run 4.44-4.5; adult 6.34 against 6.3, row off 5.25-5.36). Across a restart (the bridge'srelaunch): row on, restart, row off put B back on Shift and L3 back on LS, Sprint with nothing,sprint_auto_bindgone. So the point in #1929 (comment) and #issuecomment-60820 (the moves forgotten at a restart) no longer holds.2bfa4b22: with Sprint rebound to G before a start, row off kept G and put L3 back but left B on V, Shift unused. B's move now stands on its own (back to Shift while B is on V and no control the player chose has Shift).tests/test_sprint.pyhas the case (fails on297f977d) and one where Shift was given to X (B stays on V). The in-game rerun on2bfa4b22follows.297f977dagainstmain@dda8b119: 709 passed against 708, the same 64 failing (environment ones here).mainin Hyrule Field, within the spread (median 8.30 against 8.32 ms, p99 11.01 against 10.87, 1% low 90.9 against 92.0 fps) but held at the game's 120 fps cap; the uncapped A/B is running and goes in the next comment.@fixat 00:03 was refused because my rebase's force-push landed at 00:04:52, just before BeanBot's push: nothing in the settings (maintainer edits are on).Nothing needed changing: the review's points are already done.
Already done
Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main)to WIP: feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main)Back to WIP: the description check fails on one box, the host code built on Linux. It's built and run on Windows only here; the Test Farm's Linux PCs couldn't build main itself (vk_vma.cpp:421, not this PR's). It goes ready again once a Linux build of the head is in, with the uncapped A/B and the in-game rerun on
2bfa4b22.WIP: feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main)to feat(input): sprint on Shift or the left stick's press, the game's own post-roll run (#196 carried onto main)