WIP: feat(menu): Longshot logo and name left of the tabs, version and a dev build name right of them #1629
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1629
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:feat/menu-banner-title"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: not run (opened untested, as asked) · Needs: any OS, any GPU
TL;DR
The Insert menu's top bar showed "Longshot" and the version together, in small type at its left. This PR puts the Longshot logo and a larger "Longshot" at the left of the tabs, and moves the version to the right of the tabs. A development run can also be given a name (
mise run run-win -BuildName "...", orLONGSHOT_BUILD_NAME), shown under the version so testers know which change they have. It has not been run in the game yet.Breakdown
version_text), its fit-to-room shrinking, the tabs, the log and the bug report.tests/test_menu_size.pyupdated to read the new layout (not run here).Why
Asked for by the maintainer: the menu's title should read as the game's name with its logo, the version should sit apart from it, and dev builds should say what they test.
What changed
The banner of the Insert (F1) menu is now split around the tabs.
draw_optionsingpu/vk/vk_menu.cpp: the left block drawsui::logo(assets/longshot.png, 1.25× the text height) and "Longshot" inc.f.headingat 24 pt, shrunk to fit the room at Small and Medium (ui::fit_px, 14 pt at the least), at its size or not at all at Large. The right block drawsversion_text(LONGSHOT_VERSION)right-aligned atc.w - c.safewith the same fitting as before, and, whenLONGSHOT_BUILD_NAMEis set, that name under it at 13 pt.LONGSHOT_BUILD_NAMErow ingpu/vk/switches.def(diag).scripts/run-vk.ps1 -BuildName "..."sets it (mise run run-win -BuildName "..."); other launches set the variable themselves.tests/test_menu_size.pyreads the version without the "Longshot " prefix, at the right, and the logo + name block.docs/development.md'srun-winrow and the Running a test switch table.Measurements
Verdict: nothing to measure: a few draw calls in the menu's banner.
Flags and settings
One new switch, for development runs only.
LONGSHOT_BUILD_NAME-BuildNameTesting
Tested: nothing yet: opened untested, as the person I work for asked. The checks were not run on this PC.
Not tested: the menu in the game; the C++ compile;
mise run test.Must be tested:
LONGSHOT_BUILD_NAME="my test"and open the menu, expecting "my test" under the version (by hand).Risks
What could break: the banner's layout in a narrow window (the title or version hidden when they don't fit, as the version was before).
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why. (not run yet, as asked)
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). (not run on this PC)third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Possibly related, for context:
434712bb— Earlier merged change established the version text in the Insert-menu banner; this redesign repositions it.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.