feat(builds): an instance's folder is builds/<track>/<version>, renamed when it updates #184

Merged
HumanBean merged 4 commits from dyst/LongshotLauncher:fix/instance-folder-names into main 2026-11-17 22:17:57 +00:00
Member

A build's folder named after its track (nightly, nightly (2)) looked like a copy of another and said nothing about what was in it, so anyone cleaning up their disk couldn't tell which version was where. Every instance now lives in <builds>/<track>/<version>, and an update renames its folder to the new version.

Stacked on #190 (#181 and #182 are merged): merge order #190, #184, then #185. Related: #180 (the home's list is Your instances), #187 (Relist), #189 (the same one-level scan in OtherLauncher.GamesIn/Read).

What changed

  • New instances: <builds>/<track>/<version> (LauncherSettings.FolderFor): nightly/nightly-2029-c544828f, stable/v3.0.1. The folder name is the version itself (Versions.IsTagName's characters, safe on Windows and Linux; Longshot for an unknown track or a version with no such name). A second instance of the same version is <version> (2), the only suffix. A new build never goes inside an old instance's folder named after its track (<builds>/nightly (2)/<version> until that one is moved).
  • Update / go-back: the folder is renamed to the new version's name when the build starts, before make_game.py (BuildRegistry.FolderOf, BuildJob.Place, BuildStepViewModel.RenameFolder, InstanceFolders.Rename), so make_game.py's --out/--update is the final path.
    • A rename, not a copy: the game, its settings, shader caches (an in-place update keeps them, ShaderCaches.Keep sees the same folder), mods and a save in its own user/save go with it.
    • The row takes the new folder at once and the list is saved; the new version comes when the build finishes (BuildRegistry.Replace).
    • Fails safe: refused, nothing changed and nothing started, while Longshot runs, onto a path that exists, or on Windows while a file in the folder is held open (File Explorer, an editor, antivirus): the problem page says so and Build again retries.
    • Rolls back: a build that fails, is stopped (Cancel, the launcher's SIGTERM) or can't start renames the folder back (InstanceFolders.MoveBack, waiting up to 10 s for a file the stopped build still holds), so the row's folder names the version the row still has. If it can't go back, the row lists where the folder is and the log says so.
    • A rebuild of the same version keeps its folder as it is.
  • Step 2: "Game folder" is now the Builds folder. Its Change sets Settings' builds folder, one setting, so step 2 and Settings never disagree (the row says so). There's no way to pick a folder for one instance any more (PickedFolder is gone). Under it, where this build goes: Builds into nightly\nightly-…, or for an update/go-back nightly\nightly-189-… becomes nightly\nightly-187-… when the build starts ….
  • Settings: BUILDS FOLDER (was WHERE BUILDS GO) and BUILD FILES each say what they hold: your instances, one folder per track and version; working files every build reuses, not the game, can be on another drive. The build files folder is unchanged otherwise (its own default, its own Change).
  • Instances that already live elsewhere (a folder the player chose before) keep working where they are and are never renamed.
  • The home's offer (Instances in the old folder layout: Keep / Move) now moves the instances from before this layout into it: those named after their track (nightly, nightly (2), launchers rc.7 and on) and those named after their first version (v3.0.0-rc.5, launchers before rc.7). Track-named ones first, since <builds>/nightly becomes the nightly's folder (moved by way of a name beside it, and back the same way). Same safety rules as before, plus: never into another instance's folder. Keep is remembered.
  • Scans: the leftover offer and the saves' gather look in the tracks' folders too (InstanceFolders.Folders).

The home's layout at 960x600 (found in this PR's screenshots, on main too)

  • Every top banner is a title and one line, cut with an ellipsis (the whole text as its tooltip), and Details shows the whole text (a toggle, so a touch screen reaches it; Less hides it). That covers the launcher's update, the Hookshot and NX2navi offers, the old versions' folders, the old folder layout and the notice; what each does is unchanged. The old-layout offer's line: 2 instances use the old folder layout. Move puts them in <track>&lt;version>; saves and settings go with them.; the folders and the shortcut warning are under Details.
  • The scroll bar has a gutter of its own (16 px): Fluent's ScrollViewer draws it over the content's right edge, which covered Build another version and the list.
  • The title is on a row of its own and both columns start from the top, level (TRACK beside YOUR INSTANCES); the page is centred as a whole when it fits.
  • Tighter spacing in the left column, so Manage saves fits at 960x600 with a banner and an update showing.
  • Before/after with each banner, and with none: #184 (comment)

The builds folder's scans

Every scan of the builds folder looks in the tracks' folders too (InstanceFolders.Folders): Leftovers.Find, Leftovers.LostUpdate, Leftovers.Relist (#187) and LauncherService.BuildFolders (the saves' gather). UnlistedChecks has the nested layout beside the flat shapes. #189's OtherLauncher.GamesIn/Read has the same one-level scan: whichever of #184 and #189 merges second adapts it.

The trade-off: shortcuts made by hand

The launcher's own shortcuts start --play and keep working. A shortcut or a Steam (non-Steam game) entry made to the game's own program (bin\longshot.exe), common on the Steam Deck, or a Gear Lever entry, points at the old path and has to be made again after an update. Step 2 says so before every update that renames, and so does the README. That's the price of a folder that names its version.

Tests

  • python -I tests/test_launcher_core.py: 1966 checks pass. New InstanceFolderChecks drive the real path in temp folders:
    • first build → nightly/<v1> (make_game's --out is that folder); another version → nightly/<v2>; the same version again → (2);
    • an update renamed to <v3> with save, shader caches, mods and settings inside, the list saved; a go-back renamed down;
    • refusals: Longshot running, a path there, a file held open on Windows (a real FileShare.None lock on this PC) → nothing changed;
    • a failed build → back to the old name, list saved; MoveBack waiting for a held file;
    • a folder of the player's never renamed;
    • the offer for both old shapes, its order, every refusal, a move into its own folder and back, a list that can't be saved.
    • UpdateFolderChecks and FolderFor's vectors are rewritten for the new layout (not weakened); a source check makes sure step 2 picks no folder of its own.
  • python -I tests/test_release.py: OK. dotnet build App -c Release: 0 warnings, 0 errors.
  • Translations: the new texts are in all 12 catalogs, written by an AI: they need a native speaker's check. The replaced ones are removed.

Screenshots

Before/after in #184 (comment) (headless, tools/screenshots).

What to check on a PC with a dump

Not run with a real build here (no game dump on this PC).

  1. Build a nightly: it lands in <builds>\nightly\<version>.
  2. Build another version of the same track: <builds>\nightly\<other version>, no (2).
  3. Play it once (so it has shader caches), then Update it: step 2 says … becomes …; the folder is renamed before the build starts; after it finishes, the save, shader caches (no long "Preparing shaders" at the next start), mods and settings are there.
  4. Go back to an older version: renamed down the same way.
  5. Start an update with a File Explorer window open inside the instance's folder (Windows): the build refuses with a clear message and nothing changes; close it, Build again.
  6. Cancel an update mid-build: the folder is back to its old name.
  7. With an instance from an older launcher (<builds>\nightly or <builds>\v3.0.0-rc.5): the home offers Move; after it, the instance is in <builds>\<track>\<version> and plays.
A build's folder named after its track (`nightly`, `nightly (2)`) looked like a copy of another and said nothing about what was in it, so anyone cleaning up their disk couldn't tell which version was where. Every instance now lives in `<builds>/<track>/<version>`, and an update renames its folder to the new version. **Stacked on #190** (#181 and #182 are merged): merge order #190, #184, then #185. Related: #180 (the home's list is *Your instances*), #187 (Relist), #189 (the same one-level scan in OtherLauncher.GamesIn/Read). ## What changed - **New instances: `<builds>/<track>/<version>`** (`LauncherSettings.FolderFor`): `nightly/nightly-2029-c544828f`, `stable/v3.0.1`. The folder name is the version itself (Versions.IsTagName's characters, safe on Windows and Linux; `Longshot` for an unknown track or a version with no such name). A second instance of the **same** version is `<version> (2)`, the only suffix. A new build never goes inside an old instance's folder named after its track (`<builds>/nightly (2)/<version>` until that one is moved). - **Update / go-back: the folder is renamed to the new version's name when the build starts, before make_game.py** (`BuildRegistry.FolderOf`, `BuildJob.Place`, `BuildStepViewModel.RenameFolder`, `InstanceFolders.Rename`), so make_game.py's `--out`/`--update` is the final path. - A rename, not a copy: the game, its settings, shader caches (an in-place update keeps them, `ShaderCaches.Keep` sees the same folder), mods and a save in its own `user/save` go with it. - The row takes the new folder at once and the list is saved; the new version comes when the build finishes (`BuildRegistry.Replace`). - **Fails safe:** refused, nothing changed and nothing started, while Longshot runs, onto a path that exists, or on Windows while a file in the folder is held open (File Explorer, an editor, antivirus): the problem page says so and *Build again* retries. - **Rolls back:** a build that fails, is stopped (Cancel, the launcher's SIGTERM) or can't start renames the folder back (`InstanceFolders.MoveBack`, waiting up to 10 s for a file the stopped build still holds), so the row's folder names the version the row still has. If it can't go back, the row lists where the folder is and the log says so. - A rebuild of the same version keeps its folder as it is. - **Step 2: "Game folder" is now the Builds folder.** Its *Change* sets Settings' builds folder, one setting, so step 2 and Settings never disagree (the row says so). There's no way to pick a folder for one instance any more (`PickedFolder` is gone). Under it, where this build goes: *Builds into nightly\nightly-…*, or for an update/go-back *nightly\nightly-189-… becomes nightly\nightly-187-… when the build starts …*. - **Settings:** *BUILDS FOLDER* (was *WHERE BUILDS GO*) and *BUILD FILES* each say what they hold: your instances, one folder per track and version; working files every build reuses, not the game, can be on another drive. The build files folder is unchanged otherwise (its own default, its own Change). - **Instances that already live elsewhere** (a folder the player chose before) keep working where they are and are never renamed. - **The home's offer** (*Instances in the old folder layout*: Keep / Move) now moves the instances from before this layout into it: those named after their track (`nightly`, `nightly (2)`, launchers rc.7 and on) and those named after their first version (`v3.0.0-rc.5`, launchers before rc.7). Track-named ones first, since `<builds>/nightly` becomes the nightly's folder (moved by way of a name beside it, and back the same way). Same safety rules as before, plus: never into another instance's folder. Keep is remembered. - **Scans:** the leftover offer and the saves' gather look in the tracks' folders too (`InstanceFolders.Folders`). ## The home's layout at 960x600 (found in this PR's screenshots, on main too) - **Every top banner is a title and one line**, cut with an ellipsis (the whole text as its tooltip), and **Details** shows the whole text (a toggle, so a touch screen reaches it; Less hides it). That covers the launcher's update, the Hookshot and NX2navi offers, the old versions' folders, the old folder layout and the notice; what each does is unchanged. The old-layout offer's line: *2 instances use the old folder layout. Move puts them in &lt;track&gt;\&lt;version&gt;; saves and settings go with them.*; the folders and the shortcut warning are under Details. - **The scroll bar has a gutter of its own** (16 px): Fluent's ScrollViewer draws it over the content's right edge, which covered *Build another version* and the list. - **The title is on a row of its own and both columns start from the top**, level (TRACK beside YOUR INSTANCES); the page is centred as a whole when it fits. - **Tighter spacing** in the left column, so Manage saves fits at 960x600 with a banner and an update showing. - Before/after with each banner, and with none: https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/184#issuecomment-45723 ## The builds folder's scans Every scan of the builds folder looks in the tracks' folders too (`InstanceFolders.Folders`): `Leftovers.Find`, `Leftovers.LostUpdate`, `Leftovers.Relist` (#187) and `LauncherService.BuildFolders` (the saves' gather). `UnlistedChecks` has the nested layout beside the flat shapes. #189's `OtherLauncher.GamesIn`/`Read` has the same one-level scan: whichever of #184 and #189 merges second adapts it. ## The trade-off: shortcuts made by hand The launcher's own shortcuts start `--play` and keep working. **A shortcut or a Steam (non-Steam game) entry made to the game's own program (`bin\longshot.exe`), common on the Steam Deck, or a Gear Lever entry, points at the old path and has to be made again after an update.** Step 2 says so before every update that renames, and so does the README. That's the price of a folder that names its version. ## Tests - `python -I tests/test_launcher_core.py`: 1966 checks pass. New `InstanceFolderChecks` drive the real path in temp folders: - first build → `nightly/<v1>` (make_game's `--out` is that folder); another version → `nightly/<v2>`; the same version again → `(2)`; - an update renamed to `<v3>` with save, shader caches, mods and settings inside, the list saved; a go-back renamed down; - refusals: Longshot running, a path there, **a file held open on Windows** (a real `FileShare.None` lock on this PC) → nothing changed; - a failed build → back to the old name, list saved; `MoveBack` waiting for a held file; - a folder of the player's never renamed; - the offer for both old shapes, its order, every refusal, a move into its own folder and back, a list that can't be saved. - `UpdateFolderChecks` and `FolderFor`'s vectors are rewritten for the new layout (not weakened); a source check makes sure step 2 picks no folder of its own. - `python -I tests/test_release.py`: OK. `dotnet build App -c Release`: 0 warnings, 0 errors. - Translations: the new texts are in all 12 catalogs, **written by an AI: they need a native speaker's check**. The replaced ones are removed. ## Screenshots Before/after in https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/184#issuecomment-45346 (headless, `tools/screenshots`). ## What to check on a PC with a dump Not run with a real build here (no game dump on this PC). 1. Build a nightly: it lands in `<builds>\nightly\<version>`. 2. *Build another version* of the same track: `<builds>\nightly\<other version>`, no `(2)`. 3. Play it once (so it has shader caches), then Update it: step 2 says *… becomes …*; the folder is renamed before the build starts; after it finishes, the save, shader caches (no long "Preparing shaders" at the next start), mods and settings are there. 4. Go back to an older version: renamed down the same way. 5. Start an update with a File Explorer window open inside the instance's folder (Windows): the build refuses with a clear message and nothing changes; close it, *Build again*. 6. Cancel an update mid-build: the folder is back to its old name. 7. With an instance from an older launcher (`<builds>\nightly` or `<builds>\v3.0.0-rc.5`): the home offers *Move*; after it, the instance is in `<builds>\<track>\<version>` and plays.
Author
Member

Screenshots

The offer is new, so there is no before. Drawn with tools/screenshots (headless, scene home-rename-folders): two instances an older launcher named after a version, Keep or Rename. The existing home-leftovers scene is unchanged.

home-rename-folders.png

## Screenshots The offer is new, so there is no before. Drawn with `tools/screenshots` (headless, scene `home-rename-folders`): two instances an older launcher named after a version, Keep or Rename. The existing `home-leftovers` scene is unchanged. ![home-rename-folders.png](https://git.magicbean.dev/attachments/0baeb0ce-bdb7-457e-a806-0f2ae0c80cfe)
Member

Possibly related, for context:

  • issue #138 Launcher: Updated build folder is not renamed to the current channel name — Open request about version-named folders persisting after updates; this offers a user-directed rename
Possibly related, for context: - issue #138 Launcher: Updated build folder is not renamed to the current channel name — Open request about version-named folders persisting after updates; this offers a user-directed rename
dyst force-pushed fix/instance-folder-names from b0017b3a2c
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
to 0fc4752372
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
2026-11-17 21:06:51 +00:00
Compare
Author
Member

Rebased onto #182 so the stack merges in order; only the language files conflicted (both sides kept); builds with 0 errors.

Rebased onto #182 so the stack merges in order; only the language files conflicted (both sides kept); builds with 0 errors.
dyst force-pushed fix/instance-folder-names from 0fc4752372
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 4s
to 6bd1ab1210
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
2026-11-17 21:14:21 +00:00
Compare
Author
Member

Rebased onto main (8594b47: #180, #171 and #179 merged). Only the language files and the screenshot tool's scene list conflicted, both sides adding entries; both kept, each catalog checked as JSON with no duplicate key, the app and the screenshot tool build with 0 warnings. The code is otherwise unchanged, so the earlier test runs stand. Merge order: #181, #182, #184, #185.

Rebased onto main (8594b47: #180, #171 and #179 merged). Only the language files and the screenshot tool's scene list conflicted, both sides adding entries; both kept, each catalog checked as JSON with no duplicate key, the app and the screenshot tool build with 0 warnings. The code is otherwise unchanged, so the earlier test runs stand. Merge order: #181, #182, #184, #185.
Author
Member

Screenshots: before and after (the instance-folder rework, d9f5559)

Drawn with tools/screenshots (headless, the same scene and window size on both sides). Before is this PR's previous head, 6bd1ab1.

Settings: the builds folder and the build files

Each row now says what it holds.

before
after

Step 2, a new build

"Game folder" is now the Builds folder, Settings' own setting; the line under it says where this build goes (nightly\nightly-…).

before
after

Step 2, going back to an older nightly

The instance's folder takes that version's name when the build starts, and the line says what follows it.

before
after

The home's offer

Instances in the old layout (named after their track or their first version) move into <builds>/<track>/<version>.

before
after

## Screenshots: before and after (the instance-folder rework, d9f5559) Drawn with `tools/screenshots` (headless, the same scene and window size on both sides). Before is this PR's previous head, 6bd1ab1. ### Settings: the builds folder and the build files Each row now says what it holds. ![before](https://git.magicbean.dev/attachments/765314bc-2b1e-4502-8f24-323703363f2a) ![after](https://git.magicbean.dev/attachments/8fd3dd40-7359-4340-b4d4-5f4e612f6f15) ### Step 2, a new build "Game folder" is now the Builds folder, Settings' own setting; the line under it says where this build goes (`nightly\nightly-…`). ![before](https://git.magicbean.dev/attachments/e85dc211-ff92-493d-96b4-8ff1fd7863e9) ![after](https://git.magicbean.dev/attachments/3ecd5b0c-60e4-4ef8-8a20-fa85e1a59a7e) ### Step 2, going back to an older nightly The instance's folder takes that version's name when the build starts, and the line says what follows it. ![before](https://git.magicbean.dev/attachments/61bba7a5-4ea0-44e4-bc03-09b2e6152cb0) ![after](https://git.magicbean.dev/attachments/ef19a2ae-5b65-4c15-9831-9460df02ac58) ### The home's offer Instances in the old layout (named after their track or their first version) move into `<builds>/<track>/<version>`. ![before](https://git.magicbean.dev/attachments/3ca5f592-52bb-4742-8ccc-20d02f17c674) ![after](https://git.magicbean.dev/attachments/9e29ba40-b602-4ef2-acf7-44c3036212b7)
dyst changed title from fix(home): offer to rename instances' folders an old launcher named after a version to feat(builds): an instance's folder is builds/<track>/<version>, renamed when it updates 2026-11-17 21:47:14 +00:00
Author
Member

Reworked (d9f5559): instances live in //, a second same version is ' (2)', an update or go-back renames its folder before make_game.py and back if the build doesn't finish, step 2's Change sets the builds folder (Settings' own) and shows where the build goes, and the home's offer moves both old shapes into the layout. 1798 checks pass. Description rewritten; screenshots above.

Reworked (d9f5559): instances live in <builds>/<track>/<version>, a second same version is ' (2)', an update or go-back renames its folder before make_game.py and back if the build doesn't finish, step 2's Change sets the builds folder (Settings' own) and shows where the build goes, and the home's offer moves both old shapes into the layout. 1798 checks pass. Description rewritten; screenshots above.
Member

Heads-up for the rebase: #187 merged Leftovers.Relist (#141), which at the home's start lists again a game whose row went. Like Find and LostUpdate, it scans Directory.EnumerateDirectories(buildsFolder) one level down, so with this PR's builds/<track>/<version> layout it needs InstanceFolders.Folders too. Otherwise a game in builds/nightly/<version> whose row went is never listed again.

#187's checks are in tests/launcher_core/UnlistedChecks.cs. #189 (open) has the same one-level scan in OtherLauncher.GamesIn / Read; whichever of #184 and #189 merges second adapts.

Heads-up for the rebase: #187 merged `Leftovers.Relist` (#141), which at the home's start lists again a game whose row went. Like `Find` and `LostUpdate`, it scans `Directory.EnumerateDirectories(buildsFolder)` one level down, so with this PR's `builds/<track>/<version>` layout it needs `InstanceFolders.Folders` too. Otherwise a game in `builds/nightly/<version>` whose row went is never listed again. #187's checks are in `tests/launcher_core/UnlistedChecks.cs`. #189 (open) has the same one-level scan in `OtherLauncher.GamesIn` / `Read`; whichever of #184 and #189 merges second adapts.
dyst force-pushed fix/instance-folder-names from d9f5559815
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
to 5bc64ba994
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
2026-11-17 22:16:13 +00:00
Compare
Author
Member

Screenshots: the home's layout at 960x600, before and after (5bc64ba)

Drawn with tools/screenshots (headless, the same scene and window size on both sides). Before is this PR without the layout fix (887d282).

  • Before: the scroll bar draws over the right column (Build another versio|n), the columns drift apart (YOUR INSTANCES below TRACK), and with a banner and an update Manage saves is cut off.
  • After: every banner is a title and one line with Details, the scroll bar has its own gutter, both columns start level from the top, and the left column fits.

No banner

before
after

The launcher's update

before
after

Hookshot's saves found

before
after

NX2navi's saves found

before
after

A notice (no builds yet)

before
after

Old versions' folders

before
after

Instances in the old folder layout

before
after

Details pressed (after only)

The whole text, and the shortcut warning, under Details; the page scrolls, the columns stay level.

after

## Screenshots: the home's layout at 960x600, before and after (5bc64ba) Drawn with `tools/screenshots` (headless, the same scene and window size on both sides). Before is this PR without the layout fix (887d282). - **Before:** the scroll bar draws over the right column (*Build another versio|n*), the columns drift apart (YOUR INSTANCES below TRACK), and with a banner and an update Manage saves is cut off. - **After:** every banner is a title and one line with **Details**, the scroll bar has its own gutter, both columns start level from the top, and the left column fits. ### No banner ![before](https://git.magicbean.dev/attachments/0da1c760-17e4-46ee-87c7-46206d7ca178) ![after](https://git.magicbean.dev/attachments/15d8df8d-71d4-45f1-a5e2-cad7062e95c6) ### The launcher's update ![before](https://git.magicbean.dev/attachments/11281e64-1265-4f8b-bf0e-aad1ae46be43) ![after](https://git.magicbean.dev/attachments/3a7feac9-ab45-49fd-95b6-0cd8d334b2e9) ### Hookshot's saves found ![before](https://git.magicbean.dev/attachments/00ae1519-fb56-4c51-b2b2-5e548c7cedbf) ![after](https://git.magicbean.dev/attachments/39befc65-8f28-4648-8021-6ba194ca22e9) ### NX2navi's saves found ![before](https://git.magicbean.dev/attachments/f99f09a2-e41a-4a74-8775-1417593f701c) ![after](https://git.magicbean.dev/attachments/3ee5f05d-f57b-4d9c-bca1-ca08a4098d17) ### A notice (no builds yet) ![before](https://git.magicbean.dev/attachments/2fb20147-7d50-4af1-b73c-4b6e28b07697) ![after](https://git.magicbean.dev/attachments/2e34d567-cd87-44c0-bfc4-e9a84e533edd) ### Old versions' folders ![before](https://git.magicbean.dev/attachments/b6c5a154-4bb1-4619-83cd-ccac8ad3d347) ![after](https://git.magicbean.dev/attachments/11853848-bd37-4e28-9d8e-e3dbbe06a214) ### Instances in the old folder layout ![before](https://git.magicbean.dev/attachments/1b65bb35-362a-4037-a2d8-ac009a4daab6) ![after](https://git.magicbean.dev/attachments/ad66f705-33a0-40ea-bd38-85287c868dd8) ### Details pressed (after only) The whole text, and the shortcut warning, under Details; the page scrolls, the columns stay level. ![after](https://git.magicbean.dev/attachments/7d1f75ec-4549-4d48-b4a2-997f1a4a7cfd)
Author
Member

Rebased onto #190 (fix/linux-backup-folders @ 5802ebe, on main 12fd3af: #181, #182, #186 and #187 merged) and fixed the home's layout (5bc64ba).

  • Rebase: #184's two commits replayed onto #190. The conflicts were the language files (both sides add texts at their end: both kept, the texts #184 replaces removed, each file checked as JSON with no duplicate key) and tests/launcher_core/Program.cs (#187's UnlistedChecks() and #184's InstanceFolderChecks() both kept). No code conflict.
  • Layout fix (in this PR, as asked): one-line banners with Details, a gutter for the scroll bar, the title on its own row so both columns start level from the top, tighter spacing so the left column fits at 960x600. Before/after: #184 (comment)
  • madebyjordan's point on Relist (#187): done. Leftovers.Relist uses InstanceFolders.Folders and takes the channel from the track's folder a game is in. UnlistedChecks now has the nested layout beside the flat shapes: builds/nightly/ and builds/rc/ listed again on their channel next to an old builds/stable, the older nightly left unlisted and offered for deletion (UnlistedChecks.cs, the "#184's layout" block). No other one-level scan of the builds folder is left on main: Find, LostUpdate, Relist and the gather all go through InstanceFolders.Folders. #189's OtherLauncher.GamesIn/Read has the same scan: as you said, whichever of #184/#189 merges second adapts it; I've left a note on #189.
  • Checks: test_launcher_core.py 1966 passed, test_release.py OK, dotnet build App -c Release 0 warnings, 0 errors.
  • Merge order: #190, #184, #185.
Rebased onto #190 (fix/linux-backup-folders @ 5802ebe, on main 12fd3af: #181, #182, #186 and #187 merged) and fixed the home's layout (5bc64ba). - **Rebase:** #184's two commits replayed onto #190. The conflicts were the language files (both sides add texts at their end: both kept, the texts #184 replaces removed, each file checked as JSON with no duplicate key) and `tests/launcher_core/Program.cs` (#187's `UnlistedChecks()` and #184's `InstanceFolderChecks()` both kept). No code conflict. - **Layout fix** (in this PR, as asked): one-line banners with Details, a gutter for the scroll bar, the title on its own row so both columns start level from the top, tighter spacing so the left column fits at 960x600. Before/after: https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/184#issuecomment-45723 - **madebyjordan's point on Relist (#187): done.** `Leftovers.Relist` uses `InstanceFolders.Folders` and takes the channel from the track's folder a game is in. `UnlistedChecks` now has the nested layout beside the flat shapes: builds/nightly/<version> and builds/rc/<version> listed again on their channel next to an old builds/stable, the older nightly left unlisted and offered for deletion ([UnlistedChecks.cs, the "#184's layout" block](https://git.magicbean.dev/dyst/LongshotLauncher/src/commit/5bc64ba994bb163c27a65bf2a0f03dadaf106942/tests/launcher_core/UnlistedChecks.cs#L91)). No other one-level scan of the builds folder is left on main: Find, LostUpdate, Relist and the gather all go through InstanceFolders.Folders. #189's OtherLauncher.GamesIn/Read has the same scan: as you said, whichever of #184/#189 merges second adapts it; I've left a note on #189. - **Checks:** `test_launcher_core.py` 1966 passed, `test_release.py` OK, `dotnet build App -c Release` 0 warnings, 0 errors. - **Merge order:** #190, #184, #185.
HumanBean deleted branch fix/instance-folder-names 2026-11-17 22:17:57 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!184
No description provided.