Bug Report: Update Cache Preservation Broken in nightly-695Install: #2108
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#2108
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What you used
Linux AppImage
Version
695
Channel
Nightly
Where it stopped
Installing or updating the launcher or the builder
The error
Operating system and free space on the output drive
Cachy os 500gb+
Visual Studio or Build Tools version, and Windows SDK version
No response
Log
No response
Before you send it
Possibly related, for context:
It not my setup. its a clean cachy OS install. I had the same issue 2 week ago ON WINDOWS. so I switched. Its a issue that keeps breaking its self in your updates.
its rebuilding EVERY fucking file - code_006.c 24 MB 58s (61s)
INF code_038.c 24 MB 58s (62s)
INF code_052.c 24 MB 60s (63s)
INF code_041.c 24 MB 61s (64s)
INF code_048.c 24 MB 61s (64s)
INF code_005.c 25 MB 67s (71s)
INF code_036.c 24 MB 63s (125s)
INF code_007.c 26 MB 65s (128s)
INF code_054.c 24 MB 71s (134s)
INF code_046.c 24 MB 73s (138s)
INF code_045.c 24 MB 80s (151s)
INF code_025.c 23 MB
So tired of this shit. tell claude to not fuck with this part. You had it working perfect around 625
Correction to the cause, from reading the build code and the 618 -> 625 history. This is for whoever picks up the chunk half; no fix is claimed here, and it does not undo anything that update cost.
nx2/build.py'sobject_key(src, fl, deps)issha1(<the generated chunk C's bytes> + flag_text(fl) + <the generated headers>). There is no lift/translation key in it.nx2/chunks.pykeeps the boundaries inwork/image/chunks.txt, and the lift writes a chunk's functions in address order with no version, timestamp or hash in the file, so the same C gets the same key.the game was translated with these tools before: translating it again is skipped, so the chunk C was identical.git log 2210931c..a104182bshows the only build-relevant change between the two nightly sources was #1727, which changedsplit_giants.flag(): that function hashed its own file into every chunk's compile flags, so every chunk's key moved. #1727 also changed how giant functions are split (guest locals, direct pieces), so most chunks' compiled text genuinely changed. Replaying the two splitter versions over one translation here: 70 of 76 code files differ, and only the 6 with no function of 256 KB or more are byte-identical.There is a real, smaller fix for the future: key a chunk by the bytes actually compiled (the split copy) instead of the splitter's file hash. A later splitter edit that leaves a chunk's split output unchanged would then reuse its object (0 chunks compiled), where today any edit to
nx2/split_giants.pyrecompiles all of them. A splitter edit that changes the output still recompiles exactly the chunks it changes. #2199's host/renderer keys are separate and untouched. This is claimed in the room aschunk-object-key; no PR yet.