feat(home): builds and saves follow a player between the installed and a portable launcher #189
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!189
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:feat/other-launcher-data"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A player who goes from the installed launcher to a portable one, or back, finds no builds and no saves: each launcher keeps its own list and, on Windows, its own save folder. The only way back was Manage saves > Import > Another folder, for saves only; a build folder could not be listed at all.
Related: #141 (a portable launcher whose builds dropped off its list; fixed separately in #187).
What changes
A portable launcher with no build offers the installed launcher's, once, on the home: Your installed launcher's builds and saves, Not now or Use them.
%APPDATA%\Longshot\save) are copied in only when this launcher's save folder has no file yet.InstalledLauncherAsked).Add a build folder… on the home, beside Build another version. The empty home also has Built it already? Add its folder…. It takes:
LongshotLauncher-data, or the folder it sits in). From that, it takes that launcher's builds whose game is there, the games in its own builds folder that its list lost, and its saves when this launcher has none yet.Only Longshot's own games: a release's or a nightly's version, as #187's relisting takes. Never a Hookshot 2.x game or one with no version.
Games are found where a builds folder holds them: in
builds/<track>/<version>(#184) and right in the builds folder (the older layout), throughInstanceFolders.Folders. A game's channel is its track folder's name, or before that layout its own folder's, only for a version on that channel.A save is never copied over another. These all count as a save:
.save.longshot-old);The home then says to import it from Manage saves, which backs up first. The same saves copied before say nothing.
How the copy is made:
mouse_sens.txtandpresent.txtcome too if missing.When the home offers what:
The other launcher's
builds.jsonis only read (BuildRegistry.Peek). A broken one counts as no list, and nothing is written beside it, unlikeLoad.On Linux every launcher already shares one save folder, so only builds are taken.
Texts and docs: new texts in all 12 catalogs, with es-419's own words where they differ. README and docs/saves.md explain switching.
Screenshots
In the comment below:
home(the empty home's new link),home-installed-offer,home-add-folder(tools/screenshots).Testing
Windows 11, .NET SDK 10.0.404, TEMP on its long path.
python -I tests/test_launcher_core.py: 2000 checks passed (rebased onto main up to #194).OtherLauncherCheckscovers:GamesIn.builds/rc/<version>found, on rc; the channel from the track folder, never for a version off it.builds/<track>/<version>).python -I tests/test_release.py: 9 errors on this PC, the same without this change (signing tools); release code untouched.Not tested:
Known, not changed here:
🤖 Generated with Claude Code
Screenshots (tools/screenshots, headless, Windows layout):
home: the empty home's new link

home-installed-offer: a portable launcher with no build, on a PC whose installed launcher has some

home-add-folder: Add a build folder... beside Build another version

Possibly related, for context:
972793cbee6e99e1aa03Rebased onto main (after #186 and #187; only the catalogs' ends and the check list conflicted, both kept), and one commit from a review of the PR:
1890 checks pass on Windows; removing the version filter fails a check.
Overlap: #184 moves instances to
builds/<track>/<version>.OtherLauncher.GamesInandRead(a portable launcher's own builds folder) look one level down, likeLeftovers.Relistfrom #187, so whichever merges second adapts. If #184 lands first, I'll switch this to itsInstanceFolders.Folders.6e99e1aa030467a56ab0A note from #184 (instances in builds//): OtherLauncher.GamesIn/Read scan the builds folder one level down, so a game in builds/nightly/ isn't seen. Core/InstanceFolders.Folders(buildsFolder, platform) lists the builds folder's own folders and those in its tracks' folders; Leftovers.Find/LostUpdate/Relist use it in #184. Whichever of #184/#189 merges second switches GamesIn/Read to it.
0467a56ab0a65c490cc0Rebased onto main after #184 (and #182), adapted to its layout, and the offer restyled:
builds/<track>/<version>:OtherLauncher.GamesInlooked one level down, so a portable launcher's games inbuilds/rc/<version>were never offered or found by Add a build folder. It now usesInstanceFolders.Folders, as @dyst suggested; a picked track folder gives its versions. A game's channel is its track folder's name (or, in the older layout, its own folder's), only for a version on that channel. Putting the old one-level scan back fails a check.scripts/translations.pyreports no leftovers.1976 checks pass on Windows.
Rebased onto main after #185 and #191. Only the catalogs' ends and docs/saves.md (#185's Open saves folder paragraph, kept above this PR's) conflicted. Each catalog is main's plus this PR's 19 keys, and nothing #184 or #191 removed came back. 1987 checks pass on Windows.
#191 makes the relisting one-time; that doesn't change this PR. The installed launcher's offer still needs an empty list, and Add a build folder is the player's own action. OtherLauncher.ChannelNamed stays its own: InstanceFolders.ChannelNamed needs the builds folder, and a game folder picked alone has none.
a65c490cc0712e7e8b0dRebased onto main after #192, #193 and #194. The only conflict was HomeViewModel.BusyChanged, where #192 dropped the rows' own refresh; this PR's two lines are kept without it. Add a build folder and Use them now also wait while #184's folder move runs (renaming), as the build buttons do. 2000 checks pass on Windows; the home renders as before.
712e7e8b0d75e6c9486b