fix(home): a newer version shows once: Update available, Update beside Play, What's new opposite the title #192
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!192
Loading…
Reference in a new issue
No description provided.
Delete branch "dyst/LongshotLauncher:fix/home-update-once"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The home showed a newer version twice (under the hero and again on the instance's row), with an Update button on the row as well as beside Play, and the Track field repeated the version and the channel the Version field already shows. Now each thing shows once, where it belongs.
What changed
Button.hero), in its own colour. It takes the room left beside Play, so a longer translation is cut rather than pushing the row out of the 300 px column.What Update and What's new do is unchanged.
Translations
"Update available" and the footer's instance counts are new in the 12 full catalogs, with every plural form each language has. They need a native speaker's check. The texts no longer used are removed: "{0} is out on the {1} channel.", "none installed", "{0} installed" and the footer's "versions" forms (also from es-419).
Tests
python -I tests/test_launcher_core.py: 1983 checks passed.HomeUpdateSourceChecks, beside #184'sHomeLayoutSourceChecks, pins each change above: no Update button, "is out" line or What's new on a row; the one badge style in its three places; the Track template showing the name only; Update's icon and Play's size; the track's newest version and What's new opposite the title; and the footer's instances.python -I tests/test_release.py: OK.dotnet build App -c Release: 0 warnings, 0 errors.tools/screenshots, using three new scenes:home-nightly-update,home-versions-updateandhome-row-update.Screenshots
Before (main) and after, at 960×600, in the first comment.
Overlaps
#189 (open) adds a banner and commands to
HomeView.axamlandHomeViewModel.cs, in other places than this. Whichever merges second has a small rebase.The home listed a newer version twice (under the hero and on the row), with an Update button on the row as well as beside Play, and the Track field repeated the version and the channel the Version field already shows. - A row: only an "Update available" badge; no Update button, no "is out" line, no What's new of its own (the hero's act on the row picked). - Update beside Play: its arrow, and Play's height, padding, corners and type (Button.hero). - "Update available" on the Version field's label row (the version never cut) and in place of the note on its row in the Version list. - Opposite the title: the picked track's newest version by its shown name ("Nightly 429 · 6112edb6 is out") and What's new, only when its build has a newer version. The hero's "nightly-…-… is out on the Nightly channel." line goes. - The Track dropdown: the track's name only. - The footer counts instances, as the list's heading says. - Catalogs: the new texts in the 12 full ones, the unused ones removed (es-419 too). New screenshot scenes: home-nightly-update, home-versions-update, home-row-update. Assisted-by: Claude Code Co-Authored-By: Claude Opus 5.5 <[email protected]>Screenshots: before and after
Drawn with
tools/screenshots(headless) at 960×600, the same scenes on both sides: before from main (f2e40a0, with only the three new scenes added to the tool), after from this PR (122cabc). The Play button is grey because the scenes' builds have no game files, not because of this PR.A nightly build with a newer nightly out (
home-nightly-update, the case reported)The Version dropdown open (
home-versions-update)A build on another track with a newer version (
home-row-update)The Track dropdown open (
home-tracks)A stable build with an update (
home-update)With a banner, at 960×600 (
home-banner-hookshot)Possibly related, for context: