test(profiling): the five checks the profiling changes broke pass again, on Windows too #1323
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1323
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/Longshot:test/profiling-checks"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RX 6700 XT · Needs: none
Why
Five checks have failed on
mainsince the profiling changes went in withouttests/run_all.py(#1218, the slow-frame recorder and the frame trace's main-thread columns; #1279,HOS_PROFILE=1). Every PR since lists them among the failures it didn't cause. They aretest_profiling_mode,test_slow_frames,test_cpu_report,test_vcore_escapeandtest_invalidate_vcore. Found while testing #1279 on Windows (#1279 (comment)).What changed
The five checks pass again, on Windows too. Only the tests change: no source does.
test_profiling_mode,test_slow_frames:void hos_prof_start(void)is inhost/posix/prof.ctwice now (a prototype), andvoid hos_vcore_back(void)is inhost/hos_thread.ctwice (the stub when vcores are off), so srccut stopped. The markers now take the definition's brace.test_profiling_mode's made-upcpu.csvhad one line in the window the report reads (from the first present on), soload.jsonhad no cores. It now has a line a second, as the mode writes them.test_slow_frameson Windows: its driver calledsetenv, which the Windows C runtime lacks (_putenv_snow, astest_menu_env_overridesdoes). It also built a 684-byte sample in a 600-byte buffer:strcatwrote past its end, and Windows crashed (0xC0000005).test_cpu_report:scripts/cpu_report.pyimportsscripts/samples.pysince #1279. The check copies the scripts it runs into a folder of its own, and now copies that one too.test_vcore_escape,test_invalidate_vcore:hos_vcore_away/hos_vcore_backreadhos_fps_timing,hos_now_nsand the thread'saway_at/blocked_totalsince #1218. Both harnesses now have them, with the Breakdown off.Measurements
Nothing to measure: tests only.
Flags and settings
None.
Testing
Tested:
6d72ca93and passes here.python -I -B tests/run_all.pyon Windows @787c27c5: 593 passed, 37 failed, 90 skipped. Main @6d72ca93on the same PC: 588 passed, 42 failed. The difference is these five and nothing else. The 37 left fail on main too:test_auto_handheld,test_bug_report,test_bug_report_defaults,test_crash_dialog,test_crash_groups,test_crt_options,test_damage_debug_menu,test_display_startup_failure,test_dlss_feature_size,test_failed_compile_keeps_objects,test_framegen_preset,test_guest_imported,test_hardware_report,test_hud_layout_row,test_job_queue,test_linux_preflight,test_linux_pressure,test_mirror_budget,test_missing_nup,test_pads_after_menu,test_pending_guest_import,test_perf_report,test_pipeline_play_cache,test_portable_builder_home,test_portable_builder_startup,test_present_thread,test_readback_timeout_source,test_rumble_menu,test_run_all_changed,test_switch_table,test_target_image_pool,test_tested_configurations,test_upscaler_round_trip,test_upscaler_rows,test_vk_occlusion_queries,test_vk_swapchain_compat,test_walk_key.Not tested: Linux. These are the same checks, and nothing in the change is Windows-only except the
_WIN32shim forsetenv.Must be tested:
python -I -B tests/<each of the five>.py, expecting each to passRisks
What could break: nothing the game runs: tests only.
Turning it off: revert the commit.
Compatibility: none.
Issues
Follows #1218 and #1279. Prior work: none (searched
hos_prof_start,test_slow_frames,test_cpu_report; other PRs only list them as failing on main).Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Possibly related, for context:
Tested on Windows 11 at this head (
787c27c5, on rc.7's544229a2), with the Builder's Python and llvm-mingw: test_slow_frames, test_profiling_mode, test_invalidate_vcore, test_vcore_escape and test_cpu_report all pass (5 of 5). On rc.7 itself all five fail.RELEASING.md's MSVC check,
test_invalidate_vcore.py --cxx cl(VS 2026, cl 19.51), also passes here; it fails at rc.7.The five profiling checks compile and still check what they checked. I read head
787c27c5. It applies onto current main. This can merge as it is.The cuts now take
hos_prof_startandhos_vcore_backat the definition's brace, so the prototype and the one-line stub no longer stop them. The timedhos_vcore_backis the one that addsblocked_total. The made-upcpu.csvhas a line a second, and the report still has to come out at two cores. The slow-frame driver uses_putenv_son Windows and a buffer large enough for the 684-byte sample.test_cpu_reportcopiessamples.py, whichcpu_report.pyimports. The two vcore harnesses define the timing fields the thread code reads, with the Breakdown off. Must be tested names a Linux run of the same five checks. Nothing in the change is Windows-only except thatsetenvshim, and dukenheimer ran all five on this head on Windows, including the MSVC invalidate check. #1321 adds a different profiling test and does not edit these files.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.