test: the display startup and read-back source checks stub what #1279 and #1251 call #1410

Open
TrashPanda wants to merge 1 commit from TrashPanda/Longshot:test/readback-display-checks into main
Contributor

Type: test · Risk: low · Tested on: Linux, game-free checks (g++ and clang 21) · Needs: none

Why

Two game-free checks have failed on main since last night, because their fixtures lack a stand-in for a function a merged change started calling. Neither the game nor the behaviour they check is broken. Every PR since lists them among the failures it didn't cause.

  • test_display_startup_failure: #1279 (8e9cfc3a, HOS_PROFILE=1) calls hos_profiling_env() in the POSIX main(), after longshot_env.txt. The check compiles that main() with stand-ins for the helpers it calls, and the fixture has none for this one, so it no longer compiles. #1323 fixes five other checks #1279 and #1218 broke, but not this one.
  • test_readback_timeout_source: #1251 (c0106242) destroys the read-back command pool when its command buffer or fence can't be made. It stubbed vkDestroyCommandPool in test_readback_timeout_reuse but not here, though this check cuts the same code.

No open PR fixes either. #1409 fixes two other checks, and #1323 and #1363 fix seven more.

What changed

Each fixture gets the stand-in it lacks. No source and no check's assertions change.

  • tests/display_startup_failure_test.cpp: an empty hos_profiling_env(), the same kind of stand-in it already has for the options file, the game layout and the Discord status. Profiling is outside what this check runs.
  • tests/test_readback_timeout_source.py: an empty vkDestroyCommandPool, the one #1251 gave test_readback_timeout_reuse.

Measurements

Nothing to measure: tests only. Both checks fail on main @ 544229a2 and pass here (cddeaa71).

main @ 544229a2:
display_startup_actual.inc:90:5: error: use of undeclared identifier 'hos_profiling_env'
fixture.cpp:130:13: error: 'vkDestroyCommandPool' was not declared in this scope; did you mean 'vkResetCommandPool'?
this PR @ cddeaa71:
pass         0.8s  tests/test_readback_timeout_source.py
pass         0.2s  tests/test_display_startup_failure.py

Flags and settings

None.

Testing

Tested:

  • Both checks, and their neighbours test_readback_timeout_reuse, test_readback_pending and test_windows_display_startup, on Linux with CXX=g++ and CXX=clang++ (clang 21.1.8): they pass here.
  • The display check against a broken source: changing display_sdl.c's SDL_CreateWindow failure message makes it fail, as it should.
  • python -I -B tests/run_all.py on Linux: 605 passed, 35 failed, 81 skipped. Main @ 544229a2 on the same PC: 602 passed, 38 failed. These two checks and test_crash_record now pass; test_crash_record already passes on main when run alone. Nothing fails here that passes on main. The 35 that fail on main as well are this PC's missing packages and game folders (numpy, lz4, zstandard), plus the checks #1323, #1363 and #1409 fix, test_mirror_budget (a question on #637), test_tested_configurations, test_pipeline_play_cache and test_present_thread.

Not tested: Windows. test_display_startup_failure is the POSIX one, and the read-back fixture is standard C++.

Must be tested: None.

Risks

What could break: nothing in the game; only two test fixtures change.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
**Type:** test · **Risk:** low · **Tested on:** Linux, game-free checks (g++ and clang 21) · **Needs:** none ## Why Two game-free checks have failed on `main` since last night, because their fixtures lack a stand-in for a function a merged change started calling. Neither the game nor the behaviour they check is broken. Every PR since lists them among the failures it didn't cause. - `test_display_startup_failure`: #1279 (8e9cfc3a, `HOS_PROFILE=1`) calls `hos_profiling_env()` in the POSIX `main()`, after `longshot_env.txt`. The check compiles that `main()` with stand-ins for the helpers it calls, and the fixture has none for this one, so it no longer compiles. #1323 fixes five other checks #1279 and #1218 broke, but not this one. - `test_readback_timeout_source`: #1251 (c0106242) destroys the read-back command pool when its command buffer or fence can't be made. It stubbed `vkDestroyCommandPool` in `test_readback_timeout_reuse` but not here, though this check cuts the same code. No open PR fixes either. #1409 fixes two other checks, and #1323 and #1363 fix seven more. ## What changed Each fixture gets the stand-in it lacks. No source and no check's assertions change. - `tests/display_startup_failure_test.cpp`: an empty `hos_profiling_env()`, the same kind of stand-in it already has for the options file, the game layout and the Discord status. Profiling is outside what this check runs. - `tests/test_readback_timeout_source.py`: an empty `vkDestroyCommandPool`, the one #1251 gave `test_readback_timeout_reuse`. ## Measurements Nothing to measure: tests only. Both checks fail on `main` @ 544229a2 and pass here (cddeaa71). ``` main @ 544229a2: display_startup_actual.inc:90:5: error: use of undeclared identifier 'hos_profiling_env' fixture.cpp:130:13: error: 'vkDestroyCommandPool' was not declared in this scope; did you mean 'vkResetCommandPool'? this PR @ cddeaa71: pass 0.8s tests/test_readback_timeout_source.py pass 0.2s tests/test_display_startup_failure.py ``` ### Flags and settings None. ## Testing **Tested:** - Both checks, and their neighbours `test_readback_timeout_reuse`, `test_readback_pending` and `test_windows_display_startup`, on Linux with `CXX=g++` and `CXX=clang++` (clang 21.1.8): they pass here. - The display check against a broken source: changing `display_sdl.c`'s `SDL_CreateWindow` failure message makes it fail, as it should. - `python -I -B tests/run_all.py` on Linux: 605 passed, 35 failed, 81 skipped. Main @ 544229a2 on the same PC: 602 passed, 38 failed. These two checks and `test_crash_record` now pass; `test_crash_record` already passes on main when run alone. Nothing fails here that passes on main. The 35 that fail on main as well are this PC's missing packages and game folders (numpy, lz4, zstandard), plus the checks #1323, #1363 and #1409 fix, `test_mirror_budget` (a question on #637), `test_tested_configurations`, `test_pipeline_play_cache` and `test_present_thread`. **Not tested:** Windows. `test_display_startup_failure` is the POSIX one, and the read-back fixture is standard C++. **Must be tested:** None. ## Risks **What could break:** nothing in the game; only two test fixtures change. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers.
test: the display startup and read-back source checks stub what #1279 and #1251 call
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
cddeaa7180
#1279 (8e9cfc3a) calls hos_profiling_env() in the POSIX main() after
longshot_env.txt, and test_display_startup_failure compiles that main()
with stand-ins for the helpers it calls: the fixture had none for it,
so the check stopped compiling. It gets an empty one, as the options
file, the game layout and the Discord status have.

#1251 (c0106242) destroys the read-back command pool when its command
buffer or fence can't be made, and stubbed vkDestroyCommandPool in
test_readback_timeout_reuse but not in test_readback_timeout_source,
which cuts the same code: it gets the same stub.

Assisted-by: Claude Opus 5.5
TrashPanda changed title from WIP: test: the display startup and read-back source checks stub what #1279 and #1251 call to test: the display startup and read-back source checks stub what #1279 and #1251 call 2026-11-17 13:24:29 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 5s
Website / Website on Cloudflare (pull_request_target) Has been skipped
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'test/readback-display-checks:TrashPanda-test/readback-display-checks'
git switch 'TrashPanda-test/readback-display-checks'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1410
No description provided.