No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1419
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:test/play-cache-save-outcome"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Linux, game-free checks (g++ and clang 21) · Needs: none
Why
test_pipeline_play_cachehas failed onmainsince #416 (177d6b22). It passes on the commit before. Neither the game nor the behaviour it checks is broken: its fixture fell behind three merged changes, and clang's 20-error limit showed only the first.f9a2195c(the pipeline cache written before the title) records what a forced save did in a thread-localpcache_save_outcome, typed inprecompile_save.h. It updatedtests/pipeline_cache_save_test.cppbut not this fixture. #416 then pulled the realpipeline_cache_savein here, and it no longer compiles.pcache_load_off(), the first function of thepcache_initcut. It now readsdev.driver_id,programs_load_at_create()andpcache_load.h. The realpipeline_cache_savealso startshelper_thread_start(96e03835).35465d12) gavepcache_saved_nowa fakepipeline_cache_save. With #416's real one in the same fixture, the two collide.No open PR fixes it. #1416 only lists it among main's failures.
What changed
Only
tests/pipeline_play_cache_test.cppchanges. No source changes, and no case's assertions change.precompile_save.handpcache_save_outcome, the same aspipeline_cache_save_test.cpphas;helper_thread_start, also copied from there; andpcache_load.hwith<unistd.h>. The fake driver is not NVIDIA's own (driver_id0) and programs load before the title (programs_load_at_create()false). Sopcache_load_offreads the file unlessRX_VK_PCACHE_LOADsays not to, which is what theload-*cases expect.pipeline_cache_savegoes.pcache_saved_now's cases now run against the real save #416 extracted, and theirRX_VK_PCACHE_LOAD=0assertions hold against the real code.Measurements
Nothing to measure: tests only. The check fails on
main@544229a2and passes here (fabeed9c).Flags and settings
None.
Testing
Tested:
test_pipeline_cache_saveandtest_precompile_save, on Linux withCXX=g++andCXX=clang++(clang 21.1.8): they pass.vk_draw.cpp, through--source:pcache_load_offalways reads the file;play_files_mergemerges with the file not read;pcache_initnever setspcache_no_save. Each makes it fail (load-off*,no-save, andload-off*withpcache_saved_now's case).python -I -B tests/run_all.pyon Linux: 604 passed, 36 failed, 81 skipped. Main @544229a2on the same PC fails 38. This check now passes, and so doestest_crash_record, which already passes on main when run alone. Nothing fails here that passes on main. The 36 that also fail on main are this PC's missing packages and game folders (numpy, lz4, zstandard, the Vulkan headers), the checks #1323, #1363, #1409, #1410 and #1417 fix,test_mirror_budget(a question on #637) andtest_present_thread.Not tested: Windows. The fixture keeps its
_WIN32paths, and<unistd.h>is included only outside Windows, as invk_draw.cpp.Must be tested: None.
Risks
What could break: nothing in the game; one test fixture changes.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.WIP: test: the play cache check compiles again with #416's, #415's and f9a2195c's saveto test: the play cache check compiles again with #416's, #415's and f9a2195c's saveView command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.