test(vk): the Linux pressure and target pool checks read #637's three-level pool pressure #1409
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1409
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:test/vram-637-checks"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Linux, game-free checks (g++ and clang 21) · Needs: none
Why
Two game-free checks have failed on
mainsince #637 (8e3dfde6, the < 8 GB VRAM changes) went in:test_linux_pressureandtest_target_image_pool. #637 renamed and reshaped what they read on purpose, but the checks still look for the old text. Every PR since lists them among the failures it didn't cause. This PR changes only the two checks; no source changes. #1323 and #1363 fix seven other checks that broke overnight; this one doesn't overlap them.test_mirror_budgetis left red on purpose. It also broke with #637, but there it caught a real change, not a stale check. #637's new rule inmirror_budget()for cards of 6.5 GB or less runs beforemirror_budget.h's small-card rule. A 4 GB card now mirrorsmin(1700 MB, vram / 3), about 1.3 GB, where it got 256 MB before. #637 was tested on a 6 GB card only. That's a decision for #637's author and reviewers, asked on #637, not a test edit.What changed
The two checks read #637's code as it is now. They still guard the same behaviour, and each one fails if the line it guards is undone.
tests/test_linux_pressure.py: the Linux memory hold on an integrated GPU gives back the target pool withpool_pressure = 2;(waspool_pressed = true;). Idle staging arenas are still freed when the PC enters memory pressure. Stale arenas are now freed past twicekArena((stale && kept + it->size > kArena * 2) || linux_entered_pressure).tests/test_target_image_pool.py:texture_framesets the three levels (> 97%gives the pool back,> 90%halves it).pool_trimcaps by them, and trims up to 64 images a present under pressure. The targets' pool takesblock_size, still worked out fromkImageBlock.Measurements
Nothing to measure: tests only. The two checks fail on
main@544229a2and pass here (913e3661).Flags and settings
None.
Testing
Tested:
CXX=g++andCXX=clang++(clang 21.1.8): they fail onmain@544229a2and pass here.pool_pressure = 2to0, droppingpool_trim's 64-a-present bound, or giving the targets' pool a differentblockSizeeach make the matching check fail.python -I -B tests/run_all.pyon Linux: 605 passed, 35 failed, 81 skipped. Main @544229a2on the same PC: 602 passed, 38 failed. These two checks andtest_crash_recordnow pass;test_crash_recordalready passes on main when run alone. Nothing fails here that passes on main. The 35 that fail on main as well are this PC's missing packages and game folders (numpy, lz4, zstandard), the five #1323 fixes, the two #1363 fixes,test_mirror_budget(above),test_readback_timeout_source(#1251),test_display_startup_failure(#1279),test_tested_configurations(#1256's docs/tested file),test_pipeline_play_cacheandtest_present_thread.test_staging_burst, the other check that reads the arenas' code, is skipped here because this PC has no Vulkan headers.Not tested: Windows. These checks are standard library plus the compiler, and nothing here is Linux-only.
Must be tested: None.
Risks
What could break: nothing in the game; only two checks change.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.WIP: test(vk): the Linux pressure and target pool checks read #637's three-level pool pressureto test(vk): the Linux pressure and target pool checks read #637's three-level pool pressureView command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.