No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1410
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:test/readback-display-checks"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Linux, game-free checks (g++ and clang 21) · Needs: none
Why
Two game-free checks have failed on
mainsince last night, because their fixtures lack a stand-in for a function a merged change started calling. Neither the game nor the behaviour they check is broken. Every PR since lists them among the failures it didn't cause.test_display_startup_failure: #1279 (8e9cfc3a,HOS_PROFILE=1) callshos_profiling_env()in the POSIXmain(), afterlongshot_env.txt. The check compiles thatmain()with stand-ins for the helpers it calls, and the fixture has none for this one, so it no longer compiles. #1323 fixes five other checks #1279 and #1218 broke, but not this one.test_readback_timeout_source: #1251 (c0106242) destroys the read-back command pool when its command buffer or fence can't be made. It stubbedvkDestroyCommandPoolintest_readback_timeout_reusebut not here, though this check cuts the same code.No open PR fixes either. #1409 fixes two other checks, and #1323 and #1363 fix seven more.
What changed
Each fixture gets the stand-in it lacks. No source and no check's assertions change.
tests/display_startup_failure_test.cpp: an emptyhos_profiling_env(), the same kind of stand-in it already has for the options file, the game layout and the Discord status. Profiling is outside what this check runs.tests/test_readback_timeout_source.py: an emptyvkDestroyCommandPool, the one #1251 gavetest_readback_timeout_reuse.Measurements
Nothing to measure: tests only. Both checks fail on
main@544229a2and pass here (cddeaa71).Flags and settings
None.
Testing
Tested:
test_readback_timeout_reuse,test_readback_pendingandtest_windows_display_startup, on Linux withCXX=g++andCXX=clang++(clang 21.1.8): they pass here.display_sdl.c'sSDL_CreateWindowfailure message makes it fail, as it should.python -I -B tests/run_all.pyon Linux: 605 passed, 35 failed, 81 skipped. Main @544229a2on the same PC: 602 passed, 38 failed. These two checks andtest_crash_recordnow pass;test_crash_recordalready passes on main when run alone. Nothing fails here that passes on main. The 35 that fail on main as well are this PC's missing packages and game folders (numpy, lz4, zstandard), plus the checks #1323, #1363 and #1409 fix,test_mirror_budget(a question on #637),test_tested_configurations,test_pipeline_play_cacheandtest_present_thread.Not tested: Windows.
test_display_startup_failureis the POSIX one, and the read-back fixture is standard C++.Must be tested: None.
Risks
What could break: nothing in the game; only two test fixtures change.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.WIP: test: the display startup and read-back source checks stub what #1279 and #1251 callto test: the display startup and read-back source checks stub what #1279 and #1251 callView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.