No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1363
Loading…
Reference in a new issue
No description provided.
Delete branch "dukenheimer/Longshot:test/rc7-check-skew"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: test · Risk: low · Tested on: Windows 11, RTX 5090 (clang 23.1.5, llvm-mingw); Linux (WSL Ubuntu 24.04, g++ 13.3) · Needs: none
Why
The rc.7 release check found three game-free checks failing on main. The game is fine: in each case a merged change
moved the source, and the check still reads it the old way. Contributors see these failures on every run and have to
check by hand that they aren't theirs. These three are separate from the five that #1323 fixes.
test_vk_swapchain_compat(#1300):start()ingpu/vk/vk_main.cppgained a small#ifdef _WIN32 / #else / #endifat its top. The check took the first#elseas "Linux startup", so it saidopen_window_surface(true)was gone, though Linux startup is unchanged. Fails on Windows and Linux.test_switch_table(#1300):RX_VK_PGO_FILE's row is read throughhost/pgo_rt.c'sgetenv(PGO_ENV).nx2/build.pypasses-DPGO_ENV="RX_VK_PGO_FILE"for the renderer's copy, so no C file holds the literal, and the check reported nothing reads the row. Fails on Windows and Linux; #727's description notes it too.test_recorder_sync(#1291):vk_recorder.hnow includesvk_new.h. #1291 added it to the sync fixture's folder but not to the exit fixture's (Windows only), so the exit DLL doesn't build. Fails on Windows.The diagnosis is the PC release-check runner's, from rc.7.
Prior work: none found for these three. Searched
test_switch_table,test_vk_swapchain_compat,test_recorder_sync,vk_new.h,PGO_ENVand the team chat. #1323 (madebyjordan) fixes five other checks. #1309 (HumanBean, WIP) widenstest_switch_tableto theHOS_andLONGSHOT_names but doesn't handle thePGO_ENVread. This PR's change is a separate function and a separate call, so the two don't conflict; whichever lands second keeps both. #727 and #1321 list these checks among main's failures.What changed
Each check now reads the source as it is, and still fails when what it guards is broken.
tests/test_vk_swapchain_compat.py:linux_part()keeps the non-Windows branch of each#ifdef _WIN32instart()(and the#ifndef _WIN32branches, with nested blocks kept whole). It requires the same four items there as before.tests/test_switch_table.py:defined_reads()treats each-DNAME="RX_..."innx2/*.pyas a read of that name, if a source undergpu/orhost/callsgetenv(NAME). Either one alone counts as no read. The docstring says so.tests/test_recorder_sync.py:fixture_dir()writes the headers for both fixtures (the sync test and the Windows exit test), so a header added for one reaches the other.Measurements
Verdict: pass. All three fail on main and pass here. Each still fails when the source it guards is broken.
Hardware: Windows 11, RTX 5090, clang 23.1.5 (llvm-mingw, the Builder's), Python 3.14; WSL Ubuntu 24.04, g++ 13.3, Python 3.12
Scene: none: game-free checks
Method: each check run alone on main and on this PR, on Windows and Linux; then each run against a source changed to break what it guards, then put back
How to reproduce:
python -I -B tests/run_all.py --exact tests/test_switch_table.py tests/test_vk_swapchain_compat.py tests/test_recorder_sync.pyon main and on this branch544229a24047cd3ftest_vk_swapchain_compat, Windows / Linuxtest_switch_table, Windows / Linuxtest_recorder_sync, Windows / Linuxvk_new.hnot found) / pass (exit part Windows only)Flags and settings
None
Testing
Tested:
python -I -B tests/run_all.py(Windows 11, clang 23.1.5, 12 jobs,MAGICBEAN_TOOLINGset): this PR 626 passed, 43 failed, 52 skipped; main @544229a2in a clean checkout, the same run, 623 passed, 46 failed. The three failing on main and not here are this PR's. None fails here and not on main. The 43 that fail on both, on this PC, several fixed by #1323 (madebyjordan) and #1299:test_auto_handheld,test_bug_report_defaults,test_cpu_report,test_crash_dialog,test_crt_options,test_damage_debug_menu,test_discover,test_display_startup_failure,test_dlss_feature_size,test_failed_compile_keeps_objects,test_framegen_preset,test_fsr_uniform_ownership,test_guest_imported,test_hud_layout_row,test_import_reach,test_invalidate_vcore,test_job_queue,test_lift_lookups,test_linux_preflight,test_linux_pressure,test_mirror_budget,test_missing_nup,test_pads_after_menu,test_parallel_init_order,test_pending_guest_import,test_perf_report,test_pipeline_play_cache,test_present_thread,test_profiling_mode,test_readback_timeout_source,test_replay_write_order,test_rumble_menu,test_run_all_changed,test_slow_frames,test_staging_burst,test_target_image_pool,test_tested_configurations,test_upscaler_round_trip,test_upscaler_rows,test_vcore_escape,test_vk_occlusion_queries,test_walk_key,test_walk.Not tested:
test_recorder_sync's exit part on Linux: it runs only on Windows (exit_testreturns None elsewhere), so the check can't fail on Linux for this reason. Its Linux run is in the table.Must be tested:
Risks
What could break: Only these three checks. A source that breaks what they guard still fails them (shown above).
Turning it off: revert the commit
Compatibility: Nothing changes: tests only.
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.The three game-free checks read the source as it is now, and they still fail when the thing they guard is gone. I read head
4047cd3f. It applies onto current main. This can merge as it is.test_vk_swapchain_compatkeeps the non-Windows branch of each_WIN32test instart(), so the Linuxopen_window_surface(true)and the zero-size message stay required, and the Windows copy of that call does not satisfy them.test_switch_tablecountsRX_VK_PGO_FILEas read only whennx2/build.pypasses-DPGO_ENV="RX_VK_PGO_FILE"and a source undergpu/orhost/callsgetenv(PGO_ENV).test_recorder_syncwritesvk_new.hfor the Windows exit fixture as well as the sync fixture. Must be tested names nothing. #1309 also edits the switch-table check; the two combine, and that one is still WIP.View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.