feat(vk): FPS counter overhaul 2: size row, details page, steadier graph, Dev hardware footer #998
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!998
Loading…
Reference in a new issue
No description provided.
Delete branch "ballotstomper/Longshot:feat/fps-counter-overhaul-2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: Linux, RX 6750 XT · Needs: Windows, any GPU
Why
The FPS counter got its Breakdown graph in #928. This is the second round, from using it while recording and profiling:
See #928.
What changed
The counter gets a size row and a details page for the Dev level. The graph's cap line, peak marks and scale are steadier. The Breakdown puts two waits where they belong. Dev gains three rows and a footer with the version and hardware.
fps_scale()ingpu/vk/vk_menu.cppuses fixed scales, capped at what Auto gives at the Large menu size.draw_fps):FpsWait main_wait(kWaitMain)inpresent()(gpu/vk/vk_replay.cpp).fps_stats::split()ingpu/vk/fps_stats.htakes it as a new argument.enqueuefor a present now counts as Render thread (kWaitRender).fps_texts,DevLineinfps_stats.h).TAB_FPS_DEV, built like the Motion page). It has:gpu/vk/menu_i18n.h, all 13 languages. The README's options table and FPS counter section are updated.Measurements
Verdict: Not measured. This is a display change, and nothing changes at the Off level. At Dev it adds three counters read once a frame and a few more text lines.
Flags and settings
Two new menu rows and their ini keys. No switches.
fps_counter_size)version_and_hardware_at_every_level,vram_line…write-backs_line,cpu_and_gpu_lines)Testing
Tested:
python -I -B tests/run_all.py(567 passed, 11 failed). All 11 failures also fail onmainon this PC: test_crt_options, test_guest_imported, test_linux_preflight, test_linux_update, test_make_game_cache, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_run_all_changed, test_vk_occlusion_queries and test_walk_key. test_fps_stats has a new check for the main thread's wait.Not tested:
Must be tested:
Risks
What could break:
Turning it off: revert the commit. The counter's Off level is unchanged.
Compatibility:
longshot_options.inigains the new keys. Older files load with the defaults. Nothing else changes.Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
tests/that reads changed source updated in this PR, not weakened.Tested in game: RX 6750 XT, Mesa 26.2.7, Arch Linux: every FPS counter level and size, the details page's toggles, the version and hardware footer (Dev only, and at every level with its toggle), wide Dev values on their own row, Threaded rendering on and off; everything drew as expected.
After: this PR @
d532406b, FPS counter at Dev with the footer and the Dev lines two to a row.Possibly related, for context:
Rebased onto main @
9f8958a5(#773): only menu_i18n.h's per-language counts conflicted, recounted from the arrays.run_all.py --changed: 140 passed, 4 failed, all 4 also failing on main on this PC (test_crt_options, test_walk_key, test_vk_occlusion_queries, and test_bug_report_defaults, which fails on main since #773 withauto-profile: Auto-controlled shadow_res missing).d532406bb548a5c30251New commits pushed, approval review dismissed automatically according to repository settings
WIP: feat(vk): FPS counter overhaul 2: size row, details page, steadier graph, Dev hardware footerto feat(vk): FPS counter overhaul 2: size row, details page, steadier graph, Dev hardware footer@ballotstomper Great update, thanks! One thing the graph on the right still feels jittery. Any chance it could be smoothed out?