WIP: test(forge): the pr create check expects the edit that allows maintainer edits #926

Closed

zeldaootr wants to merge 1 commit from zeldaootr/Longshot:forge-pr-check-maintainer-edit into main

pull from: zeldaootr/Longshot:forge-pr-check-maintainer-edit

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 1 Commits 1 Files changed 1 +5 -1

zeldaootr commented 2026-11-15 20:54:43 +00:00

Contributor

• Copy link
• Copy Markdown

Type: test · Risk: low · Tested on: Linux, game-free checks · Needs: none

Why

test_forge_pr fails on main since pr create turns on "Allow edits from maintainers"
(#905): every create now edits the PR once more, and one case
still counted the old writes. A red check on main hides new failures in every PR that touches the forge script.

How to reproduce

Seen on: Linux, any PC (no game, no GPU)
Settings and switches: defaults
Steps: python -I -B tests/test_forge_pr.py on main c45be62f
Expected: all cases pass
Actual: test_create_draft_is_the_default_and_wip_is_not_doubled fails: ['POST', 'PATCH', 'POST', 'PATCH'] != ['POST', 'POST', 'PATCH']

What changed

The case now expects what pr create does: an edit after each create, both turning on allow_maintainer_edit, and
the description in the edit only where the template was filled in.

• tests: test_create_draft_is_the_default_and_wip_is_not_doubled in tests/test_forge_pr.py checks each write's
  method and fields, and that every edit allows maintainer edits.

Measurements

Verdict: nothing to measure: a game-free check, the game doesn't run it.

Flags and settings

None

Testing

Tested: Linux: tests/test_forge_pr.py fails on main c45be62f (the case above) and passes here, 32 of 32;
test_forge_session_lock passes. With #831 merged on top, all
37 of test_forge_pr pass.

Not tested: the rest of tests/run_all.py (this changes one case of one check, nothing else reads it).

Must be tested:

• None

Risks

What could break: Nothing: a test's expectation.

Turning it off: revert the commit

Compatibility: Nothing changes

Checklist

Everyone

• One topic.
• The title is a Conventional Commit (type(scope): description) of the status line's type.
• Why gives the reason plainly and links the issues that fit (the tracker searched).
• Measurements has a verdict, or one line saying why there is nothing to measure.
• Testing names what was tested, what wasn't, and what must still be tested, where and how.
• Rebased on current main. On main c45be62f.
• python -I -B tests/run_all.py passes (any failure that also fails on main is named). Not run in full yet: only the forge checks.
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• A check under tests/ that reads changed source updated in this PR, not weakened.

**Type:** test · **Risk:** low · **Tested on:** Linux, game-free checks · **Needs:** none ## Why `test_forge_pr` fails on `main` since `pr create` turns on "Allow edits from maintainers" (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/905): every create now edits the PR once more, and one case still counted the old writes. A red check on `main` hides new failures in every PR that touches the forge script. ## How to reproduce **Seen on:** Linux, any PC (no game, no GPU) **Settings and switches:** defaults **Steps:** `python -I -B tests/test_forge_pr.py` on `main` c45be62f **Expected:** all cases pass **Actual:** `test_create_draft_is_the_default_and_wip_is_not_doubled` fails: `['POST', 'PATCH', 'POST', 'PATCH'] != ['POST', 'POST', 'PATCH']` ## What changed The case now expects what `pr create` does: an edit after each create, both turning on `allow_maintainer_edit`, and the description in the edit only where the template was filled in. - tests: `test_create_draft_is_the_default_and_wip_is_not_doubled` in `tests/test_forge_pr.py` checks each write's method and fields, and that every edit allows maintainer edits. ## Measurements **Verdict:** nothing to measure: a game-free check, the game doesn't run it. ### Flags and settings None ## Testing **Tested:** Linux: `tests/test_forge_pr.py` fails on `main` c45be62f (the case above) and passes here, 32 of 32; `test_forge_session_lock` passes. With https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/831 merged on top, all 37 of `test_forge_pr` pass. **Not tested:** the rest of `tests/run_all.py` (this changes one case of one check, nothing else reads it). **Must be tested:** - None ## Risks **What could break:** Nothing: a test's expectation. **Turning it off:** revert the commit **Compatibility:** Nothing changes ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. On `main` c45be62f. - [ ] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). Not run in full yet: only the forge checks. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened.

zeldaootr added 1 commit 2026-11-15 20:54:43 +00:00

test(forge): the pr create check expects the edit that allows maintainer edits ... 8004191095

Since `pr create` turns on `allow_maintainer_edit` (#905) it edits every PR it opens once, so the check that counted
the writes of two creates (POST, POST, PATCH) failed on `main`. It now expects an edit after each create, both
allowing maintainer edits, and the body only in the one whose template was filled.

Assisted-by: Claude

BeanIssues added the

area/tooling

kind

chore

risk

low

labels 2026-11-15 20:54:56 +00:00

zeldaootr commented 2026-11-15 20:57:03 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Closing: tests/test_forge_pr.py moved to MagicBeanDev/Tooling with #915, and Tooling's copy already expects the edit that allows maintainer edits (MagicBeanDev/Tooling#2). Nothing left to fix here.

Closing: `tests/test_forge_pr.py` moved to MagicBeanDev/Tooling with https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/915, and Tooling's copy already expects the edit that allows maintainer edits (https://git.magicbean.dev/MagicBeanDev/Tooling/pulls/2). Nothing left to fix here.

zeldaootr closed this pull request 2026-11-15 20:57:03 +00:00

Some checks failed

Hide checks

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

PR description / Description follows the template (pull_request_target) Successful in 3s

Details

Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled

Details

CI / Conventional Commit title (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled

Details

CI / Workflow lint (actionlint) (pull_request) Has been cancelled

Details

Third-party parts / As their notes say (pull_request) Has been cancelled

Details

Third-party parts / The same as upstream (pull_request) Has been cancelled

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/tooling

Developer tools: scripts, CI, build and release tooling

  

area/upscaling

DLSS, FSR, frame generation

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

risk

high

Broad or core change: the renderer, defaults on many systems, saves, installs, security

  

risk

low

Small, contained change: little can break

  

risk

medium

Changes behaviour in one area, or a default on some systems

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/tooling

area/upscaling

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

risk

high

risk

low

risk

medium

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!926

No description provided.