WIP: chore(agents): the shared sign-in, forge.py, team chat and shared skills move to MagicBeanDev/Tooling, and a game change opens only once it has run in the game #915
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved @ 1697603
beanstalk: approved @ 2c5a62e
beanstalk: approved @ 4fd82b7
beanstalk: approved @ 64d6d09
beanstalk: approved @ 6f91fae
beanstalk: approved @ 70a78f9
beanstalk: approved @ 8015c9a
beanstalk: approved @ 8d361dc
beanstalk: approved @ 9d8356e
beanstalk: approved @ abf2227
beanstalk: approved @ d82f202
beanstalk: approved @ e5f1e40
beanstalk: approved @ ee8ab5f
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
testing wanted
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!915
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:chore/tooling-repo"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: chore · Risk: medium · Tested on: Linux (the forwarder and Tooling's forge.py, opening this PR) · Needs: any OS: the game-free checks, by hand
Why
The sign-in,
forge.py, the team chat and the team-updates and release skills are used by every MagicBeanDev repository, but they live here, so the launcher, Beanstalk and Site send people to "run it in a Longshot checkout", and the release skill is copied in two repositories and drifting. They move to MagicBeanDev/Tooling (Tooling#1, merge it first; the launcher, Beanstalk and Site point there in LongshotLauncher#114, Beanstalk#14 and Site#20), which agents clone beside their checkout and pull each session. What is Longshot's own stays here. Also: a change the game runs now has to have run in the game before its PR opens.What changed
Longshot points at Tooling for the shared parts and keeps its own: test requests (
scripts/test_requests.py, therequest-testingandtestingskills, docs/test-requests.md), prior-work, fix-with-test, measure, and its PR rules.scripts/forge.pyis now a forwarder to Tooling's, so every git credential helper set up before the move keeps working.forge.py,magicbean_login.py,team_chat.pyremoved (now Tooling's);forge.pyforwards to../Tooling/scripts/forge.py(scripts/tooling.pyfinds it:MAGICBEAN_TOOLING, elseToolingbeside the checkout, and says how to clone it when missing).test_requests.pyandhardware_report.pyimport the sign-in and the API client from there.scripts/check_pr_description.py:TITLE, the Conventional Commit regex (was forge.py's), andGAME_PATHS(gpu/,host/,nx2/,assets/,third_party/): Tooling'spr createrefuses a branch that changes one until--tested-in-game "where it ran and what you saw", unless--force..forgejo/workflows/ci.yml: the title job loadscheck_pr_description.pyinstead offorge.py.test_forge_pr.py,test_forge_session_lock.py,test_team_chat.pymoved to Tooling;test_test_requests.pyskips, saying so, without Tooling beside the checkout;test_check_pr_description.pycoversTITLE,GAME_PATHSand the title job.team-updatesandreleaseremoved (Tooling's plugin:/magicbean:team-updates,/magicbean:release);request-testing,testing,measure,prior-workrun forge.py and team_chat.py from../Tooling.Measurements
Verdict: nothing to measure: scripts, checks and docs only; the game is untouched.
Flags and settings
None (
MAGICBEAN_TOOLINGis an environment variable for where Tooling is, not a game switch).Testing
Tested: this PR was opened through the forwarder (
python -I scripts/forge.py pr createhere ran Tooling's forge.py, which foundMagicBeanDev/Longshotfrom the remotes, loaded this branch'scheck_pr_description.pyand let a docs/scripts branch open without--tested-in-game). Linux.Not tested: no test was run on this PC (the person I work for asked for none here):
tests/run_all.pyhasn't run on this branch.Must be tested:
python -I -B tests/run_all.pyhere andpython -I -B tests/run_all.pyin Tooling, expecting both to pass (by hand: no game needed).Risks
What could break: anyone without Tooling beside their checkout gets "MagicBeanDev/Tooling is not beside this checkout ... git clone ..." from
scripts/forge.pyandtest_requests.pyuntil they clone it (git's credential helper too, so pushes ask for a password until then). CircleCI doesn't clone Tooling, sotest_test_requests.pyskips there. Open PRs that changeforge.py,team_chat.pyormagicbean_login.pyhere (#905, /891, /831, /640, /310, /298) need to move to Tooling.Turning it off: revert the commit.
Compatibility: Nothing changes for players. The sign-in in
~/.config/longshot/is unchanged and keeps working.Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). (not run here; Must be tested)third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.