chore(forge): search pull requests and issues, pr close and reopen, pr view --body and --json #831

Open

zeldaootr wants to merge 7 commits from zeldaootr/Longshot:forge-search-close-body into main

pull from: zeldaootr/Longshot:forge-search-close-body

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 2 Commits 7 Files changed 5 +489 -8

zeldaootr commented 2026-11-15 16:32:08 +00:00

Contributor

• Copy link
• Copy Markdown

Type: chore · Risk: low · Tested on: Linux, game-free checks and read-only calls to git.magicbean.dev · Needs: none

Why

An agent spent hours building a change that another contributor already had open as a WIP pull request under the same
switch name: pr list prints only titles, over 350 of them, and nothing searches the descriptions. A PR superseded by
a merged change could only be commented on, not closed, and editing a description meant calling the API by hand to get
its raw text. This adds the three commands that were missing.

What changed

forge.py search finds the pull requests and issues that already name a switch, a function or some words; pr close
closes a PR with a comment saying why; pr view --body prints the description alone, so it can be edited and put back.

• forge: search WORD|"A PHRASE" ... [--state open|closed|all] [--mine] [--limit N] in scripts/forge.py
  (cmd_search, listing, matching_line): every word or quoted phrase must be in the title or the description, in
  any case. Each hit prints its number, PR or issue, its state (open, wip, merged, closed), author, title and
  the description's line with the match, shortened around it. Nothing found says so, with exit code 0. It reads the
  issue listing (both kinds, 50 a page, 4 pages at once) and matches locally, not through Forgejo's q= search: on
  this forge (17.0.1) the indexer found 70 of the 90 items with "mesh" and "shaders" in them and was no faster. --mine
  passes created_by.
• forge: pr close N (--comment TEXT | --comment-file F) [--force] (cmd_pr_close) posts the comment, then closes.
  The comment is required, and someone else's PR is refused without --force. pr reopen N [--comment ...]
  (cmd_pr_reopen) opens a closed PR again and refuses a merged one.
• forge: pr view N --body (print_raw) prints the description exactly as stored and nothing else: into a file or a
  pipe its UTF-8 bytes, so CRLF stays CRLF on Windows too. --json (pr_json) prints number, title, state, WIP, head
  and base refs and commits, merge base, author, labels, description and times. Both exclude --comments. The plain
  pr view output is unchanged.
• docs: docs/forge.md (a Search before building section, close and reopen, --body for editing a description),
  AGENTS.md (search before building, in the Choosing or claiming work bullet, linking docs/forge.md).
• tests: tests/test_forge_search.py (new) and tests/test_forge_pr.py, against a stand-in Forgejo in memory.

Measurements

Nothing to measure: a script for the forge with its own game-free tests; the game doesn't run it.

Flags and settings

None

Testing

Tested: Linux. python -I -B tests/run_all.py: 495 passed, 85 skipped, 14 failed. The same 14 fail on main
(aa95d35f) on this PC, and none of them reads the forge script: test_appimage_player_build, test_lift_cache,
test_crash_dialog, test_mods_size_table, test_make_game_cache, test_pipeline_tour, test_env_on,
test_lift_cleanup_error, test_cpm_discovery, test_walk_key, test_bake_portability, test_vk_pgo,
test_readback_late, test_options_budget_once. The forge checks (test_forge_pr, test_forge_search,
test_forge_session_lock, test_check_pr_description) pass. The new tests cover search matching (a switch name in a
Flags table, any case, a phrase across a line break, every word required), the output's shape, the states, --state,
--mine, --limit and paging, and nothing found. They also cover pr close's comment and PATCH bodies in that
order, its refusals (no comment, an empty one, someone else's PR, a closed or merged one), pr reopen, pr view --body
printing exactly the body (CRLF, no last newline, an emoji, into a cp1252 pipe), and --json's fields. Close and
reopen also ran over HTTP against a local stub server, which received the comment POST, then
PATCH {"state": "closed"} (and {"state": "open"} for reopen), with the sign-in's bearer token. Read-only against
git.magicbean.dev: search RX_VK_ASTC_BC1 (2 found, both WIP PRs naming it, in about 12 s), search "mesh shaders"
(38 found in about 8 s), pr view 687 --body | head and pr view 687 --json.

Not tested: pr close and pr reopen against git.magicbean.dev itself (only read-only calls were made there);
Windows (the code is the standard library only, and --body's byte output is covered by the cp1252 pipe test).

Must be tested:

• None

Risks

What could break: Nothing existing: pr list, pr view without the new flags and the other commands print as
before. A search lists every open item (about 570 now), which takes 8 to 15 s.

Turning it off: revert the commit

Compatibility: Nothing changes

Checklist

Everyone

• One topic.
• The title is a Conventional Commit (type(scope): description) of the status line's type.
• Why gives the reason plainly and links the issues that fit (the tracker searched).
• Measurements has a verdict, or one line saying why there is nothing to measure.
• Testing names what was tested, what wasn't, and what must still be tested, where and how.
• Rebased on current main. Onto main 94abdd57 (head da418ffa) with one conflict, in AGENTS.md: main's 08f3d3d3 (docs(agents)) replaced its Pick and claim work section and the PR command block with a guide per task, so the search line now sits in the Choosing or claiming work bullet and links docs/forge.md#search-before-building, and the pr view --body and pr close lines, which docs/forge.md in this PR already has, are no longer added to AGENTS.md (that commit is now docs(agents): search before building), with the commit subjects made Conventional Commits, which CI's lint job now checks for every commit, on a base that has CI's config (#417); each commit's change is the same as before by git patch-id. The commits named in this description are from before this rebase: 23e4ff77 is now 82d96724, c1452d58 is now 69c47ab4, 1a8e39e6 is now b76e55a7, 0be29674 is now af1dd980, 584b15c2 is now de07ec7d, b48507b4 is now 35f9e11e, 306dd602 is now da418ffa. Re-run on 94abdd57: the forge checks (test_forge_pr, test_forge_search, test_forge_session_lock, test_check_pr_description) and every check that reads the changed files pass, 5 of 5 with g++ and the 2 new ones with clang too.
• python -I -B tests/run_all.py passes (any failure that also fails on main is named).
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• A check under tests/ that reads changed source updated in this PR, not weakened.
• Docs updated.

**Type:** chore · **Risk:** low · **Tested on:** Linux, game-free checks and read-only calls to git.magicbean.dev · **Needs:** none ## Why An agent spent hours building a change that another contributor already had open as a WIP pull request under the same switch name: `pr list` prints only titles, over 350 of them, and nothing searches the descriptions. A PR superseded by a merged change could only be commented on, not closed, and editing a description meant calling the API by hand to get its raw text. This adds the three commands that were missing. ## What changed `forge.py search` finds the pull requests and issues that already name a switch, a function or some words; `pr close` closes a PR with a comment saying why; `pr view --body` prints the description alone, so it can be edited and put back. - forge: `search WORD|"A PHRASE" ... [--state open|closed|all] [--mine] [--limit N]` in `scripts/forge.py` (`cmd_search`, `listing`, `matching_line`): every word or quoted phrase must be in the title or the description, in any case. Each hit prints its number, PR or issue, its state (`open`, `wip`, `merged`, `closed`), author, title and the description's line with the match, shortened around it. Nothing found says so, with exit code 0. It reads the issue listing (both kinds, 50 a page, 4 pages at once) and matches locally, not through Forgejo's `q=` search: on this forge (17.0.1) the indexer found 70 of the 90 items with "mesh" and "shaders" in them and was no faster. `--mine` passes `created_by`. - forge: `pr close N (--comment TEXT | --comment-file F) [--force]` (`cmd_pr_close`) posts the comment, then closes. The comment is required, and someone else's PR is refused without `--force`. `pr reopen N [--comment ...]` (`cmd_pr_reopen`) opens a closed PR again and refuses a merged one. - forge: `pr view N --body` (`print_raw`) prints the description exactly as stored and nothing else: into a file or a pipe its UTF-8 bytes, so CRLF stays CRLF on Windows too. `--json` (`pr_json`) prints number, title, state, WIP, head and base refs and commits, merge base, author, labels, description and times. Both exclude `--comments`. The plain `pr view` output is unchanged. - docs: `docs/forge.md` (a *Search before building* section, close and reopen, `--body` for editing a description), `AGENTS.md` (search before building, in the *Choosing or claiming work* bullet, linking `docs/forge.md`). - tests: `tests/test_forge_search.py` (new) and `tests/test_forge_pr.py`, against a stand-in Forgejo in memory. ## Measurements Nothing to measure: a script for the forge with its own game-free tests; the game doesn't run it. ### Flags and settings None ## Testing **Tested:** Linux. `python -I -B tests/run_all.py`: 495 passed, 85 skipped, 14 failed. The same 14 fail on `main` (`aa95d35f`) on this PC, and none of them reads the forge script: `test_appimage_player_build`, `test_lift_cache`, `test_crash_dialog`, `test_mods_size_table`, `test_make_game_cache`, `test_pipeline_tour`, `test_env_on`, `test_lift_cleanup_error`, `test_cpm_discovery`, `test_walk_key`, `test_bake_portability`, `test_vk_pgo`, `test_readback_late`, `test_options_budget_once`. The forge checks (`test_forge_pr`, `test_forge_search`, `test_forge_session_lock`, `test_check_pr_description`) pass. The new tests cover search matching (a switch name in a Flags table, any case, a phrase across a line break, every word required), the output's shape, the states, `--state`, `--mine`, `--limit` and paging, and nothing found. They also cover `pr close`'s comment and `PATCH` bodies in that order, its refusals (no comment, an empty one, someone else's PR, a closed or merged one), `pr reopen`, `pr view --body` printing exactly the body (CRLF, no last newline, an emoji, into a cp1252 pipe), and `--json`'s fields. Close and reopen also ran over HTTP against a local stub server, which received the comment `POST`, then `PATCH {"state": "closed"}` (and `{"state": "open"}` for reopen), with the sign-in's bearer token. Read-only against git.magicbean.dev: `search RX_VK_ASTC_BC1` (2 found, both WIP PRs naming it, in about 12 s), `search "mesh shaders"` (38 found in about 8 s), `pr view 687 --body | head` and `pr view 687 --json`. **Not tested:** `pr close` and `pr reopen` against git.magicbean.dev itself (only read-only calls were made there); Windows (the code is the standard library only, and `--body`'s byte output is covered by the cp1252 pipe test). **Must be tested:** - None ## Risks **What could break:** Nothing existing: `pr list`, `pr view` without the new flags and the other commands print as before. A search lists every open item (about 570 now), which takes 8 to 15 s. **Turning it off:** revert the commit **Compatibility:** Nothing changes ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. Onto main 94abdd57 (head da418ffa) with one conflict, in `AGENTS.md`: main's 08f3d3d3 (`docs(agents)`) replaced its *Pick and claim work* section and the PR command block with a guide per task, so the search line now sits in the *Choosing or claiming work* bullet and links `docs/forge.md#search-before-building`, and the `pr view --body` and `pr close` lines, which `docs/forge.md` in this PR already has, are no longer added to `AGENTS.md` (that commit is now `docs(agents): search before building`), with the commit subjects made Conventional Commits, which CI's lint job now checks for every commit, on a base that has CI's config (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/417); each commit's change is the same as before by `git patch-id`. The commits named in this description are from before this rebase: 23e4ff77 is now 82d96724, c1452d58 is now 69c47ab4, 1a8e39e6 is now b76e55a7, 0be29674 is now af1dd980, 584b15c2 is now de07ec7d, b48507b4 is now 35f9e11e, 306dd602 is now da418ffa. Re-run on 94abdd57: the forge checks (`test_forge_pr`, `test_forge_search`, `test_forge_session_lock`, `test_check_pr_description`) and every check that reads the changed files pass, 5 of 5 with g++ and the 2 new ones with clang too. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated.

zeldaootr added 7 commits 2026-11-15 16:32:09 +00:00

test(forge): pr view --body prints the raw description, --json the fields ... 23e4ff771a

Assisted-by: Claude

feat(forge): pr view --body and --json ... c1452d5804

Assisted-by: Claude

test(forge): pr close says why and is yours to close, pr reopen ... 1a8e39e608

Assisted-by: Claude

feat(forge): pr close with the reason required, and pr reopen ... 0be2967492

Assisted-by: Claude

test(forge): search over pull requests and issues ... 584b15c249

Assisted-by: Claude

feat(forge): search pull requests and issues by title and description ... b48507b4ca

Assisted-by: Claude

docs(agents): search before building, pr view --body, pr close ... 306dd6027e

Assisted-by: Claude

HumanBean commented 2026-11-15 18:47:53 +00:00

Owner

• Copy link
• Copy Markdown

This conflicts with main in AGENTS.md: it was cut down to a pointer page and its pull request guidance moved to docs/agent-pull-requests.md (the docs(agents) commit, then #571), so the two new lines (search before building, pr view --body and pr close) need a new home there. The code and test commits rebase without conflicts. Please rebase onto current main.

This conflicts with `main` in `AGENTS.md`: it was cut down to a pointer page and its pull request guidance moved to `docs/agent-pull-requests.md` (the `docs(agents)` commit, then https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/571), so the two new lines (search before building, `pr view --body` and `pr close`) need a new home there. The code and test commits rebase without conflicts. Please rebase onto current `main`.

zeldaootr force-pushed forge-search-close-body from 306dd6027e to da418ffa7a 2026-11-15 19:16:32 +00:00 Compare

zeldaootr commented 2026-11-15 19:16:34 +00:00

Author

Contributor

• Copy link
• Copy Markdown

Rebased onto main 94abdd57 (head da418ffa), with one conflict, in AGENTS.md: main's 08f3d3d3 (docs(agents)) replaced its Pick and claim work section and the PR command block with a guide per task, so the search line now sits in the Choosing or claiming work bullet and links docs/forge.md#search-before-building, and the pr view --body and pr close lines, which docs/forge.md in this PR already has, are no longer added to AGENTS.md (that commit is now docs(agents): search before building); the commit subjects are now Conventional Commits, which CircleCI's lint job checks for every commit of a pull request (#417), and the base has the CI's config, which a fork's pull request needs at its own head. No other change: each commit's change is the same as before by git patch-id.
Re-run on 94abdd57: the forge checks (test_forge_pr, test_forge_search, test_forge_session_lock, test_check_pr_description) and every check that reads the changed files pass, 5 of 5 with g++ and the 2 new ones with clang too. The description names the new commits.

Rebased onto `main` 94abdd57 (head da418ffa), with one conflict, in `AGENTS.md`: main's 08f3d3d3 (`docs(agents)`) replaced its *Pick and claim work* section and the PR command block with a guide per task, so the search line now sits in the *Choosing or claiming work* bullet and links `docs/forge.md#search-before-building`, and the `pr view --body` and `pr close` lines, which `docs/forge.md` in this PR already has, are no longer added to `AGENTS.md` (that commit is now `docs(agents): search before building`); the commit subjects are now Conventional Commits, which CircleCI's lint job checks for every commit of a pull request (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/417), and the base has the CI's config, which a fork's pull request needs at its own head. No other change: each commit's change is the same as before by `git patch-id`. Re-run on 94abdd57: the forge checks (`test_forge_pr`, `test_forge_search`, `test_forge_session_lock`, `test_check_pr_description`) and every check that reads the changed files pass, 5 of 5 with g++ and the 2 new ones with clang too. The description names the new commits.

zeldaootr referenced this pull request 2026-11-15 19:30:26 +00:00

WIP: chore(agents): /prior-work, a skill that looks for the work already done before a change is built #888

Some checks are pending

Hide checks

PR description / Description follows the template (pull_request_target) Waiting to run

Details

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request) Blocked by required conditions

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

Some workflows are waiting to be reviewed.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'forge-search-close-body:zeldaootr-forge-search-close-body'

git switch 'zeldaootr-forge-search-close-body'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/upscaling

DLSS, FSR, frame generation

  

beanstalk: approved @ 1697603

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 2c5a62e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 4fd82b7

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 64d6d09

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 6f91fae

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 70a78f9

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8015c9a

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8d361dc

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 9d8356e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ abf2227

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ d82f202

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ e5f1e40

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ ee8ab5f

Set by Beanstalk for show; the farm's database is what counts

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/upscaling

beanstalk: approved @ 1697603

beanstalk: approved @ 2c5a62e

beanstalk: approved @ 4fd82b7

beanstalk: approved @ 64d6d09

beanstalk: approved @ 6f91fae

beanstalk: approved @ 70a78f9

beanstalk: approved @ 8015c9a

beanstalk: approved @ 8d361dc

beanstalk: approved @ 9d8356e

beanstalk: approved @ abf2227

beanstalk: approved @ d82f202

beanstalk: approved @ e5f1e40

beanstalk: approved @ ee8ab5f

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!831

No description provided.